🇧🇷Brazil @julio_retkwa

Hi @joachim I see you worked on the branch '3530764-options-in-the'
is that something you taking care atm? do I got ahead of myself and you are already dealing with that on this branch?

Let me know if That makes sense or if I thought it was too simple
Thank you!

julio_retkwa → made their first commit to this issue’s fork.

Hi @joachim

Let me know if that makes sense? Sub-theme I guess?

Thanks!

julio_retkwa → made their first commit to this issue’s fork.

I'm sorry but I'll need to give up this one, I'm out of ideas on how to solve the test problems that I'm facing

Can anyone review this?

There is anything else that needs to be done ?

anyone can review it?

Hey all
I've added a test scenario let me know if that makes sense
any reviews are welcome :D https://git.drupalcode.org/project/drupal/-/merge_requests/12390

julio_retkwa → made their first commit to this issue’s fork.

I created a MR against branch 8.x-2.x-dev but its failing on composer step
https://git.drupalcode.org/issue/google_calendar_service-3528488/-/jobs/...

I'm missing something here?

PS: I see there are some PHPCS issues on branch 1.x should those be addressed as well? Let me know
https://git.drupalcode.org/issue/google_calendar_service-3528488/-/jobs/...

Thanks!

Hi @danrod sorry, yes

I was not aware that you was working on this, sorry for jumping in

Anyone can review this please? Thanks

julio_retkwa → made their first commit to this issue’s fork.

Does this happens in any other module/theme or just on gin?

I've updated MR based on feedback, let me know if that makes sense

Can anyone review this please?

Anyone can review this? If needs any correction let me know

Can anyone review this and check if seems covered right?

julio_retkwa → made their first commit to this issue’s fork.

Hi @rfmarcelino can you review this one as well ? Thanks

julio_retkwa → changed the visibility of the branch 3525113-europe-timezone-past to active.

julio_retkwa → changed the visibility of the branch 3525113-europe-timezone-past to hidden.

julio_retkwa → created an issue.

My go to:

- Will Huggins (zoocha-will)
- Nico Grienauer (grienauer)

Hi @rfmarcelino can you review this piece ? Thanks

julio_retkwa → created an issue.

Hi @smustgrave I've rebased to last 11.x version

Hi @adinancenci I've just tested this following the steps
1. Upload an image with an uppercase extension.
2. Try to open the fallback.

And is working fine

Thank you!

I've added a MR but I'm not quite sure if that sounds reasonable

I appreciate any inputs here

Hi @mxh I've added your suggestion to MR

Thank you!

julio_retkwa → made their first commit to this issue’s fork.

Hi @drupalmatts while testing this I realized that tag 3.1.0 has already the changes of this commit

julio_retkwa → changed the visibility of the branch 11.x to hidden.

julio_retkwa → made their first commit to this issue’s fork.

julio_retkwa → changed the visibility of the branch 3515604-use-drupal-behaviours to active.

Hi @sandip thank for the suggestion! - I've added that on my last commit

Hi @aaron.ferris I've just followed the test instructions and seems working fine

Thank you!

video proof →

julio_retkwa → made their first commit to this issue’s fork.

I created an MR for this, but I'm not sure about regression tests since I cannot set IE on my actual setup. I've checked the elements styles on chrome 135.0.7049.85 and looks same as before. If anyone could provide some default test instructions (if there is any guideline for manual testing on core), that would be great.

julio_retkwa → changed the visibility of the branch 3519513-remove-remaining-ie11 to active.

julio_retkwa → changed the visibility of the branch 3519513-remove-remaining-ie11 to hidden.

julio_retkwa → changed the visibility of the branch 3519513-remove-remaining-ie11 to hidden.

julio_retkwa → made their first commit to this issue’s fork.

Okay let me know when and if we will proceed at time
thanks

julio_retkwa → made their first commit to this issue’s fork.

Hi @mstrelan I've just add initial commit for that but I'm not sure about the summary, I'll update that but let me know if something seems off

Thanks!

Hi @kim.pepper I've added a initial commit to this issue but I'm not sure if we are missing test instructions or may we need add new test cases for it ?

As far I understood it is just a sub task from #833734

Thank you!

julio_retkwa → made their first commit to this issue’s fork.

julio_retkwa → made their first commit to this issue’s fork.

Hi @aaron May you can review it for me?

would this require any test instructions ?

Thank you

#16 Hi @bnjmnm Thanks for jumping into that, I've changed summary wrongly.
Here is the result of my MR:

I'll start this one, thanks!

julio_retkwa → made their first commit to this issue’s fork.

Hi @smustgrave I've just updated, but I'm not sure if following are right:
* Release notes snippet
* Introduced terminology
* Remaining tasks

May you can assit me with that?

Thank you!

#14 Hi @smustgrave sorry I'm not sure if I get it right. I should add some test coverage on which stage exactly? (I presume nightwatch?) and the CR would stand for Change Request on contrib themes yes?

Hi @bnjmnm thanks for the insights I've updated my MR based on your suggestion

off topic here:
My previous commits where made based on the following issue:

There is any issue related to that already opened? it basically happens on any media library item that has a text that goes less than 80% of wrapper size

I've added a possible fix for that, would be helpful to add on test instructions that if you are on vanilla drupal site you can just zoom in the browser under step 3
If anyone could review, that would be great :)

julio_retkwa → made their first commit to this issue’s fork.

I've added an approach that solves the issue, but my concern is on how to test it widely to make sure it works on all instance
If anyone could help me with that would be great :)

julio_retkwa → made their first commit to this issue’s fork.

I've updated the JS removing forEach and making sure it scrolls just the modal (on my vanilla setup it was scrolling the document root too)

Drupal.behaviors.mediaLibraryScrollOnOpen = {
    attach: function (context, settings) {
      const input = once('mediaLibraryScrollOnOpen', 'input[type="file"]', context)[0];
      if (input) {
        const modalContent = input.closest('#drupal-modal');
        if (modalContent) {
          setTimeout(() => {
            modalContent.scrollTo({
              top: modalContent.offsetTop  - modalContent.scrollTop,
              behavior: 'smooth',
            });
          }, 100);
        }
      }
    }
  };

As I've investigated, the issue lies on jQuery adding max-height on #drupal-modal.ui-front ui-dialog-content ui-widget-content when it actually should add this property to .media-library-wrapper I couldn't find yet how we can tweak the jQuery

If anyone could Shed a light I'll be thankful :)

Some buttons on :focus are using --drupal-navy font color on dark background. Carousel items should keep the consistent size

breidert → credited julio_retkwa → .