🇧🇷Brazil @julio_retkwa

Okay let me know when and if we will proceed at time
thanks

julio_retkwa → made their first commit to this issue’s fork.

Hi @mstrelan I've just add initial commit for that but I'm not sure about the summary, I'll update that but let me know if something seems off

Thanks!

Hi @kim.pepper I've added a initial commit to this issue but I'm not sure if we are missing test instructions or may we need add new test cases for it ?

As far I understood it is just a sub task from #833734

Thank you!

julio_retkwa → made their first commit to this issue’s fork.

julio_retkwa → made their first commit to this issue’s fork.

Hi @aaron May you can review it for me?

would this require any test instructions ?

Thank you

#16 Hi @bnjmnm Thanks for jumping into that, I've changed summary wrongly.
Here is the result of my MR:

I'll start this one, thanks!

julio_retkwa → made their first commit to this issue’s fork.

Hi @smustgrave I've just updated, but I'm not sure if following are right:
* Release notes snippet
* Introduced terminology
* Remaining tasks

May you can assit me with that?

Thank you!

#14 Hi @smustgrave sorry I'm not sure if I get it right. I should add some test coverage on which stage exactly? (I presume nightwatch?) and the CR would stand for Change Request on contrib themes yes?

Hi @bnjmnm thanks for the insights I've updated my MR based on your suggestion

off topic here:
My previous commits where made based on the following issue:

There is any issue related to that already opened? it basically happens on any media library item that has a text that goes less than 80% of wrapper size

I've added a possible fix for that, would be helpful to add on test instructions that if you are on vanilla drupal site you can just zoom in the browser under step 3
If anyone could review, that would be great :)

julio_retkwa → made their first commit to this issue’s fork.

I've added an approach that solves the issue, but my concern is on how to test it widely to make sure it works on all instance
If anyone could help me with that would be great :)

julio_retkwa → made their first commit to this issue’s fork.

I've updated the JS removing forEach and making sure it scrolls just the modal (on my vanilla setup it was scrolling the document root too)

Drupal.behaviors.mediaLibraryScrollOnOpen = {
    attach: function (context, settings) {
      const input = once('mediaLibraryScrollOnOpen', 'input[type="file"]', context)[0];
      if (input) {
        const modalContent = input.closest('#drupal-modal');
        if (modalContent) {
          setTimeout(() => {
            modalContent.scrollTo({
              top: modalContent.offsetTop  - modalContent.scrollTop,
              behavior: 'smooth',
            });
          }, 100);
        }
      }
    }
  };

As I've investigated, the issue lies on jQuery adding max-height on #drupal-modal.ui-front ui-dialog-content ui-widget-content when it actually should add this property to .media-library-wrapper I couldn't find yet how we can tweak the jQuery

If anyone could Shed a light I'll be thankful :)

Some buttons on :focus are using --drupal-navy font color on dark background. Carousel items should keep the consistent size

breidert → credited julio_retkwa → .

Check comment #77

That patch worked for me https://www.drupal.org/project/decoupled_router/issues/3111456#comment-1... 🐛 Unable to resolve path on node in other language than default Needs work

Using Drupal 10.2.6

and comment #29 worked for me

I'm adding a patch for it

Thanks @lecabori

Thanks @vlyalko

Patch #44 worked fine for me on all my views

Drupal 10.3.1

Here is the Portuguese translation of the Drupal 11 landing page

If someone could review that for me would be great!

https://docs.google.com/spreadsheets/d/1HbXlin1gkiETHSigwcBLjOpJ9BHdQ991...

Thank you!

I will look at this issue.

julio_retkwa → created an issue.

#9 worked like a charm

Thank you.

julio_retkwa → made their first commit to this issue’s fork.

Hi all

I've faced the same issue and solution from @mahtab_alam worked fine, Thank you!
had to do nothing else on maxlength.libraries.yml
then just add:
- ckeditor5/internal.drupal.ckeditor5

In my scenario I was using paragraph

julio_retkwa → made their first commit to this issue’s fork.

julio_retkwa → created an issue.

looks like this is a duplicate of https://www.drupal.org/project/image_lazy_loader/issues/3297403 💬 Automated Drupal 10 compatibility fixes RTBC can this be closed ?

May someone can have a look on it? https://git.drupalcode.org/project/image_lazy_loader/-/merge_requests/1

Is the same code presented by update bot

julio_retkwa → created an issue.

#3 working fine for me as I had to follow the new standard described here: https://www.drupal.org/docs/contributed-modules/components/registering-t... →

TL:DR
I had to replace my theme.info.yml section from this:

component-libraries:
  base:
    paths:
      - components/00-base
  atoms:
    paths:
      - components/01-atoms
  molecules:
    paths:
      - components/02-molecules
  organisms:
    paths:
      - components/03-organisms

To something like:

components:
  namespaces:
    base: components/00-base
    atoms: components/01-atoms
    molecules: components/02-molecules
    organisms: components/03-organisms
    templates: components/04-templates
    pages: components/05-pages

I think this was already fixed on newer versions, but anyway I'm adding this patch to whoever is facing this on alpha4 as me

For anyone that is facing this you can try something like:

CKEDITOR.on("instanceReady", function(event) {
  event.editor.on("beforeCommandExec", function(event) {
    // Show the paste dialog for the paste buttons and right-click paste
    if (event.data.name === "paste") {
      event.editor._.forcePasteDialog = true;
    }
    // Don't show the paste dialog for Ctrl+Shift+V
    if (event.data.name === "pastetext" && event.data.commandData.from === "keystrokeHandler") {
      event.cancel();
    }
  })
});

which will force the old dialog, looks like is something asked since 2017: https://github.com/ckeditor/ckeditor4/issues/469#issuecomment-524185244

julio_retkwa → created an issue.

#83 it's working fine for me. Thanks !