- Issue created by @bnjmnm
- 🇮🇳India niranjan_panem Gurugram
In Drupal 11 the labels in media library moved to center below the file, below is the screen shot of it.
- 🇺🇸United States bnjmnm Ann Arbor, MI
- 🇺🇸United States phenaproxima Massachusetts
This is of interest to Experience Builder and, therefore, to Drupal CMS. I'm hoping it can be fixed in time for Drupal CMS 2.0, which will have XB as its native page builder.
- First commit to issue fork.
- Merge request !11488Issue #3502895: remove padding and set max-width → (Open) created by julio_retkwa
- 🇧🇷Brazil julio_retkwa Balneário Camboriú
I've added an approach that solves the issue, but my concern is on how to test it widely to make sure it works on all instance
If anyone could help me with that would be great :) - 🇺🇸United States bnjmnm Ann Arbor, MI
I've added an approach that solves the issue, but my concern is on how to test it widely to make sure it works on all instance
If anyone could help me with that would be great :)Testing it widely could be difficult, but there's a way to approach this where this wouldn't be necessary.
Instead of changing padding and max-width, the least disruptive way to do this would be to preserve the styling that is known to already work. If you make the enclosing
<article>
tag haveposition: relative;
, but use a selector that isn't dependent on the.contextual-region
class being present, this fixes it in a way that only requires a few moments of testing. - 🇧🇷Brazil julio_retkwa Balneário Camboriú
Hi @bnjmnm thanks for the insights I've updated my MR based on your suggestion
off topic here:
My previous commits where made based on the following issue:There is any issue related to that already opened? it basically happens on any media library item that has a text that goes less than 80% of wrapper size
- 🇺🇸United States smustgrave
Hello, can the IS be updated please.
Proposed solution
Steps to reproduce
Before/after screenshots in the User Interface sectionAPI and Data model are unchanged so probably can just put NA.
Thanks!
- 🇧🇷Brazil julio_retkwa Balneário Camboriú
Hi @smustgrave I've just updated, but I'm not sure if following are right:
* Release notes snippet
* Introduced terminology
* Remaining tasksMay you can assit me with that?
Thank you!
- 🇺🇸United States bnjmnm Ann Arbor, MI
@julio_retkwa appreciate the attempt but the changes to the summary are not at all what was reported, the steps to reproduce and proposed solution seem like they are from an entirely different issue that happens to be media library related. Among other things you added "Added a js behaviour to scroll up on field media modal open." as the Proposed Solution despite not touching any JS in your MR or the issue having anything to do with scrolling.
I updated the IS to address this.
- 🇧🇷Brazil julio_retkwa Balneário Camboriú
#16 Hi @bnjmnm Thanks for jumping into that, I've changed summary wrongly.
Here is the result of my MR:
- 🇮🇳India sdhruvi5142
Hi
I've applied MR!11488 on Drupal Version 11.x and the changes are working as expected.Testing Steps:
1. Installed Claro as the admin theme
2. Added a media library field to any content type.
3. Disabled the Contextual module
5. Open the media library dialog in the add/edit form for the content type
6. Observe the changes thereTesting result:
After applying the MR! the Media libarray item styles looks proper nothing seems to be broken. Attaching SS for reference. Moving this to RTBC+1Status : PASS