- Issue created by @Haris Khan Jadoon
The menu appears to be working in the screenshot you posted. Additionally, I can't reproduce the problem on Drupal 10.4 with the steps to reproduce as written above.
Yes, it's working, but when it's opened, the icon or appearance doesn't change as it should.
Like this
The issue summary says that "users are unable to access additional options or features when clicking the icon", but in fact the problem is that the icon should change when used. Do I understand now?
Which theme is this?
- 🇳🇿New Zealand quietone
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .
Restored the standard template, which we use to track progress and others tasks on an issue.
I tested this on Drupal 11.x, standard install, following the step in the issue summary. At step 3, there is no "dropdown menu icon in the upper right corner of the page". Is something missing? Is there custom code on the site?
- First commit to issue fork.
- 🇧🇷Brazil julio_retkwa Balneário Camboriú
I've added a possible fix for that, would be helpful to add on test instructions that if you are on vanilla drupal site you can just zoom in the browser under step 3
If anyone could review, that would be great :) - Status changed to Needs work
about 1 month ago 6:47pm 24 March 2025 - 🇺🇸United States smustgrave
Probably be good to get test coverage added for this. Twig template will probably need a CR as contrib themes would have to update theirs.
- 🇧🇷Brazil julio_retkwa Balneário Camboriú
#14 Hi @smustgrave sorry I'm not sure if I get it right. I should add some test coverage on which stage exactly? (I presume nightwatch?) and the CR would stand for Change Request on contrib themes yes?
- 🇺🇸United States bnjmnm Ann Arbor, MI
This isn't a bug - it's a feature request.
The issue summary is still inaccurate. It should be presented as a desire to have a different icon present depending on open/closed state.
- 🇺🇸United States smustgrave
So my fault I actually should of mentioned the issue summary is incomplete. Proposed solution should almost always be filled in.
Maybe nightwatch (I'm not great with those) or a functional javascript test maybe? So we can confirm that the functionality is still working to make sure the bug doesn't comeback.
And correct CR is change record, you'll see the button on the right at the top for adding one. Can be real simple too
- 🇮🇳India snehal-chibde
hello, I have checked this on Drupal 11.x-dev, as per the steps mentioned. The MR is working as expected.
On click of hamburger, when the menu is open the hamburger icon changes to close icon. Added before and after screenshots for reference. - 🇮🇳India sandip
Hi @julio_retkwa, I’ve reviewed your MR — the changes are looking good overall. One suggestion I’d like to propose is to enhance accessibility by adding the
aria-hidden
attribute to the<span>
elements wrapping the hamburger and close icons.In addition, we should update the JavaScript to toggle the
aria-hidden
values based on the menu state. This ensures that only the currently visible icon is announced by screen readers, aligning with accessibility best practices.Let me know what you think!
- 🇧🇷Brazil julio_retkwa Balneário Camboriú
Hi @sandip thank for the suggestion! - I've added that on my last commit
- 🇮🇳India sandip
Changes looks good to me attaching a Video for better understanding. Also corrected the branch versions in CR. Moving this issue to RTBC.