Coimbatore
Account created on 2 September 2022, almost 3 years ago
  • Drupal Front - Engineer at QED42 
#

Merge Requests

More

Recent comments

🇮🇳India vasantha deepika Coimbatore

Apologies for the confusion in my previous comment. While I initially confirmed the issue in the 1.x branch, I later noticed that the entire component has been removed. Because of this, I’m currently unable to reproduce the issue. Just wanted to clarify this point.

🇮🇳India vasantha deepika Coimbatore

Confirming the issue exists in the 1.x branch as well. Attached a screenshot showing the problem.

I’ll work on a fix and raise a merge request shortly.

🇮🇳India vasantha deepika Coimbatore

Fixed the content breaking issue on the canvas in Firefox.
Created a merge request with the fix and attached screenshots for reference.

Before Fix:

After Fix:

🇮🇳India vasantha deepika Coimbatore

This issue is related to CKEditor, and a solution has already been proposed in issue #3328095 (MR !8096), but the MR is still under review.
To unblock progress here, I’ve added the patch from that MR.

Please refer to this comment for more details. Patch Link 🐛 CKEditor 5 toolbar overflow can become unusable in Off canvas Needs review

🇮🇳India vasantha deepika Coimbatore

The MR !8096 seems fine, but the pipeline is failing due to test-related files.

I'm attaching a patch generated from the MR [3328095-mr8096.patch] in case anyone needs it to proceed without being blocked, until the MR is merged.

🇮🇳India vasantha deepika Coimbatore

Fixed the issue where the menubar alignment overlap when the title exceeded 150 characters.

What was done:
- Applied a `max-width` to the title container to prevent it from stretching beyond its parent layout.
- Ensured that long titles wrap gracefully without breaking or misaligning other UI elements in the menubar.

Steps to verify:
1. Create an article with a title longer than 150 characters.
2. Go to Experience Builder and observe the menu bar.
3. The layout should now remain intact, with the long title gracefully truncated.

Attached the before and after screenshots.
BEFORE:

AFTER:

Marking this issue as Needs review.

🇮🇳India vasantha deepika Coimbatore

Unable to view SEO settings under the "Page Data" tab. Please help reproduce the issue for further investigation.

🇮🇳India vasantha deepika Coimbatore

After applying MR11723, I’m no longer seeing the discard popup.

@sandip — could you please help me reproduce the issue?

🇮🇳India vasantha deepika Coimbatore

Let me check the pipeline issue and try to fix it.

This MR only includes CSS changes, but the failure seems to be caused by a JS functional test (JSWebAssertTest), which appears to be unrelated to this update.

I will investigate further and re-run the pipeline if needed. Will share findings shortly.

Additionally, I have increased the dropdown visibility by adjusting the --ck-toolbar-dropdown-max-width value from 90 to 95 to ensure the CKEditor 5 toolbar dropdown displays correctly.

🇮🇳India vasantha deepika Coimbatore

I’m taking a look at this issue. I’ll review the patch and share my feedback shortly.

🇮🇳India vasantha deepika Coimbatore

I have updated the layout by embedding the main content area within the container component to constrain its width and ensure consistent alignment across the design system.

This approach helps standardize spacing and improves the responsiveness of the layout.

I explored this as a potential solution based on the current structure.
If there are any alternative recommendations or preferred approaches, I’m happy to revise accordingly.

🇮🇳India vasantha deepika Coimbatore

I’m on it and will circle back with an update.

🇮🇳India vasantha deepika Coimbatore

Hi @marcus_johansson, Please provide the steps to reproduce the issue along with relevant screenshots or a screen recording. This will help to understand the problem clearly and work on a fix more efficiently.

🇮🇳India vasantha deepika Coimbatore

I'll look into this issue

🇮🇳India vasantha deepika Coimbatore

Fixed the issue and Raised MR #9

🇮🇳India vasantha deepika Coimbatore

Hi @jphelan, I couldn't reproduce the issue on my end, i tried with the versions mentioned below

Gin theme version: 4.0.6
Layout Builder iFrame Modal version: 1.3.6

Could you please let me know which version of the Layout Builder iFrame Modal you're using?

🇮🇳India vasantha deepika Coimbatore

Could you please provide the steps to reproduce it? This will help us understand the context.

🇮🇳India vasantha deepika Coimbatore

hi @rikki_iki,

I've reviewed all the commands you added in the Merge Request and resolved them accordingly. The MR has been updated and is now ready for review. Please let me know if any further changes are required.

Thanks!

🇮🇳India vasantha deepika Coimbatore

Moving the ticket for review now that the pipeline issue has been resolved.

🇮🇳India vasantha deepika Coimbatore

There are some deviations in the MR. I will review them and update the MR accordingly.

🇮🇳India vasantha deepika Coimbatore

Thanks for the update! I've already started work on the footer component, but no issues on my end—I’ll proceed with the review/testing. Let me know if anything else comes up!

🇮🇳India vasantha deepika Coimbatore

I have fixed the issue and raised a merge request for review. I have also attached a screenshot for reference. Please let me know if any further changes are required. Thanks!

🇮🇳India vasantha deepika Coimbatore

I've addressed all the comments and updated the MR accordingly. Moving the issue for review. Let me know if any further changes are needed!

🇮🇳India vasantha deepika Coimbatore

Thank you for the review! I'am currently looking into them and working on fixes.

🇮🇳India vasantha deepika Coimbatore

I’m picking up this issue and will update the status here.

🇮🇳India vasantha deepika Coimbatore

Thank you for the new design update! I have updated the MR based on the new design. Additionally, @mherchel, I have used the element for the accordion.

🇮🇳India vasantha deepika Coimbatore

Thanks for the feedback Jim Birch!
I’ll review the approach using the element and update the component accordingly.

🇮🇳India vasantha deepika Coimbatore

I have created the Accordion component, but a few improvements are still needed. I am actively working on them.
Please review it and share your suggestions, as they would be very helpful.

Thanks!

🇮🇳India vasantha deepika Coimbatore

vasantha deepika made their first commit to this issue’s fork.

🇮🇳India vasantha deepika Coimbatore

I attempted to reproduce the reported issue but found that the functionality is working as expected. The mobile menu button only appears when there are items added to the primary or secondary menu regions. If no menu items are present, the button does not appear, ensuring the expected behavior.

Please let me know if there are specific steps or conditions under which the issue occurs so I can investigate further.

🇮🇳India vasantha deepika Coimbatore

vasantha deepika changed the visibility of the branch 3507482-page-not-visible-fullwidth to hidden.

🇮🇳India vasantha deepika Coimbatore

Apologies for the earlier approach. Since Olivero is a core theme in Drupal 11, I have updated the relevant tags accordingly and will be raising a Merge Request (MR) against Drupal core.

🇮🇳India vasantha deepika Coimbatore

The issue has been resolved, and I have raised a merge request. Please review and provide feedback as needed.
Thanks!

🇮🇳India vasantha deepika Coimbatore

hi @saschaeggi,
Based on your feedback, I have updated the merge request (MR ID: #558).

Thanks!

🇮🇳India vasantha deepika Coimbatore

Not able to re produce even i could see the aria-describedby in detail tag.

🇮🇳India vasantha deepika Coimbatore

I attempted to reproduce by installing the Navigation module, but the feature request has already been implemented. Therefore, I am changing the status to 'Closed - (Cannot reproduce)' Please feel free to reopen if further action is required.

🇮🇳India vasantha deepika Coimbatore

As the mentioned issue has already been resolved in the related ticket, I will proceed with closing this issue. Please feel free to reopen if further action is needed.

🇮🇳India vasantha deepika Coimbatore

I have updated MR #372 based on the feedback provided in the comments and changed its status to 'Needs Review' for further evaluation.

🇮🇳India vasantha deepika Coimbatore

@balintbrews Thank you for your feedback; I am updating the MR accordingly.

@boulaffasae Thank you for your clarification!

🇮🇳India vasantha deepika Coimbatore

I need clarification regarding the desktop design—there seems to be a variation in the padding of the card. Could someone confirm which desktop design we should proceed with?

🇮🇳India vasantha deepika Coimbatore

Reverting the image slot back to props due to limitations with the current image implementation.
Thank you, @balintbrews, for your suggestion—it makes the process more streamlined.

🇮🇳India vasantha deepika Coimbatore

Hi,

Thank you for the details. Could you please share the exact steps to reproduce the issue, including your View configuration and behavior in the Views preview? This will help to investigate further.

🇮🇳India vasantha deepika Coimbatore

Hi @saschaeggi,
I have updated MR #527 with the required dist file. Please review the changes.

🇮🇳India vasantha deepika Coimbatore

vasantha deepika changed the visibility of the branch 3487605-view-for-submit to active.

🇮🇳India vasantha deepika Coimbatore

vasantha deepika changed the visibility of the branch 3487605-view-for-submit to hidden.

🇮🇳India vasantha deepika Coimbatore

Replace "Local Tasks" with "Quick Links" to make navigation more intuitive and user-friendly for non-technical users as well. Raised an MR #108

🇮🇳India vasantha deepika Coimbatore

vasantha deepika made their first commit to this issue’s fork.

🇮🇳India vasantha deepika Coimbatore

Hi @jayemel,
I am unable to reproduce the issue you mentioned. Could you please provide more detailed steps to help me replicate it?
Thanks!

🇮🇳India vasantha deepika Coimbatore

Thank you for confirming that the fix works as expected and for the suggestion regarding the initial changes.

Based on your feedback, I have reverted the first two changes and updated the merge request (MR ID: #558).

Thanks!

Production build 0.71.5 2024