- Issue created by @mayur-sose
- @vasantha-deepika opened merge request.
- 🇮🇳India vasantha deepika Coimbatore
Fixed the content breaking issue on the canvas in Firefox.
Created a merge request with the fix and attached screenshots for reference.Before Fix:
After Fix:
- First commit to issue fork.
- @jessebaker opened merge request.
-
bnjmnm →
committed ddc94d58 on 1.x authored by
jessebaker →
Issue #3538506 by vasantha deepika, jessebaker: Preview Canvas Content...
-
bnjmnm →
committed ddc94d58 on 1.x authored by
jessebaker →
@jessebaker @bnjmnm I have tested the changes on the 1.x branch and am still able to reproduce this issue. Please see the attached video for reference.
- 🇬🇧United Kingdom jessebaker
The issue found by @mayur-sose is slightly different from the one fixed in the original MR but actually probably more of an actual problem.
The initial MR fixed the canvas not increasing in size to accommodate the iframe on page load.
The second issue found is that, once the canvas is scaled (e.g zoomed to 80%), it does not increase in height/width to accommodate the iframe when the iframe changes size. It only recalculates when the scale is changed.
Adding a resize observer should capture this scenario.
- @jessebaker opened merge request.
- 🇬🇧United Kingdom jessebaker
MR !1437 has a fix for the issue found in #11
-
bnjmnm →
committed a4254bcd on 1.x authored by
jessebaker →
Issue #3538506 by jessebaker, bnjmnm, mayur-sose: Preview Canvas Content...
-
bnjmnm →
committed a4254bcd on 1.x authored by
jessebaker →
- 🇺🇸United States bnjmnm Ann Arbor, MI
I could only reproduce #14 in Firefox though it mentioned it occurred in all browsers. The MR does fix it, and the approach makes sense, so this is going in.
Automatically closed - issue fixed for 2 weeks with no activity.