- Issue created by @rinku jacob 13
- š®š³India Kanchan Bhogade
@rinku jacob 13 No Patch available for review or manual testing
- š®š³India vasantha deepika Coimbatore
Iām picking up this issue and will update the status here.
- Merge request !595Issue #3509043 by Vasantha Deepika: Fixed layout issue for feed type form. ā (Open) created by vasantha deepika
- š®š³India vasantha deepika Coimbatore
I have fixed the issue and raised a merge request for review. I have also attached a screenshot for reference. Please let me know if any further changes are required. Thanks!
- š®š³India Kanchan Bhogade
Tested manually MR 595 on Drupal 11
MR is applied successfully...Testing Steps:
1). Install Drupal site.
2). Enable Gin admin theme.
3). Install and Enable Feed type module.
4). Try to add one feed type. check the alignment issue on feed type dropdownTest Result: Alignment issue with the feed type dropdown is resolved.
Attaching screenshotsKeeping in review for code verification.
The pipeline has failed and needs to be fixed. Moving this to "Needs Work" status.
- š®š³India vasantha deepika Coimbatore
Moving the ticket for review now that the pipeline issue has been resolved.
- š®š³India sandip
I believe the current approach may not be optimal, as the issue specifically affects the Feed module. Fixing it in
_layers.scssis causing unrelated changes elsewhere. To maintain consistency and prevent such issues, I will follow the standard used in the Gin theme by creating a dedicatedfeed.scssfile inside thecomponentsfolder for module-specific styling. - š®š³India snehal-chibde
hello @sandip , I have tested this on Drupal 11,gin theme, the MR changes are working fine.
I have added before and after screenshots of the same.The issue is only specific to gin and not replicated on claro , have also checked that and added a screenshot of the same.
So the approach of keeping these changes inside components folder for module-specific styling makes sense.