🇮🇳India @Rinku Jacob 13

@Nitin_shrivastava , Reviewed Your MR . it was successfully applied. Adding screenshot for the reference.

Rinku Jacob 13 → made their first commit to this issue’s fork.

Created new MR to fix the issue. Please review.

Rinku Jacob 13 → created an issue.

Hi @Nitin shrivastava , Successfully Applied your MR. Adding screen shots for the references.

Hi @shweta__sharma, Base theme of adminal theme is seven. so remove button color is inherited from seven theme.
do we need to follow any theme/design to style remove button?
for the example in claro theme they are used different style for remove button compared to other buttons. so can you please give any suggestion to style that.

@ Luke.Leber, I have checked this issue in my local. I can't able to see any text area over flows in revision log message.also text area's max-width is 100%.

I have checked this issue on my local . i couldn't able to reproduce this issue as well as i think the header doesn't need any style changes. @ivan.mihailov, can you please guide me how we can reproduce this issue

hi @DinuDodon, can you please include reproduce steps for this issue. i'am not able to reproduce this issue because of i couldn’t able to see search icon as well as other icons in the header section.

Created new Merge request for solving the issue, Please review

Rinku Jacob 13 → made their first commit to this issue’s fork.

Hi @couloir007, The solution for this issue is hidden parameter in the info.yml. If you try to remove/comment that parameter you will able to see the theme in the list of appearances .

hi @Pravesh_Poonia , i have checked the issue and applied your MR. like sweta said it was forming an another issue.in my local i have tried and got resolved the issue.
my solution for this issue give important properties to views.scss file.

 .add a:hover,
  .add a:focus,
  li a:hover,
  li a:focus,
  li.is-active a,
  li.is-active a.is-active {
    color: var(--gin-bg-app) !important;
    background: var(--gin-color-primary);
    border-color: transparent;
  }

.add {
    &.open {
      a {
        background: var(--gin-bg-layer2);

        &:hover, &:focus, &:active {
          color: var(--gin-color-primary) !important;
        }
      }
    }
  }

I have applied the patch #19. I think it's just a re-roll. It doesn't make any changes on message as per comment #13.

Created new patch for drupal version 10.1.x. Please review.

Hi @Akshay kashyap, in your patch you have removed quotes from regions. But we have to remove quotes from description and alt_text key.Created new patch for that. Please review.

Applied patch #20 on drupal version 10.1.x. It was successful ly applied and i got the solution. Adding screenshots for the reference.Need RTBC+1.

Hi @cosmicdreams , Applied your MR. It was successfully added Enable Same Page Preview checkbox on content types. Need RTB+1

Hi @DanielVeza, Applied your patch successfully and i got the solution. It was added a simple title attribute . Need RTBC+1.

Hi @smustgrave, when we use the logo supplied by the theme the slogans accurately displayed.

But when we use a custom logo(especially larger size custom logo) slogan was show as non-aligned. Need to work on this.

Hi @Guru2023 , I have made 2 changes on my MR. Removed quotes from Description and alt text key.

Hi @muriqui , Reviewed your MR. After the MR we can see a new "Disable automatic queueing" checkbox to the admin form.Need RTBC+1.

H i @smustgrave ,Issue summary updated. Please review.

Proposed resolution
Remove all single quotes in claro.info.yml.

Rinku Jacob 13 → created an issue.

I have check this issue on version 8.x-2.x(latest version)

Rinku Jacob 13 → created an issue.

Hi @Shaimaa Natshah, I think you have added page.html.twig to version 9.1.x. Can you please change issue status to needs review or fixed. I have tested the issue and the issue already fixed. But the issue status make me some confusion.

Hi @smustgrave , Tested your patch on drupal version 10.1.x. It was successfully applied and i got solution. Adding screenshots for the reference. Need RTBC+1

Rinku Jacob 13 → made their first commit to this issue’s fork.

Grevil → credited Rinku Jacob 13 → .

Hi @elber,Applied your patch and patch doesn't applied successfully . I think we don't need to include info.yml changes to this patch.
Barrio Bootstrap 5 Theme is already compatible with drupal 9 and drupal 10. I have created new patch. please review

Rinku Jacob 13 → made their first commit to this issue’s fork.

HI @mahtab_alam , Applied your MR, and i didn't see any changes after the MR.

Reviewed Merge requests!3603 . After applying the Merge request edit comment message changed to "Your comment has been updated". Need RTBC +1.

Hi @quietone , sorry for the mistake i have done. I didn't noticed comment on 45.2. according to comment on 26.1 we can change '#default_value' => $title_setting === DRUPAL_DISABLED ? NULL : ($items[$delta]->title ?? NULL), to'#default_value' => $title_setting === DRUPAL_DISABLED ? NULL : ($items[$delta]->title), because it shouldn't raise and error. I think this changes we need to do here. If it's wrong please excuse me. I f it is correct i will create a patch based on that

Hi @alok_singh, Applied your MR successfully. Adding screenshots for the reference. Need RTBC+1.

Hi @alok,Your MR doesn't applied successfully .I got below error during applying the MR.
Checking patch css/media.css...
Checking patch global_zymphonies_theme.info.yml...
error: while searching for:
type: theme
description: 'Designed & Developed by Zymphonies
Contact us for any kind of Drupal services info@zymphonies.com'
package: core
core: 8.x

# Libraries
libraries:

error: patch failed: global_zymphonies_theme.info.yml:2
error: global_zymphonies_theme.info.yml: patch does not apply

Your MR have 2 changes including info.yml. I think we don’t need info.yml changes for this issue.We already have fixes for that.

Hi @alok_singh , Applied your MR and i got the solution. Adding screenshots for the reference.

Hi @alok_singh, Applied your MR. The MR doesn’t applied successfully . I got below error applying the MR.
Checking patch css/custom-media.css...
error: while searching for:
text-transform: uppercase;
font-size: 16px;
}

.main-header nav{
margin: 0;
padding: 0;

error: patch failed: css/custom-media.css:39
error: css/custom-media.css: patch does not apply
Checking patch industrial_zymphonies_theme.info.yml...
error: while searching for:
type: theme
description: 'Designed & Developed by Zymphonies
Contact us for any kind of Drupal services info@zymphonies.com'
package: core
# core: 8.x
#Libraries
libraries:
- industrial_zymphonies_theme/bootstrap

error: patch failed: industrial_zymphonies_theme.info.yml:2
error: industrial_zymphonies_theme.info.yml: patch does not apply

I think your MR have 2 changes including info.yml changes. info.yml changes doesn't needed for this issue. I have tried your changes on the custom-media.css. But still issue doesn't fixed.

Rinku Jacob 13 → made their first commit to this issue’s fork.

Hi @francoud , We can set base theme as false. Recently created themes are using base theme as false. If set to false, no base theme is being used. It is clearly mentioned in - Defining a theme with an .info.yml file → document.If you need this changes on info.yml file i will create a patch for that.

I can't able to reproduce the issue on drupal version 9.5.x. Followed the steps which is mentioned above ,but still i didn't got any error's on dblog. Can any one please check on this.

Hi @alok_singh,Your MR doesn’t applied successfully . i think we need to change only media.css file. applied your changes on media.css file. I got the solution. Can you please check on this issue. I think we need to cahnge only media.css file.

Hi @̌alok_singh, your MR doesn’t applied successfully . MR!2 having info.yml changes also. That changes doesn't needed for this issue.So that i created patch.

Updated README.md. please review.

Rinku Jacob 13 → made their first commit to this issue’s fork.

The MR doesn’t applied. I got some error while applying the MR.
5.diff:51: trailing whitespace.
color: #ff982c !important;
Checking patch charity_zymphonies_theme.info.yml...
error: while searching for:
type: theme
description: 'Designed & Developed by Zymphonies
Contact us for any kind of Drupal services info@zymphonies.com'
package: core
core: 8.x

#libraries
libraries:

error: patch failed: charity_zymphonies_theme.info.yml:2
error: charity_zymphonies_theme.info.yml: patch does not apply
Checking patch css/global.css...
error: while searching for:

/*Bottom Widgets*/
.bottom-widget {
background: #fff; }
.bottom-widget h2.title, .bottom-widget * {
color: #7964ad; }

.path-frontpage .bottom-widgets {
padding: 20px 0; }

error: patch failed: css/global.css:669
error: css/global.css: patch does not apply
Checking patch css/media.css...

Hi @alok_singh , Can you please check on your MR. Because it contains info.yml changes also. while applying your MR getting some error. I have created a patch based on your MR. Please review

Hi @alok_singh, The patch doesn’t applied successfully . Can you please check on this.
Checking patch css/media.css...
6.diff:73: trailing whitespace.
color: #ff982c !important;
Checking patch charity_zymphonies_theme.info.yml...
error: while searching for:
type: theme
description: 'Designed & Developed by Zymphonies
Contact us for any kind of Drupal services info@zymphonies.com'
package: core
core: 8.x

#libraries
libraries:

error: patch failed: charity_zymphonies_theme.info.yml:2
error: charity_zymphonies_theme.info.yml: patch does not apply
Checking patch css/global.css...
Checking patch css/media.css...

Got the same error for drupal version 9.5.x. Applied the above patch and got the solution. and i have make small changes in info.yml file.

Rinku Jacob 13 → made their first commit to this issue’s fork.

Reviewed patch #14. It was successfully applied to drupal version 7.x-dev. Adding screenshots for the reference. Need RTBC+1.

updated README.md. please review.

Rinku Jacob 13 → created an issue.

Successfully applied above patch.After the patch we can see separate permissions for events and calendars. Move the issue to RTBC.

Applied patch #2. I didn't got any solution after applied the patch. Adding screen records for the references.

Rinku Jacob 13 → made their first commit to this issue’s fork.

Hi @jlscott , Reviewed your MR. The MR was working perfectly. Moved this issue RTBC.

Updated info.yml file. Please Review

Rinku Jacob 13 → made their first commit to this issue’s fork.

I have tested the patch #14 on drupal version 10.1.x. After applying the patch#14 maxlength attribute value changed to 255.
But patch #2 maxlength attribute value is null. Why this changes happened in new patch. Which value is acceptable ?

Rinku Jacob 13 → made their first commit to this issue’s fork.

Updated README.md file. Please Review.

Rinku Jacob 13 → created an issue.

Hi @alok_sing, Patch doesn’t applied . Getting some error during applying the patch. Can you please check on this.

error: while searching for:

.region-sidebar-first nav h2{
display: block;
}
error: patch failed: css/global.css:1054
error: css/global.css: patch does not apply

I have tested the issue in drupal version 10.1.x (https://simplytest.me/). Applied above patch and i got the solution. Adding Screenshots for the reference . Need RTBC+1

Hi @alok_singh, Tested and verified your patch. It was successfully applied and i got the solution. Adding Screenshots for the references . Need RTBC+1.