@sandip poddar, I have already added the before and after screenshots, but I have no idea how the latest comment was generated.
I applied the MR for Drupal 11.x-dev, and the issue was fixed after its implementation. I've attached the before and after screenshots for reference.
Before applying the style:
After applying the style:
I created a new branch because I encountered conflict errors when trying to check out to the old branches. also, in the previous MR, no SCSS file was created. We need to create the SCSS file, and after compilation, it will automatically generate the CSS file. Based on the comments in the catch, I have made some changes to my MR
rinku jacob 13 → made their first commit to this issue’s fork.
I have applied the merge request, and the issue has been resolved. Here are the before and after screenshots for reference.
Before the changes (MR) were applied
After the changes(MR) were applied
I have applied the merge request, and the issue has been resolved. Here are the before and after screenshots for reference.
Before the changes (MR) were applied
After the changes(MR) were applied
rinku jacob 13 → made their first commit to this issue’s fork.
@anjaliprasannan , I wasn't able to reproduce the issue on Drupal 11.x, . I couldn't identify any changes before or after the merge request. When we tried enabling the checkbox to display the elements related to that particular field, they showed up as expected. Otherwise, the elements remained hidden, and I didn't observe any scrolling issues.I will include a screen recording as proof. Could you please provide a screen recording to help better understand how to reproduce the issue or demonstrate the problem?
The background color for the ViewBulk actions in the Gin admin theme is being overridden by other styles that were specifically designed for the Gin theme.
If we remove these core ViewBulk actions styles, the default styles (like those in Claro) will be applied, where the background color is #232429.
Should we update the Gin ViewBulk action background color to match Claro's, or should we increase the contrast of the existing color?
Hi nod_, From understanding the issue from the beginning, we need to change the value of --color-absolutezero-active because in the issue (Darker Blue color for hover & active 📌 Darker blue color for :hover & :active Fixed ) , @saschaeggi mentions that the hover color should be #0036B1 and the active color should be #00339A. However, based on comment #11, she updated the color codes for both hover and active states according to the Figma design: Despite this, the recent patches haven't updated the active color value. Therefore, I didn't change the active color code. Should we proceed with updating the active color value as well? "I have created a merge request based on the recent patches, which means I only made changes to the hover color. The latest version of Drupal uses #002e9a as the active color value.
rinku jacob 13 → made their first commit to this issue’s fork.
rinku jacob 13 → made their first commit to this issue’s fork.
hi , I thoroughly investigated the issue, and it appears that the problem occurred due to the stacking order of the popover being higher than that of the admin toolbar. To fix this, I modified the stacking order of the popover without altering the existing --admin-toolbar-z-index-popover. Instead, I introduced a new variable named --admin-toolbar-z-index-popover-wrapper and set its value to 98, since the admin toolbar's z-index is 99. Could someone please confirm if I'm on the right track or if any modifications are needed to my MR?
Hello @finnsky , Thanks for the review. I noticed the error and I'm currently working on fixing the issue.
rinku jacob 13 → changed the visibility of the branch 3511047-navigation-sidebar-alignment to hidden.
When I tried to create the first MR, the issue was on the 11.1.x branch. so i created MR according to that .Now, the branch has changed to 11.x, so I will create a new branch and merge request for this issue. I believe the merging is happening on the 11.x branch
rinku jacob 13 → made their first commit to this issue’s fork.
I have created a new merge request on a new branch and made adjustments to remove the tight space between the toolbar header logo and the titles.
.
I also updated the backlink hover style.
Could you please review the merge request?
rinku jacob 13 → changed the visibility of the branch 3511047-navigation-sidebar-logo to hidden.
i will work on this issue
rinku jacob 13 → made their first commit to this issue’s fork.
"Hi @mherchel, I have renamed the primary colors and created a merge request based on that. The variable --color--primary-95 does not exist in the theme. Instead, --color--primary-80 is available. Can you please confirm once?
rinku jacob 13 → changed the visibility of the branch 3257284-create-designs-for to hidden.
rinku jacob 13 → made their first commit to this issue’s fork.
@ckrin, Based on your comment, I have updated the block title color and created a merge request. Could you please verify it?
rinku jacob 13 → made their first commit to this issue’s fork.
Hi @mgifford, based on your comment, I have removed the -ms-high-contrast and rebuilt the functionality using the forced-color media query. Could you please check and confirm if it's on the right track?
rinku jacob 13 → made their first commit to this issue’s fork.
Hi @macsim, I have tested and verified your MR. This merge request adds a 'Distinguish Long and Short Quotes' filter option to the CKEditor-enabled filter settings.
After enabling the filter option, the
tag is being replaced with the
Even though I have made the menus clickable, they are not directing to the corresponding pages. Need to work on fixing this as well.
The above MR will fix the navigation link click issue. However, for the second-level menu, if there is a submenu, the page immediately refreshes. I need to work on fixing that issue. For the navigation link fix, I’m awaiting feedback from the maintainers to confirm if I’m on the right track. Once I receive approval, I will focus on addressing the second issue I discovered. Adding screen records for the reference.
Hi @mherchel,
I have reviewed Classy issue #2544868 regarding the removal of the 'clearfix' class. The clearfix classes have been removed from the template folder, where they were previously included for the Classy theme. However, for Claro, the clearfix classes are still present in both the .theme file and the ClaroPreRender.php file. Should I also remove them from these files? I have already removed the clearfix classes from the template folder and created an MR for that. Please review.
rinku jacob 13 → made their first commit to this issue’s fork.
rinku jacob 13 → made their first commit to this issue’s fork.
rinku jacob 13 → made their first commit to this issue’s fork.
Hi @blink38, I have reviewed your patch. It was successfully applied, and I can see the changes in my bootstrap.theme file. After the patch, the values for -bb-h1-color, -bb-h2-color, and -bb-h3-color should be sourced from the $color array. I didn't take a screenshot of the code change because no value was provided for the issue.
rinku jacob 13 → created an issue.
hi @fionamorrison23 , I believe this issue is not related to the theme. The problem seems to be connected to the Toolbar module, which is responsible for the admin toolbar. After testing, I don’t think this is an issue with the theme itself.
I tested this with the Olivero(core theme) theme as well, and I observed that the submenus are still not expanding, indicating that the problem is likely related to the Toolbar module rather than the theme.
I've created a Merge Request based on Proposed Resolution 2. Could you please review the Merge Request.
before the CSS style changes are applied
After the CSS changes:
rinku jacob 13 → made their first commit to this issue’s fork.
rinku jacob 13 → created an issue.
Re-rolled patch against 11.x-dev. Please review
rinku jacob 13 → created an issue.
Hi @tomislav.matokovic ,The merge request MR!583 has been tested and verified. After applying the MR, I can see an increased color contrast in the toggle. Adding screenshots for reference.
Hi smustgrave, The issue doesn't appear or isn't visible when the screen width is 100%. However, if the screen width is reduced to less than 90%, the issue will appear on the screen, so should I update the issue summary based on this?
@bwaindwain, I have reviewed and tested your MR on Drupal 11.x-dev, and it was successful in removing the table drag weights from core.libraries.yml. Additionally, I can see the changes reflected in the UI, including the alignment table drag functionality. The row weights link has also been updated as expected.Thanks @bwaindwain
@Nitin_shrivastava , Reviewed Your MR . it was successfully applied. Adding screenshot for the reference.
Rinku Jacob 13 → made their first commit to this issue’s fork.
Created new MR to fix the issue. Please review.
Rinku Jacob 13 → created an issue.
Hi @Nitin shrivastava , Successfully Applied your MR. Adding screen shots for the references.
Hi @shweta__sharma, Base theme of adminal theme is seven. so remove button color is inherited from seven theme.
do we need to follow any theme/design to style remove button?
for the example in claro theme they are used different style for remove button compared to other buttons. so can you please give any suggestion to style that.
@ Luke.Leber, I have checked this issue in my local. I can't able to see any text area over flows in revision log message.also text area's max-width is 100%.
I have checked this issue on my local . i couldn't able to reproduce this issue as well as i think the header doesn't need any style changes. @ivan.mihailov, can you please guide me how we can reproduce this issue
hi @DinuDodon, can you please include reproduce steps for this issue. i'am not able to reproduce this issue because of i couldn’t able to see search icon as well as other icons in the header section.
Created new Merge request for solving the issue, Please review
Rinku Jacob 13 → made their first commit to this issue’s fork.