- Issue created by @Chi
- Status changed to Needs review
about 2 years ago 3:09am 27 March 2023 - 🇮🇳India gauravvvv Delhi, India
I have updated the selector in the patch. please review
- Assigned to rinku jacob 13
- Issue was unassigned.
- 🇮🇳India Akshay kashyap
@Gauravvvv Thanks for the work. I have applied your patch it's working fine
- Status changed to RTBC
about 2 years ago 10:53am 27 March 2023 - 🇷🇺Russia Chi
"system-status-report__entry__value" class looks weird. It doesn't follow BEM naming convention.
- First commit to issue fork.
- @rckstr_rohan opened merge request.
- Status changed to Needs review
about 2 years ago 3:37pm 27 March 2023 - 🇮🇳India rckstr_rohan
Assuming that the "system-status-report__entry__value" is a component or element of a larger system status report UI, I would name it using the BEM methodology as follows:
Block: system-status-report
Element: entry
Modifier: valueThus, the complete BEM name for this element would be "system-status-report__entry--value".
- 🇷🇺Russia Chi
Modifier: value
I think "value" is not a modifier here but element. That template initially had weird class names. Fixing them is out of scope of this issue.
Patch #3 looks good. The only concern here is that element "system-status-report__entry__value" has no parent component.
- Status changed to RTBC
about 2 years ago 1:25am 28 March 2023 - 🇺🇸United States smustgrave
Would agree with #13 but since it's currently not using a parent think it should be safe.
#3 fixed the issue.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Removing credit for the MR, as there was already an RTBC patch beforehand
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Confirmed the existing template uses
system-status-report__entry__value
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Not granting credit for the screenshots, which would have been useful, but unfortunately don't show a h3 element
here's some before/after shots with a hacked in h3 that was in caps in the source (ie the capitalization isn't from CSS).
This seems like a simple misnamed selector in the file, so going to commit.
-
larowlan →
committed bc217933 on 10.0.x
Issue #3350387 by Gauravvvv, Chi: Claro: fix size of H3 elements in...
-
larowlan →
committed bc217933 on 10.0.x
-
larowlan →
committed a21a8cb7 on 10.1.x
Issue #3350387 by Gauravvvv, Chi: Claro: fix size of H3 elements in...
-
larowlan →
committed a21a8cb7 on 10.1.x
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Committed to 10.1.x and backported to 10.0.x and 9.5.x
-
larowlan →
committed 7dcaebdf on 9.5.x
Issue #3350387 by Gauravvvv, Chi: Claro: fix size of H3 elements in...
-
larowlan →
committed 7dcaebdf on 9.5.x
- Status changed to Fixed
about 2 years ago 1:11pm 3 April 2023 - 🇺🇸United States drumm NY, US
(Updating to resolve Drupal.org issue indexing issue, please disregard)