the section config error
Install and configured the module with instance, looks good,but the section getting config failure, even I have configured the section.io through the docs. so may be the problem from section.io as tried multiple times.
will proceed now, have done some in past will complete and update, thanks.
yeah i was getting the core same error, I don't use Skeleton, but my issue get fixed by patch #6 , thanks.
Drupal version: 9.4
Reviewed the MR, looks good to go, can be merge.thanks.
rckstr_rohan → made their first commit to this issue’s fork.
Reviewed and Tested , Patch corrects the requirement i.e spelling correction, moving to RTBC.
The MR looks good, fixed the issue, also the preview is aligned as expected by @sonam.chaturvedi on #7 , thnks
Applied the MR and check the Help text, well concerned, addressing the issue requirement, moving to RTBC , thanks.
issue is dependent on the https://www.drupal.org/project/drupal/issues/3350481 🐛 permissions are sorted by title but with the wrong comparison operator Closed: duplicate , so as the prior is not resolved, keeping it in Active state
failed cases indentified Deprecated NULL placeholder value for key (%type_name), would refine more on it.
until the issue is not resolved,
https://www.drupal.org/project/drupal/issues/3350482
🐛
PermissionHandler class docs to specify how permissions are sorted
Active
can't be moved.
rckstr_rohan → made their first commit to this issue’s fork.
rckstr_rohan → made their first commit to this issue’s fork.
Hi, @cosmicdreams, reviwed the patch #5, it works well but the patch fixes is inside core, so or for MR need to ovwerwite the same class in the module css.
Hi @Mahima thanks for the review, have made a MR , Taking back to Needs Review, thanks.
the issue, summary say Olivero theme but the above patch is for claro, demo_umami and starterkit_theme, looks summary needs to be updated:
Suggestion:
The 'forms-inline' class should ensure all direct descendants are inline within all the core themes provided namely: claro, olivero, demo_umami and starter kit
created a MR, as per the new administer block content permission, pls review, suggestions are welcomed.thanks
Created mR for the above requirement, pls review.
rckstr_rohan → made their first commit to this issue’s fork.
Added a patch with interdiff to #3, adding Untitled as title when title is not present.
Added Configurations in Readme , please Review
rckstr_rohan → made their first commit to this issue’s fork.
@smustgrave yeah now i noticed spaceless filter
{{
"
"|spaceless }}
is #118 good or should I make a patch to spaceless filter
Addressed #119 and #120, used https://twig.symfony.com/doc/2.x/tags/spaceless.html
The CSS codes are available in the repository.
grep -r 'form--inline' core/themes/olivero
make a little change to the doc comment
rckstr_rohan → made their first commit to this issue’s fork.
InfoParserException exception can handle 'core_version_requirement' issue.
rckstr_rohan → made their first commit to this issue’s fork.
Read the doc and replaced Token::replace($text, $data) with \Drupal::token()/, ready to review, thanks.
rckstr_rohan → made their first commit to this issue’s fork.
little bit confused about the issue, as this is a CMS, you can go the Basic Site Settings and check/update the homepage, all pages are treated as node , so I wont confirm about the requirement of this issue.
the T() calls are made called in class with this keyword, that's is the best solution available till now, so the patch #2 is good to go, thasnks
rckstr_rohan → made their first commit to this issue’s fork.
Re-rolled Patch #5 for 2.1.x-dev
the unused import has been removed by #2 , RTBC +1 , not moving to RTBC as its assigned ticket.
MR!6 looks good removed LICENSE.TXT file with all its phrases, can be merged and moved to fixed, thanks.
Readme.md looks good with the proper understanding of the context of the module, format is also as per drupal, request the maintainers to merge. thanks.
Added A mR to remove the [ ] from count, other method would be by applying "replace" filter, but as it is not needed, so no use. thanks.
rckstr_rohan → made their first commit to this issue’s fork.
rckstr_rohan → made their first commit to this issue’s fork.
The patch looks not following the patch format, please follow https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →
Hii, @vuil i think only maintainers have the rights to release a new version, also I am willing to MAINTAINER of the module, as it have high scope for development and usability as social site Instagram is always on trends.
rckstr_rohan → made their first commit to this issue’s fork.
reviewed the automated patches, worked well as I can able to use the module in D10, can be merged and moved to fix.
Attaching interdiff, thanks.
his , use a mapping to retrieve the correct translation for each label is more useful for dynamic datas
Example:
{% set adjustmentTranslations = {
'shipping': 'Shipping',
'tax': 'Tax',
'discount': 'Discount',
'fee': 'Fee',
} %}
{% for adjustment in totals.adjustments %}
{% endfor %}
hii, addressed the 3 $op in node.module, as they are not part of hooks [hook_query_alter() ] mentioned above, should they be replaced .
as per my suggestion this hooks also seems to be a part , please confirm, then will proceed with patch.
Checked the MR, looks good, settings and configuration has been removed, no break found while using the module with the MR. Can be moved to the Fixed.
hii, The above patch failed because the branch has been updated with file layout-builder.php, so removing the file from the patch and adding assertion after to the check the expected value after test run, addressed #55.
indiff is same as #60
rckstr_rohan → made their first commit to this issue’s fork.
hi, i checked D10.1 , $op argument is not found in documentations, can you specify where the changes need to be done, thanks
i think there are 2 ways,
To keep people actively testing we can add a checklist for manual test to validate SDC
OR
To use the technologies and independent from the human mistakes, we can use automation testing.
Addressed #55 adding an assertion after to the check the expected value after test run.
Hi, i have some eye dryness infesction due to laptop, mobile rays, so keeping myself away for 10 days as instructed by doctor, will surly work on it after a week, thanks.
reviewed the MR, looks good and optimised, didn't find any issue while adding new block to a category leads.
rckstr_rohan → made their first commit to this issue’s fork.
hi as @andypost extension.list.module is not yet stable, in D10, is it good to use it here?
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...
Reviewed the patch, looks optimized, suggestions
if (!empty($this->getNid())) {
if ($this->getAgreeNode()) {
Instead can be used:
if ((!empty($this->getNid()) && ($this->getAgreeNode())) {
Hi @ultimike, sorry for late response, have taken your comments in consideration and have made some changes, please review.
thanks for the information, yes will go through it and start using
understand the /dev/null importance, thanks
making more correction to the #40
Creating a Patch because the mR is not mergeable, asking for rebase.
the patch in #40 failed due to drupal PHP standards, just modifying the PHP standards.
Nowadays unrelated failure are more, any specific reasons, previously too test case were there.
Willing to investigate on these failures and how to quick fix them.
so whats the next step ?
okay proceeding with the gif , that will start with the Smart Trim Logo and will show a small walkthrough to the module, assigning to myself coz, will understand the working of module and make a gif , keeping in mind the assessibilty.
hii @ultimike addressed the comments. thanks
hi @ultimike, we can do both, once the maintainers confirm, I will proceed.
i think the gif would not have audio, so if we are preparing a gif, I should be a walkthrough.
hi @lauriii , how to tackle the issue with all the themes, specifically making changes in all of them or is there any one time way, pls suggest
yes i install the module though composer require
Can we add a video with audio explaining the user experience of the action of module, this is a video made by the #3 screenshots, if like this idea, we can make a short summary video.
Added a MR for the contribution.md file as per my understanding, suggestions are welcome, module looks good to be , will try to pick more issues, thanks.
rckstr_rohan → made their first commit to this issue’s fork.
starting to work on it, will perform the test to the latest MR today
The failure occurred in the testContextualLinks function, where there was an assertion failure due to a NULL value being evaluated as empty.
To correct this issue, the code for the JSWebAssertTest class needs to be reviewed and corrected. It is likely that the testJsWebAssert method needs to be updated to account for changes in the web page during testing. Additionally, the WebDriver configuration may need to be updated to ensure that it is properly interacting with the web page
The failing tests are related to the Drupal\FunctionalJavascriptTests\Tests\JSWebAssertTest class, specifically to the testJsWebAssert method. The error message suggests that there was a problem with the WebDriver, specifically with a stale element reference. This could be caused by the web page changing before the test could complete, or by an error in the test script itself.
craeted a MR with Replaced deprecated functions,
rckstr_rohan → made their first commit to this issue’s fork.
reviewed #2 and also Created MR for convenience, after removing the unused Paypal dependency, the module worked as expected, no issue detected, can be merged, thanks.
rckstr_rohan → made their first commit to this issue’s fork.
reviewed the issue on Link Checker module on D9.5, MR !41 is good , no issue found after installation.
Moving to RTBC. Thanks
rckstr_rohan → made their first commit to this issue’s fork.
rckstr_rohan → made their first commit to this issue’s fork.
rckstr_rohan → made their first commit to this issue’s fork.
rckstr_rohan → made their first commit to this issue’s fork.
Assuming that the "system-status-report__entry__value" is a component or element of a larger system status report UI, I would name it using the BEM methodology as follows:
Block: system-status-report
Element: entry
Modifier: value
Thus, the complete BEM name for this element would be "system-status-report__entry--value".
rckstr_rohan → made their first commit to this issue’s fork.
Created MR for the issue for convenience.
rckstr_rohan → made their first commit to this issue’s fork.
rckstr_rohan → made their first commit to this issue’s fork.