- Issue created by @gauravvvv
- Status changed to Needs review
almost 2 years ago 3:56am 27 March 2023 - ๐ฎ๐ณIndia gauravvvv Delhi, India
I have added trans filter to static text in the patch #2, please review
- Assigned to Guru2023
The last submitted patch, 2: 3350526-2.patch, failed testing. View results โ
- Issue was unassigned.
- ๐ฎ๐ณIndia Guru2023
I have reviewed patch #2. And it applied successfully. Please see attached screenshot.
- First commit to issue fork.
- ๐ฎ๐ณIndia Akshay kashyap
@Gauravvvv Thanks for the work. Applied patch #2 cleanly. Now It looks good. Its Added a trans filter in the status-report-counter.html.twig file.
- Status changed to RTBC
almost 2 years ago 5:42am 28 March 2023 - Status changed to Needs work
almost 2 years ago 8:23am 29 March 2023 - ๐ซ๐ฎFinland lauriii Finland
This bug is not specific to Claro โ it exists in all instances of the template. Since this is a straight forward change, let's fix it in all of the templates at once.
- ๐ฎ๐ณIndia rckstr_rohan
hi @lauriii , how to tackle the issue with all the themes, specifically making changes in all of them or is there any one time way, pls suggest
- ๐ซ๐ฎFinland lauriii Finland
@rckstr_rohan You could search for all instances of
status-report-counter.html.twig
template in core, and make the change manually to those files. ๐ - Status changed to Needs review
almost 2 years ago 6:32am 30 March 2023 - ๐ฎ๐ณIndia rassoni Bangalore
Address #10 feedback point.
git grep '</span>Details</a>' | awk -F: '{print $1}' | sort -u | nl
~/projects/drupal-d10 (10.1.x*) ยป git grep '</span>Details</a>' | awk -F: '{print $1}' | sort -u | nl rashmi.krishnachand@FVFH90DXQ05N 1 core/modules/system/templates/status-report-counter.html.twig 2 core/themes/claro/templates/status-report-counter.html.twig 3 core/themes/stable9/templates/admin/status-report-counter.html.twig
Found few new files and updated. Please review
- Status changed to RTBC
almost 2 years ago 6:42am 30 March 2023 - ๐ซ๐ฎFinland lauriii Finland
Thanks, @Rassoni! Patch looks good, and I confirmed with the command you provided that there aren't any remaining instances of this problem.
-
lauriii โ
committed d33a870f on 10.1.x
Issue #3350526 by Rassoni, Gauravvvv: trans filter is missing on text in...
-
lauriii โ
committed d33a870f on 10.1.x
- Status changed to Fixed
almost 2 years ago 7:21am 30 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.