🇮🇳India @Rashmisoni

Fixed Cache issue.

Rassoni → created an issue.

Rassoni → created an issue.

Rassoni → created an issue.

Rassoni → made their first commit to this issue’s fork.

After making changes, please refer to the images below to see how the page will appear.

Rassoni → made their first commit to this issue’s fork.

Fixed CCF failed.

Addressed #37 fixed patch applied failed. #28 comments Found few new files address that accordingly.

grep -r http://drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl

• core/modules/link/tests/src/Functional/LinkFieldUITest.php : changed
• core/tests/Drupal/Tests/Component/Plugin/PluginHelperLegacyTest.php : not change, part of deprecation message

grep -r https://drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl

• core/modules/announcements_feed/tests/src/Unit/AnnounceFetcherUnitTest.php : not change, test validate url sample
• core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaTest.php : changed
• core/modules/link/tests/src/FunctionalJavascript/LinkFieldFormStatesTest.php : changed
• core/modules/update/tests/src/Unit/ProjectReleaseTest.php : changed
• core/tests/Drupal/FunctionalTests/HttpKernel/CorsIntegrationTest.php : not change, test validate url sample
• core/tests/Drupal/Tests/Core/Logger/LogMessageParserTest.php : changed

grep -r http://www.drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl

• core/modules/media/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php - D10 does not exist.
• core/tests/Drupal/Tests/Core/Ajax/AjaxCommandsTest.php : not change, part of deprecation message

Rassoni → created an issue.

Address #4. Renamed field label and field machine name with all dependencies. Also fixed test cases failed issue.

Rassoni → made their first commit to this issue’s fork.

Rassoni → made their first commit to this issue’s fork.

Within this MR, I have updated the author image.csv. Currently, In image.csv , there are three columns of 18-20 image content linked to the umami block and the footer image content.

Umami admin side all users related to recipes or articles, Should we update for this author of three columns? If we do not update this content, then umami user is not able to delete completely.

Re-roll against D10.

Sorry for converting patch into MR due to local CI failed.Please review MR.

Below points addressed:

• CSpell - demo-umani to correct word demo-umami
• I think that the "What to do when you are ready to build your Drupal website" should be split out with it's own tag. This would make it clearer that it is not a 'use' of Umami.
• The
  

  s should be changed to
  

  s. This is a HTML schematic error and could be an a11y issue.

Rassoni → made their first commit to this issue’s fork.

Fixed Custom failed to patch #17 for D10.

Fixed Custom failed to patch #4for D10.
Addressed #5 feedback points.

I think that the "What to do when you are ready to build your Drupal website" should be split out with it's own tag. This would make it clearer that it is not a 'use' of Umami.

- Addressed

The <h3>s should be changed to <h2>s. This is a HTML schematic error and could be an a11y issue.

- Addressed

Addressed #52 feedback point. Tried to locate the (Anna Christoforou) author's Drupal org account, but not able to locate the user(Anna Christoforou). For consistency, follow the contents of the license text file and mention the user with the user's image.

Please check PHPCS issues:

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml darcula 

FILE: ~/projects/drupal-d10/themes/custom/darcula/css/components/views-ui.css
------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------
 180 | ERROR | [x] Multiple selectors should each be on a single line
 184 | ERROR | [x] Multiple selectors should each be on a single line
------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------


FILE: ~/projects/drupal-d10/themes/custom/darcula/css/components/fieldset.css
------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------
 59 | ERROR | [x] Expected 1 space before opening brace of class definition; 2 found
------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------


FILE: ~/projects/drupal-d10/themes/custom/darcula/css/components/action-link.css
---------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------
 27 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------

Time: 157ms; Memory: 10MB

Fixed Build failure.

Addressed #13 Please review.

Remove unnecessary use statement .

Re-roll against 2.1.x branch.

Rassoni → made their first commit to this issue’s fork.

Rassoni → made their first commit to this issue’s fork.

#14 review locally. Patch applied successfully, but below issues are still pending.

FILE: ~/projects/drupal-d10/modules/contrib/pwa/src/Form/ManifestConfigurationForm.php
------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------
 150 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 164 | WARNING | Unused variable $wrapper.
 167 | WARNING | Unused variable $realpath.
------------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/pwa/src/Manifest.php
------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------
 169 | WARNING | Unused variable $lang.
------------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/pwa/src/Controller/PWAController.php
---------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------
 211 | ERROR   | Using the e flag in preg_match_all is a possible security risk. For details see https://www.drupal.org/node/750148
 246 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------

Time: 266ms; Memory: 12MB

Patch #7 applied. #9 image not able to find complete pending issue list so attaching pending issues.

FILE: ~/projects/drupal-d10/modules/contrib/config_partial_export/src/Commands/ConfigPartialExportCommands.php
--------------------------------------
FOUND 51 ERRORS AND 2 WARNINGS AFFECTING 49 LINES
-----------------------------------------
  23 | ERROR   | Missing short description in doc comment
  28 | ERROR   | Missing member variable doc comment
  30 | ERROR   | Missing member variable doc comment
  32 | ERROR   | Missing member variable doc comment
  34 | ERROR   | Missing member variable doc comment
  36 | ERROR   | Missing member variable doc comment
  38 | ERROR   | Missing member variable doc comment
  40 | ERROR   | Missing member variable doc comment
  42 | ERROR   | Missing member variable doc comment
  44 | ERROR   | Missing short description in doc comment
  49 | ERROR   | Missing short description in doc comment
  50 | ERROR   | Missing parameter comment
  51 | ERROR   | Missing parameter comment
  52 | ERROR   | Missing parameter comment
  53 | ERROR   | Missing parameter comment
  54 | ERROR   | Missing parameter comment
  55 | ERROR   | Missing parameter comment
  56 | ERROR   | Missing parameter comment
  57 | ERROR   | Missing parameter comment
  58 | ERROR   | Missing parameter comment
  59 | ERROR   | Missing parameter comment
  78 | ERROR   | Missing parameter type
  80 | ERROR   | Missing parameter type
  81 | WARNING | Line exceeds 80 characters; contains 112 characters
  83 | WARNING | Line exceeds 80 characters; contains 88 characters
 163 | ERROR   | Parameter $destination_dir is not described in comment
 176 | ERROR   | Public method name "ConfigPartialExportCommands::_config_partial_export_write_config" is not in lowerCamel format
 203 | ERROR   | Public method name "ConfigPartialExportCommands::_config_partial_export_get_wildcard_keys" is not in lowerCamel format
 242 | ERROR   | Public method name "ConfigPartialExportCommands::_config_partial_export_get_changes" is not in lowerCamel format
 265 | ERROR   | Missing short description in doc comment
 266 | ERROR   | Missing parameter comment
 267 | ERROR   | Description for the @return value is missing
 269 | ERROR   | Public method name "ConfigPartialExportCommands::_user_abort" is not in lowerCamel format
 269 | ERROR   | Type hint "null" missing for $msg
 275 | ERROR   | Missing short description in doc comment
 276 | ERROR   | Missing parameter comment
 276 | ERROR   | Missing parameter type
 277 | ERROR   | Missing parameter comment
 278 | ERROR   | Missing parameter comment
 279 | ERROR   | Missing parameter comment
 280 | ERROR   | Description for the @return value is missing
 282 | ERROR   | Public method name "ConfigPartialExportCommands::_choice" is not in lowerCamel format
 354 | ERROR   | Missing short description in doc comment
 355 | ERROR   | Missing parameter comment
 355 | ERROR   | Missing parameter type
 356 | ERROR   | Missing parameter comment
 357 | ERROR   | Missing parameter comment
 358 | ERROR   | Missing parameter comment
 359 | ERROR   | Description for the @return value is missing
 361 | ERROR   | Public method name "ConfigPartialExportCommands::_print_table" is not in lowerCamel format
 361 | ERROR   | Type hint "null" missing for $handle
 372 | ERROR   | Doc comment is empty
 375 | ERROR   | Public method name "ConfigPartialExportCommands::_drush_format_table" is not in lowerCamel format
---------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/config_partial_export/src/Utility/CommandHelper.php
-------------------------------------------------
FOUND 25 ERRORS AFFECTING 25 LINES
-----------------------------------------------
  22 | ERROR | Missing short description in doc comment
  27 | ERROR | Missing member variable doc comment
  29 | ERROR | Missing member variable doc comment
  31 | ERROR | Missing member variable doc comment
  33 | ERROR | Missing member variable doc comment
  35 | ERROR | Missing member variable doc comment
  37 | ERROR | Missing member variable doc comment
  39 | ERROR | Missing member variable doc comment
  41 | ERROR | Missing member variable doc comment
  43 | ERROR | Missing short description in doc comment
  48 | ERROR | Missing short description in doc comment
  49 | ERROR | Missing parameter comment
  50 | ERROR | Missing parameter comment
  51 | ERROR | Missing parameter comment
  52 | ERROR | Missing parameter comment
  53 | ERROR | Missing parameter comment
  54 | ERROR | Missing parameter comment
  55 | ERROR | Missing parameter comment
  56 | ERROR | Missing parameter comment
  57 | ERROR | Missing parameter comment
  58 | ERROR | Missing parameter comment
  74 | ERROR | Parameter $destination_dir is not described in comment
  87 | ERROR | Public method name "CommandHelper::_config_partial_export_write_config" is not in lowerCamel format
 114 | ERROR | Public method name "CommandHelper::_config_partial_export_get_wildcard_keys" is not in lowerCamel format
 153 | ERROR | Public method name "CommandHelper::_config_partial_export_get_changes" is not in lowerCamel format
------------------------------------------------------
Time: 196ms; Memory: 12MB

Review patch and tested locally. Mention all phpcs issues are resolved. RTBC +

Rassoni → made their first commit to this issue’s fork.

Rassoni → made their first commit to this issue’s fork.

Rebase the branch. Please review.

Rassoni → made their first commit to this issue’s fork.

Rassoni → made their first commit to this issue’s fork.

Updated MR. Found file and updated the content. Please review.

@aziza_a: #4 is not complete and not change the status due to working on this.

Thanks @smustgrave I am working on this.

Rassoni → made their first commit to this issue’s fork.

Rassoni → made their first commit to this issue’s fork.

Addressed #16 Feedback.

Also, it would be worth making them consistent whilst we're here (one has single quotes around the field name and entity type, the other does not).

Not changing status #16 remaining part.

Please check PHPCS issues.

command :

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml dalim_es    

FILE: ~/projects/drupal-d10/modules/contrib/dalim_es/css/dalim-es-style.css
----------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------
 156 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 157 | ERROR | [x] Blank lines are not allowed in class definitions
 194 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 195 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 196 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 206 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/dalim_es/css/dalim-es-field-style.css
----------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 21 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/dalim_es/README.md
---------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
---------------------------------------------------------------------------------------
 13 | WARNING | Line exceeds 80 characters; contains 204 characters
 15 | WARNING | Line exceeds 80 characters; contains 173 characters
 17 | WARNING | Line exceeds 80 characters; contains 98 characters
 37 | WARNING | Line exceeds 80 characters; contains 90 characters
 49 | WARNING | Line exceeds 80 characters; contains 123 characters
 58 | WARNING | Line exceeds 80 characters; contains 133 characters
 59 | WARNING | Line exceeds 80 characters; contains 129 characters
 67 | WARNING | Line exceeds 80 characters; contains 135 characters
 71 | WARNING | Line exceeds 80 characters; contains 104 characters
 75 | WARNING | Line exceeds 80 characters; contains 272 characters
 77 | WARNING | Line exceeds 80 characters; contains 302 characters
---------------------------------------------------------------------------------------

Time: 452ms; Memory: 18MB

PHPCS coding standard issues:

Command

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml codario 

FILE: ~/projects/drupal-d10/modules/contrib/codario/codario.module
-------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------
  6 | ERROR | [x] There must be exactly one blank line after the file comment
 12 | ERROR | [x] Expected 1 blank line before function; 2 found
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/codario/src/Form/CodarioSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
 175 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 175 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 182 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 245 | WARNING | File::load calls should be avoided in classes, use dependency injection instead
 246 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 272 | WARNING | File::load calls should be avoided in classes, use dependency injection instead
 274 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/codario/src/Form/CodarioResetSettingsForm.php
------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------
  6 | WARNING | [x] Unused use statement
  7 | WARNING | [x] Unused use statement
  9 | WARNING | [x] Unused use statement
 29 | ERROR   | [ ] Doc comment for parameter $configFactory does not match actual variable name $codarioHelper
 52 | ERROR   | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/codario/src/CodarioHelper.php
--------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 5 WARNINGS AFFECTING 8 LINES
--------------------------------------------------------------------------------------------------
   5 | WARNING | [x] Unused use statement
  13 | WARNING | [x] Unused use statement
 115 | ERROR   | [x] Expected "bool" but found "boolean" for function return type
 152 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 169 | ERROR   | [x] Expected newline after closing brace
 174 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 174 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
 188 | ERROR   | [x] Expected 1 blank line after function; 0 found
 189 | ERROR   | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

Time: 152ms; Memory: 10MB

Fixed CC issue

Fix patch failed 10.1.x branch (not include test cases issues)

Reviewed MR and MR tested locally. PHPCS issues are fixed.

Review the MR and check MR locally. After checkout MR branch all fps issues are resolved.

Attached Interdiff

Addressed #10 feedback point. Please review

Addressed #5.

Thank you @apaderno for more clarity regarding issue for phpstan.

@luannguyen: Yes, #18 and #20 reports are different. As mention on #23 file PHPSTAN issues. Running command is generating same issues.

I am following below steps to regenerate the phpstan issues.

• Installed PHPSTAN via https://github.com/mglaman/phpstan-drupal
• Not configured any level on PHPSTAN.neon file. if required adding level in command.
• running this command php -d memory_limit=4G vendor/bin/phpstan analyse modules/contrib/wordsonline_connector

if you check #18 and #23 files all PHPSTAN issues are already verified.
Major issues are related to tmgmt as per comment #21 we can go forward.

Call to static method load() on an unknown class Drupal\tmgmt\Entity\Job.

Static method load is exists on class Drupal\tmgmt\Entity\Job because it is inherited from class ContentEntityInterface through interface JobInterface.

Parameter $job of method
Drupal\tmgmt_wordsonline\Controller\OrderController::importTranslation() has invalid type Drupal\tmgmt\JobInterface.

Because Drupal\tmgmt\Entity\Job is inherited from Drupal\tmgmt\JobInterface , this should not be an error.

\Drupal calls should be avoided in classes, use dependency injection
instead

All issues are already answered and regarding #23 issues already covered by #26 comments.

Major if checking #18 and #23 files major issues are already rectified and answered.

Please let me know if we need to check any other way to generate PHPSTAN file like #20

@luannguyen : As per #21 comment. tmgmt issues if we are avoiding then below issue needs to fix related to Drupal calls.

------ ------------------------------------------------------------------------------ 
  Line   src/Common/ZipHandle.php                                                      
 ------ ------------------------------------------------------------------------------ 
  68     \Drupal calls should be avoided in classes, use dependency injection instead  
 ------ ------------------------------------------------------------------------------ 

@luannguyen Yes, I have not passed any level on command so it will check all issues.

If you passing level 0 then only

 basic checks, unknown classes, unknown functions, unknown methods called on $this, wrong number of arguments passed to those methods and functions, always undefined variables
 

You can refer this document for level https://phpstan.org/user-guide/rule-levels

@luannguyen : I have tested on 1.0.x branch. Please find the text file for PHPSTAN issues.

Command run : php -d memory_limit=4G ../../vendor/bin/phpstan analyse wordsonline_connector

Fixed test failed issues. Please review as empty_vocabulary test checked Update preview button.

Fixed cs commands

Address #10 feedback point.

git grep '</span>Details</a>' | awk -F: '{print $1}' | sort -u | nl

~/projects/drupal-d10 (10.1.x*) » git grep '</span>Details</a>' | awk -F: '{print $1}' | sort -u | nl                       rashmi.krishnachand@FVFH90DXQ05N
     1	core/modules/system/templates/status-report-counter.html.twig
     2	core/themes/claro/templates/status-report-counter.html.twig
     3	core/themes/stable9/templates/admin/status-report-counter.html.twig

Found few new files and updated. Please review

Rassoni → created an issue.

Rassoni → created an issue.

@sourabhjain majorly two MR was created and has same code like patch 12. If an issue is using a patch workflow then it is usually best to continue with that. Introducing an multiple MR can cause confusion, as in this case. and sometimes duplication of work.

Patch #35 Verified and tested locally on Drupal 10.1.x.
Patch applied successfully and looks good to me.


Testing steps:

1. Goto admin/structure/types/manage/basic page

2. Observe that the title description field is absent.

3. Apply the patch.

4. Reload.

5. Observe that the title description field has been added.


Testing Result:
 After applying the patch the title description field appears.


Review patched #12 and applied locally. Below issue still present.

FILE: ~/projects/drupal-d10/modules/contrib/rabbit_hole/README.md
------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------
 31 | WARNING | Line exceeds 80 characters; contains 98 characters
------------------------------------------------------------------------------------------

Time: 589ms; Memory: 14MB

Reviewed MR below issues still pending

FILE: ~/projects/drupal-d10/modules/contrib/s3fs/modules/s3fs_streamwrapper/tests/src/Kernel/S3fsBucketStreamWrapperTest.php
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
 28 | WARNING | Unused variable $type.
-------------------------------------------------------------------------


FILE: ~/projects/drupal-d10/modules/contrib/s3fs/src/Form/ActionsForm.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------
 239 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 290 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 373 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------

Time: 1.66 secs; Memory: 18MB

--------------------------------------------------------------------------
~/projects/drupal-d10/modules/contrib (10.1.x*) » phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml s3fs

FILE:~/projects/drupal-d10/modules/contrib/s3fs/src/Form/ActionsForm.php
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------
 239 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 290 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 373 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------

Time: 1.65 secs; Memory: 18MB

Interdiff attached

Address #39feedbacks. Re-roll against #26Please review.

PHPSTAN issues:

php vendor/bin/phpstan analyse modules/contrib/eu_cookie_compliance_gtm

 2/2 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   eu_cookie_compliance_gtm.module                                                                                                                   
 ------ -----------------------------------------------------
  87     Parameter $menu of function eu_cookie_compliance_gtm_category_form_builder() has invalid type Drupal\eu_cookie_compliance\Entity\CookieCategory.  
 ------ ----------------------------------------------------

 ------ ------------------------------------------------------
  Line   tests/src/Functional/LoadTest.php                                                                                                                   
 ------ ------------------------------------------------------
  13     Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055, which includes recommendations on which theme to  
         use.                                                                                                                                                
  32     Return type mixed of method Drupal\Tests\eu_cookie_compliance_gtm\Functional\LoadTest::setUp() is not covariant with return type void of method     
         PHPUnit\Framework\TestCase::setUp().                                                                                                                
 ------ ---------------------------------------------

Tested locally after applying #2 patch changes are reflected as per proposed resolution. The table has module-list class according to labels are replaced with Proposed resolution. Attached screenshot and video for reference.

Steps to Test:

1. Download #29 Patch locally and apply it.
2. Clear cache.
3. Navigate to structure -> view and edit any view which contains table format.
4. Check in mobile view version, Lables are reflected as per Proposed resolution.

Thanks @apaderno, Addressed #5 feedback. Please review

Sorry wrong interdiff.

Addressed the points mentioned in #38 in Patch #40, Currently, Parent loops is not using $key So used $key instead of $sub_key and that loop ended in line no 65. IMO line number 91 changes not required as it starts with different loop. Please review.

Fixed coding standard and created MR. Please Review.

Rassoni → created an issue.

Fixed Coding standard and created MR. Please review.

Rassoni → created an issue.