The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- last update
almost 2 years ago Patch Failed to Apply - Status changed to Needs review
almost 2 years ago 12:57pm 4 May 2023 21:04 20:10 Running- 🇮🇳India rassoni Bangalore
Addressed #37 fixed patch applied failed. #28 comments Found few new files address that accordingly.
grep -r http://drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl
- core/modules/link/tests/src/Functional/LinkFieldUITest.php : changed
- core/tests/Drupal/Tests/Component/Plugin/PluginHelperLegacyTest.php : not change, part of deprecation message
grep -r https://drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl
- core/modules/announcements_feed/tests/src/Unit/AnnounceFetcherUnitTest.php : not change, test validate url sample
- core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaTest.php : changed
- core/modules/link/tests/src/FunctionalJavascript/LinkFieldFormStatesTest.php : changed
- core/modules/update/tests/src/Unit/ProjectReleaseTest.php : changed
- core/tests/Drupal/FunctionalTests/HttpKernel/CorsIntegrationTest.php : not change, test validate url sample
- core/tests/Drupal/Tests/Core/Logger/LogMessageParserTest.php : changed
grep -r http://www.drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl
- core/modules/media/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php - D10 does not exist.
- core/tests/Drupal/Tests/Core/Ajax/AjaxCommandsTest.php : not change, part of deprecation message
- Status changed to RTBC
almost 2 years ago 9:39pm 6 May 2023 - 🇺🇸United States smustgrave
Applied patch and ran greps from #38 and every file not updated seems to be documented in #38 and #28.
Think this is good to go.
- last update
almost 2 years ago 29,379 pass - last update
almost 2 years ago 29,380 pass - last update
almost 2 years ago 29,383 pass - Status changed to Fixed
almost 2 years ago 1:01pm 11 May 2023 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!
I did wonder briefly about the update module tests which are faking Drupal.org data, but it's still example data and it's easier not to have exceptions.
Automatically closed - issue fixed for 2 weeks with no activity.