Convert drupal.org to example.com in tests

Created on 18 April 2018, about 6 years ago
Updated 11 May 2023, about 1 year ago

Problem/Motivation

I have found that some of the links are given the protocol http://www.drupal.org/. I think to have a secure mode of connection its better if we change it to https://www.drupal.org/ .

drumm pointed out in #21 📌 Convert drupal.org to example.com in tests Fixed that the remaining occurrences are in tests. And in tests we do need to to http:/.

Steps to reproduce

Proposed resolution

Change drupal.org in tests to example.com to indicate that the domain does not matter.

Remaining tasks

write a patch
review
commit

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

10.1

Component
PHPUnit 

Last updated about 15 hours ago

Created by

🇮🇳India bhanuprakashnani

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

  • 🇮🇳India Nikhil_110

    Re-roll patch #28 for Drupal 10.1.x

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    Patch Failed to Apply
  • Status changed to Needs review about 1 year ago
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    41:44
    40:50
    Running
  • 🇮🇳India Rashmisoni Bangalore

    Addressed #37 fixed patch applied failed. #28 comments Found few new files address that accordingly.

    grep -r http://drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl

    • core/modules/link/tests/src/Functional/LinkFieldUITest.php : changed
    • core/tests/Drupal/Tests/Component/Plugin/PluginHelperLegacyTest.php : not change, part of deprecation message

    grep -r https://drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl

    • core/modules/announcements_feed/tests/src/Unit/AnnounceFetcherUnitTest.php : not change, test validate url sample
    • core/modules/ckeditor5/tests/src/FunctionalJavascript/MediaTest.php : changed
    • core/modules/link/tests/src/FunctionalJavascript/LinkFieldFormStatesTest.php : changed
    • core/modules/update/tests/src/Unit/ProjectReleaseTest.php : changed
    • core/tests/Drupal/FunctionalTests/HttpKernel/CorsIntegrationTest.php : not change, test validate url sample
    • core/tests/Drupal/Tests/Core/Logger/LogMessageParserTest.php : changed

    grep -r http://www.drupal.org core | egrep Test\*.php | awk -F: '{print $1}' | sort -u | nl

    • core/modules/media/tests/src/FunctionalJavascript/CKEditorIntegrationTest.php - D10 does not exist.
    • core/tests/Drupal/Tests/Core/Ajax/AjaxCommandsTest.php : not change, part of deprecation message
  • Status changed to RTBC about 1 year ago
  • 🇺🇸United States smustgrave

    Applied patch and ran greps from #38 and every file not updated seems to be documented in #38 and #28.

    Think this is good to go.

  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    29,379 pass
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    29,380 pass
  • Open in Jenkins → Open on Drupal.org →
    Environment: PHP 8.1 & MySQL 5.7
    last update about 1 year ago
    29,383 pass
    • catch committed a51a50e0 on 10.1.x
      Issue #2962088 by yogeshmpawar, jvsouto, Rassoni, Prashant.c,...
    • catch committed dd5a5b71 on 11.x
      Issue #2962088 by yogeshmpawar, jvsouto, Rassoni, Prashant.c,...
  • Status changed to Fixed about 1 year ago
  • 🇬🇧United Kingdom catch

    Committed/pushed to 11.x and cherry-picked to 10.1.x, thanks!

    I did wonder briefly about the update module tests which are faking Drupal.org data, but it's still example data and it's easier not to have exceptions.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024