- 🇮🇳India rassoni Bangalore
PHPCS coding standard issues:
Command
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml codario
FILE: ~/projects/drupal-d10/modules/contrib/codario/codario.module ------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ------------------------------------------------------------------------------------------- 6 | ERROR | [x] There must be exactly one blank line after the file comment 12 | ERROR | [x] Expected 1 blank line before function; 2 found ------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------- FILE: ~/projects/drupal-d10/modules/contrib/codario/src/Form/CodarioSettingsForm.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 175 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 175 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 182 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 245 | WARNING | File::load calls should be avoided in classes, use dependency injection instead 246 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 272 | WARNING | File::load calls should be avoided in classes, use dependency injection instead 274 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------ FILE: ~/projects/drupal-d10/modules/contrib/codario/src/Form/CodarioResetSettingsForm.php ------------------------------------------------------------------------------------------------------------------ FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------------ 6 | WARNING | [x] Unused use statement 7 | WARNING | [x] Unused use statement 9 | WARNING | [x] Unused use statement 29 | ERROR | [ ] Doc comment for parameter $configFactory does not match actual variable name $codarioHelper 52 | ERROR | [x] Expected 1 blank line after function; 0 found ------------------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------ FILE: ~/projects/drupal-d10/modules/contrib/codario/src/CodarioHelper.php -------------------------------------------------------------------------------------------------- FOUND 4 ERRORS AND 5 WARNINGS AFFECTING 8 LINES -------------------------------------------------------------------------------------------------- 5 | WARNING | [x] Unused use statement 13 | WARNING | [x] Unused use statement 115 | ERROR | [x] Expected "bool" but found "boolean" for function return type 152 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 169 | ERROR | [x] Expected newline after closing brace 174 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 174 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 188 | ERROR | [x] Expected 1 blank line after function; 0 found 189 | ERROR | [x] The closing brace for the class must have an empty line before it -------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------- Time: 152ms; Memory: 10MB
- Status changed to Closed: won't fix
over 1 year ago 7:29am 12 October 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
I am closing this application, since there haven't been replies in more than six months and the application has been created eight months ago or more.
Feel free to re-open it, once the project has been changed basing on what reported in the last review.