- Issue created by @larowlan
- First commit to issue fork.
- @rckstr_rohan opened merge request.
- Status changed to Needs review
over 1 year ago 2:58am 11 April 2023 - ๐ฎ๐ณIndia rckstr_rohan
created a MR, as per the new administer block content permission, pls review, suggestions are welcomed.thanks
- ๐ฎ๐ณIndia amietpatial
Changes look good to have suggestions on if "manage" can be replaced by "configure" in the sentence just to be more specific and also being used inside the block layout page "The Custom Block module allows you to create, manage and delete custom block types and content-containing blocks."
- Status changed to Needs work
over 1 year ago 11:49pm 11 April 2023 - ๐บ๐ธUnited States smustgrave
These don't appear to be the suggestions @larowlan was looking for.
New permissions were added but they were not mentioned in the MR.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 9:18am 12 April 2023 - Status changed to Needs work
over 1 year ago 1:57pm 12 April 2023 - ๐ฌ๐งUnited Kingdom AaronMcHale Edinburgh, Scotland
We definitely need to describe each new permission that was added. I would suggest adding a bulleted list with each new permission and a description of what it does. Note that the permissions are now per block type, so that should also be clearly described.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
re #9 ๐ Hook help for block content module is out of date after new permissions Needs work i am not sure if it would be necessary to describe each new permission on the help page. those help pages are about the functionality available within a module not about each settings option and available permissions in particular ( https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... โ ). if you compare it with the help page of the node module permissions are summarized in one dedicated point:
User permissions
The Node module makes a number of permissions available for each content type, which can be set by role on the permissions page.aside that permissions are only mentioned in some of the others points.
but aside the points in the uses section i would definitely update the about section as well. removing the link to the custom block module documentation. it is basically more or less the same as the current help page for the block content module: https://www.drupal.org/documentation/modules/block_content โ . therefore it is sort of redundant information.
but on the other hand i would also add one important piece of information to the about section. that you are able to create content blocks in two locations within the drupal admin interface. content blocks created in/admin/content/block
(the new path) are reusable content blocks and content blocks created within layout builder are none reusable content blocks aka inline block (or what name will be agreed on in ๐ Adjust the block terminology in Layout Builder to align with block and block_content changes Active ). but i consider that detail not well documented and clear to the user. me for example i've learned and understood it completely in the course of the whole reorganizing the block items issue. and it is also something that wasn't clear to everyone who has attended the feedback sessions in the different user groups i've visited. - ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Left some suggestions in the MR
Will need a rebase now the rename issue is in