Hook help for block content module is out of date after new permissions

Created on 5 April 2023, about 1 year ago
Updated 17 April 2023, about 1 year ago

Problem/Motivation

In โœจ Add more granular block content permissions Fixed we added new permissions for block content module
However the hook help entry still references the old administer blocks permission

Steps to reproduce

Creating and managing block types
Users with the Administer blocks permission can create and edit block types with fields and display settings, from the Block types page under the Structure menu. For more information about managing fields and display settings, see the Field UI module help and Field module help.
Creating content blocks
Users with the Administer blocks permission can create, edit, and delete content blocks of each defined block type, from the Content blocks page. After creating a block, place it in a region from the Block layout page, just like blocks provided by other modules.

Proposed resolution

Update the help text to be more appropriate to the new permissions

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

๐Ÿ› Bug report
Status

Needs work

Version

10.1 โœจ

Component
Block contentย  โ†’

Last updated 4 days ago

Created by

๐Ÿ‡ฆ๐Ÿ‡บAustralia larowlan ๐Ÿ‡ฆ๐Ÿ‡บ๐Ÿ.au GMT+10

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Comments & Activities

  • Issue created by @larowlan
  • First commit to issue fork.
  • @rckstr_rohan opened merge request.
  • Status changed to Needs review about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia rckstr_rohan

    created a MR, as per the new administer block content permission, pls review, suggestions are welcomed.thanks

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia amietpatial

    Changes look good to have suggestions on if "manage" can be replaced by "configure" in the sentence just to be more specific and also being used inside the block layout page "The Custom Block module allows you to create, manage and delete custom block types and content-containing blocks."

  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States smustgrave

    These don't appear to be the suggestions @larowlan was looking for.

    New permissions were added but they were not mentioned in the MR.

  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Rashmisoni Bangalore

    Rassoni โ†’ made their first commit to this issueโ€™s fork.

  • Status changed to Needs review about 1 year ago
  • ๐Ÿ‡ฎ๐Ÿ‡ณIndia Rashmisoni Bangalore
  • Status changed to Needs work about 1 year ago
  • ๐Ÿ‡ฌ๐Ÿ‡งUnited Kingdom AaronMcHale Edinburgh, Scotland

    We definitely need to describe each new permission that was added. I would suggest adding a bulleted list with each new permission and a description of what it does. Note that the permissions are now per block type, so that should also be clearly described.

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    re #9 ๐Ÿ› Hook help for block content module is out of date after new permissions Needs work i am not sure if it would be necessary to describe each new permission on the help page. those help pages are about the functionality available within a module not about each settings option and available permissions in particular ( https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... โ†’ ). if you compare it with the help page of the node module permissions are summarized in one dedicated point:

    User permissions
    The Node module makes a number of permissions available for each content type, which can be set by role on the permissions page.

    aside that permissions are only mentioned in some of the others points.

    but aside the points in the uses section i would definitely update the about section as well. removing the link to the custom block module documentation. it is basically more or less the same as the current help page for the block content module: https://www.drupal.org/documentation/modules/block_content โ†’ . therefore it is sort of redundant information.
    but on the other hand i would also add one important piece of information to the about section. that you are able to create content blocks in two locations within the drupal admin interface. content blocks created in /admin/content/block (the new path) are reusable content blocks and content blocks created within layout builder are none reusable content blocks aka inline block (or what name will be agreed on in ๐Ÿ“Œ Adjust the block terminology in Layout Builder to align with block and block_content changes Active ). but i consider that detail not well documented and clear to the user. me for example i've learned and understood it completely in the course of the whole reorganizing the block items issue. and it is also something that wasn't clear to everyone who has attended the feedback sessions in the different user groups i've visited.

  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia larowlan ๐Ÿ‡ฆ๐Ÿ‡บ๐Ÿ.au GMT+10

    Left some suggestions in the MR

    Will need a rebase now the rename issue is in

Production build 0.69.0 2024