- ๐ฎ๐ณIndia kkalashnikov Ghaziabad, India
Patch #3 is failed to apply.
Updated patch accordingly. - Status changed to Needs review
over 1 year ago 8:34am 17 March 2023 - Status changed to RTBC
over 1 year ago 8:44am 17 March 2023 - ๐ฎ๐ณIndia Akram Khan Cuttack, Odisha
checked patch #7 it apply cleanly and Fix phpcs coding standards issue
- Status changed to Needs work
over 1 year ago 9:05am 17 March 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ '#description' => $this->t('One url per line, you can use <a href="@token">Token</a> module. Url must start from "/". Use @nolink_key if you don\'t want to set a link for the respective title.', + [ + '@token' => 'https://www.drupal.org/project/token', + '@nolink_key' => '<nolink>', + ] + ),
url is not spelled correctly.
- ๐ฎ๐ณIndia kkalashnikov Ghaziabad, India
@apaderno thanks for reviewing. I have created MR of patch #7 and include commented change as well.
Please review. - Status changed to Needs review
over 1 year ago 6:22am 20 March 2023 - Status changed to Needs work
over 1 year ago 12:18pm 20 March 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- '#description' => $this->t('One url per line, you can use <a href="@token">Token</a> module. Url must start from "/". Use @nolink_key if you don\'t want to set a link for the respective title.', ['@token' => 'https://www.drupal.org/project/token', '@nolink_key' => '<nolink>']), + '#description' => $this->t('One URL per line, you can use <a href="@token">Token</a> module. Url must start from "/". Use @nolink_key if you don\'t want to set a link for the respective title.', + [
URL is an acronym and it is only written in one way. Also, since that sentence is going to be changed, also must start from needs to be corrected, since the correct phrase is must start with.
Then, One url per line, you can use Token module. is a comma-splice sentence. Instead of the comma, it should use a period because those are two different sentences.+ '#description' => $this->t("A set of patterns separated by a newline. @front_key@ is used to front page. The * character is a wildcard. An example path is /admin/* for every admin pages.",
The correct phrase is is used for the front page, not is used to front page.
+ '#description' => $this->t('One URL per line, you can use <a href="@token">Token</a> module. Url must start from "/". Use @nolink_key if you don\'t want to set a link for the respective title.',
An article is missing before
<a href="@token">Token</a> module.
The Needs work status was also set for the issue summary, which does not show what arguments has been passed to
phpcs
. - First commit to issue fork.
- Status changed to Needs review
over 1 year ago 7:47pm 14 April 2023 - Status changed to Needs work
over 1 year ago 7:55pm 14 April 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
- * Configure the user permissions in Administration รยป People รยป Permissions: + * Configure the user permissions in + Administration รยป People รยป Permissions:
The last line must be indented.
/** - * Class BreadcrumbBuilder. + * Breadcrumb builder class.
That is still repeating the class name. Splitting the class name in two words does not change that is the class name.
- '#description' => $this->t('One url per line, you can use <a href="@token">Token</a> module. Url must start from "/". Use @nolink_key if you don\'t want to set a link for the respective title.', ['@token' => 'https://www.drupal.org/project/token', '@nolink_key' => '<nolink>']), + '#description' => $this->t('One URL per line, you can use <a href="@token">Token</a> module. Url must start from "/". Use @nolink_key if you don\'t want to set a link for the respective title.', + [ + '@token' => 'https://www.drupal.org/project/token', + '@nolink_key' => '<nolink>', + ] + ),
One URL per line, you can use Token module. is a comma-splice sentence (a grammatical error). Instead of a comma, a semicolon or a period must be used.
Url is still a misspelled word. (Acronyms are always in upper-case characters.) - First commit to issue fork.
- ๐ฎ๐ณIndia nitin_lama India
nitin_lama โ changed the visibility of the branch 3318181-fix-phpcs-coding to hidden.
- ๐ฎ๐ณIndia nitin_lama India
nitin_lama โ changed the visibility of the branch 3318181-fix-phpcs-coding to active.
- Assigned to nitin_lama
- ๐ฎ๐ณIndia nitin_lama India
Rebased and pushed changes. Updating IS for the remaining issues.
- Issue was unassigned.
-
nitin_lama โ
committed 0b89716b on 1.x
#3318181: Fixing phpcs issues.
-
nitin_lama โ
committed 0b89716b on 1.x
- Status changed to Fixed
11 months ago 8:23am 12 January 2024 Automatically closed - issue fixed for 2 weeks with no activity.