Rzeszow
Account created on 14 April 2014, almost 11 years ago
#

Merge Requests

More

Recent comments

🇵🇱Poland lamp5 Rzeszow

Excuse me? It is opensource. I spend my free time to maintain this so release cycle is based my humor.

🇵🇱Poland lamp5 Rzeszow

It looks like settnings on Gitlab does not populate settings from Drupal project page. Done.

🇵🇱Poland lamp5 Rzeszow

Only 2.0.x is supported and recommended.

🇵🇱Poland lamp5 Rzeszow

The file name should be "file_delete.schema.yml"

🇵🇱Poland lamp5 Rzeszow

Hi. I detected that for actions we missed schemas so I suggested to add this in this issue instead of creating new one ticket.
Please create schema directory and add to the schema file:

action.configuration.file_delete_mark_temporary:
  type: action_configuration_default
  label: 'Mark file for deletion'

action.configuration.file_delete_immediately:
  type: action_configuration_default
  label: 'Immediate delete'
🇵🇱Poland lamp5 Rzeszow

It will base your pathauto configuration.

🇵🇱Poland lamp5 Rzeszow

We need testers with access to S3 to check this patch. I have no project with S3 already to check this.

🇵🇱Poland lamp5 Rzeszow

lamp5 made their first commit to this issue’s fork.

🇵🇱Poland lamp5 Rzeszow

Same case. 3.1.0 is the last working version.

🇵🇱Poland lamp5 Rzeszow

Oh, automatic merge failed and I missed this. Sorry. I changed the target branch to correct 2.0.x and this change should be available now in latest dev release. Stable release will be soon.

🇵🇱Poland lamp5 Rzeszow

Ok, but Link element has 2 properties, title and url.
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...
So problem is in bario theme, not in tabtamer module.

🇵🇱Poland lamp5 Rzeszow

So please resave your formatter and update settings.

🇵🇱Poland lamp5 Rzeszow

Could you provide MR for this?

🇵🇱Poland lamp5 Rzeszow

Could you provide steps to reproduce ? I think you have a problem with your config and config manager because this two properties are very old and we have an update to set one new variable here. If you have problem with your config, go to CB settings form and resave. Thanks

🇵🇱Poland lamp5 Rzeszow

I can not agree with you. This options has been implemented before we added checking if our custom breadcrumb has configured any pattern for entity or path to allow fallback other modules to build breadcrumbs. Now if you want to test this you need to configure breadcrumb by path e.g /node/* and then module will work for node canonical url but not for edit node.

🇵🇱Poland lamp5 Rzeszow

Hi. Why you change:

-   * @param \Drupal\Core\Extension\ThemeHandlerInterface $themeHandler
+   * @param \Drupal\Core\Extension\ThemeHandlerInterface $theme_handler

??

🇵🇱Poland lamp5 Rzeszow

📌 Set up Gitlab CI Fixed merged, If you have a free time, you can go ahead with this task.

🇵🇱Poland lamp5 Rzeszow

@brulain but it is possible that you use views_bootstrap module and templates from this module causes the issues in my case.

🇵🇱Poland lamp5 Rzeszow

It is not an issue with twig_tweak nor drupal core views. The problem is caused by your views custom twig template, potentially views bootstrap grid or other.

before:

{% if title %}
  <h3>{{ title }}</h3>
{% endif %}
<div id="{{ id }}" {{ attributes.addClass(classes) }}>
    {% for row in rows %}
      <div{{ row.attributes }}>
        {{row}}
      </div>
    {% endfor %}
</div>

after:

<div {{ attributes.setAttribute('id', id).addClass(classes) }}>
    {% for row in rows %}
      <div{{ row.attributes }}>
        {{- row.content -}}
      </div>
    {% endfor %}
</div>
🇵🇱Poland lamp5 Rzeszow

Hello @Project Update Bot, you have a bug :D this module is Drupal 10 compatible.

🇵🇱Poland lamp5 Rzeszow

HI @GeorgeSerbanescu,
your patch looks good. I enabled gitlab CI testing for this module. Could you create a MR to check that tests will pass ? Thanks

🇵🇱Poland lamp5 Rzeszow

lamp5 made their first commit to this issue’s fork.

🇵🇱Poland lamp5 Rzeszow

lamp5 made their first commit to this issue’s fork.

🇵🇱Poland lamp5 Rzeszow

lamp5 made their first commit to this issue’s fork.

🇵🇱Poland lamp5 Rzeszow

I merged 💬 Make drupal 10 compatible Fixed so testing should works fine. Please check.

🇵🇱Poland lamp5 Rzeszow

I merged 💬 Make drupal 10 compatible Fixed so testing should works fine. Please check.

🇵🇱Poland lamp5 Rzeszow

I don't know when we release full stable version because right now this module is out of my work scope, but it is nice that plenty of developers work on this module.

🇵🇱Poland lamp5 Rzeszow

I opened 2.0.x to go forward work with cocoen 3.x plugin

🇵🇱Poland lamp5 Rzeszow

I also rewrote my whole project to avoid serialize objects of class so we can mark this issue like "works as designed"

🇵🇱Poland lamp5 Rzeszow

Resave your global custom breadcrumb config. It looks like you removed value from config because module setups it during install.
https://git.drupalcode.org/project/custom_breadcrumbs/-/blob/1.x/config/...

Production build 0.71.5 2024