Nice catch. Thx.
Could you provide steps to reproduce ? I think you have a problem with your config and config manager because this two properties are very old and we have an update to set one new variable here. If you have problem with your config, go to CB settings form and resave. Thanks
I can not agree with you. This options has been implemented before we added checking if our custom breadcrumb has configured any pattern for entity or path to allow fallback other modules to build breadcrumbs. Now if you want to test this you need to configure breadcrumb by path e.g /node/* and then module will work for node canonical url but not for edit node.
You can do this using hook form alter.
Hi. Why you change:
- * @param \Drupal\Core\Extension\ThemeHandlerInterface $themeHandler
+ * @param \Drupal\Core\Extension\ThemeHandlerInterface $theme_handler??
📌 Set up Gitlab CI Fixed merged, If you have a free time, you can go ahead with this task.
@brulain but it is possible that you use views_bootstrap module and templates from this module causes the issues in my case.
It is not an issue with twig_tweak nor drupal core views. The problem is caused by your views custom twig template, potentially views bootstrap grid or other.
before:
{% if title %}
<h3>{{ title }}</h3>
{% endif %}
<div id="{{ id }}" {{ attributes.addClass(classes) }}>
{% for row in rows %}
<div{{ row.attributes }}>
{{row}}
</div>
{% endfor %}
</div>after:
<div {{ attributes.setAttribute('id', id).addClass(classes) }}>
{% for row in rows %}
<div{{ row.attributes }}>
{{- row.content -}}
</div>
{% endfor %}
</div>Hello @Project Update Bot, you have a bug :D this module is Drupal 10 compatible.
HI @GeorgeSerbanescu,
your patch looks good. I enabled gitlab CI testing for this module. Could you create a MR to check that tests will pass ? Thanks
Could you attach a patch or mr ??
I merged 💬 Make drupal 10 compatible Fixed so testing should works fine. Please check.
I merged 💬 Make drupal 10 compatible Fixed so testing should works fine. Please check.
I don't know when we release full stable version because right now this module is out of my work scope, but it is nice that plenty of developers work on this module.
Hi @lpeabody,
I will check your patch soon. Thanks
I opened 2.0.x to go forward work with cocoen 3.x plugin
I also rewrote my whole project to avoid serialize objects of class so we can mark this issue like "works as designed"
Resave your global custom breadcrumb config. It looks like you removed value from config because module setups it during install.
https://git.drupalcode.org/project/custom_breadcrumbs/-/blob/1.x/config/...
Clear your cache.
It has completely sense. I added parent issue. Let's test.
I suggest to close this issue (duplicated) and check this issue 🐛 URL don't include the base path Needs work
It does not work for multisite drupal sites.
Symfony\Component\Routing\Exception\RouteNotFoundException: Route "/doamin3/search" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 206 of core/lib/Drupal/Core/Routing/RouteProvider.php).
Drupal\Core\Routing\UrlGenerator->getRoute() (Line: 276)Sure, I debug the process of services registration and I detected that it is a problem with that, I can't see any issue using drush 12 and config split right now.
lamp5 → changed the visibility of the branch 3424087-support-latest-versions to hidden.
"extra": {
"drush": {
"services": {
- "drush.services.yml": "^9 || ^10"
+ "drush.services.yml": ">=9"
}
}
}Lets fix it permanently.
@malik.kotob could you go ahead with this ?
Do you have any suggestions ?
Really? Uppercase for vars causes a lot of issues in js....
2.0.x is branch under development. 2.x has a wrong branching name but I can't remove it.
I can confirm. The issue exists after update to Drupal 10.2.2 and when using "drupal/twig_extender": "5.1.0",