- π΅π±Poland lamp5 Rzeszow
Thats true, all cases are not supported right now. So I am working with tests for multi language CB support.
- π΅π±Poland lamp5 Rzeszow
@liquidcms I not agree fully with you, lets see how drupal translate default Homepage link for untranslated nodes. But when I checking @arvind.kinja's patch, I can agree with you, we should use $lang from current entity to have the same behavior like drupal core has.
- Status changed to Needs work
about 2 years ago 1:06pm 24 March 2023 - Status changed to Needs review
about 2 years ago 7:13pm 31 March 2023 - π΅π±Poland Krzysztof DomaΕski Poland
Let's commit π Invalidate Breadcrumbs cache after saving Custom Breadcrumbs Settings Fixed first.
- Status changed to Needs work
about 2 years ago 12:58pm 3 April 2023 - π΅π±Poland lamp5 Rzeszow
Done, let's improve the test,
+ $this->assertBreadcrumb('hu/node/1', [ + 'hu' => 'Strona glowna', + 'foo' => 'Foobar test', + 'bar' => 'Bar', + 'taxonomy' => $this->terms[2]->getTranslation($this->translateToLangcode)->label(), + 'hu/taxonomy/term/1' => $this->terms[0]->getTranslation($this->translateToLangcode)->label(), + 'hu/taxonomy/term/2' => $this->terms[1]->getTranslation($this->translateToLangcode)->label(), + 'hu/taxonomy/term/3' => $this->terms[2]->getTranslation($this->translateToLangcode)->label(), + 'hu/node/1' => $node->getTranslation($this->translateToLangcode)->label(), + ]);
We should use loop to attach breadcrumbs from term hierarchy and we can try to avoid using language prefixes in paths, instead we can implements generating paths with language argument to Url object, Additional homepage for hungarian is "itthon" :D
- π¨π¦Canada liquidcms
Anyone know the status of this? Its tagged as Needs Work but looks as though this may be in 1.1.0.
- π΅π±Poland lamp5 Rzeszow
Last patch should fix issue with translations, additional we should improve tests to commit this.
- πΊπ¦Ukraine Vadym.Tseiko
Drupal 10.2.4, PHP 8.1 - Could not apply patch after update drupal/custom_breadcrumbs 1.1.0 => 1.1.1.
Re-roll patch: - last update
about 1 year ago 3 pass, 1 fail