🇵🇱Poland @Krzysztof Domański

smustgrave → credited Krzysztof Domański → .

Krzysztof Domański → created an issue.

Krzysztof Domański → created an issue.

Thanks @Berdir

RTBC+1

RTBC+1

RTBC +1

I have the same problem after changing to 8.x-1.0-alpha5. Drupal core 10.

Krzysztof Domański → created an issue.

Needs reroll.

Looks good!

Let's commit 📌 Invalidate Breadcrumbs cache after saving Custom Breadcrumbs Settings Fixed first.

Krzysztof Domański → created an issue.

For semantic reasons, deleting paragraphs is not recommended. A semantic element clearly describes its meaning to the browser.

If you need to get rid of <p> tags add them to core filter Limit allowed HTML tag and correct faulty HTML.

1/ Naming conventions should be consistent throughout the code. Change $currentUser to $current_user.
public function __construct(array $configuration, $plugin_id, $plugin_definition, AccountProxyInterface $currentUser = NULL) {

2/ It should be more descriptive.

+  /**
+   * CurrentUser.
+   *
+   * @var \Drupal\Core\Session\AccountProxyInterface
+   */
+  protected $currentUser;
+
+  /**
+   * CurrentUser constructor.

Change record https://www.drupal.org/node/3347878 →

@Ranjit1032002

if ($currentUser === NULL) {
  @trigger_error...
  $current_user = \Drupal::currentUser();
}
$this->currentUser = $current_user;

smustgrave → credited Krzysztof Domański → .

The 'testing' install profile's setting of a default theme (Classy) is now deprecated →

Addressed #12 📌 Fix the issues reported by phpcs Fixed 📌 Overridden test methods require void return type hints Fixed

Krzysztof Domański → created an issue.

It was fixed in PHP 8.1.7. Now it works in Drupal 10 and PHP 8.1. It still doesn't work in the older version e.g. Drupal 9.5 and PHP 8.0. See 🐛 DateTimePlus does not create dates with proper timestamps during DST transitions Needs work .

1/ PHP Bug #77103 new DateTime('now') return incorrect timezone during DST transitions was fixed in PHP 8.1.7. It should work in Drupal 10. See PHP requirements → .

2/ We should add coverage tests for DST https://www.drupal.org/files/issues/2020-11-29/3018996-10.patch → .

3/ Not sure if the fix should still be added. D9.5 with old PHP 7 will not work without fix.
https://www.drupal.org/node/3060/qa →