🇵🇱Poland @Krzysztof Domański

Poland
Account created on 29 April 2018, almost 7 years ago
#

Recent comments

🇵🇱Poland Krzysztof Domański Poland

Unfortunately, I noticed incorrect validation messages on several separate websites. As a result, the content editing page does not work.

Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "ckeditor5_globalAttributeDir" CKEditor 5 plugin definition has a "drupal.conditions" value that contains some unsupported condition types: "filter". Only the following conditions types are supported: "toolbarItem", "imageUploadStatus", "filter", "requiresConfiguration", "plugins". in Drupal\ckeditor5\Plugin\CKEditor5PluginDefinition->validateDrupalAspects() (line 224 of /core/modules/ckeditor5/src/Plugin/CKEditor5PluginDefinition.php).

The validation message on the one hand informs that the 'filter' type is incorrect. And on the other hand it indicates the 'filter' type as correct. This type is on the list of permitted parameters. So we are dealing with an error in the validation itself, here.

See 🐛 The "ckeditor5_globalAttributeDir" CKEditor 5 plugin definition has a "drupal.conditions" value that contains some unsupported condition types: "filter" Active

🇵🇱Poland Krzysztof Domański Poland

I have the same problem after changing to 8.x-1.0-alpha5. Drupal core 10.

🇵🇱Poland Krzysztof Domański Poland

For semantic reasons, deleting paragraphs is not recommended. A semantic element clearly describes its meaning to the browser.

If you need to get rid of <p> tags add them to core filter Limit allowed HTML tag and correct faulty HTML.

🇵🇱Poland Krzysztof Domański Poland

1/ Naming conventions should be consistent throughout the code. Change $currentUser to $current_user.
public function __construct(array $configuration, $plugin_id, $plugin_definition, AccountProxyInterface $currentUser = NULL) {

2/ It should be more descriptive.

+  /**
+   * CurrentUser.
+   *
+   * @var \Drupal\Core\Session\AccountProxyInterface
+   */
+  protected $currentUser;
+
+  /**
+   * CurrentUser constructor.
🇵🇱Poland Krzysztof Domański Poland

@Ranjit1032002

if ($currentUser === NULL) {
  @trigger_error...
  $current_user = \Drupal::currentUser();
}
$this->currentUser = $current_user;
🇵🇱Poland Krzysztof Domański Poland

It was fixed in PHP 8.1.7. Now it works in Drupal 10 and PHP 8.1. It still doesn't work in the older version e.g. Drupal 9.5 and PHP 8.0. See 🐛 DateTimePlus does not create dates with proper timestamps during DST transitions Needs work .

Production build 0.71.5 2024