- Issue created by @Krzysztof Domański
- First commit to issue fork.
- Status changed to RTBC
about 1 year ago 12:05pm 9 January 2024 - 🇫🇮Finland heikkiy Oulu
@maxilein You can get the patch file from the MR: https://git.drupalcode.org/project/field_group/-/merge_requests/44.patch
Note that it's always recommended to save the patch file in local repository and use it from there. The MR patch can change if new commits are added to it might break existing functionality and it's also a possible attack vector because someone could slip malicious code to the MR.
- 🇩🇪Germany Anybody Porta Westfalica
Comparing this with https://git.drupalcode.org/issue/field_group-3412511/-/blob/3412511-filt... the fix totally makes sense to me.
I'd vote to order the variables like in the libraries.yml for better compareability and future changes?
- 🇧🇪Belgium nils.destoop
The commit adds dependencies in the javascript code to once, and drupalSettings. While it is not always used.
I see 3 things that need to happen:
- once should be added in the field_group.field_ui.js file, as it is used there
- drupalSettings should be added to field_group.js
- libraries.yml should be updated as there is no direct dependency to some of those libraries - Status changed to Fixed
8 months ago 1:00pm 1 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.