🇧🇪Belgium @nils.destoop

The patch is focussing on the editor but breaks the linkit field widget. When you are selecting an url and save the node, you are getting a validation error "Manually entered paths should start with one of the following characters: / ? #"

nils.destoop → made their first commit to this issue’s fork.

The fix will need to be smarter. As the column only exists for 11.1. We don't want to break the screens of sites running an older version.

Thx for the merge request. I committed to both versions. We will release a new version with this hotfix.

I updated the merge request with a type check.

nils.destoop → made their first commit to this issue’s fork.

A fix was committed to add null safe operator for the mode + a type check

nils.destoop → created an issue.

@apotek Could it be that you also have a merge-plugin setting? I had the same issue like you are describing. And the reason is that the drupalmodule contains a reference to 5.7.2 in the composer.libraries.json file: https://git.drupalcode.org/project/dropzonejs/-/blob/8.x-2.x/composer.li...

The moment I removed the reference to this file, I was able to switch to 5.9.3.

I configured the given summary on the project page.

@webfer It was moved to a separate module to handle the dependency to jquery_ui. I thought that jquery_ui was deprecated (because of https://www.drupal.org/node/3156376 → , where they are mentioning people should replace jquery ui with other libraries in the long term), that's why I marked the accordion module also as deprecated. However, if jquery ui is still maintained, I'm willing to drop the deprecation warning.

Thank you for your offer. It's also a +1 for me.
I would add you as maintainer, but I see I only have the developer role for field_group.

@anybody I see you have the maintainer role. Would it be possible to also give me this role?

The trailing comma should not be the cause of your fatal error, as this is a coding standard. The pipelines are now failing because of this: https://git.drupalcode.org/issue/field_group-3465611/-/jobs/2465176

Did you clear the cache after update? As I'm having no problems on 10.3. Your PHP error says it only received 3 arguments, while the service definition is declaring 4.

I temporarily reverted #3456987 and created a new release

Thx for the patch. I committed this to dev

Your merge request seems to be started from an older version, as your merge is trying to re-add files that are removed in current dev version.
In latest dev version all phpstan, phpcs and cs issues are already fixed.

An updated patch. The check in DomainAccessNodeTranslationHandler was not using the same logic like the node access. Now it also checks access using the entityAccess helper.

Included a patch

nils.destoop → created an issue.

The solution will not prevent your deadlock from happening. The solution will only make sure that your views data cache is not broken when the exception occurred.
By catching it, the caching system does not known that something went wrong and thinks the returned data is complete. While in realtime, it is missing all views plugins that still needed to be scanned.

The deadlock is not caused by views data itself, but just a combination of lot's of config, leading to a very big set of cache data that needs to be written during a full cache rebuild.

Re-roll of the patch on the 2.x branch as starting point

The docs that need to be updated is the quick fix, but imo a dirty fix. It makes no sense to return an int for getChangedTime and a string for getCreatedTime.
I agree that there could. be backwards compatibility issues, but a simple release note can warn users for this.

The failing test that I just fixed also shows how illogical it is:

before:

    $this->assertSame('1421727536', $comment->getCreatedTime());
    $this->assertSame(1421727536, $comment->getChangedTime());

after:

    $this->assertSame(1421727536, $comment->getCreatedTime());
    $this->assertSame(1421727536, $comment->getChangedTime());

nils.destoop → changed the visibility of the branch 3453210-getcreatedtime-returns-string to hidden.

Updated the logic to correctly return an integer.

nils.destoop → created an issue.

Tests are green again, so marking this as fixed

Fixed, it was related with #3452325

The template content is now also in the repo.

Seems like I accidentally also removed field-group-html-element.html.twig when moving the accordion templates. I re-added the template, sorry for the issue.
Can you check if it's fixed in latest dev?

I support this.

This was already removed in latest dev

nils.destoop → made their first commit to this issue’s fork.

This is not an issue of field_group, but an issue with the implementation of the toggle. If this is still the case, I suggest you create a core issue.

The reason why multipage was removed, because multipage is not grouping. If you have multipage, you also want the validation correctly going wrong. For Drupal 7, there were a lot of issues and requests for the field group module, that were totally not related with the main goal of this module: grouping.

Please re-open if this is still an issue, but this feels more like an issue with the module that is auto-creating that paragraph

Thx. The logo was committed to the repo.

You can idd use the elements in custom forms. But you should use the correct types like shown in #3.

Like you say. Field group is about grouping fields. It's not ment to add only markup. #4 seems to be a solution for you.

Closing this as duplicate.

Can not reproduce this. Did you try clearing the cache?

Coding standards were fixed in #3423199. But closing this as fixed for credits.

Already fixed

Seems to be fixed in latest version

Already fixed in current version

Already fixed in current version

Already fixed