- Issue created by @jan kellermann
- Merge request !73#3469261: Use element in each() function (because $(this) is in the wrong... → (Merged) created by jan kellermann
- Status changed to Needs review
6 months ago 6:14pm 20 August 2024 - 🇩🇪Germany jan kellermann
The errors in the CI pipeline are not related to this MR.
- 🇩🇪Germany Anybody Porta Westfalica
@jan kellermann could you please check related issues and if this issue still exists in 4.x? Then I'd be happy to proceed here.
Best would be to have a dedicated test.
- Merge request !77#3469261: Accordion: accordion items not opened → (Merged) created by jan kellermann
- 🇩🇪Germany jan kellermann
The javascript in 4.x is still unfixed and wrong:
https://git.drupalcode.org/project/field_group/-/blob/4.x/modules/field_...The refactoring of `.each(function(){})` is wrong. You cannot access `$(this)` in this loop.
In line 50 the refactoring is correct:
https://git.drupalcode.org/project/field_group/-/blob/4.x/modules/field_...See https://jsfiddle.net/sckya7j4/1/
I opened new MR for 4.x
Thank you for your work.
- 🇩🇪Germany jan kellermann
jan kellermann → changed the visibility of the branch 8.x-3.x to hidden.
- 🇩🇪Germany Anybody Porta Westfalica
Thanks, just found it: https://stackoverflow.com/questions/36638002/jquery-each-function-with-e...
-
anybody →
committed 5471187f on 4.x authored by
jan kellermann →
Issue #3469261 by jan kellermann, anybody: Accordion: accordion items...
-
anybody →
committed 5471187f on 4.x authored by
jan kellermann →
- Status changed to Fixed
5 months ago 9:47am 9 September 2024 - 🇩🇪Germany jan kellermann
Thank you for merging. Maybe you can also merge the MR for the 3.x branch if it is still a version 3.7?
- 🇩🇪Germany jan kellermann
jan kellermann → changed the visibility of the branch 3469261-accordion-accordion-items to hidden.
- 🇩🇪Germany jan kellermann
jan kellermann → changed the visibility of the branch 8.x-3.x to active.
-
anybody →
committed 5df542ae on 8.x-3.x authored by
jan kellermann →
Issue #3469261 by jan kellermann, anybody: Accordion: accordion items...
-
anybody →
committed 5df542ae on 8.x-3.x authored by
jan kellermann →
- 🇩🇪Germany Anybody Porta Westfalica
Yup! (Still we focus on 4.x - but no problem)
As far as I can see the error with the accordion is because after version 3.5 it was removed from the module. According to the Release notes, "Accordion is now a separate deprecated module to notify people that this shouldn't be used anymore" which is not good news because there is a lot of content using this option, in addition, this option is really useful to build accordions easily. Please add it back!
- 🇩🇪Germany Anybody Porta Westfalica
@webfer how to you come to that conclusion?
It's still present in 8.x-3.x and 4.x. It was just deprecated due to the jquery_ui dependency, but you can still use it and there are no plans yet to remove it.
https://git.drupalcode.org/project/field_group/-/tree/8.x-3.x/modules/fi...
https://git.drupalcode.org/project/field_group/-/tree/4.x/modules/field_... - 🇧🇪Belgium nils.destoop
@webfer It was moved to a separate module to handle the dependency to jquery_ui. I thought that jquery_ui was deprecated (because of https://www.drupal.org/node/3156376 → , where they are mentioning people should replace jquery ui with other libraries in the long term), that's why I marked the accordion module also as deprecated. However, if jquery ui is still maintained, I'm willing to drop the deprecation warning.
Automatically closed - issue fixed for 2 weeks with no activity.