getCreatedTime returns string instead of integer

Updated the logic to correctly return an integer.

nils.destoop → changed the visibility of the branch 3453210-getcreatedtime-returns-string to hidden.

Think maybe the docs should be updated? You can see the change causes test failures so there is backwards compatibility concerns with making this change.

The docs that need to be updated is the quick fix, but imo a dirty fix. It makes no sense to return an int for getChangedTime and a string for getCreatedTime.
I agree that there could. be backwards compatibility issues, but a simple release note can warn users for this.

The failing test that I just fixed also shows how illogical it is:

before:

    $this->assertSame('1421727536', $comment->getCreatedTime());
    $this->assertSame(1421727536, $comment->getChangedTime());

after:

    $this->assertSame(1421727536, $comment->getCreatedTime());
    $this->assertSame(1421727536, $comment->getChangedTime());

Right but about the BC concern this could immediately start breaking someone's code with no warning.

Discussed in slack with @catch, for reference https://drupal.slack.com/archives/C04CHUX484T/p1718289507191399

Created a CR just in case.

But does have a legit failure.

Setting parent issue to 🌱 [META] Stronger Typing for Entity API Active .