[PATCH] Wrong 'additional_settings' implementation

Hey there,

I have revealed a bug during extending the additional settings in the node view mode interface.

You are creating an "additional_settings" fieldset if it is not already there, which is okay.
The the problem is that you are using it with '#tree'. This makes everything put in there a "child" of "additional settings" in the post, which of course was your intention here.

The second and more significant problem is the "field_group" fieldset. You are using '#parents' here.

The combination of both of the above leads to the problem that no other module that would want to visually integrate with the "addtional_settings", would be able to do so properly.
Everything that you tie to "additional_settings" via '#group' will also be a child of the "field_group" fieldset.
Strangely they also appear as vertical tabs, but nevertheless, your implementation is against known conventions.

I have created a patch that would fix that problem and clear the passage for other modules.
You will find it in the first comment to this issue.

I hope you like it and I haven't missed anything.
Hoping for a quick merge, since all the work is basically done. :)

func0der