Fix PHP 8.4.x deprecation and other warnings (PHPStan)

------ --------------------------------------------------------------------------------------------------------- Line contrib/field_group_migrate/src/Plugin/migrate/destination/d7/FieldGroup.php ------ --------------------------------------------------------------------------------------------------------- 45 Deprecated in PHP 8.4: Parameter #5 $migration (Drupal\migrate\Plugin\MigrationInterface) is implicitly nullable via default value null. 106 Deprecated in PHP 8.4: Parameter #1 $migration (Drupal\migrate\Plugin\MigrationInterface) is implicitly nullable via default value null. ------ --------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------------------------------- Line contrib/field_group_migrate/src/Plugin/migrate/source/d7/FieldGroup.php ------ --------------------------------------------------------------------------------------------------------- 57 Deprecated in PHP 8.4: Parameter #5 $migration (Drupal\migrate\Plugin\MigrationInterface) is implicitly nullable via default value null. ------ --------------------------------------------------------------------------------------------------------- ------ -------------------------------------------------------------------------------------------------------------- Line field_group.module ------ -------------------------------------------------------------------------------------------------------------- 358 Call to static method isDisabled() on an unknown class Drupal\ds\Ds. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols 426 Deprecated in PHP 8.4: Parameter #2 $form_state (Drupal\Core\Form\FormStateInterface) is implicitly nullable via default value null. 493 Deprecated in PHP 8.4: Parameter #2 $form_state (Drupal\Core\Form\FormStateInterface) is implicitly nullable via default value null. 637 Deprecated in PHP 8.4: Parameter #2 $vars (array) is implicitly nullable via default value null. 730 Deprecated in PHP 8.4: Parameter #2 $vars (array) is implicitly nullable via default value null. 824 No error to ignore is reported on line 824. 877 Deprecated in PHP 8.4: Parameter #2 $display (Drupal\Core\Entity\Display\EntityDisplayInterface) is implicitly nullable via default value null. ------ -------------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------------------------------- Line modules/field_group_accordion/src/Plugin/field_group/FieldGroupFormatter/Accordion.php ------ --------------------------------------------------------------------------------------------------------- 99 Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0 required. ------ --------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------------------------------- Line modules/field_group_accordion/src/Plugin/field_group/FieldGroupFormatter/AccordionItem.php ------ --------------------------------------------------------------------------------------------------------- 133 Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0 required. ------ --------------------------------------------------------------------------------------------------------- ------ -------------------------------------------------------------------------------------------------------------- Line src/FormatterHelper.php ------ -------------------------------------------------------------------------------------------------------------- 63 Deprecated in PHP 8.4: Parameter #2 $form_state (Drupal\Core\Form\FormStateInterface) is implicitly nullable via default value null. 121 No error to ignore is reported on line 121. ------ -------------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------------------------------- Line src/Plugin/field_group/FieldGroupFormatter/Details.php ------ --------------------------------------------------------------------------------------------------------- 124 Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0 required. ------ --------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------------------------------- Line src/Plugin/field_group/FieldGroupFormatter/Fieldset.php ------ --------------------------------------------------------------------------------------------------------- 116 Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0 required. ------ --------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------------------------------- Line src/Plugin/field_group/FieldGroupFormatter/HtmlElement.php ------ --------------------------------------------------------------------------------------------------------- 253 Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0 required. ------ --------------------------------------------------------------------------------------------------------- ------ --------------------------------------------------------------------------------------------------------- Line src/Plugin/field_group/FieldGroupFormatter/Tab.php ------ --------------------------------------------------------------------------------------------------------- 123 Static method Drupal\field_group\FieldGroupFormatterBase::defaultSettings() invoked with 1 parameter, 0 required. ------ --------------------------------------------------------------------------------------------------------- ------ -------------------------------------------------------------------------------------------------------------- Line tests/modules/field_group_test/field_group_test.module ------ -------------------------------------------------------------------------------------------------------------- 20 Deprecated in PHP 8.4: Parameter #4 $items (Drupal\Core\Field\FieldItemListInterface) is implicitly nullable via default value null. ------ -------------------------------------------------------------------------------------------------------------- ------ ------------------------------------------------------------------------------------------------------- Line tests/src/FunctionalJavascript/HorizontalTabsLabelsTest.php ------ ------------------------------------------------------------------------------------------------------- 119 @dataProvider providerTestHorizontalTabsLabels related method must be static in PHPUnit 10 and newer. ------ -------------------------------------------------------------------------------------------------------

Comments & Activities

Issue created by @Grevil
Comment about 2 months ago →
nidhish
Comment about 2 months ago →
🇩🇪Germany lrwebks Porta Westfalica
Merge request !95Resolve #3504453 "Fix php 8.4.x" → (Merged) created by lrwebks
Pipeline finished with Failed
about 2 months ago
Total: 438s
#416901
Comment about 2 months ago →
🇧🇪Belgium nils.destoop
nils.destoop → made their first commit to this issue’s fork.
First commit to issue fork.
Merge request !98Fix PHP 8.4.x deprecation and other warnings (PHPStan) for 3.x branch. → (Open) created by beloglazov91
Pipeline finished with Failed
about 2 months ago
Total: 333s
#422838
Comment about 2 months ago →
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
liam morland → made their first commit to this issue’s fork.
Comment about 2 months ago →
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Tests are passing for 4.x. They are failing for 8.x-3.x, but they are failing on the dev branch too. The merge request here fixes phpcs on that branch.
Pipeline finished with Failed
about 2 months ago
Total: 422s
#423343
Pipeline finished with Failed
about 2 months ago
Total: 311s
#423360
Comment about 2 months ago →
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
phpunit now passes on both branches.
Pipeline finished with Success
about 2 months ago
Total: 333s
#423414
Comment about 2 months ago →
System Message

nils.destoop → committed 0b836516 on 4.x authored by lrwebks →
Resolve #3504453 "Fix php 8.4.x"
Comment about 1 month ago →
🇩🇪Germany Anybody Porta Westfalica
@nils.destoop guess the issue can be set fixed?
Comment about 1 month ago →
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
This has been done on 4.x. Will this also be done on 8.x-3.x?
Comment about 1 month ago →
🇩🇪Germany Anybody Porta Westfalica
@liam morland I just tried a cherry-pick. If someone reviews it and confirms it works, I'm willing to merge it into 8.x-3.x.

For now, I'm setting this fixed.
Comment about 1 month ago →
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Thanks. The cherry-pick looks good.
Comment about 1 month ago →
🇩🇪Germany Anybody Porta Westfalica
Comment about 1 month ago →
🇩🇪Germany Anybody Porta Westfalica
anybody → changed the visibility of the branch 8.x-3.x to hidden.
Comment about 1 month ago →
🇩🇪Germany Anybody Porta Westfalica
anybody → changed the visibility of the branch 4.x to hidden.
Comment about 1 month ago →
🇩🇪Germany Anybody Porta Westfalica
Sorry, here's the MR to review: https://git.drupalcode.org/project/field_group/-/merge_requests/100
We could also merge MR!98, but I don't have time to review and decide currently.
Comment about 1 month ago →
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Looks good
Comment about 1 month ago →
🇩🇪Germany Anybody Porta Westfalica
@liam morland so which one should I merge?
Comment about 1 month ago →
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Merge !100, then !101, then !102. Then you can close !98.
Comment 8 days ago →
🇳🇴Norway steinmb
Is there anything that is holding this back?

Fix PHP 8.4.x deprecation and other warnings (PHPStan)

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!98Fix PHP 8.4.x deprecation and other warnings (PHPStan)
Open

!95Fix PHP 8.4.x deprecation and other warnings (PHPStan)
Merged

Comments & Activities

Fix PHP 8.4.x deprecation and other warnings (PHPStan)

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!98Fix PHP 8.4.x deprecation and other warnings (PHPStan)Open

!95Fix PHP 8.4.x deprecation and other warnings (PHPStan)Merged

Comments & Activities

!98Fix PHP 8.4.x deprecation and other warnings (PHPStan)
Open

!95Fix PHP 8.4.x deprecation and other warnings (PHPStan)
Merged