Account created on 8 May 2012, almost 13 years ago
#

Merge Requests

More

Recent comments

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Issue actual only for current release 2.0.0, in 2.0.x-dev it's already fixed.
Attached patch for that.

πŸ‡·πŸ‡ΊRussia kiseleva.t

kiseleva.t β†’ changed the visibility of the branch 3519213-php-8.4-fix to hidden.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Attached file for v6.0.5 to fix these PHP8.4 warnings:

FILE: /src/MigrateExecutable.php
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
 91 | ERROR | [x] Parameter $message has null default value, but is not marked as nullable.
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------


FILE: /src/Routing/RouteProcessor.php
--------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------
 26 | ERROR | [x] Parameter $bubbleable_metadata has null default value, but is not marked as nullable.
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------
πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Patch for nullable declarations only, for v3.0.2.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Actually in 3.x version it already fixed, but for case the 2.x with D10.3 and PHP 8.4 issue is still presented.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR into patch for composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR to patch for composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR changes into patch to use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Rerolled patch for 1.12.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Static patch for use in composer.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Included changes from https://www.drupal.org/node/3510584 β†’ and updated logic to have clone option available only for included CTs even for admins with bypass node access permission.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Rolled back commit `ccd1255d` to avoid issues on existing configuration.

πŸ‡·πŸ‡ΊRussia kiseleva.t

MR fixed issue for us too, thank you!

Exported MR into static patch.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Exported MR changes into static file patch.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Added an empty section to new entity before first save, in that case layout storage will be OverridesSectionStorageInterface and on next save at the end of import, it will not duplicate inline blocks.

πŸ‡·πŸ‡ΊRussia kiseleva.t

kiseleva.t β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Attached static patch file for use on project.

πŸ‡·πŸ‡ΊRussia kiseleva.t

did not know that block_id is a part of layout builder component, is it available out of the box in Drupal core or it's extra that is provided by some patch or contrib module?

That's part of default configuration at layout_builder/src/Plugin/Block/InlineBlock.php

Attached static file patch for using on project.

πŸ‡·πŸ‡ΊRussia kiseleva.t

kiseleva.t β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡ΊRussia kiseleva.t

kiseleva.t β†’ made their first commit to this issue’s fork.

πŸ‡·πŸ‡ΊRussia kiseleva.t

After upgrade to 8.x-2.0-alpha6 external entities got broken for me, it could not correctly get value for some properties, for example, label.

Found that it happens due to use doCreate method in mapFromRawStorageData, there are seems some differences for external entities between these two way of creation:

$entity = new $entity_class([], $this->entityTypeId, $bundle);
$this->initFieldValues($entity, $values);

and

$entity = new $entity_class($values, $this->entityTypeId, $bundle);

I didn't investigate more deep, just suggest to rollback usage of doCreate.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Updated MR with latest 3.x-dev version and exported static patch file to use with installed 3.4.1 module version on the project.

πŸ‡·πŸ‡ΊRussia kiseleva.t

Just wrapped the code by next condition:
if (typeof drupalSettings.simple_recaptcha !== 'undefined' && typeof drupalSettings.simple_recaptcha.form_ids !== 'undefined') {}
for v3:
if (typeof drupalSettings.simple_recaptcha_v3 !== 'undefined' && typeof drupalSettings.simple_recaptcha_v3.forms !== 'undefined') {}

πŸ‡·πŸ‡ΊRussia kiseleva.t

Updated patch for latest 3.x-dev

Production build 0.71.5 2024