Automated Drupal 10 compatibility fixes

So this can be considered as reviewed, right?

I don't usually mark as RTBC if I am the first, but if someone else was to confirm the test, then it could be considered as reviewed

Makes sense. I created an issue fork and an MR, and updated the .info.yml files. It works for me on Drupal 10.0.3. However, the tests need to be updated.

I reviewed the patch in the Drupal 10.0.5 version. The patch was applied cleanly and able to install the module on D10 and working as expected.

Moving to RTBC.

Added D10 compatibility and composer file.
https://git.drupalcode.org/project/view_profiles_perms/-/merge_requests/...

Try adding the patch with:

composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/view_profiles_perms"]'
composer config --json --merge extra.patches.drupal/view_profiles_perms '{"3290410: Automated Drupal 10 compatibility fixes": "https://git.drupalcode.org/project/view_profiles_perms/-/merge_requests/3.diff"}'
composer require --no-update drupal/view_profiles_perms:2.0.x-dev@dev

or

composer config repositories.view_profiles_perms vcs git@git.drupal.org:issue/view_profiles_perms-3290410.git
composer require --no-update drupal/logging_alerts:dev-3290410-add-composer

MR3 applied as per #13 and is working for me. @Krzysztof Domański is there anything new in your patch?

Looking at:
git.drupalcode.org/project/view_profiles_perms/-/merge_requests/3.diff
and comparing it to the patch added in 14 they look identical. The MR version also includes a composer,json file which I added to made it possible to use the forked repo and branch through composer and the lenient endpoint.

Commenting for geting the update notification. It still lags the D10 compatible version release.

Here is an updated patch which contains the core_version_requirement fix, and the automated rector fixes.

This patch should apply, the previous one didn't.

I attempted to apply patches from #19, #18, #14 and #3 (separately) by adding it to composer.json at root. #19 and #14 failed to apply. #14 applies but is incomplete. I applied #3 and then manually updated the two .info files to update core version requirement and remove core line.

Patch #19 applies to dev.

I've just cut a new 2.1.0 → release. Added the composer.json file and also we are dropping Drupal 8 support.

Thank you all for the help and patience in this.

https://git.drupalcode.org/project/view_profiles_perms/-/commit/fe151a20...

andrew.farquharson → made their first commit to this issue’s fork.

Manuel Garcia → closed merge request !2

Manuel Garcia → closed merge request !3

Automatically closed - issue fixed for 2 weeks with no activity.