Account created on 21 April 2009, over 16 years ago
#

Merge Requests

More

Recent comments

🇬🇧United Kingdom the_g_bomb

From an accessibility standpoint, I think it would be beneficial to explore the use of contextual alt text for images. This issue highlights that the same image can be used in multiple places and so may require different alt text, for example (or may be deemed as decorative in some places). Being able to use a very descriptive alt text in the media browser, but have a more specific one used in the front end, would help make things more accessible rather than just passing the WCAG requirement.

[META] Improve workflows for image alternative text Active outlines some aspects of the issue, but I believe there are others that overlap and address additional parts.

The UX team have been discussing a set of issues around this as can be seen at: 📌 Drupal Usability Meeting 2025-07-11 Active .

I have also created an issue within the AI Alt text to try to get AI to help with being more contextual when generating the Alt text, but the above issues need to be addressed first before AI can be improved.

🇬🇧United Kingdom the_g_bomb

Removed the version number from the Drupal.org issue queue link, as it was using version 10.x it was showing 0 issues. All the issues seem to have been updated to target 11.x and all older issues for D6 & D7 have been closed. Removing the Version parameter will keep the number of issues valid without much updating.
Also minor grammar tidy up.

🇬🇧United Kingdom the_g_bomb

Moving to the project ownership queue, for progressing

🇬🇧United Kingdom the_g_bomb

Fixing the links

🇬🇧United Kingdom the_g_bomb

Thanks for letting me join today

🇬🇧United Kingdom the_g_bomb

I have duplicated the reports block to override various bits as requested.
e.g.: here is the new "No results message":

And the listings with a link to the Editoria11y reports page.

🇬🇧United Kingdom the_g_bomb

Thanks Pamela. The title override for the no results is an issue with the module. I have opened a couple of issues already, and plan to open a couple more, so hopefully that specifically can be fixed.

I have our own title override in place for the dashboard, so it shouldn't matter what happens to the view, if the module is updated, the title of this block will always remain as "Pages with accessibility alerts". I can change the text used there if required, but it also adds some stability for the recipe test that is in place.

In terms of the button colour, I 100% agree that needs to be sorted. I'll look into where that is coming from. I thought the view was just using the standard More link, so it may be an issue with the Drupal CMS CSS, but I'll investigate and add changes here or in the module as appropriate.

🇬🇧United Kingdom the_g_bomb

Updating Outstanding tasks in the summary from #4:
The code being replaced here originally came from \Drupal\file\Plugin\Field\FieldWidget\FileWidget::submit() and that uses the _weight already.
Is is possible to remove the same code from FileWidget too? (potentially another ticket to investigate file widget)

The patch needs more documentation to explain:
Why _weight exists
What is stored in field state,
why $form_state->getUserInput() is called.

🇬🇧United Kingdom the_g_bomb

Yup, I struggled with this; rather than adding a media field, you have to add an entity reference field and then choose Media with contextual modifications once that is selected.

🇬🇧United Kingdom the_g_bomb

I have updated the recipe. I suspect a different block may be a better choice for this on further investigation. I have also updated the recipe so that the dashboard now overrides the title to be more useful.

I then updated the test to use the new title to identify if the block is being placed in the dashboard rather than testing if the config is being updated, as requested.

I was struggling to identify the block as stark doesn't output the classes as expected in the test, but also I thought the title may be a bit brittle to use as a test, as it is being provided by a third-party module, and may change if the module updates at any point leading to a broken test, overriding the title means that should always be available.

🇬🇧United Kingdom the_g_bomb

This is an upstream issue from Editoria11y. I'll open a ticket to amend the block titles and make them more usable.

This is essentially the out-of-the-box "No results behavior"

This block shows the issues discovered by Editoria11y. When you first install it, as there are no issues discovered yet, you need to browse the site to make this useful.

If you visit the demo page at: /accessibility-tools-demo-page. Then revisit the dashboard, you should see that block gets populated with a list of some of the issues found. The header also changes to say "Recent issues", and there is a "more link" to a more detailed list page.

🇬🇧United Kingdom the_g_bomb

Thanks for the pointer @thejimbirch. Nice and straightforward.
The only bit I wasn't clear on was how to determine the position.
Is that used instead of weight? (I noted it says weight will be automatically calculated)
What happens if another recipe chooses the same position?

🇬🇧United Kingdom the_g_bomb

the_g_bomb changed the visibility of the branch 2.x to hidden.

🇬🇧United Kingdom the_g_bomb

the_g_bomb changed the visibility of the branch 0.x to hidden.

🇬🇧United Kingdom the_g_bomb

the_g_bomb changed the visibility of the branch 3485831- to hidden.

🇬🇧United Kingdom the_g_bomb

Confirmed, patch applies and improves the border contrast.

I have also checked the new contrast with a contrast Checker.

🇬🇧United Kingdom the_g_bomb

Shame there isn't a needs a lot of work status...

I'm not even sure this is worth it, given the current status of the JS library. But this is the very first step in an upgrade. The info file has been renamed and reformatted, and the other files have been rearranged. No renaming or recoding was done to them; instead, the files have been relocated to a logical location for their intended purpose.

I will try and run moduleupgrader to see what changes that implements.

🇬🇧United Kingdom the_g_bomb

FYI, There is now a way to create a list of content and display the A11y issues status, so I may like to bring this out of postponment if there is still appetite for an A11y related block on a Dashboard.

At first thoughts I would wonder how that would be applied to an existing dashboard. Does the recipe need to know where on Dashboard it is going to be applied, given that the Accessibility Tools are an optional recipe and will likely be enabled after everything else has been setup.

🇬🇧United Kingdom the_g_bomb

the_g_bomb made their first commit to this issue’s fork.

🇬🇧United Kingdom the_g_bomb

OK, I'll bite. I love HP Lovecraft, and having this on my list of modules would be great. I have a Terry Pratchett-related module already, so I would be happy to keep this going and bring it up to readiness for future versions of Drupal.

🇬🇧United Kingdom the_g_bomb

In order to stop having to keep creating patches you can do this instead:

composer config --json extra.patches-ignore '{"drupal/lightning_core": {"drupal/core": {"2869592 - Disabled update module shouldn't produce a status report warning": "https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch"}}}'
composer require 'drupal/update_notifications_disable:^2.0@RC'
drush en update_notifications_disable
🇬🇧United Kingdom the_g_bomb

the_g_bomb made their first commit to this issue’s fork.

🇬🇧United Kingdom the_g_bomb

When adding a new bundle variation, the products do not pull through to be selected:

🇬🇧United Kingdom the_g_bomb

I have rerolled and created a new MR as I had to fixed a couple of things to get the module to work.

This now require a few hurdles to jump through to get it installed. Not sure if all these steps are strictly required but I did this:

composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/commerce_product_bundles"]'
composer config --json --merge extra.patches.drupal/commerce_product_bundles '{"Issue #3419195: Drupal 10 support": "https://git.drupalcode.org/project/commerce_product_bundles/-/merge_requests/8.diff"}'
composer require drupal/commerce_currencies_price
composer require drupal/commerce_currency_resolver
composer require "drupal/commerce:3.0.2 as 2.19"
composer require "drupal/commerce_cart:3.0.2 as 2.19"
composer require "drupal/commerce_product:3.0.2 as 2.19"
composer require "drupal/select2:2.0.0 as 1.6"
composer require "drupal/core:11.1.7 as 10.5.x-dev"
composer require "drupal/commerce_product_bundles:1.x-dev@dev"

Hopefully when the patch is merged the dependency issues will go away.

🇬🇧United Kingdom the_g_bomb

Patch does not apply to the 8.x-1.x-dev branch, it looks like the PR has been raised against master.

Also:
:29: trailing whitespace.
7. Use 'Order item title formatter' for Commerce Order Item Title field on commerce_order_item_table view to get full descriptive
warning: 1 line adds whitespace errors.

🇬🇧United Kingdom the_g_bomb

After a quick glance, I can see that this MR also includes the changes offered at, 📌 Automated Drupal 10 compatibility fixes Needs review , so I will test this over that patch.

🇬🇧United Kingdom the_g_bomb

Not sure there will be any more Update Bot additions

🇬🇧United Kingdom the_g_bomb

The change required for this has been made in the MR at: https://git.drupalcode.org/project/boldy/-/merge_requests/14

🇬🇧United Kingdom the_g_bomb

Preview now works. Review required. Will merge shortly if no review appears.

🇬🇧United Kingdom the_g_bomb

Moving back to RTBC, after updating the issue summary and testing the PR #8 as well. Patch applies and clears the issue.

Production build 0.71.5 2024