🇬🇧United Kingdom @the_g_bomb

I suspect the following issue will be needed for to enable ai alt text to happen: 📌 Design a UI to allow various kinds of alterations to referenced Media entities in a modal Active

I have duplicated the reports block to override various bits as requested.
e.g.: here is the new "No results message":

And the listings with a link to the Editoria11y reports page.

The button comes from here:
https://git.drupalcode.org/project/editoria11y/-/blob/2.2.x/editoria11y....

Thanks Pamela. The title override for the no results is an issue with the module. I have opened a couple of issues already, and plan to open a couple more, so hopefully that specifically can be fixed.

I have our own title override in place for the dashboard, so it shouldn't matter what happens to the view, if the module is updated, the title of this block will always remain as "Pages with accessibility alerts". I can change the text used there if required, but it also adds some stability for the recipe test that is in place.

In terms of the button colour, I 100% agree that needs to be sorted. I'll look into where that is coming from. I thought the view was just using the standard More link, so it may be an issue with the Drupal CMS CSS, but I'll investigate and add changes here or in the module as appropriate.

Updating Outstanding tasks in the summary from #4:
The code being replaced here originally came from \Drupal\file\Plugin\Field\FieldWidget\FileWidget::submit() and that uses the _weight already.
Is is possible to remove the same code from FileWidget too? (potentially another ticket to investigate file widget)

The patch needs more documentation to explain:
Why _weight exists
What is stored in field state,
why $form_state->getUserInput() is called.

Yup, I struggled with this; rather than adding a media field, you have to add an entity reference field and then choose Media with contextual modifications once that is selected.

I have updated the recipe. I suspect a different block may be a better choice for this on further investigation. I have also updated the recipe so that the dashboard now overrides the title to be more useful.

I then updated the test to use the new title to identify if the block is being placed in the dashboard rather than testing if the config is being updated, as requested.

I was struggling to identify the block as stark doesn't output the classes as expected in the test, but also I thought the title may be a bit brittle to use as a test, as it is being provided by a third-party module, and may change if the module updates at any point leading to a broken test, overriding the title means that should always be available.

the_g_bomb → created an issue.

the_g_bomb → created an issue.

This is an upstream issue from Editoria11y. I'll open a ticket to amend the block titles and make them more usable.

This is essentially the out-of-the-box "No results behavior"

This block shows the issues discovered by Editoria11y. When you first install it, as there are no issues discovered yet, you need to browse the site to make this useful.

If you visit the demo page at: /accessibility-tools-demo-page. Then revisit the dashboard, you should see that block gets populated with a list of some of the issues found. The header also changes to say "Recent issues", and there is a "more link" to a more detailed list page.

the_g_bomb → created an issue.

Thanks for the pointer @thejimbirch. Nice and straightforward.
The only bit I wasn't clear on was how to determine the position.
Is that used instead of weight? (I noted it says weight will be automatically calculated)
What happens if another recipe chooses the same position?

the_g_bomb → changed the visibility of the branch 2.x to hidden.

the_g_bomb → changed the visibility of the branch 0.x to hidden.

the_g_bomb → changed the visibility of the branch 3485831- to hidden.

the_g_bomb → created an issue.

the_g_bomb → created an issue.

the_g_bomb → created an issue.

Confirmed, patch applies and improves the border contrast.

I have also checked the new contrast with a contrast Checker.

Shame there isn't a needs a lot of work status...

I'm not even sure this is worth it, given the current status of the JS library. But this is the very first step in an upgrade. The info file has been renamed and reformatted, and the other files have been rearranged. No renaming or recoding was done to them; instead, the files have been relocated to a logical location for their intended purpose.

I will try and run moduleupgrader to see what changes that implements.

FYI, There is now a way to create a list of content and display the A11y issues status, so I may like to bring this out of postponment if there is still appetite for an A11y related block on a Dashboard.

At first thoughts I would wonder how that would be applied to an existing dashboard. Does the recipe need to know where on Dashboard it is going to be applied, given that the Accessibility Tools are an optional recipe and will likely be enabled after everything else has been setup.

the_g_bomb → created an issue. See original summary → .

the_g_bomb → made their first commit to this issue’s fork.

the_g_bomb → created an issue.

the_g_bomb → created an issue.

MR !133 no longer applies to 2.0.x

the_g_bomb → made their first commit to this issue’s fork.

OK, I'll bite. I love HP Lovecraft, and having this on my list of modules would be great. I have a Terry Pratchett-related module already, so I would be happy to keep this going and bring it up to readiness for future versions of Drupal.

In order to stop having to keep creating patches you can do this instead:

composer config --json extra.patches-ignore '{"drupal/lightning_core": {"drupal/core": {"2869592 - Disabled update module shouldn't produce a status report warning": "https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch"}}}'
composer require 'drupal/update_notifications_disable:^2.0@RC'
drush en update_notifications_disable

the_g_bomb → created an issue. See original summary → .

the_g_bomb → made their first commit to this issue’s fork.

When adding a new bundle variation, the products do not pull through to be selected:

the_g_bomb → created an issue.

I have rerolled and created a new MR as I had to fixed a couple of things to get the module to work.

This now require a few hurdles to jump through to get it installed. Not sure if all these steps are strictly required but I did this:

composer require mglaman/composer-drupal-lenient
composer config --merge --json extra.drupal-lenient.allowed-list '["drupal/commerce_product_bundles"]'
composer config --json --merge extra.patches.drupal/commerce_product_bundles '{"Issue #3419195: Drupal 10 support": "https://git.drupalcode.org/project/commerce_product_bundles/-/merge_requests/8.diff"}'
composer require drupal/commerce_currencies_price
composer require drupal/commerce_currency_resolver
composer require "drupal/commerce:3.0.2 as 2.19"
composer require "drupal/commerce_cart:3.0.2 as 2.19"
composer require "drupal/commerce_product:3.0.2 as 2.19"
composer require "drupal/select2:2.0.0 as 1.6"
composer require "drupal/core:11.1.7 as 10.5.x-dev"
composer require "drupal/commerce_product_bundles:1.x-dev@dev"

Hopefully when the patch is merged the dependency issues will go away.

Patch does not apply to the 8.x-1.x-dev branch, it looks like the PR has been raised against master.

Also:
:29: trailing whitespace.
7. Use 'Order item title formatter' for Commerce Order Item Title field on commerce_order_item_table view to get full descriptive
warning: 1 line adds whitespace errors.

After a quick glance, I can see that this MR also includes the changes offered at, 📌 Automated Drupal 10 compatibility fixes Needs review , so I will test this over that patch.

the_g_bomb → created an issue.

Not sure there will be any more Update Bot additions

Merged

Merged

Merged

The change required for this has been made in the MR at: https://git.drupalcode.org/project/boldy/-/merge_requests/14

These issues have been fixed as a part of the MR at: https://git.drupalcode.org/project/boldy/-/merge_requests/14

Preview now works. Review required. Will merge shortly if no review appears.

the_g_bomb → created an issue.

the_g_bomb → created an issue.

the_g_bomb → created an issue.

Moving back to RTBC, after updating the issue summary and testing the PR #8 as well. Patch applies and clears the issue.

the_g_bomb → created an issue.

the_g_bomb → created an issue.

The work done in 🐛 phpunit: 7 errors, 7 total tests Active incorporates the changes needed here.
The test results with the fix can be viewed at: https://git.drupalcode.org/project/dopl/-/merge_requests/8
When that gets merged, it would have allowed this to be merged, but will also fix this issue.

Finally got the phpunit tests to pass.

Tested with Drupal 10.4 and media_bulk_upload 3.0.x. using "Form Mode" set to "none" and "Upload location" set to "public://tmp".

After applying the MR, media_bulk_upload worked both with and without the dropzonejs and media_bulk_upload_dropzonejs modules enabled.

I also tried testing with Drupal 11.1, but had to use the fix offered in 🐛 Fixed the file validate constraint plugins Needs review . I had to apply it manually due to the changed file locations. With the ['file_validate_extensions'] changed to ['FileExtension']['extensions'], the MR works on D11 as well.

I used this to apply the MR:

composer config --json --merge extra.patches.drupal/media_bulk_upload '{"Issue #3355468: Can not upload using core file upload element": "https://git.drupalcode.org/project/media_bulk_upload/-/merge_requests/8.diff"}'
composer update drupal/media_bulk_upload

Confirming previous state of RTBC after the recent code updates in MR 8

Tested with Drupal 11.1.4 and media_bulk_upload dev-3.0.x, the above patch clears up errors
"Drupal\Component\Plugin\Exception\PluginNotFoundException: The "file_validate_extensions" plugin does not exist. Valid plugin IDs for Drupal\Core\Validation\ConstraintManager are: Callback... "

the_g_bomb → created an issue.

I have triaged the D7 issues that were marked "Closed (Outdated)" and produced this list of potential targets:

Patch offered, reviewed once
🐛 Required parameter $file follows optional parameter $storage in includes/hackedProject.inc on line 366 Closed: outdated - Required parameter $file follows optional parameter $storage in includes/hackedProject.inc on line 366
✨ Add support for new/added/created files Needs review - Add support for new/added/created files

Patch offered, needs review or reroll
#2570533: Support drush output formats (JSON, CSV etc) → , #2608816: Add support for Drush Output Formats to features-list → , ✨ Drush hacked-list-projects --pipe (D8) Closed: outdated - Improve drush support
🐛 Ignore line endings hasher doesn't handle windows carriage returns Closed: outdated - Ignore line endings hasher doesn't handle windows carriage returns
✨ Allow custom project types in the report Closed: outdated - Allow custom project types in the report
✨ Git clone support Closed: outdated - Git clone support
#1665742: Drush output on a csv → - Drush output on a csv
✨ Search for new malicious files Closed: outdated - Search for new malicious files
🐛 Fails if project name different to module/theme name Closed: outdated - Fails if project name different to module/theme name
✨ Option to ignore missing text files? Closed: outdated - Option to ignore missing text files?

Worth fixing, but no patch provided
✨ Adjust module order to give priority to Changed! Closed: outdated - Adjust module order to give priority to Changed!
✨ Integrate with Jenkins Closed: outdated - Integrate with Jenkins
✨ check for selected module only Closed: outdated - check for selected module only
✨ Add patch file support Closed: outdated - Add patch file support
🐛 Core Drual 418 files deleted? Not! Closed: outdated - Core Drupal 418 files deleted? Not! (Possible duplicate of ✨ Option to ignore missing text files? Closed: outdated )

the_g_bomb → created an issue.

Merged