🇬🇧United Kingdom @the_g_bomb

I have fixed 2 typos: "buttom" and "continer" in the file js/skipto.min.js
I have added the other words that cspell reported to a new .cspell-project-words.txt file.

the_g_bomb → created an issue.

The patch applies, and the CSS files are removed.
The styling, as described, looks to be addressed.

the_g_bomb → made their first commit to this issue’s fork.

The patch applies and removes the required file and reference.

Merged

The patch applies and moves the menu item as required.

I usually leave it as the default and change things if any issues can't be fixed.

the_g_bomb → created an issue.

the_g_bomb → created an issue.

Tested this and I think it looks good, there are a couple of things I spotted, but when I looked at:
https://skipto-landmarks-headings.github.io/page-script-5/ I can see them there too. If I get a chance, I will raise upstream.

I think supporting ^10 would be a good idea as well.

thank you

The only reason I would put this in the Autosave Node module issues is if it was a request to be able to pause autosaving. Perhaps other tools may be interrupted if the Autosave is triggered during a process.

If such a pause feature already exists, I don't think it would be correct for Autosave Node to guess which modules need it to pause.

It should offer a way to pause, then the module that needs it to pause should be able to trigger a pause state until it completes its task.

Done, thank you

the_g_bomb → created an issue.

Fair enough. The request was raised prior to knowing there weren't any active maintainers involved at all.

Given there aren't any maintainers other than me, perhaps I should be a maintainer rather than just a co-maintainer. I assume that will give me permissions to alter the settings in gitlab. Currently I can't change the default branch

As per https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → I am moving this to the Drupal.org project ownership issue queue.
I am offering to help with https://www.drupal.org/project/skipto → module but no response has been received.

I am going to close this task and keep open the suggestions if anyone needs new features added, they can be done there. There is a D8+ version available now so this is closing.

liampower → credited the_g_bomb → .

On installation I was getting errors about having missing modules for civicrm and mailchimp, to do with the config/install folder having group type related config, so I removed message_group_notify.message_group_type.mailchimp.yml & message_group_notify.message_group_type.civicrm.yml which allowed me to install the module without adding those modules.

I also found another issue when I try to enable the group at /admin/config/message/message_group_notify, possibly because I removed those config, but I kept getting a warning that "Only the Role and CiviCRM group group types are currently being implemented." when I expected something to allow me to choose which groups types should be enabled for notification.

I have tried to update this to be available to D10+ and fixed some of the issue that arose. It still Needs work.
To use this in a project you may need to do:

composer config repositories.message_group_notify vcs https://git.drupalcode.org/issue/message_group_notify-3097948.git
composer require drupal/message_group_notify:dev-3097948-Update-code

Or you could add a patch to the git version

git clone https://git.drupalcode.org/project/message_group_notify.git
cd message_group_notify
curl https://git.drupalcode.org/project/message_group_notify/-/merge_requests/1.diff | git apply --index -

Ref: https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... →

the_g_bomb → made their first commit to this issue’s fork.

Changing to target the latest branch

I hope the addition to the description satisfies the request in #4

the_g_bomb → made their first commit to this issue’s fork.

I don't think this affects the D8+ versions

drush en seckit using this latest patch and seckit: 2.0.3 or seckit dev-2.x seems to work ok for me when you view the admin form.

  - Installing drupal/seckit (dev-2.x f15d470): Cloning f15d470265 from cache
  - Applying patches for drupal/seckit
    https://git.drupalcode.org/project/seckit/-/merge_requests/16.diff (3193697: default-src has wrong description)

And also when running:

 % drush cget seckit.settings
_core:
  default_config_hash: **SNIP**
seckit_xss:
  csp:
    checkbox: false
    vendor-prefix:
      x: false
      webkit: false
    report-only: false
    default-src: "'self'"
    script-src: ''
    object-src: ''
..snip..

the_g_bomb → made their first commit to this issue’s fork.

The MR in #25 looks to be the one that is feature complete and should be tested.
https://git.drupalcode.org/project/seckit/-/merge_requests/19.diff is the patch from that.

Pushed a reroll of #21 applying to the 2.x branch.
This patch can be used if needed:
https://git.drupalcode.org/project/seckit/-/merge_requests/46.diff

Hi,
@luismagr there is a solution offered already that solves this in #21, you MR in #30 does not include the complete solution.
@manish.upadhyay I think your patch at #29 is close, but I don't think defer="defer" can be used for css

the_g_bomb → made their first commit to this issue’s fork.

I suspect a new issue will need to be created as this one is closed (fixed) and so it is not possible to re-open

This should be testable by using:

composer config repositories.skipto vcs https://git.drupalcode.org/issue/skipto-2634774.git
composer require drupal/skipto:dev-2634774-port-to-drupal

Having looked it doesn't appear that either of the current maintainers are active in the Drupal community or even in the paypal/SkipTo repository either.
https://github.com/paypal/SkipTo?tab=readme-ov-file#authors

Thanks, to be honest, it fell off my radar too. MR is updated, now

If anyone needs a patch this can be used: https://git.drupalcode.org/project/autologout/-/merge_requests/71.diff

Would be good to see this progressing again, I would be happy to RBTC this except I wrote some of the patch and feel weird reviewing my own work. Happy to green tick the work that followed, however.

The solution in ✨ Extend length of src fields Needs review may help

Double check this isn't caused by a browser extension.

I have seen google blocked because a browser extension is causing the type of script to be mis-reported in the log files. e.g. seckit sees google as script-src, but the browser sees google as data: because the script is being changed in the browser extension.
It fails due to that, but the report still thinks it is being blocked because it isn't listed in the script-src.

There should be no reason script-src-elem should be needed if you have script-src already.

There is already an issue trying to solve this: #3285493: How to add all google tlds for CSP → .
That being said, I find, when changing anything in SecKit, you need to clear caches to see any effect.

Messages sent to maintainers to highlight this request.

I was demo'ing the AI functionality in Drupal CMS, if anyone wants any further information please get in touch.
Everything in the demo is available to any Drupal installation using contributed modules, there was no custom code, so it would be easily replicable.
Tools included in the demo:

• https://www.drupal.org/project/ai → (including ai_ckeditor)
• https://www.drupal.org/project/ai_agents →
• https://www.drupal.org/project/ai_provider_openai → (other providers are available)

If anyone is interested in the recipe that was installed it can be viewed here:
https://git.drupalcode.org/project/drupal_cms/-/tree/1.x/recipes/drupal_...

the_g_bomb → created an issue. See original summary → .

No point reviewing, the duplicates thing is a problem and stops this working

FYI: I have installed the media_duplicates module and it doesn't seem to work with media_bulk_upload as you are still able to upload media while duplicates exist

When using the regular media upload only, the new module throws a form error which stops you creating a new media item while the same file exists, so there would need to be an extra step to ensure the bulk upload continues to process the other media entities after the duplicate is reached.

FYI: I have installed the media_duplicates module and
a) It doesn't seem to work with media_bulk_upload as you are still able to upload media while duplicates exist
b) When using the media upload only, the new module throws a form error which stops you creating a new media item while the same file exists, it doesn't then update the existing media item instead.

the_g_bomb → created an issue.

One thing I did spot when doing the patch to MR conversion

    $duplicates = [];

    // Loop through each of the uploaded files
    foreach ($fileNames as $fileName) {
      $pattern = $realpath . '/*/' . $fileName;
      $matches = glob($pattern);

      if (count($matches) > 0) {
        // If there is already a file in the public directory with the same name
        $duplicates[] = $fileName;
      }
    }

    if (!empty($duplicateUris)) {
      // Load the file entities by their URIs.
      $existingFileIds = \Drupal::entityQuery('file')
      ->accessCheck(TRUE)
      ->condition('uri', $duplicateUris, 'IN')
      ->execute();

The array of duplicates is never used once populated, and I wonder if the $duplicateUris variable is a typo as it is never populated that I can see.

Perhaps the $duplicates is meant to be used in place of $duplicateUris

I have created a PR based on the patch supplied in #6 with some coding standards improvements.

This could be considered a duplicate although that doesn't have a solution as yet. The original request is slightly different however, that is asking for a skip if exists feature, this is a replace if exists feature request, both have merit and should exist in and of themselves, I think, so one solution may fix both and it may be that we end up with a selection on the upload form requesting how to handle duplicates.

There still needs to be some investigation into whether https://www.drupal.org/project/media_duplicates → works combined, this issue can be closed, I think.

the_g_bomb → made their first commit to this issue’s fork.

Confirmed without dropzone this isn't working without the patch in from the MR or #4.

Added the Note as requested. I even got AI to help tidy up the wording.

the_g_bomb → created an issue. See original summary → .

I changed it, same reasons as yours (hills etc)

As an FYI, this is what it looks like, which I don't think looks that clunky as it isn't duplicated.

Hey, I went with that to make it obvious the user had to go to a different site then and they would know where to go later. This might be their first introduction to Open AI or Anthropic and they may not know the URLs.

It is also possible that they know the tools but don't know where to get the API Keys.

Great idea, patches welcome, if you have the time.

the_g_bomb → created an issue.

Should this have gone into the 2.x branch as well?

Using the new service parameter also change the patch to make the module only available to Drupal 10.1 and above.
We can backport a different solution for earlier versions if required.
For the backport I would think we should copy the current core setting which is 200000 and set 'Lax' by default.

I have removed the additional config for samesite and lifetime settings, but grabbed those values from core and added them to the JS settings.

I left the cookie secure setting default to FALSE just in case sites don't have an SSL cert. I am also not sure what will happen if that is on without one, so thought it best to leave it as False as turning it on is easier than potentially debugging an error if it is on and causes problems.

Thank you, I have responded

the_g_bomb → created an issue.

Yeah, I did think there would be a reason for using a slimmed-down profile, but then as the a11y tests are testing the user experience rather than specific functions or features, using a controlled environment might not test what users actually experience.

In fact, there is a case that freshly installed Drupal may not have enough things in place to ensure everything is accessible. e.g. the homepage list of articles with pagination.

To be honest, I suspect we may want each profile to have its own set of tests. I would love to see umami_demo and the drupal cms out-of-the-box experience covered by some a11y tests.

Thanks for the feedback, looking forward to seeing how you get on with PHPUnit.

Thank you

I have now sent contact form messages to the maintainers who appear to have been active in the past 60 days based on recent commits.

Sorry, I completely forgot I opened this, I opened it and thought I would see if the maintainers responded, they haven't so I will procede and use any of the contact forms to see if I can get a response.
Thanks for the reminder

FYI, I think it would be a good idea to move the existing Nightwatch tests to either Playwright or PHPUnit as appropriate when they are available. Just keen to get the current tests working as optimally as possible in the meantime.

FYI, I think it would be a good idea to move the existing Nightwatch tests to either Playwright or PHPUnit as appropriate when they are available. Just keen to get the current tests working as optimally as possible in the meantime.

I think there is some work required in core/modules/user/src/Form/UserMultipleCancelConfirm.php as well.

I suspect this should be solved by: ✨ Expand the a11y nightwatch coverage in Core Active

In that PR Standard has been used, and as you suggest more Axe tests fail and as such those tests have had to be skipped for now.

the_g_bomb → created an issue.

Can I check, would moving to Playwirght solve the issue outlined here: 🐛 Impossible to run only Nightwatch tests in a given directory (f.e. for contrib modules) Needs work ?

If you think about what we are dealing with here.

There is core it has been forked at a point in time to make the fork repo and branch for this issue.

Since that point core has progressed, this repo and branch are still stuck in time, back when the repo was cloned.

To bring this up to date we need to get core 11.x up to date, we need to push that to the 11,.x version in this repo and then probably also need to merge the changes in this branch too.

If you look at the forked repo you may notice it says
`Forked from project / drupal
223 commits behind the upstream repository.` I think that refers to the default branch.

If you have permission there is usually a button you can click to update the repo, or sync the repo, which is probably the easiest, assuming you have the 11.x branch in your forked, that is probably easiest.

You can also manually do it with git.

Which I can imagine might look something like:

git checkout 11.x
git pull
git push drupal-3485202/11.x
git checkout 3485202-change-the-dialog
git merge 11.x
git push drupal-3485202/3485202-change-the-dialog

That should make your forked repo up to date with the current core as it is now, all the latest code will be in 11.x and your branch, so only the changes you are introducing should be shown in the MR.

Updating to use latest branch

I like this article about when to use alt text and when there is enough information nearby that it perhaps can create duplicate content.
https://webaim.org/techniques/alttext/

Also, there should be rules to ensure that if an image is being used to display text, the text should be conveyed in the alt text as well.

¯\_(ツ)_/¯ Sometimes the tests don't work until you retry them.