- Status changed to Needs work
over 2 years ago 11:05pm 13 February 2023 - Merge request !6511Issue #3263397 by @mably: Simplify form logic in media library (Drupal 9.5.11 compatible version) → (Closed) created by mably
- First commit to issue fork.
- First commit to issue fork.
- First commit to issue fork.
- 🇬🇧United Kingdom the_g_bomb
I hope the addition to the description satisfies the request in #4
- Status changed to Needs review
4 months ago 5:58pm 24 March 2025 - 🇺🇸United States smustgrave
Fact some tests had to be updated to pass makes me think could be a breaking change for some
- Status changed to Needs work
about 2 months ago 6:34pm 26 May 2025 - 🇺🇸United States smustgrave
What if someone extending the media library doesn't have these new keys what are the odds it'll be an immediate breaking.
Also not sure '_weight' is standard key format? But moving to NW as there appear to be open questions from #4
- 🇬🇧United Kingdom the_g_bomb
Updating Outstanding tasks in the summary from #4:
The code being replaced here originally came from \Drupal\file\Plugin\Field\FieldWidget\FileWidget::submit() and that uses the _weight already.
Is is possible to remove the same code from FileWidget too? (potentially another ticket to investigate file widget)The patch needs more documentation to explain:
Why _weight exists
What is stored in field state,
why $form_state->getUserInput() is called.