Disabled update module shouldn't produce a status report warning

Re-roll for Drupal 10.3.x.

Re-roll for 10.3.x branch, above one has little issue in finding file.

All issues should target the 11.x branch.

In addition, there is a merge request open, so please refrain from making changes by submitting patches. It's hard to see what changed without an interdiff, and the pipeline won't run.

Facing issues here, not getting edit button while trying to target existing MR against 11.x

Even facing issue while creating new branch against 11.x :
Not able to search branch 11.x

Already 11.x selected however when create new button, getting error:
Failed to create branch '2869592-disabled-update-module-status': invalid reference name '11.x'

@smitghelani, @solideogloria, @pooja_sharma, @hswong3i. It is an important part of working on an issue to read the comments and the issue tags to determine what to do. Not all issues at needs work needs an MR updated. And comment #39 and #40 explained that the approach here is not acceptable. This was stated again in #60. The work here is an issue summary update and to provide the information asked for in #39.

Okay @quietone got your concerns, Thanks for flagging it out along with constructive feedback, recently I just have started exploring contribution. As this issue comments are too long due to which some comments that needs to be addressed remain unnoticed unintentionally, however try to make it sure contribute meaningfully in the right direction

I agree with #39 & #40, maybe it's best to think of something else instead of hide the warnings information from core itself, especially from a security perspective where transparency & awareness of potential risks are crucial.

If this request still needs, then I believe suggested one contrib module approach 'll fit well in this scenario.

Reroll for Drupal 10.2.7

Re-roll for Drupal 10.3.1

Adding new patch for 10.3.5

Hi @quietone,

I understood all the concerns mentioned in old chats, but it was necessary step required in lightning_core module, as it is added as dependency patch and not working with latest Drupal versions like 10.3.x and 11.x. So, for time being or i can say till we find alternative and most promising solution for this issue, we need something to keep this thing running in our project as it is.

So, that's why added new patch to replace it in lightning_core. But, lightning_core is still bottle neck with this issue and merge request with replaced patch is also in pending to merge. So, looks like I need to find some alternative options to get rid of it.

Hi @smitghelani,

I had the same problem with an older site with the Lightning distro on and I fixed it by adding this in my composer file:
"patches-ignore": {
"drupal/lightning_core": {
"drupal/core": {
"2869592 - Disabled update module shouldn't produce a status report warning": " https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch → "
}
}
}

Hope that helps you!

Re-roll for Drupal 11.0.6

Rerolled to 11.x

Given #309040: Add hook_requirements_alter() → is in core since 9.5.x and up, seems the update_notifications_disable contrib could be ported to use that mechanism to suppress or alter the warning, not the problematic methodology it used per the summary here.

I’d strongly be in favor of closing this as “works as designed”

Given #309040: Add hook_requirements_alter() is in core since 9.5.x and up, seems the update_notifications_disable contrib could be ported to use that mechanism to suppress or alter the warning, not the problematic methodology it used per the summary here.

I’d strongly be in favor of closing this as “works as designed”

I disagree. The use of that contrib module is not the only use-case where the warning occurs. It also occurs if you actually disable the update module, for example if the server doesn't have access to the Internet, and the check for updates creates network connection errors in the logs every time cron runs. That's my use-case.

@solideogloria: I think you misunderstand my point and the intention of that contrib module. It (was?) is implemented using a methodology that might have been necessary pre 9.5.0 core, but which has various problems. There's a better way now. If that contrib was ported to modern Drupal and used hook_requirements_alter(), it would actually do what it's supposed to - silence this warning. That's the whole point why that contrib module exists. So if you're in one of the use cases from comment #15 (or any other use case) where silencing this warning is actually a good move, install the (updated, and working properly) contrib module, once it has a new release. 😅

But we don't want to change this behavior in core, for all the reasons the release managers have already written (and which I fully support).

Opened 📌 Use hook_requirements_alter() to only silence the warning, not take over the whole update.module namespace Active for the better solution to this problem.

📌 Use hook_requirements_alter() to only silence the warning, not take over the whole update.module namespace Active now has a working MR for a new branch. See also 📌 Add dww as a co-maintainer for the 2.0.x branch Active . Or, I could move it into a whole new contrib project, something like update_hide_uninstalled_warning or something.

https://www.drupal.org/project/update_notifications_disable/releases/2.0... → is now out.

Adding new patch for 10.4.7

In order to stop having to keep creating patches you can do this instead:

composer config --json extra.patches-ignore '{"drupal/lightning_core": {"drupal/core": {"2869592 - Disabled update module shouldn't produce a status report warning": "https://www.drupal.org/files/issues/2869592-remove-update-warning-7.patch"}}}'
composer require 'drupal/update_notifications_disable:^2.0@RC'
drush en update_notifications_disable

I'm uploading a new patch, this make it compatible with drupal 11.2.0-rc2

Please use the contributed module instead of continuing to post patches on this closed issue. Thanks!

Saving credits for a few folks that helped manage the issue discussion here, and then locking the issue to prevent further patches from being posted. If you think the functionality of the contrib module needs improvement, please file issues against it instead of core. Thanks everyone!