🇮🇳India @bala_28

Adding new patch for 10.3.5

Seems its not working with Drupal 10.3.5
Anyone tired with this version?

Patch from #129 applies on 10.3.1

But getting warning while I navigate to Add Content:
Warning: Undefined property: Drupal\Core\Extension\Extension::$ancestors in Drupal\Core\Extension\ProfileExtensionList->getAncestors()

Added the below fix on top of the patch and generated a new one.

diff --git a/core/lib/Drupal/Core/Extension/ProfileExtensionList.php b/core/lib/Drupal/Core/Extension/ProfileExtensionList.php
index cbaae106d3..a211365966 100644
--- a/core/lib/Drupal/Core/Extension/ProfileExtensionList.php
+++ b/core/lib/Drupal/Core/Extension/ProfileExtensionList.php
@@ -62,8 +62,10 @@ public function getAncestors($profile = NULL) {
 
     $extension = $this->get($profile);
 
-    foreach ($extension->ancestors as $ancestor) {
-      $ancestors[$ancestor] = $this->get($ancestor);
+    if (!empty($extension->ancestors)) {
+      foreach ($extension->ancestors as $ancestor) {
+        $ancestors[$ancestor] = $this->get($ancestor);
+      }
     }
     $ancestors[$profile] = $extension;

A temporary fix until search_api_solr fixes from its end.

Added a patch to fix this issue.

bala_28 → created an issue.

Patch #3 is invalid and it updates the current time on submit.

Found that this error occurs due to the overridden massageFormValues() in /src/Plugin/Field/FieldWidget/TimestampDatetimeNoDefaultWidget.php

After removing this method, the error is not reproducible.

Created the patch accordingly. Please review.

bala_28 → created an issue.

Adding new patch for D10 version. (excludes test cases)

New patch added for D10 version.

I was trying the apply the entity_embed-3272732-80.patch using cweagans and it failed on two files.

tests/modules/entity_embed_test/entity_embed_test.info.yml
tests/modules/entity_embed_translation_test/entity_embed_translation_test.info.yml

So removed those two files and using a new patch which gets applied and now able to pull the entity into ckeditor5.

Here is my diff of composer.json

+      "drupal/entity_embed": {
+        "Drupal 10 & CKEditor 5 readiness[https://www.drupal.org/project/entity_embed/issues/3272732]": "https://www.drupal.org/files/issues/2023-06-19/entity_embed-3272732-93.patch"
+      },
+      "drupal/embed": {
+        "CKEditor 5 compatibility[https://www.drupal.org/project/embed/issues/3309747]": "https://www.drupal.org/files/issues/2023-03-30/fix_module_embed_compatibility_CKEditor_5.patch"
+      },

As mentioned in Proposed solution adding a patch.
Please validate and share your suggestions.

bala_28 → created an issue.

Yes @darvanen. It's for token module.

And here is the updated patch, where we included ckeditor5 under dependencies.
This will make the ckeditor5 lib to load before the token.js and prevents the "'First click a text field to insert your tokens into.'" alert display and inserts the token into editor.

bala_28 → made their first commit to this issue’s fork.

bala_28 → made their first commit to this issue’s fork.

This patch works for me. But I have not verified on text_format change.

On page load, the token.js loads first and then comes the ckeditor5.js.
Before the ckeditor is applied, we are trying to iterate the Drupal.CKEditor5Instances which is null by default.

Hope the patch #8 works after changing the js order.

bala_28 → made their first commit to this issue’s fork.