Chennai
Account created on 3 January 2012, over 12 years ago
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

Added a patch to fix this issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

bala_28 โ†’ created an issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

Patch #3 is invalid and it updates the current time on submit.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

Found that this error occurs due to the overridden massageFormValues() in /src/Plugin/Field/FieldWidget/TimestampDatetimeNoDefaultWidget.php

After removing this method, the error is not reproducible.

Created the patch accordingly. Please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

Adding new patch for D10 version. (excludes test cases)

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

New patch added for D10 version.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

I was trying the apply the entity_embed-3272732-80.patch using cweagans and it failed on two files.

tests/modules/entity_embed_test/entity_embed_test.info.yml
tests/modules/entity_embed_translation_test/entity_embed_translation_test.info.yml

So removed those two files and using a new patch which gets applied and now able to pull the entity into ckeditor5.

Here is my diff of composer.json

+      "drupal/entity_embed": {
+        "Drupal 10 & CKEditor 5 readiness[https://www.drupal.org/project/entity_embed/issues/3272732]": "https://www.drupal.org/files/issues/2023-06-19/entity_embed-3272732-93.patch"
+      },
+      "drupal/embed": {
+        "CKEditor 5 compatibility[https://www.drupal.org/project/embed/issues/3309747]": "https://www.drupal.org/files/issues/2023-03-30/fix_module_embed_compatibility_CKEditor_5.patch"
+      },
๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

As mentioned in Proposed solution adding a patch.
Please validate and share your suggestions.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

Yes @darvanen. It's for token module.

And here is the updated patch, where we included ckeditor5 under dependencies.
This will make the ckeditor5 lib to load before the token.js and prevents the "'First click a text field to insert your tokens into.'" alert display and inserts the token into editor.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

bala_28 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

bala_28 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

This patch works for me. But I have not verified on text_format change.

๐Ÿ‡ฎ๐Ÿ‡ณIndia bala_28 Chennai

On page load, the token.js loads first and then comes the ckeditor5.js.
Before the ckeditor is applied, we are trying to iterate the Drupal.CKEditor5Instances which is null by default.

Hope the patch #8 works after changing the js order.

Production build 0.69.0 2024