Contrib.social

New 4.x branch for Drupal 10 compatibility with SimpleSamlPHP dev-master

Open on Drupal.org →
Created on 16 June 2022, over 2 years ago
Updated 28 March 2023, over 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

3.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Status changed to Fixed almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States edmund.dunn Olympia, WA

    I am running into this error using the 4.x branch. Unable to install module simplesamlphp/simplesamlphp-assets-base, package name must be on the form "VENDOR/simplesamlphp-module-MODULENAME". For context, we are setting up a test instance of Drupal 10 as a starting point for our upgrade from Drupal 9. Currently, this is the only remaining blocker to getting composer to update.

  • Comment almost 2 years ago →
    🇨🇭Switzerland berdir Switzerland

    i don't know what depends on it and why you get that error, but we have passing tests on D10. That doesn't mean much, but it it at least shows that this 4.x *can* be installed on D10. i suggest you create a new issue and check where/why you depend on that. Maybe that no longer exists on dev-master?

  • Comment almost 2 years ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Status changed to Fixed over 1 year ago
  • Comment over 1 year ago →
    drase15

    Hello,

    I know this thread is closed, but someone can help me please.

    I tried to download the module from branch 4 with composer, but I get this error:

    simplesamlphp/simplesamlphp[v1.19.0, ..., v1.19.1] require php >=7.1 <8.0 -> your php version (8.1.15) does not satisfy that requirement.
    - simplesamlphp/simplesamlphp[v1.19.2, ..., v1.19.7] require symfony/console ^4.4 || ^5.0 -> found symfony/console[v4.4.0, ..., v4.4.49, v5.0.0, ..., v5.4.19] but the package is fixed to v6.2.5 (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
    - simplesamlphp/simplesamlphp v1.19.6 requires gettext/gettext v4.x-dev#3e7460f8d9c90174824e3f39240bd578bb3d376a -> found gettext/gettext[4.x-dev] but it does not match your minimum-stability.
    - drupal/simplesamlphp_auth 4.x-dev is an alias of drupal/simplesamlphp_auth dev-4.x and thus requires it to be installed too.
    - drupal/simplesamlphp_auth dev-4.x requires simplesamlphp/simplesamlphp ^1.19 | dev-master -> satisfiable by simplesamlphp/simplesamlphp[v1.19.0, ..., v1.19.7].
    - Root composer.json requires drupal/simplesamlphp_auth 4.x-dev@dev -> satisfiable by drupal/simplesamlphp_auth[4.x-dev (alias of dev-4.x)].

    But D10 require php 8 or higher.

    How can I install this module from branch 4, compatible with D10, but get error on php version?

    Thanks in advance

  • Comment over 1 year ago →
    🇨🇦Canada gwvoigt London, ON 🇨🇦

    Same error as #27

  • Comment over 1 year ago →
    🇺🇸United States mark_fullmer Tucson

    I am running into this error using the 4.x branch. Unable to install module simplesamlphp/simplesamlphp-assets-base, package name must be on the form "VENDOR/simplesamlphp-module-MODULENAME"

    This occurs if you have previously installed the simplesamlphp assets into the vendor directory before updating. You can resolve this by removing the vendor directory, then doing the composer update. FWIW, this is not really an issue with the simplesamlphp_auth Drupal module.

    I tried to download the module from branch 4 with composer, but I get this error:
    simplesamlphp/simplesamlphp[v1.19.0, ..., v1.19.1] require php >=7.1 <8.0 -> your php version (8.1.15) does not satisfy that requirement.

    Try explicitly requiring simplesamlphp/simplesamlphp ^2 first.

  • First commit to issue fork.
  • Open on Drupal.org →
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update over 1 year ago
    Not currently mergeable.
  • @bala_28 opened merge request.
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024