πŸ‡ΊπŸ‡ΈUnited States @edmund.dunn

Olympia, WA
Account created on 22 June 2017, over 6 years ago
#

Recent comments

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

We used this successfully. We had this same error. Two revisions, one created by an automated migration job, the other by an editor, both within a few hours. This created a conflict of some sort. This solved the issue. Well done!

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Turns out this patch was no longer necessary to fix our issue once we applied the patch from entity_browser_table.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. This also fixed our issue. Again, nice work!!

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. This also fixed our issue. Nice work!!

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

@evaldas-uΕΎkuras, that is a good point. The combination of your patch here, and the patch you added for entity_browser_table seemed to fix our issue. We will be doing some more testing here in the next couple of weeks. Nice work!

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

I am not sure that @EthanT 's solution is ideal. We have cases where it is still needed and is not being injected. I am wondering if there is something to do with the recent changes to using the create() methods to inject? Although why it works the first time and not the second (see video) is the true mystery.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

This is occurring for us as well. When I stepped through the first time entityTypeManager was injected correctly, everything appeared to be working correctly. The second time, see attached screen recording, it was not there. The entity type is loaded correctly, but entityTypeManager = null.

Feel free to pull down https://github.com/department-of-veterans-affairs/va.gov-cms. It runs on ddev. ddev pull va --skip-files gets you the database.

Full error is:
Error: Call to a member function getStorage() on null in Drupal\entity_browser\Plugin\Field\FieldWidget\EntityReferenceBrowserWidget->formElementEntities() (line 759 of modules/contrib/entity_browser/src/Plugin/Field/FieldWidget/EntityReferenceBrowserWidget.php).
Drupal\entity_browser\Plugin\Field\FieldWidget\EntityReferenceBrowserWidget->formElement(Object, 0, Array, Array, Object) (Line: 130)
Drupal\entity_browser_table\Plugin\Field\FieldWidget\EntityReferenceBrowserTableWidget->formElement(Object, 0, Array, Array, Object) (Line: 342)
Drupal\Core\Field\WidgetBase->formSingleElement(Object, 0, Array, Array, Object) (Line: 92)
Drupal\Core\Field\WidgetBase->form(Object, Array, Object) (Line: 183)
Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm(Object, Array, Object) (Line: 669)
Drupal\paragraphs\Plugin\Field\FieldWidget\InlineParagraphsWidget->formElement(Object, 0, Array, Array, Object) (Line: 342)
Drupal\Core\Field\WidgetBase->formSingleElement(Object, 0, Array, Array, Object) (Line: 849)
Drupal\paragraphs\Plugin\Field\FieldWidget\InlineParagraphsWidget->formMultipleElements(Object, Array, Object) (Line: 111)
Drupal\Core\Field\WidgetBase->form(Object, Array, Object, NULL) (Line: 968)
Drupal\paragraphs\Plugin\Field\FieldWidget\InlineParagraphsWidget->form(Object, Array, Object) (Line: 183)
Drupal\Core\Entity\Entity\EntityFormDisplay->buildForm(Object, Array, Object) (Line: 121)
Drupal\Core\Entity\ContentEntityForm->form(Array, Object) (Line: 127)
Drupal\node\NodeForm->form(Array, Object) (Line: 107)
Drupal\Core\Entity\EntityForm->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 536)
Drupal\Core\Form\FormBuilder->retrieveForm('node_step_by_step_form', Object) (Line: 283)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object) (Line: 39)
Drupal\layout_builder\Controller\LayoutBuilderHtmlEntityFormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 592)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 68)
Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 53)
Asm89\Stack\Cors->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

And missed one change for the patch.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

I had to update the patch to add an accessCheck() to the query for the getAlertsByLabel method. Missed that!

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

This mostly works for us. Thank you and good work @sascha_meissner! It is definitely a big improvement on the previous. The style replicates on the same line but doesn't follow if you hit enter. This is workable until a permanent fix is in place!

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

I went ahead and created a patch from the work @puidu did in #113. That worked for us; we have several instances where the initial render of one of the ckeditor5 instances was out of the viewport, and the height when it was revealed was set to 65px. Changing it to 24 gets us close to the 180pc height all of our other ckeditor instances have.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

I rerolled this to move the menu link from config->system to config->user interface. Also had to move the setting.yml file into the config/install directory to prevent an error when installing the module.

This works well for our needs.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. This also fixed our issue.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

We are in the process of upgrading to D10 from D9.5. We didn't notice the issue until we got it up on our test instance for testing. On our local and dev environments, we have aggregation turned off so we hadn't noticed any issues.

Turning aggregating off does fix the issue.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

We are having the same issue as @FiNeX in #56.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Just an update on our testing. There were a couple of bugs with the dedicated metadata URL. Those have been fixed. We are waiting for our IAM team to set up or test site with their test IdP with he updated metadata to complete testing. I will update this thread once that is complete.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

@caesius good catch! That worked! Thank you!

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

4.x-dev still requires dev-master not 2.1.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Ok it is installed, and everything seems to be working. Once we get the IdP configured we can test. I will update this thread once we can confirm either way.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

I just ran into it too! Adding "twig/twig": "3.7.0 as 3.6", fixed it. I just used that in my main composer.json. This hacky approach will at least work for testing.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

@nitesh624 we can test it. It will take us a bit to set up because we have to coordinate with the IAM team for our organization. I will post our results here.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

I am unable to replicate this. Could you please provide some more info on your setup?

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Here is the patch.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

We are going to address this. Working with our designer to get comp to work from. More to follow.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. This also fixed our issue.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

ALso tested on 10.1 and this fixed everything right up for us! Thank you!

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

This was addressed in https://www.drupal.org/project/textfield_counter/issues/3358129 πŸ› Module does not work in d10 due to .once js issue Fixed . Thank you for identifying and patching.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

#4 would not apply for me. I re-rolled it.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

This should fix the tests.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Good point @swirt! Made the relevant changes as this simplifies things.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Updated patch to allow for the above situations.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Attached patch.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

edmund.dunn β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Ok, I will rework it to do the above.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. This also fixed our issue.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Rerolled for 10.1. Applies cleanly.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Slight change in approach; this just returns the none string value so that the next process in the chain can continue on. I misunderstood and thought this was what the MigrateSkipProcessException did. This also iterates through an array and acts aon all strings in the array, returning all non-string items as is.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

We had this issue pop up again in a different area. This time it was a field that isn't always populated. It comes in with a value of NULL when it isn't populated. Here is a patch. I added a check to verify whether the incoming value is a string or an array of strings, and if it isn't it will throw a MigrateSkipProcessException. I also added a unit test for it.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

I messed up the above patch. Here's the correct one.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Somehow the first one ended up empty. This one has the patch.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

As requested! :)

This uses the php boolval() function. It also accounts for yes/no strings.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. This also fixed our issue.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

#11 would not apply. I rerolled it for the latest release(3.4.1).

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. Rerolled for 2.1. This also fixed our issue.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. This also fixed our issue.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Added patch with .info.yml.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

This applied cleanly for us!

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

#5 worked for us.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

@orakili package in #22 works well. I tried the patcher from vaimo, but it wasn't applying all of the patches cleanly.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Found the solution. https://www.drupal.org/project/drupal/issues/3036459#comment-14836380 πŸ› Packaging info from .info.yml often creates conflicts when patching Active I had to add it in a separate patch file. But it installs cleanly.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

This works for us.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

This applies cleanly via composer. I had to take out the portion that applied to fast_404.info.yml. If anyone can get that working via composer it would be super helpful!

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

This should apply cleanly. I Hope.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

I rerolled the patch to add a couple of other fixes to @mnk-0210 's work.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Never mind, it doesn't apply using composer. My apologies.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC. This also fixed our issue.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

This worked for me.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

edmund.dunn β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting a static patch because merge requests don't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Patch attached.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

I rerolled the patch for the latest release.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Posting the static patch because using the MR doesn't allow pinning to a specific commit, so anyone can submit pretty much anything and inject it into our codebase IIRC

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Patch with fixes.

πŸ‡ΊπŸ‡ΈUnited States edmund.dunn Olympia, WA

Adding a fixed patch to avoid unexpected changes. This works for us too.

Production build https://api.contrib.social 0.61.6-2-g546bc20