- 🇮🇳India nayana_mvr
Reviewed the patch #2 and tested it on Drupal version 10.1.x and Textfield Counter version 8.x-1.x. README.txt file has been replaced with new README.md. I have attached the before and after screenshots for reference. Need RTBC+1
- Assigned to Sonal Gyanani
- @sonal-gyanani opened merge request.
- Issue was unassigned.
- 🇮🇳India Sonal Gyanani
Fixed formatting issues as per comment #3.
Please review.
Thanks - 🇮🇳India nayana_mvr
Reviewed MR#5 and verified README.md format issues. Only change noticed is the title 'Contents of this file'. As per template it should be 'Table of contents'. But I'm not sure if it needs to be changed as that section is given as optional in the template. Attached screenshot for reference. Need RTBC+1
- Status changed to RTBC
over 1 year ago 3:02pm 11 July 2023 - Status changed to Needs review
over 1 year ago 2:27pm 14 July 2023 - 🇳🇴Norway gisle Norway
Nupur Badola: Please don't upload screenshots of your terminal showing that a patch applies, followed by a directory listing. Anyone can observe what the automated tools does. Posting a screenshot of it here just adds noise to the issue.
Before an issue can be marked RTBC the changes need to be manually reviewed, this wasn't done.
Please read up on Issue Etiquette → . Pay attention on #11 and #14 on the "Don't" list.
Your comment here is spam and you've been tagged as a spammer. I'm setting the status back to "Needs review".
- Status changed to Fixed
over 1 year ago 9:12pm 18 July 2023 -
nayana_mvr →
authored c18d87aa on 2.x
Issue #3321068 by Sonal Gyanani, gowthami reddy, nayana_mvr, Nupur...
-
nayana_mvr →
authored c18d87aa on 2.x
- Status changed to Fixed
over 1 year ago 2:45pm 19 July 2023