- Issue created by @albertosilva
- Status changed to Needs review
almost 2 years ago 9:08am 9 February 2023 - 🇫🇷France arnaud-brugnon
This is quite important.
8.x-1.1 is supposed to be compatible with Drupal 10. - Status changed to RTBC
over 1 year ago 4:47pm 26 June 2023 - 🇺🇸United States edmund.dunn Olympia, WA
ALso tested on 10.1 and this fixed everything right up for us! Thank you!
- 🇨🇿Czech Republic Bohus Ulrych Pilsen (Czechia)
Hi all,
only first patch replace_jquery_once_with_core_once.patch works as expected.
The other one - paragraphs-browser-jquery-once-d10.patch - fixes errors in the console, but functionality doesn't work.
Goal of this Drupal.behaviors.PBStyling was to enable whole fieldset clickable. But now it doesn't work, because
* e.target.matches catches img tag and also it's parent div, only when you click outside then condition (e.target.matches('.paragraphs-browser-paragraph-type')) is try
* but still then it seem thatinputElement.dispatchEvent(new Event('mousedown'));
do nothingThanks
- 🇩🇪Germany simonbaese Berlin
Tested patch in #9 with Drupal 10.1! Fixes the issue for me.
- 🇺🇸United States aasarava
Confirmed that the patch works, thanks! Would be great to get a new release so that there's a true D10-compatible release of the module.
- Status changed to Needs review
about 1 year ago 4:21am 15 November 2023 - 🇫🇮Finland j-vee Turku, Finland
The patch here broke functionality with clicking on the fieldset to add a new paragraph instead of the Add-button directly. The same issue raised by #10.
Issue was javascript using currentTarget instead of target to select the button inside the fieldset element. Attached patch fixes that issue.
- Status changed to RTBC
about 1 year ago 6:15pm 22 November 2023 - 🇺🇸United States mlncn Minneapolis, MN, USA
Attesting to the efficacy of j-vee's patch in #13!
- 🇩🇪Germany simonbaese Berlin
Worked with patch #13 for a couple weeks now. Fixes the described issues.
- 🇨🇿Czech Republic Bohus Ulrych Pilsen (Czechia)
Patch #13 now works for me without any problem. Thanks!
I found that the patch was not taking into consideration clicking on other elements within the fieldset. Mainly clicking on the image/thumbnails of the paragraph. By checking if the target's closest we check if the current element or a parent of it is the fieldset we need. Then we target the input of said fieldset.
- 🇨🇿Czech Republic Bohus Ulrych Pilsen (Czechia)
Yes! #18 works even when clicked on the image.
- 🇦🇷Argentina gerzenstl Resistencia
- 🇫🇷France Fabsgugu
Hello,
I think we should release a new version for this module.
There are several tickets to commit. (Like https://www.drupal.org/project/paragraphs_browser/issues/3347934 🐛 PHP 8.2 Deprecated function: Creation of dynamic property RTBC ) - 🇺🇸United States rymcveigh
I can confirm that the patch from #18 works for me as well.
I tested on:
Drupal 10.2.3
paragraphs_browser 1.1.0I completely agree that there needs to be a new release of this version.
- 🇻🇳Vietnam phannphong Ho Chi Minh City
The path #18 is working well and I think it can be delivered asap.
- First commit to issue fork.
- Status changed to Fixed
9 months ago 9:58pm 29 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.