Basque Country
Account created on 28 February 2011, about 14 years ago
  • Drupal Developer at Biko2Β 
#

Merge Requests

Recent comments

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Thanks @kentr for the MR!

Merged and new version published.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Please consider this new patch, the first one was incomplete.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Thanks for the report, already fixed and published

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country
πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Thanks, fixed and merged

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Merged, thanks @dieterholvoet

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

albertosilva β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

I cannot reproduce it.

Any hint on a possible solution or a way to reproduce it?

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Merged and published a new release, thanks @geoffreyr

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

This patch adds #maxlength to the field, sot FormValidator::performRequiredValidation() validates it, as proposed in #17.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

albertosilva β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

It is out of the scope of this module.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

HI,

Thanks for your patch, I've already merged it and will publish a new version soon.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

albertosilva β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Hi,

Thanks for your patch, I've already merged it and will publish a new version in a couple of days.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Hi,

Thanks for your patch, I've already merged it and will publish a new version in a couple of days.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Hi pianomansam

Thanks for your patch, I've already merged it and will publish a new release in a couple of days.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Hi,

I cannot reproduce this issue, could you please try it again and provide more details?

Thanks

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Hi,

Could you please confirm if the solution provided by https://www.drupal.org/project/critical_css/issues/3394895 πŸ› Critical CSS breaks AJAX Dialogs (popups) in D10 Active is working for you? I have already committed the patch from that issue, and I think it should also work for you use case.

Thanks

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Hi,

Could you please confirm if the solution provided by https://www.drupal.org/project/critical_css/issues/3394895 πŸ› Critical CSS breaks AJAX Dialogs (popups) in D10 Active is working for you? I have already committed the patch from that issue, and I think it should also work for you use case.

Thanks

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Hi @gaele,

Could you confirm if the solution provided by https://www.drupal.org/project/critical_css/issues/3394895 πŸ› Critical CSS breaks AJAX Dialogs (popups) in D10 Active is working for you? I have already committed the the patch from that issue, and I think it should also work for you use case.

Thanks

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Hi @tarazingo:

Thanks for your patch, I will publish a new version with it in a couple of days.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

albertosilva β†’ made their first commit to this issue’s fork.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Hi,

I cannot reproduce this issue, could you please provide more details on the steps you follow to get to that error?

Thanks

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Confirmed this patch is working and fixes the error.

This error is happening because the interface is defined as Drupal\syslog\Logger\SysLog::log($level, Stringable|string $message, array $context = []): void but this module misses the Stringable|string declaration and the : void return type.

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Hi @vidorado,

Static Suite is aimed at decoupling Drupal sites and making them static, and therefore it offers a plethora of features focused on that aim. Exporting redirects is one of those features, but maybe using Static Suite only to get those redirects seems to me somewhat overkilling.

I would recommend making a custom module or Drush command and copy there the functionality from modules/static_export/modules/static_export_exporter_redirect/src/Plugin/static_export/Exporter/Custom/RedirectExporter.php::calculateDataFromResolver().

You don't need the rest of features from Static Suite (and its inherit complexity), so I think that is a much better approach.

Thanks

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Thanks @RenatoG, MR merged!

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country
πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Thank you all for this patch, I have just merged it!

πŸ‡ͺπŸ‡ΈSpain albertosilva Basque Country

Just to clarify it, "created" field is also named as "Authored on" in some installations.

Production build 0.71.5 2024