- Issue created by @yashmalviya
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:40am 29 June 2023 - 🇮🇳India yashmalviya
I have fixed the errors and warnings. Please review the patch.
- Status changed to RTBC
over 1 year ago 11:01am 29 June 2023 - 🇵🇭Philippines roberttabigue
Hi @yashmalviya,
I reviewed your changes and confirmed the Patch was applied cleanly.
Checking patch src/Asset/CssCollectionRenderer.php... Checking patch src/Form/SettingsForm.php... Checking patch tests/src/Unit/CriticalCssProviderTest.php... Applied patch src/Asset/CssCollectionRenderer.php cleanly. Applied patch src/Form/SettingsForm.php cleanly. Applied patch tests/src/Unit/CriticalCssProviderTest.php cleanly.
And all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,ymlApplied to Critical CSS module with 8.x-1.19 version and with the Drupal core version of 9.5.x.
Attaching screenshots and moving this to RTBC,
Thanks.
-
albertosilva →
committed 9f092cff on 8.x-1.x
Issue #3371298 by yashmalviya, roberttabigue: Fix the issues reported by...
-
albertosilva →
committed 9f092cff on 8.x-1.x
- Assigned to albertosilva
- Status changed to Fixed
11 months ago 9:19am 29 December 2023 - 🇪🇸Spain albertosilva Basque Country
Hi,
Thanks for your patch, I've already merged it and will publish a new version in a couple of days.
- Status changed to Fixed
11 months ago 9:29am 29 December 2023