Hi,
I installed and enabled the Choices module against 2.x-dev on my D10 site, and confirmed the Hook help was implemented after applying MR!21. However, I got this Error message that says 'Warning: Undefined variable $output in choices_help() (line 17 of modules/contrib/choices/choices.module).' on the Choices.js help page.
Please see the attached files for reference.
I'm moving this now to ‘Needs Work’.
Thank you!
Hi @larowlan,
I reviewed the phpstan next major
and phpstan next minor
in your latest MR and confirmed that both are now fixed: https://git.drupalcode.org/issue/aggregator-3471498/-/jobs/2624198.
Running with gitlab-runner 17.3.1 (66269445)
on gitlab-runner-9dccd6855-vtfgl s8ex1X2yJ, system ID: r_Fs6duF1rd5sK
Resolving secrets
Preparing the "kubernetes" executor
00:00
"CPURequest" overwritten with "2"
Using Kubernetes namespace: gitlab-runner
Using Kubernetes executor with image drupalci/php-8.1-apache:production ...
Using attach strategy to execute scripts...
Preparing environment
00:31
Using FF_USE_POD_ACTIVE_DEADLINE_SECONDS, the Pod activeDeadlineSeconds will be set to the job timeout: 1h0m0s...
Waiting for pod gitlab-runner/runner-s8ex1x2yj-project-159040-concurrent-1-g3i5h5kh to be running, status is Pending
Running on runner-s8ex1x2yj-project-159040-concurrent-1-g3i5h5kh via gitlab-runner-9dccd6855-vtfgl...
Getting source from Git repository
00:01
Fetching changes with git depth set to 20...
Initialized empty Git repository in /builds/issue/aggregator-3471498/.git/
Created fresh repository.
Checking out f9a6e1b1 as detached HEAD (ref is 3471498-fix-fails-in)...
Skipping Git submodules setup
Downloading artifacts
00:06
Downloading artifacts for composer (next minor) (2624193)...
Downloading artifacts from coordinator... ok host=drupal-gitlab-job-artifacts.s3.us-west-2.amazonaws.com id=2624193 responseStatus=200 OK token=glcbt-64
Executing "step_script" stage of the job script
00:11
$ [[ $_CURL_TEMPLATES_REF == "" ]] && export _CURL_TEMPLATES_REF=$_GITLAB_TEMPLATES_REF # collapsed multi-line command
$ if [ -f $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME/phpstan.neon ]; then # collapsed multi-line command
Using the existing phpstan.neon configuration from the project.
$ touch $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME/phpstan-baseline.neon
$ php vendor/bin/phpstan --version
PHPStan - PHP Static Analysis Tool 1.12.0
$ php --version
PHP 8.1.29 (cli) (built: Jun 6 2024 17:38:49) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.1.29, Copyright (c) Zend Technologies
with Zend OPcache v8.1.29, Copyright (c), by Zend Technologies
$ echo "Executing php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION"
Executing php vendor/bin/phpstan analyze web/modules/custom/aggregator-3471498 --configuration=web/modules/custom/aggregator-3471498/phpstan.neon
$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --error-format=junit > junit.xml || true
0/145 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░] 0%
145/145 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress --error-format=gitlab > phpstan-quality-report.json || true
$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$?
[OK] No errors
$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress --generate-baseline --allow-empty-baseline || true # collapsed multi-line command
[OK] Baseline generated with 0 errors.
This baseline file is an artifact you can download and use in the project.
$ sed -i "s#$_WEB_ROOT/modules/custom/$CI_PROJECT_NAME/##" junit.xml phpstan-baseline.neon phpstan-quality-report.json || true
$ exit $EXIT_CODE
Uploading artifacts for successful job
00:02
Uploading artifacts...
junit.xml: found 1 matching artifact files and directories
phpstan-baseline.neon: found 1 matching artifact files and directories
phpstan-quality-report.json: found 1 matching artifact files and directories
Uploading artifacts as "archive" to coordinator... 201 Created id=2624198 responseStatus=201 Created token=glcbt-64
Uploading artifacts...
junit.xml: found 1 matching artifact files and directories
Uploading artifacts as "junit" to coordinator... 201 Created id=2624198 responseStatus=201 Created token=glcbt-64
Uploading artifacts...
phpstan-quality-report.json: found 1 matching artifact files and directories
Uploading artifacts as "codequality" to coordinator... 201 Created id=2624198 responseStatus=201 Created token=glcbt-64
Cleaning up project directory and file based variables
00:01
Job succeeded
I'm marking this now as 'RTBC'.
Thank you.
Hi,
I installed and enabled the Views Bulk Edit module against 8.x-2.x-dev on my D10 site, and confirmed the Status message is now working after applying MR!33.
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @avpaderno,
I got it. I'm marking this now as 'RBTC'.
Thank you.
Hi,
I have applied the MR!1 again and confirmed all PHPCS errors have been fixed.
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @cindytwilliams,
I installed and enabled the Views Exposed Form Fieldset module against 8.x-1.x-dev on my D10 site, and confirmed it works now after applying Patch #7.
Please see the attached files for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi,
After reviewing and applying the MR!1 to the Token Content Access module with 3.0.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
Please see below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/tca/tca.module
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/tca/modules/tca_commerce_product/tca_commerce_product.module
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views\Plugin\views\query\QueryPluginBase.
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/tca/modules/tca_node/tca_node.module
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views\Plugin\views\query\QueryPluginBase.
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/tca/src/TcaSettingsManager.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactory.
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/tca/src/FormManglerService.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
139 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/tca/src/Access/TcaAccessCheck.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Access\AccessResult.
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/tca/src/Entity/TcaSettings.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\tca\Exception\InvalidTcaSettingException.
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/tca/src/Plugin/TcaPluginManager.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Cache\CacheBackendInterface.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/tca/src/TcaPermissionGenerator.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerInjectionInterface.
-----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml tca/
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi,
I have applied the latest MR !3 from comment #14 to the Layout Builder Publish/UnPublish module with the 1.0.0 version on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml layout_builder_norender/
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi,
I have applied the latest MR !12 to the Website Services Branch Menu module with 1.0.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme y_branch_menu/
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @avpaderno,
The Gitlab CI failed to run the Jobs: https://git.drupalcode.org/issue/single_page_site-3150482/-/jobs/1066014.
Please see the attached file for reference.
I'm moving this to 'Needs work' for now.
Thank you.
Hi,
I have applied the latest MR !2 to the Editor Mailto Link module with 1.0.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml editor_mailto_link
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @kellyjacobs,
After reviewing and applying the MR!4 to the Smart Content CDN module with 1.0.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
Please see below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/smart_content_cdn/js/interest_count.js
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
59 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/smart_content_cdn/tests/src/Unit/VaryTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerBuilder.
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/smart_content_cdn/tests/src/Unit/EvaluationTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\smart_content_block\Plugin\smart_content\Decision\MultipleBlockDecision.
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/smart_content_cdn/src/Form/SmartContentCDNConfigForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Ajax\AjaxResponse.
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/smart_content_cdn/src/EventSubscriber/SmartCDNCookie.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpFoundation\Cookie.
-----------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/smart_content_cdn/src/EventSubscriber/HeaderEventSubscriber.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpKernel\Event\ResponseEvent.
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal smart_content_cdn/
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @avpaderno,
I'm still seeing 1 PHPCS warning in the GitLab CI PHP_CodeSniffer: https://git.drupalcode.org/issue/globallink-3344157/-/jobs/2507007.
FILE: ...loballink-3344157/web/modules/custom/globallink-3344157/globallink.install
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 85 characters
| | (Drupal.Files.LineLength.TooLong)
--------------------------------------------------------------------------------
Time: 238ms; Memory: 8MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE ERRORS WARNINGS
--------------------------------------------------------------------------------
...57/web/modules/custom/globallink-3344157/globallink.install 0 1
--------------------------------------------------------------------------------
A TOTAL OF 0 ERRORS AND 1 WARNING WERE FOUND IN 6 FILES
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
----------------------------------------------------------------------
SOURCE COUNT
----------------------------------------------------------------------
Drupal.Files.LineLength.TooLong 1
----------------------------------------------------------------------
A TOTAL OF 1 SNIFF VIOLATION WERE FOUND IN 1 SOURCE
----------------------------------------------------------------------
I'm moving this to ‘Needs work’ for your review.
Thank you!
Hi @avpaderno,
Confirmed PHPCS errors no longer exist: https://git.drupalcode.org/issue/menu_trail_by_path-3371317/-/jobs/2505527.
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @avpaderno,
Confirmed PHPCS errors no longer exist: https://git.drupalcode.org/issue/fortytwo_admin-3285448/-/jobs/2505378.
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @avpaderno,
After reviewing and applying your latest commits to MR!1 for the FortyTwo - Administration theme against 8.x-1.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/css/fortytwo_admin.css
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/plugins/window-size.js
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/transit.js
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/enquire.js
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/polyfills/placeholder.js
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
59 | ERROR | [x] Opening brace must be the last content on the line
71 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------
I ran this command on the theme:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js fortytwo_admin/
I'm moving this to ‘Needs work’ again.
Thank you!
Hi @avpaderno,
Confirmed all PHPCS errors have been fixed already.
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @pooja_sharma,
I installed and enabled the Tour module with 2.0.x-dev on my Drupal 10 site. After reviewing and applying your MR!17, it seems the MR is currently not working on the Admin menu pages, particularly the Structure > Menu page.
Please see the attached file for reference.
I'm moving this to 'Needs work' for now.
Thank you.
Hi @avpaderno,
After reviewing and applied the MR!1, I still see 1 PHPCS warning.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/data_hover_filter/data_hover_filter.info.yml
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------------------------
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @avpaderno,
I got these errors below when applying MR!3 by using the plain diff
to the GlobalLink Connect for Drupal module against 8.x-2.x-dev on my Drupal 10 site.
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 37882 0 37882 0 0 92760 0 --:--:-- --:--:-- --:--:-- 94000
Checking patch .gitlab-ci.yml...
Checking patch composer.json...
error: while searching for:
"source": "https://www.drupal.org/project/globallink"
},
"require": {
"drupal/core": "~8.1",
"drupal/tmgmt": "~1.4",
"translations-com/globallink-connect-api-php": "4.18.4"
}
}
error: patch failed: composer.json:11
error: composer.json: patch does not apply
Checking patch config/schema/globallink.schema.yml...
error: while searching for:
label: Submission name Prefix
pd_notify_emails:
type: string
label: Space separated list of emails to notify
pd_combine:
type: string
label: Combine all items into a single document
error: patch failed: config/schema/globallink.schema.yml:18
error: config/schema/globallink.schema.yml: patch does not apply
Checking patch globallink.info.yml...
error: while searching for:
- tmgmt:tmgmt
- tmgmt:tmgmt_file
type: module
# Information added by Drupal.org packaging script on 2019-07-22
version: '8.x-2.0-rc1'
core: '8.x'
project: 'globallink'
datestamp: 1563812593
error: patch failed: globallink.info.yml:7
error: globallink.info.yml: patch does not apply
Checking patch globallink.install...
Checking patch globallink.module...
error: while searching for:
<?php
use Drupal\tmgmt\Entity\Job;
/**
* Implements hook_theme().
error: patch failed: globallink.module:1
error: globallink.module: patch does not apply
Checking patch globallink.services.yml...
Checking patch src/EventSubscriber/GloballinkContinuousEvents.php...
Checking patch src/GlExchangeAdapter.php...
error: while searching for:
<?php
namespace Drupal\globallink;
use Drupal\Core\Entity\EntityTypeManagerInterface;
use Drupal\Core\Extension\ModuleHandlerInterface;
error: patch failed: src/GlExchangeAdapter.php:1
error: src/GlExchangeAdapter.php: patch does not apply
Checking patch src/GlobalLinkTranslatorUi.php...
error: while searching for:
'#type' => 'textfield',
'#title' => t('Emails for notification'),
'#default_value' => $translator->getSetting('pd_notify_emails'),
'#description' => t('A space separated list of emails to notify. Leave blank for no notifications'),
];
$form['pd_combine'] = [
'#type' => 'checkbox',
error: patch failed: src/GlobalLinkTranslatorUi.php:88
error: src/GlobalLinkTranslatorUi.php: patch does not apply
Checking patch src/Plugin/tmgmt/Translator/GlobalLinkTranslator.php...
Hunk #1 succeeded at 8 (offset 1 line).
Hunk #2 succeeded at 36 (offset 1 line).
Hunk #3 succeeded at 48 (offset 1 line).
error: while searching for:
'ar-DZ' => 'Arabic, Algeria',
'ar-EG' => 'Arabic, Egypt',
'ar-IQ' => 'Arabic, Iraq',
'ar-JO' => 'Arabic, Jordan',
'ar-KW' => 'Arabic, Kuwait',
'ar-LB' => 'Arabic, Lebanon',
error: patch failed: src/Plugin/tmgmt/Translator/GlobalLinkTranslator.php:129
error: src/Plugin/tmgmt/Translator/GlobalLinkTranslator.php: patch does not apply
I'm moving this to ‘Needs work’ for your review.
Thank you!
Hi @avpaderno,
After reviewing and applied the MR!10 to the Weight module against 7.x-3.x-dev on Drupal 10, I still see 1 PHPCS warning.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/weight/views/views_handler_weight_selector.inc
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
8 | WARNING | Class name must be prefixed with the project name "Weight"
-------------------------------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js weight/
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @batigolix,
After reviewing and applied the MR!1 to the FortyTwo - Administration theme against 8.x-1.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/includes/bootstrap.inc
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
13 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Link.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/css/fortytwo_admin.css
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/plugins/window-size.js
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/transit.js
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/enquire.js
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/fortytwo_admin/static/js/lib/polyfills/placeholder.js
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------
59 | ERROR | [x] Opening brace must be the last content on the line
71 | ERROR | [x] Opening brace must be the last content on the line
--------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------
I ran this command on the theme:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js fortytwo_admin/
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @vipin.mittal18,
I have reviewed the changes and confirmed that Patch #2 was applied cleanly to the Data-hover Filter module against 8.x-1.1 on Drupal 10, and all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js data_hover_filter/
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @realsp,
After reviewing and applied the MR!3 to the Backup and Migrate: BackBeaver module against 2.0.0-beta2 on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/backup_migrate_backbeaver/README.md
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------
25 | WARNING | Line exceeds 80 characters; contains 254 characters
26 | WARNING | Line exceeds 80 characters; contains 122 characters
27 | WARNING | Line exceeds 80 characters; contains 112 characters
28 | WARNING | Line exceeds 80 characters; contains 376 characters
--------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/backup_migrate_backbeaver/src/Destination/BackBeaverDestination.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
81 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/backup_migrate_backbeaver/src/BackBeaverClient.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------
46 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 6
47 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 6
166 | WARNING | [ ] Unused variable $responseBodyAsString.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js backup_migrate_backbeaver/
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @realsp,
After reviewing and applied the MR!1 to the Chat AI module against 1.0.0-alpha on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/chat_ai/src/Form/SettingsForm.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
46 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/chat_ai/src/Form/ChatBlockForm.php
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
70 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/chat_ai/src/Form/EmbeddingsForm.php
--------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------
90 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
91 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/chat_ai/src/Embeddings.php
-----------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------
137 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
138 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/chat_ai/src/Supabase.php
---------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------
97 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
246 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/chat_ai/src/ChatAI.php
---------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------
102 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
103 | ERROR | [x] Multi-line function declaration not indented correctly; expected 2 spaces but found 4
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js chat_ai/
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @realsp,
After reviewing MR!5 and applied to the Google Text to Speech module against 8.x-2.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
Please see the attached file for reference.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js google_text_to_speech
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @viren18febS,
After applying your Patch #14 to the Required Content module against 1.0.x-dev on Drupal 10, I still see a 1 PHPCS error.
Please see the attached file for reference.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js required_content/
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @hardikpandya,
I installed and enabled the Draggable Dashboard module with 8.x-2.x-dev version on my D10 site, created Dashboard entities, added them to pages, and confirmed that no errors were shown in the devtool Console panel after applying MR!2.
Please see the attached files for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @sahil.goyal,
After applying MR!3 on the YamlElement module against the 8.x-1.x-dev version on my Drupal 10 site, confirmed the README.md is now present.
However, I have only 2 concerns:
* Remove the following from the TOC
* Installation
* Configuration
* Important
* Maintainers
* Remove the ':' from the ## Configuration:
heading
Please refer to this template: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
Please see the attached files for reference.
I'm moving this to 'Needs work' for now.
Thank you.
Hi @Shanmuganathi,
Upon reviewing your README.md file in #3, below are my suggestions:
* Missing Requirements heading which is required.
* Missing Installation heading which is required.
* Missing Configuration heading which is required.
* Change ## Contact
heading to ## Maintainers
For more information, please refer to this template: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → .
I'm moving this to 'Needs work' for now.
Thank you.
Hi @Anishnirmal,
Upon reviewing your README.md file in #6, below are my suggestions:
* Missing Installation heading which is required.
* Missing Configuration heading which is required.
* For this one Not working for you? See [Troubleshooting Git clone](https://www.drupal.org/node/1065850). Once it works, you need the [Git deploy](https://www.drupal.org/project/git_deploy) module. See [Versioned dependencies and Git](https://www.drupal.org/node/1314752) for an explanation.
, it should be under the ## Troubleshooting heading.
* I saw some special characters from the following:
- ✓Recommended by the project’s maintainer.
- ### When you’re done: Reverting uncommited changes
For more information, please refer to this template: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... →
I'm moving this to 'Needs work' for now.
Thank you.
Hi @Sandeep Sanwale,
After applying MR!1 on the ApacheSolr Workbench Moderation module against the 7.x-1.1 version on my Drupal 10 site, confirmed the README.md is now present.
However, I have some concerns:
* The README file should append a file type '.md' or '.text', e.g. README.md
* Requirements - It's better to add a link to each module e.g. [Installing Drupal Modules]( https://www.drupal.org/docs/extending-drupal/installing-drupal-modules → ).
* Recommended Modules - It's better to add a link to each module e.g. [Installing Drupal Modules]( https://www.drupal.org/docs/extending-drupal/installing-drupal-modules → ).
* Installation - Ordered lists use "1", for easier updates and to avoid errors.
* Configuration - Ordered lists use "1", for easier updates and to avoid errors.
* Troubleshooting & FAQ - It should be 'FAQ' heading only.
Please refer to this template: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → .
Please see the attached files for reference.
I'm moving this to 'Needs work' for now.
Thank you.
Hi @Shanmuganathi,
After applying MR!3 on the Opigno dashboard module against 3.1.0 version on my Drupal 10 site, confirmed the README.md is now present.
However, I have one concern:
* Missing the Configuration section.
Based on this template: https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → , the 'Configuration' is required.
Please see the attached files for reference.
I'm moving this to 'Needs work' for now.
Thank you.
Hi @bhaveshads,
I have applied the latest MR !14 again to the Varbase Components module against 2.0.x-dev on my D10 local, and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig varbase_components/
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @sidharth_soman,
I have applied the latest MR!1 to the Seeds Security module against 1.0.0 on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig seeds_security
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @sidharth_soman,
I have applied the latest MR !2 to the Admin Toolbar Mediteran module against 8.x-1.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig admin_toolbar_mediteran/
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @neel24,
Your patch#10 is not working on the 'Social Auth PayPal' module against 8.x-2.x-dev on my D10 site.
I ran this command on the module:
curl https://www.drupal.org/files/issues/2020-01-29/social_auth_paypal-fix-coding-standards-3101051-10.patch | git apply -v
Please see the attached file for reference.
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @DamienMcKenna,
After applying your Patch #5 to the EVA: Entity Views Attachment module against 7.x-1.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/eva/eva.module
---------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AND 1 WARNING AFFECTING 9 LINES
---------------------------------------------------------------------------------------------------
69 | ERROR | [x] list(...) is forbidden, use [...] instead.
97 | ERROR | [x] list(...) is forbidden, use [...] instead.
161 | ERROR | [x] list(...) is forbidden, use [...] instead.
168 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
221 | ERROR | [x] list(...) is forbidden, use [...] instead.
242 | ERROR | [x] Use null coalesce operator instead of ternary operator.
245 | ERROR | [x] Use null coalesce operator instead of ternary operator.
258 | ERROR | [ ] Parameter tags must be defined first in a doc comment
305 | WARNING | [x] '@todo: security?' should match the format '@todo Fix problem X here.'
---------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/eva/eva_plugin_display_entity.inc
------------------------------------------------------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 8 LINES
------------------------------------------------------------------------------------------------------------------
11 | ERROR | [ ] Class name must begin with a capital letter
11 | ERROR | [ ] Class name must use UpperCamel naming without underscores
16 | ERROR | [x] Visibility must be declared on method "option_definition"
16 | ERROR | [ ] Method name "eva_plugin_display_entity::option_definition" is not in lowerCamel format
33 | ERROR | [x] Visibility must be declared on method "options_summary"
33 | ERROR | [ ] Method name "eva_plugin_display_entity::options_summary" is not in lowerCamel format
102 | ERROR | [x] Visibility must be declared on method "options_form"
102 | ERROR | [ ] Method name "eva_plugin_display_entity::options_form" is not in lowerCamel format
224 | ERROR | [x] Visibility must be declared on method "options_submit"
224 | ERROR | [ ] Method name "eva_plugin_display_entity::options_submit" is not in lowerCamel format
280 | ERROR | [x] Visibility must be declared on method "validate"
293 | ERROR | [x] Visibility must be declared on method "get_path"
293 | ERROR | [ ] Method name "eva_plugin_display_entity::get_path" is not in lowerCamel format
310 | ERROR | [x] Visibility must be declared on method "execute"
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/eva/eva-display-entity-view.tpl.php
--------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
24 | ERROR | [x] Doc comment long description must end with a full stop
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml eva/
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @ankitv18,
Thank you for responding! I saw that all the PHPCS issues have been resolved here: https://git.drupalcode.org/issue/social_media_links-3315142/-/pipelines/....
I'm moving this now to 'RTBC'.
Thank you!
Hi @sandipta,
I installed and enabled the Redirect module against 8.x-1.x-dev on my D10 site including the Redirect 404, and confirmed the 404 Referrers view is now available and working after applying MR!101.
Please see the attached files for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @sourabhsisodia,
I installed and enabled the Theme; however, when I add a second-level menu and enable 'Show as expanded' in the First-level menu display settings, the 'Show as expanded' feature does not work. Additionally, I have also applied the MR!1.
Please refer to the video attached.
I'm moving this to 'Needs work' for now.
Thank you.
Hi @avpaderno,
I have applied the latest MR!3 again to the Content syncer module against 8.x-2.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @ankitv18,
I am moving this to 'Needs work', please check the PHPCS issues below after applying the 'MR !39' to the Social Media Links Block and Field module against 8.x-2.x-dev on my D10 local.
See below:
FILE: ...roject/DrupalOrg/drupalorgissues/web/modules/contrib/social_media_links/modules/social_media_links_field/src/Plugin/Field/FieldWidget/SocialMediaLinksFieldBaseWidget.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
36 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: ...upalOrg/drupalorgissues/web/modules/contrib/social_media_links/modules/social_media_links_field/src/Plugin/Field/FieldFormatter/SocialMediaLinksFieldDefaultFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
218 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
231 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/social_media_links/src/IconsetFinderService.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------------------
72 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
74 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
89 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig social_media_links
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @apaderno,
After applying the MR!3 to the Content syncer module against 8.x-2.x-dev on Drupal 10, I still see 1 PHPCS warning.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/syncer/src/Controller/Export.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
10 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig syncer
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @apdermo,
I have applied the latest MR !4 to the Countries Field module against 8.x-1.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig countries_field
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @Snehal Brahmbhatt,
After applying your Patch #3 to the Alternative Character module on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/drupalion-1841838/alternative_character.info
-----------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
1 | ERROR | "name" property is missing in the info file
1 | ERROR | "description" property is missing in the info file
1 | ERROR | "core" property is missing in the info file
-----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/drupalion-1841838/alternative_character.module
----------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 116 ERRORS AND 2 WARNINGS AFFECTING 45 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [ ] File contains UTF-8 byte order mark, which may corrupt your application
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
5 | ERROR | [x] Doc comment short description must start with a capital letter
7 | WARNING | [ ] @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
9 | ERROR | [x] There must be exactly one blank line after the file comment
10 | ERROR | [x] Missing function doc comment
11 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
14 | ERROR | [x] Missing function doc comment
15 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
15 | ERROR | [x] Space found before square bracket; expected "where[" but found "where ["
15 | ERROR | [x] Space found before square bracket; expected "][" but found "] ["
16 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
17 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
18 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
18 | ERROR | [x] Space before opening parenthesis of function call prohibited
18 | ERROR | [x] There should be no white space after an opening "("
18 | ERROR | [x] There should be no white space before a closing ")"
19 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
19 | ERROR | [x] Space found before square bracket; expected "where[" but found "where ["
19 | ERROR | [x] Space found before square bracket; expected "][" but found "] ["
22 | ERROR | [x] Missing function doc comment
23 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
24 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
24 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
25 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
26 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
27 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
27 | ERROR | [x] Space before opening parenthesis of function call prohibited
27 | ERROR | [x] There should be no white space after an opening "("
27 | ERROR | [x] There should be no white space before a closing ")"
30 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "convert_to_persian_char" but expected
| | "alternative_character_convert_to_persian_char"
30 | ERROR | [x] Missing function doc comment
31 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
31 | ERROR | [x] A unary operator statement must not be followed by a space
31 | ERROR | [x] Space before opening parenthesis of function call prohibited
31 | ERROR | [x] There should be no white space after an opening "("
31 | ERROR | [x] There should be no white space before a closing ")"
32 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
32 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
32 | ERROR | [x] There should be no white space after an opening "("
32 | WARNING | [ ] Unused variable $key1.
32 | ERROR | [x] There should be no white space before a closing ")"
33 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
33 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
33 | ERROR | [x] Space before opening parenthesis of function call prohibited
33 | ERROR | [x] There should be no white space after an opening "("
33 | ERROR | [x] There should be no white space before a closing ")"
34 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
34 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
35 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
35 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
35 | ERROR | [x] Space before opening parenthesis of function call prohibited
35 | ERROR | [x] There should be no white space after an opening "("
35 | ERROR | [x] There should be no white space before a closing ")"
36 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
36 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
36 | ERROR | [x] Whitespace found at end of line
37 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
37 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
37 | ERROR | [x] Use "elseif" in place of "else if"
38 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
38 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 4
38 | ERROR | [x] Space before opening parenthesis of function call prohibited
38 | ERROR | [x] There should be no white space after an opening "("
38 | ERROR | [x] There should be no white space before a closing ")"
39 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
39 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 3
40 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
40 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2
41 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
42 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
44 | ERROR | [x] Closing brace indented incorrectly; expected 1 spaces, found 2
47 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "replace_char" but expected
| | "alternative_character_replace_char"
47 | ERROR | [x] Missing function doc comment
48 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
48 | ERROR | [x] No space found before comment text; expected "// dvm(($string));" but found "//dvm(($string));"
48 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
49 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
49 | ERROR | [x] There must be no space between the "array" keyword and the opening parenthesis
49 | ERROR | [x] There should be no white space before a closing ")"
50 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
50 | ERROR | [x] There must be no space between the "array" keyword and the opening parenthesis
50 | ERROR | [x] There should be no white space before a closing ")"
51 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
52 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
52 | ERROR | [x] Space before opening parenthesis of function call prohibited
52 | ERROR | [x] There should be no white space after an opening "("
52 | ERROR | [x] There should be no white space before a closing ")"
53 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
53 | ERROR | [x] No space found before comment text; expected "// dvm($result);" but found "//dvm($result);"
54 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
55 | ERROR | [x] Expected 1 newline at end of file; 9 found
57 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
57 | ERROR | [x] Whitespace found at end of line
61 | ERROR | [ ] More than 2 empty lines are not allowed
62 | ERROR | [ ] More than 2 empty lines are not allowed
63 | ERROR | [ ] More than 2 empty lines are not allowed
----------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 110 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 76ms; Memory: 10MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml drupalion-1841838/
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @annopsingh29
After applying your Patch #5 to the Material Admin module against 8.x-1.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
See below:
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5456 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5460 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5462 | ERROR | [x] Multiple selectors should each be on a single line
5659 | ERROR | [ ] Class definition is empty
5672 | ERROR | [x] Multiple selectors should each be on a single line
5738 | ERROR | [x] Multiple selectors should each be on a single line
5741 | ERROR | [x] Multiple selectors should each be on a single line
5751 | ERROR | [x] Multiple selectors should each be on a single line
5760 | ERROR | [x] Multiple selectors should each be on a single line
5768 | ERROR | [x] Multiple selectors should each be on a single line
5780 | ERROR | [x] Multiple selectors should each be on a single line
5788 | ERROR | [x] Multiple selectors should each be on a single line
5793 | ERROR | [x] Multiple selectors should each be on a single line
5798 | ERROR | [x] Multiple selectors should each be on a single line
5802 | ERROR | [x] Multiple selectors should each be on a single line
5806 | ERROR | [x] Multiple selectors should each be on a single line
5809 | ERROR | [x] Multiple selectors should each be on a single line
5834 | ERROR | [x] Multiple selectors should each be on a single line
5854 | ERROR | [x] Multiple selectors should each be on a single line
5932 | ERROR | [x] Multiple selectors should each be on a single line
5973 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6046 | ERROR | [x] Multiple selectors should each be on a single line
6270 | ERROR | [x] Multiple selectors should each be on a single line
6270 | ERROR | [x] Multiple selectors should each be on a single line
6321 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
6342 | ERROR | [x] Multiple selectors should each be on a single line
6342 | ERROR | [x] Multiple selectors should each be on a single line
6352 | ERROR | [x] Multiple selectors should each be on a single line
6372 | ERROR | [x] Multiple selectors should each be on a single line
6372 | ERROR | [x] Multiple selectors should each be on a single line
6372 | ERROR | [x] Multiple selectors should each be on a single line
6372 | ERROR | [x] Multiple selectors should each be on a single line
6372 | ERROR | [x] Multiple selectors should each be on a single line
6397 | ERROR | [x] Multiple selectors should each be on a single line
6397 | ERROR | [x] Multiple selectors should each be on a single line
6397 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6414 | ERROR | [x] Multiple selectors should each be on a single line
6576 | ERROR | [x] Multiple selectors should each be on a single line
6576 | ERROR | [x] Multiple selectors should each be on a single line
6579 | ERROR | [x] Multiple selectors should each be on a single line
6579 | ERROR | [x] Multiple selectors should each be on a single line
6583 | ERROR | [x] Multiple selectors should each be on a single line
6583 | ERROR | [x] Multiple selectors should each be on a single line
6586 | ERROR | [x] Multiple selectors should each be on a single line
6586 | ERROR | [x] Multiple selectors should each be on a single line
6590 | ERROR | [x] Multiple selectors should each be on a single line
6590 | ERROR | [x] Multiple selectors should each be on a single line
6590 | ERROR | [x] Multiple selectors should each be on a single line
6590 | ERROR | [x] Multiple selectors should each be on a single line
6590 | ERROR | [x] Multiple selectors should each be on a single line
6590 | ERROR | [x] Multiple selectors should each be on a single line
6590 | ERROR | [x] Multiple selectors should each be on a single line
6590 | ERROR | [x] Multiple selectors should each be on a single line
6608 | ERROR | [x] Multiple selectors should each be on a single line
6608 | ERROR | [x] Multiple selectors should each be on a single line
6613 | ERROR | [x] Multiple selectors should each be on a single line
6613 | ERROR | [x] Multiple selectors should each be on a single line
6633 | ERROR | [x] Multiple selectors should each be on a single line
6633 | ERROR | [x] Multiple selectors should each be on a single line
6677 | ERROR | [x] Multiple selectors should each be on a single line
6677 | ERROR | [x] Multiple selectors should each be on a single line
6683 | ERROR | [x] Multiple selectors should each be on a single line
6683 | ERROR | [x] Multiple selectors should each be on a single line
6686 | ERROR | [x] Multiple selectors should each be on a single line
6686 | ERROR | [x] Multiple selectors should each be on a single line
6692 | ERROR | [x] Multiple selectors should each be on a single line
6692 | ERROR | [x] Multiple selectors should each be on a single line
6898 | ERROR | [x] CSS colours must be defined in lowercase; expected #e3f2fd but found #E3F2FD
6966 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
6972 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
7028 | ERROR | [x] Multiple selectors should each be on a single line
7319 | ERROR | [x] Multiple selectors should each be on a single line
7319 | ERROR | [x] Multiple selectors should each be on a single line
7347 | ERROR | [x] Multiple selectors should each be on a single line
7347 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7763 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7765 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7766 | ERROR | [x] Multiple selectors should each be on a single line
7780 | ERROR | [ ] Style definitions must end with a semicolon
7804 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
7816 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
7824 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7855 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7857 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7858 | ERROR | [x] Multiple selectors should each be on a single line
7892 | ERROR | [x] Multiple selectors should each be on a single line
7908 | ERROR | [ ] Class definition is empty
7917 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
7921 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
7935 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
7940 | ERROR | [ ] Class definition is empty
7948 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
7949 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
7950 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
7955 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
8005 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8028 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8032 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8034 | ERROR | [x] Multiple selectors should each be on a single line
8150 | ERROR | [x] CSS colours must be defined in lowercase; expected #e53935 but found #E53935
8154 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffcdd2 but found #FFCDD2
8157 | ERROR | [x] Multiple selectors should each be on a single line
8157 | ERROR | [x] Multiple selectors should each be on a single line
8159 | ERROR | [x] CSS colours must be defined in lowercase; expected #e53935 but found #E53935
8175 | ERROR | [x] Multiple selectors should each be on a single line
8176 | ERROR | [x] CSS colours must be defined in lowercase; expected #388e3c but found #388E3C
8180 | ERROR | [x] CSS colours must be defined in lowercase; expected #c8e6c9 but found #C8E6C9
8185 | ERROR | [x] CSS colours must be defined in lowercase; expected #4caf50 but found #4CAF50
8190 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
8200 | ERROR | [x] Multiple selectors should each be on a single line
8200 | ERROR | [x] Multiple selectors should each be on a single line
8204 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8208 | ERROR | [x] Multiple selectors should each be on a single line
8216 | ERROR | [x] Multiple selectors should each be on a single line
8216 | ERROR | [x] Multiple selectors should each be on a single line
8216 | ERROR | [x] Multiple selectors should each be on a single line
8216 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8220 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8229 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8255 | ERROR | [x] Multiple selectors should each be on a single line
8292 | ERROR | [x] Multiple selectors should each be on a single line
8295 | ERROR | [x] Multiple selectors should each be on a single line
8301 | ERROR | [x] Multiple selectors should each be on a single line
8309 | ERROR | [x] Multiple selectors should each be on a single line
8324 | ERROR | [x] Multiple selectors should each be on a single line
8324 | ERROR | [x] Multiple selectors should each be on a single line
8328 | ERROR | [x] Multiple selectors should each be on a single line
8331 | ERROR | [x] Multiple selectors should each be on a single line
8331 | ERROR | [x] Multiple selectors should each be on a single line
8331 | ERROR | [x] Multiple selectors should each be on a single line
8331 | ERROR | [x] Multiple selectors should each be on a single line
8334 | ERROR | [x] Multiple selectors should each be on a single line
8334 | ERROR | [x] Multiple selectors should each be on a single line
8334 | ERROR | [x] Multiple selectors should each be on a single line
8334 | ERROR | [x] Multiple selectors should each be on a single line
8353 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
8415 | ERROR | [x] CSS colours must be defined in lowercase; expected #1e88e5 but found #1E88E5
8420 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
8452 | ERROR | [x] CSS colours must be defined in lowercase; expected #42a5f5 but found #42A5F5
8596 | ERROR | [x] Multiple selectors should each be on a single line
8652 | ERROR | [x] CSS colours must be defined in lowercase; expected #2196f3 but found #2196F3
8686 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
8931 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
8945 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef9a9a but found #EF9A9A
8948 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef9a9a but found #EF9A9A
8951 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef9a9a but found #EF9A9A
9000 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
9014 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef9a9a but found #EF9A9A
9017 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef9a9a but found #EF9A9A
9020 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef9a9a but found #EF9A9A
9086 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
9127 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
9199 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
9204 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
9208 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
9212 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
9216 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
9225 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
9231 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
9254 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef9a9a but found #EF9A9A
9257 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef9a9a but found #EF9A9A
9264 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef9a9a but found #EF9A9A
10104 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
10107 | ERROR | [x] CSS colours must be defined in lowercase; expected #42a5f5 but found #42A5F5
10211 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
10229 | ERROR | [x] Multiple selectors should each be on a single line
10229 | ERROR | [x] Multiple selectors should each be on a single line
10235 | ERROR | [x] Multiple selectors should each be on a single line
10235 | ERROR | [x] Multiple selectors should each be on a single line
10236 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
10252 | ERROR | [x] CSS colours must be defined in lowercase; expected #bbdefb but found #BBDEFB
10263 | ERROR | [x] CSS colours must be defined in lowercase; expected #bbdefb but found #BBDEFB
10270 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
10290 | ERROR | [x] CSS colours must be defined in lowercase; expected #bbdefb but found #BBDEFB
10298 | ERROR | [x] Multiple selectors should each be on a single line
10363 | ERROR | [x] Multiple selectors should each be on a single line
10364 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
10404 | ERROR | [x] Multiple selectors should each be on a single line
10404 | ERROR | [x] Multiple selectors should each be on a single line
10408 | ERROR | [x] Multiple selectors should each be on a single line
10408 | ERROR | [x] Multiple selectors should each be on a single line
10658 | ERROR | [x] CSS colours must be defined in lowercase; expected #f44336 but found #F44336
10706 | ERROR | [x] CSS colours must be defined in lowercase; expected #e53935 but found #E53935
10708 | ERROR | [x] Multiple selectors should each be on a single line
10708 | ERROR | [x] Multiple selectors should each be on a single line
10708 | ERROR | [x] Multiple selectors should each be on a single line
10708 | ERROR | [x] Multiple selectors should each be on a single line
10708 | ERROR | [x] Multiple selectors should each be on a single line
10708 | ERROR | [x] Multiple selectors should each be on a single line
10712 | ERROR | [x] Multiple selectors should each be on a single line
10712 | ERROR | [x] Multiple selectors should each be on a single line
10712 | ERROR | [x] Multiple selectors should each be on a single line
10712 | ERROR | [x] Multiple selectors should each be on a single line
10712 | ERROR | [x] Multiple selectors should each be on a single line
10712 | ERROR | [x] Multiple selectors should each be on a single line
10774 | ERROR | [x] Multiple selectors should each be on a single line
10803 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10886 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10888 | ERROR | [x] Multiple selectors should each be on a single line
10998 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11024 | ERROR | [x] CSS colours must be defined in lowercase; expected #2196f3 but found #2196F3
11028 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11046 | ERROR | [x] CSS colours must be defined in lowercase; expected #2196f3 but found #2196F3
11105 | ERROR | [x] Multiple selectors should each be on a single line
11105 | ERROR | [x] Multiple selectors should each be on a single line
11115 | ERROR | [x] Multiple selectors should each be on a single line
11115 | ERROR | [x] Multiple selectors should each be on a single line
11118 | ERROR | [x] Multiple selectors should each be on a single line
11118 | ERROR | [x] Multiple selectors should each be on a single line
11194 | ERROR | [x] CSS colours must be defined in lowercase; expected #2196f3 but found #2196F3
11195 | ERROR | [x] CSS colours must be defined in lowercase; expected #2196f3 but found #2196F3
11209 | ERROR | [x] Multiple selectors should each be on a single line
11209 | ERROR | [x] Multiple selectors should each be on a single line
11211 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11216 | ERROR | [x] Multiple selectors should each be on a single line
11216 | ERROR | [x] Multiple selectors should each be on a single line
11217 | ERROR | [x] CSS colours must be defined in lowercase; expected #e53935 but found #E53935
11218 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11223 | ERROR | [x] Multiple selectors should each be on a single line
11223 | ERROR | [x] Multiple selectors should each be on a single line
11224 | ERROR | [x] CSS colours must be defined in lowercase; expected #4caf50 but found #4CAF50
11225 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11242 | ERROR | [x] CSS colours must be defined in lowercase; expected #4caf50 but found #4CAF50
11246 | ERROR | [x] CSS colours must be defined in lowercase; expected #4caf50 but found #4CAF50
11258 | ERROR | [x] CSS colours must be defined in lowercase; expected #e53935 but found #E53935
11262 | ERROR | [x] CSS colours must be defined in lowercase; expected #e53935 but found #E53935
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11290 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11292 | ERROR | [x] Multiple selectors should each be on a single line
11293 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11300 | ERROR | [x] Multiple selectors should each be on a single line
11309 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11313 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11315 | ERROR | [x] Multiple selectors should each be on a single line
11335 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11359 | ERROR | [x] CSS colours must be defined in lowercase; expected #1e88e5 but found #1E88E5
11422 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11481 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11484 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11531 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
11791 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
12132 | ERROR | [x] CSS colours must be defined in lowercase; expected #2196f3 but found #2196F3
12141 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
12160 | ERROR | [x] Multiple selectors should each be on a single line
12178 | ERROR | [x] CSS colours must be defined in lowercase; expected #2196f3 but found #2196F3
12180 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
12326 | ERROR | [x] Multiple selectors should each be on a single line
12326 | ERROR | [x] Multiple selectors should each be on a single line
12329 | ERROR | [x] Multiple selectors should each be on a single line
12329 | ERROR | [x] Multiple selectors should each be on a single line
12356 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
12366 | ERROR | [x] Multiple selectors should each be on a single line
12366 | ERROR | [x] Multiple selectors should each be on a single line
12368 | ERROR | [x] CSS colours must be defined in lowercase; expected #388e3c but found #388E3C
12372 | ERROR | [x] Multiple selectors should each be on a single line
12372 | ERROR | [x] Multiple selectors should each be on a single line
12384 | ERROR | [x] Multiple selectors should each be on a single line
12384 | ERROR | [x] Multiple selectors should each be on a single line
12386 | ERROR | [x] CSS colours must be defined in lowercase; expected #e53935 but found #E53935
12390 | ERROR | [x] CSS colours must be defined in lowercase; expected #e53935 but found #E53935
12415 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef5350 but found #EF5350
12418 | ERROR | [x] CSS colours must be defined in lowercase; expected #ef5350 but found #EF5350
12432 | ERROR | [x] CSS colours must be defined in lowercase; expected #ffffff but found #FFFFFF
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3317 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/material_admin/README.md
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 111 characters
14 | WARNING | Line exceeds 80 characters; contains 135 characters
22 | WARNING | Line exceeds 80 characters; contains 306 characters
51 | WARNING | Line exceeds 80 characters; contains 116 characters
59 | WARNING | Line exceeds 80 characters; contains 109 characters
62 | WARNING | Line exceeds 80 characters; contains 100 characters
---------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/material_admin/material_admin.info.yml
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/material_admin/theme-settings.php
------------------------------------------------------------------------------------------------------------------
FOUND 50 ERRORS AND 2 WARNINGS AFFECTING 44 LINES
------------------------------------------------------------------------------------------------------------------
11 | WARNING | [ ] Hook implementations should not duplicate @param documentation
11 | ERROR | [ ] Missing parameter type
13 | WARNING | [ ] Hook implementations should not duplicate @param documentation
13 | ERROR | [ ] Missing parameter type
17 | ERROR | [x] Short array syntax must be used to define arrays
24 | ERROR | [x] Short array syntax must be used to define arrays
31 | ERROR | [x] Short array syntax must be used to define arrays
38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
38 | ERROR | [x] Short array syntax must be used to define arrays
39 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
40 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
41 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
42 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
43 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 2
45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
45 | ERROR | [x] Short array syntax must be used to define arrays
46 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
47 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
48 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
49 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
50 | ERROR | [x] Array closing indentation error, expected 3 spaces but found 2
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Short array syntax must be used to define arrays
53 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
54 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
55 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
56 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
57 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 2
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
59 | ERROR | [x] Short array syntax must be used to define arrays
60 | ERROR | [x] Array indentation error, expected 3 spaces but found 4
61 | ERROR | [x] Array indentation error, expected 3 spaces but found 4
62 | ERROR | [x] Array indentation error, expected 3 spaces but found 4
63 | ERROR | [x] Array indentation error, expected 3 spaces but found 4
64 | ERROR | [x] Array closing indentation error, expected 1 spaces but found 2
66 | ERROR | [x] Short array syntax must be used to define arrays
72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
72 | ERROR | [x] Short array syntax must be used to define arrays
73 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
74 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
75 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
76 | ERROR | [x] Array indentation error, expected 6 spaces but found 4
77 | ERROR | [x] Array closing indentation error, expected 4 spaces but found 2
79 | ERROR | [x] Short array syntax must be used to define arrays
86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
86 | ERROR | [x] Short array syntax must be used to define arrays
87 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
88 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
89 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
90 | ERROR | [x] Array indentation error, expected 5 spaces but found 4
91 | ERROR | [x] Array closing indentation error, expected 3 spaces but found 2
93 | ERROR | [x] Short array syntax must be used to define arrays
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 48 MARKED SNIFF VIOLATIONS AUTOMATICALLY
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml material_admin/
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @silvi.addweb,
I have reviewed the changes and confirmed that Patch #6 was applied cleanly to the Custom Messages module against 8.x-1.x-dev on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml custom_messages
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi,
I have applied the latest MR to the Logout Redirect module against 2.0.1 on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml logout_redirect
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi,
I am moving this to 'Needs work', please check the PHPCS issues below after applying the 'MR !14' to the Varbase Components module against 2.0.x-dev on my D10 local.
Please run this command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig varbase_components/
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/varbase_components/components/atoms/accordion-item/accordion-item.twig
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------
141 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/varbase_components/components/organisms/heroslider/heroslider.twig
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
167 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/varbase_components/components/organisms/media-header/media-header.twig
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------
46 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/varbase_components/components/organisms/card-hero/card-hero.twig
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
197 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------
Please check.
Thank you!
Hi,
I am moving this to 'Needs work', please check the PHPCS issues below after applying the 'MR !14' to the CROP API module against 8.x-2.x-dev on my D10 local.
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/crop/tests/src/Functional/CropFunctionalTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 13 WARNINGS AFFECTING 13 LINES
------------------------------------------------------------------------------------------------------------------------------------------
84 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
85 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
88 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
101 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
109 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
110 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
122 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
123 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
142 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
147 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
148 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
152 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
153 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/crop/tests/src/Kernel/CropCRUDTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES
------------------------------------------------------------------------------------------------------------------------------------------
68 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
69 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
70 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
75 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
76 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
77 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
103 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
104 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
105 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
106 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
109 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
110 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
111 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
112 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
113 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
114 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/crop/tests/src/Kernel/CropEffectTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
95 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/crop/src/Form/CropTypeDeleteForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
46 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
60 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/crop/src/CropTypeListBuilder.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------
71 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
112 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
131 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/crop/src/Entity/Crop.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
124 | WARNING | Exceptions should not be translated
124 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
Time: 365ms; Memory: 12MB
Please check.
Thank you!
Hi @everyone!
I have applied the latest fixes to the Admin Toolbar Messages module against 1.0.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml admin_toolbar_messages/
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @everyone!
I have applied the latest fixes to the Google Module Viewer module against 1.0.x-dev on Drupal 10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml gmv/
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
I have applied your latest MR to the Project Browser module against 1.0.x-dev on Drupal 10 and confirmed that the help text at /admin/help/project_browser is now updated and other information is also implemented.
Please see the attachments for reference.
I'm marking this now as 'RTBC'.
Thank you!
Hi @alexb7217,
I enabled the RSVP List module against 1.0.x-dev on my Drupal 10 site, tested all the functionalities, and confirmed it works without getting any of the errors mentioned above.
Please see the attachments for reference.
I'm marking this now to 'RTBC'.
Thank you.
Hi guys!
I have reviewed the changes and confirmed that Patch #30 was applied cleanly to the Preview Site module against 1.x-dev on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml preview_site
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @arunkumark,
I have reviewed the changes and confirmed that Patch #23 was applied cleanly to the Mail System module against 8.x-4.x on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig mailsystem
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @silvi.addweb,
I have reviewed the changes and confirmed that Patch #35 was applied cleanly to the Token module against 8.x-1.x-dev on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md token
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @noorulshameera,
I have reviewed the changes and confirmed that Patch #12 was applied cleanly to the Telephone Validation module against 8.x-2.x-dev on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js telephone_validation
Please see the attached files for reference.
I'm moving this now to 'RTBC'.
Thank you!
Hi @IGhosh,
After applying your latest MR !5 to the Drupal REST & JSON API module against 2.0.12 on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/rest_api_authentication.info.yml
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/Form/miniorangeAPIAuth.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------------------
23 | ERROR | Class name doesn't match filename; expected "class miniorangeAPIAuth"
81 | WARNING | Unused global variable $base_url.
82 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
295 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/setupAuthenticationForm.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Class name doesn't match filename; expected "class setupAuthenticationForm"
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/customerSetupForm.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Class name doesn't match filename; expected "class customerSetupForm"
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/upgradePlansForm.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Class name doesn't match filename; expected "class upgradePlansForm"
24 | WARNING | Unused global variable $base_url.
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/advancedSettingsForm.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Class name doesn't match filename; expected "class advancedSettingsForm"
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/Utilities.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------
86 | WARNING | Unused variable $ajax_form.
95 | WARNING | Unused variable $ajax_form.
--------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/MiniorangeApiAuthSupport.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
170 | WARNING | Unused variable $response.
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/Routing/RouteSubscriber.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
35 | WARNING | Unused private method restLoginRount()
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/requestForDemoForm.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Class name doesn't match filename; expected "class requestForDemoForm"
-----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/Authentication/Provider/restAPI.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
18 | ERROR | Class name doesn't match filename; expected "class restAPI"
------------------------------------------------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml rest_api_authentication
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @Deepthi kumari,
After applying your Patch #3 to the Start Trek module on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/startrek.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/EnterpriseMessage.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManager.
13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
43 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
44 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
45 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
45 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
45 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/Controller/KobayashiMaruController.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/StarTrekParserInterface.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/EnterpriseMessageInterface.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/StarTrekParserYAML.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Exception\InvalidDataTypeException.
13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/EventSubscriber/CrewSubscriber.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Authentication\AuthenticationManager.
16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
43 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
44 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
45 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
45 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
45 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------
Time: 101ms; Memory: 10MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml startrek
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @avinashm,
After applying your Patch #4 to the Custom Messages module against 8.x-1.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
See errors below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/custom_messages.info.yml
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | [ ] "core_version_requirement" property is missing in the info.yml file
4 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/src/Form/CustomMessageForm.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
19 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/src/Form/CustomMessageSettingsForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
14 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/src/Entity/CustomMessage.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityBase.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/src/CustomMessageAccessControlHandler.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Access\AccessResult.
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/src/CustomMessageListBuilder.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
32 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
Time: 125ms; Memory: 10MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml custom_messages
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @Deepthi kumari,
After applying your Patch #3 to the Ckeditor Shortcode module against 8.x-1.1 on Drupal 10, not all of the PHPCS errors were resolved.
Please see below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/ckeditor_shortcodes/ckeditor_shortcodes.info.yml
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/ckeditor_shortcodes/src/Plugin/CKEditorPlugin/btshortcodes.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\ckeditor\CKEditorPluginBase.
17 | ERROR | [ ] Class name doesn't match filename; expected "class btshortcodes"
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------
Time: 77ms; Memory: 10MB
I'm moving this to 'Needs work' for now.
Thank you!
Hi @silvi,
After applying your Patch #10 to the Content Editing Messages module against 8.x-1.x-dev on Drupal 10, I still see 1 PHPCS warning.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/content_editing_message/src/Form/ContentEditingMessageFormBase.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
194 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------------------------
Time: 159ms; Memory: 12MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml content_editing_message
Please see the attached files for reference.
I'm moving this now to Needs work.
Thank you!
Hi @chaitanyadessai,
I have reviewed the changes and confirmed that Patch was applied cleanly to the Drupal Mega Menu module against 8.x-1.x-dev on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme we_megamenu
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi @Dydave,
I have applied the latest MR !36 to the Entity Reference Revisions module against 8.x-1.x-dev on Drupal 10 and confirmed that all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme entity_reference_revisions
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I have reviewed the changes and confirmed that Patch #5 was applied cleanly to the OMDB API module on Drupal 10.1.2.
And all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig omdb_api/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I have reviewed the changes and confirmed that Patch #5 was applied cleanly to the Widget Type module against 1.5.14 on Drupal 10.1.2.
Checking patch css/options-filter.css...
Checking patch src/Controller/InteractiveComponents.php...
Checking patch src/Element/WidgetSelectorElement.php...
Checking patch src/Entity/WidgetType.php...
Checking patch src/Form/WidgetTypeSettingsForm.php...
Checking patch src/Plugin/EntityReferenceSelection/WidgetTypeSelection.php...
Checking patch src/WidgetRegistrySourceInterface.php...
Checking patch src/WidgetRegistrySourceListBuilder.php...
Checking patch src/WidgetTypeInterface.php...
Checking patch src/WidgetTypeListBuilder.php...
Checking patch tests/src/Unit/WidgetTypeConfigurationTest.php...
Checking patch widget_type.install...
Applied patch css/options-filter.css cleanly.
Applied patch src/Controller/InteractiveComponents.php cleanly.
Applied patch src/Element/WidgetSelectorElement.php cleanly.
Applied patch src/Entity/WidgetType.php cleanly.
Applied patch src/Form/WidgetTypeSettingsForm.php cleanly.
Applied patch src/Plugin/EntityReferenceSelection/WidgetTypeSelection.php cleanly.
Applied patch src/WidgetRegistrySourceInterface.php cleanly.
Applied patch src/WidgetRegistrySourceListBuilder.php cleanly.
Applied patch src/WidgetTypeInterface.php cleanly.
Applied patch src/WidgetTypeListBuilder.php cleanly.
Applied patch tests/src/Unit/WidgetTypeConfigurationTest.php cleanly.
Applied patch widget_type.install cleanly.
And all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml widget_type/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi @akshay.singh,
After applying the latest MR !3 to the Trumba module against 2.0.1 on Drupal 9.5.10, not all of the PHPCS errors were resolved.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml trumba/
Please see the attached file.
Moving this now to Needs work for now.
Thank you.
Hi,
I have reviewed the changes and confirmed that Patch was applied cleanly to the CKEditor Styles Combo Plus module against 1.0.x-dev on Drupal 9.5.10.
And confirmed all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig stylescomboplus/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I have reviewed the changes and confirmed Patch #3 was applied cleanly to the Node By Term module against 1.0.x-dev on Drupal 9.5.10.
For that Patch, confirmed all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml node_by_term/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi @prachi6824,
I've checked your Patch and it doesn't work on my end.
Please see the attached file.
Moving this to Needs work for now.
Thank you.
Hi,
I reviewed the changes and it looks good on my end.
Moving this now to RTBC.
Thank you!
Hi,
I have applied the latest MR !2 to the Feeds LDAP module against 4.0.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml feeds_ldap/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi @chaitanyadessai,
After applying your Patch #23 to the Progressive Web App module against 2.x-dev on Drupal 9.5.10, not all of the PHPCS errors were resolved.
<stdin>:20: trailing whitespace.
Service workers are only available
Checking patch README.md...
Checking patch modules/pwa_extras/pwa_extras.links.menu.yml...
Checking patch modules/pwa_extras/pwa_extras.module...
Checking patch modules/pwa_extras/src/Form/PwaExtrasSettingsForm.php...
Checking patch pwa.api.php...
Checking patch pwa.install...
Checking patch src/Controller/PWAController.php...
Checking patch src/EventSubscriber/ResponseSubscriber.php...
Checking patch src/Form/BasicConfigurationForm.php...
Checking patch src/Form/ManifestConfigurationForm.php...
Checking patch src/Form/ServiceWorkerConfigurationForm.php...
Checking patch src/Manifest.php...
Applied patch README.md cleanly.
Applied patch modules/pwa_extras/pwa_extras.links.menu.yml cleanly.
Applied patch modules/pwa_extras/pwa_extras.module cleanly.
Applied patch modules/pwa_extras/src/Form/PwaExtrasSettingsForm.php cleanly.
Applied patch pwa.api.php cleanly.
Applied patch pwa.install cleanly.
Applied patch src/Controller/PWAController.php cleanly.
Applied patch src/EventSubscriber/ResponseSubscriber.php cleanly.
Applied patch src/Form/BasicConfigurationForm.php cleanly.
Applied patch src/Form/ManifestConfigurationForm.php cleanly.
Applied patch src/Form/ServiceWorkerConfigurationForm.php cleanly.
Applied patch src/Manifest.php cleanly.
warning: 1 line adds whitespace errors.
Please run this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pwa/
Please see the attached files for reference.
I'm moving this to Needs work for now.
Thank you!
Hi @kpoornima,
When I applied your MR !3 to the Audio Embed Field module against 8.x-2.x-dev on Drupal 9.5.10, it didn't resolve all the errors.
See the remaining 1 error below:
FILE: /.../audio_embed_field/modules/audio_embed_media/audio_embed_media.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
--------------------------------------------------------------------------------------------------------------------------------------------------
Time: 473ms; Memory: 10MB
Please run this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig audio_embed_field
Moving this to Needs work for now.
Thank you!
Hi,
I reviewed the changes made in #12 to address the issues mentioned in #9, and confirmed that Patch #12 was applied cleanly to the module.
Checking patch README.md...
Checking patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php...
Applied patch README.md cleanly.
Applied patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php cleanly.
And no PHPCS errors have been detected.
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR !2 to the module on Drupal 9.5.10 and confirmed all PHPCS errors have been resolved!
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml codefilter/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR !12 to the Real Name module against 2.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml realname/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
Reviewed the latest MR and applied it to the module, confirmed no PHPCS errors were detected.
Please see the attached file.
Moving this to RTBC.
Thank you!
Hi,
Patch #47 was applied cleanly and no PHPCS errors were detected.
Please see the attached file.
Moving this to RTBC.
Thank you!
Hi @bharath-kondeti,
I applied the latest MR !2 to the Gif Player Field module against 8.x-1.x-dev on Drupal 9.5.10 and I'm still seeing 1 warning from GifPlayerFormatter.php file, please see below:
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig gifplayer/
Please see the attached files for reference.
I'm moving this to Needs work for now.
Thank you!
Hi @apaderno,
Moving this again to RTBC, please check the feedback of @bharath-kondeti.
Thank you!
Hi,
I applied the latest MR !13 to the Accordion for Layout Builder module against 1.0.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors had been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js lb_accordion/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
After applying the MR !3, confirmed the README.md file has been added to the ZURB Foundation Sites module against 2.x-dev on Drupal 9.5.10 and upon reviewing the README.md file, confirmed it has all relevant information based on this documentation https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → .
Attaching screenshots.
I'm moving this now to RTBC.
Thanks!
Hi,
Patch #2 was applied cleanly to the External Entities module against 8.x-2.x-dev on Drupal 9.5.10, and confirmed that the ExternalEntityStorageClientInterface.php is now updated.
Checking patch src/StorageClient/ExternalEntityStorageClientInterface.php...
Applied patch src/StorageClient/ExternalEntityStorageClientInterface.php cleanly.
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed that Patch #6 was applied cleanly to the Group Message module against 1.0.x-dev on Drupal 9.5.10.
Checking patch src/Plugin/Group/Relation/GroupMessage.php...
Checking patch src/Plugin/Group/Relation/GroupMessageDeriver.php...
Checking patch src/Plugin/GroupContentEnabler/GroupMessageDeriver.php...
Applied patch src/Plugin/Group/Relation/GroupMessage.php cleanly.
Applied patch src/Plugin/Group/Relation/GroupMessageDeriver.php cleanly.
Applied patch src/Plugin/GroupContentEnabler/GroupMessageDeriver.php cleanly.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml gmessage/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed that Patch#8 was applied cleanly to the Save All Nodes module against 2.x-dev on Drupal 9.5.10.
Checking patch src/Commands/SaveAllNodesCommands.php...
Applied patch src/Commands/SaveAllNodesCommands.php cleanly.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig save_all_nodes/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi @mrinalini9,
I reviewed the changes and confirmed the Patch#9 was applied cleanly to the Layout Builder No-render module against 1.0.0 on Drupal 9.5.10.
Checking patch layout_builder_norender.info.yml...
Checking patch layout_builder_norender.module...
Checking patch src/Element/NorenderLayoutBuilder.php...
Checking patch src/EventSubscriber/SectionComponentNorender.php...
Applied patch layout_builder_norender.info.yml cleanly.
Applied patch layout_builder_norender.module cleanly.
Applied patch src/Element/NorenderLayoutBuilder.php cleanly.
Applied patch src/EventSubscriber/SectionComponentNorender.php cleanly.
However, the Patch didn't fix the PHPCS errors:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/layout_builder_norender-3355278/css/norender.css
----------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------
34 | ERROR | [x] CSS colours must be defined in lowercase; expected #ff0000ff but found #FF0000FF
44 | ERROR | [x] CSS colours must be defined in lowercase; expected #ff0000ff but found #FF0000FF
47 | ERROR | [x] Blank lines are not allowed in class definitions
69 | ERROR | [x] CSS colours must be defined in lowercase; expected #ff0000ff but found #FF0000FF
70 | ERROR | [x] CSS colours must be defined in lowercase; expected #ff0000ff but found #FF0000FF
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/layout_builder_norender-3355278/README.md
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 6 WARNINGS AFFECTING 7 LINES
---------------------------------------------------------------------------------------------------------------------
17 | WARNING | [ ] Line exceeds 80 characters; contains 132 characters
18 | WARNING | [ ] Line exceeds 80 characters; contains 135 characters
21 | WARNING | [ ] Line exceeds 80 characters; contains 123 characters
22 | WARNING | [ ] Line exceeds 80 characters; contains 123 characters
23 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
34 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
44 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/layout_builder_norender-3355278/src/Element/NorenderLayoutBuilder.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
28 | ERROR | Type hint "array" missing for $element
-------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/layout_builder_norender-3355278/src/Controller/NorenderBlockController.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------
49 | ERROR | Missing parameter type
51 | ERROR | Missing parameter type
53 | ERROR | Missing parameter type
56 | ERROR | Description for the @return value is missing
------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/layout_builder_norender-3355278/src/EventSubscriber/SectionComponentNorender.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------
25 | ERROR | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
30 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
58 | ERROR | [x] Array closing indentation error, expected 10 spaces but found 12
------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 105ms; Memory: 10MB
Moving this now to Needs work for investigations.
Thank you!
Hi,
I reviewed the changes and confirmed the Patch #10 was applied cleanly to the CSV Serialization module against 3.x-dev on Drupal 9.5.10.
Checking patch README.md...
Checking patch csv_serialization.install...
Applied patch README.md cleanly.
Applied patch csv_serialization.install cleanly.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml csv_serialization/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the MR !8 to the Advanced Link Attributes module against 8.x-2.5-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,md ala/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR !8 to the Menu Trail By Path module against 2.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml menu_trail_by_path/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi @imustakim,
I reviewed your changes and after applying the MR !12 on the module, there were coding standard issues found by the PHPCS:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/y_branch_menu/assets/css/y_branch_menu.css
----------------------------------------------------------------------------------------------------------------------
FOUND 104 ERRORS AFFECTING 87 LINES
----------------------------------------------------------------------------------------------------------------------
2 | ERROR | [x] Closing brace of class definition must be on new line
5 | ERROR | [x] Closing brace of class definition must be on new line
6 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
7 | ERROR | [x] Closing brace of class definition must be on new line
11 | ERROR | [x] Closing brace of class definition must be on new line
12 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Closing brace of class definition must be on new line
22 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
33 | ERROR | [x] CSS colours must be defined in lowercase; expected #e9e9e9 but found #E9E9E9
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
34 | ERROR | [x] Closing brace of class definition must be on new line
35 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
37 | ERROR | [x] Closing brace of class definition must be on new line
38 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
39 | ERROR | [x] Closing brace of class definition must be on new line
40 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Closing brace of class definition must be on new line
45 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Closing brace of class definition must be on new line
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
51 | ERROR | [x] Closing brace of class definition must be on new line
52 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
55 | ERROR | [x] Closing brace of class definition must be on new line
56 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
60 | ERROR | [x] Closing brace of class definition must be on new line
61 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
67 | ERROR | [x] Closing brace of class definition must be on new line
68 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 8
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
71 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
72 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
73 | ERROR | [x] Closing brace of class definition must be on new line
74 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 8
75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
76 | ERROR | [x] Closing brace of class definition must be on new line
77 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 8
78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
80 | ERROR | [x] Closing brace of class definition must be on new line
81 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 8
82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
89 | ERROR | [x] Closing brace of class definition must be on new line
90 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 10
91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 14
92 | ERROR | [x] Closing brace of class definition must be on new line
94 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 104 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------
Time: 229ms; Memory: 10MB
I re-ran this command on the module after the MR applied:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml y_branch_menu/
Moving this now to Needs work for investigations.
Thank you!
Hi,
I applied the latest MR to the SpamSpan filter module against 3.x-dev on Drupal 9.5.10 and confirmed the spamspan.js
file has been updated now.
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR to the SpamSpan filter module against 3.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig spamspan/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR and confirmed I'm seeing the 2 issues remaining mentioned above which can be ignored.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig bootstrap_pages/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the latest changes and confirmed that Patch #14 was applied cleanly and no PHPCS errors were found.
Checking patch assets/css/y_branch_menu.css...
Checking patch src/Plugin/Block/BranchMenuBlock.php...
Checking patch y_branch_menu.info.yml...
Checking patch y_branch_menu.module...
Applied patch assets/css/y_branch_menu.css cleanly.
Applied patch src/Plugin/Block/BranchMenuBlock.php cleanly.
Applied patch y_branch_menu.info.yml cleanly.
Applied patch y_branch_menu.module cleanly.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml y_branch_menu/
Please see the attached file for reference.
Moving this again to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed the Patch was applied cleanly to the Menu Link Clone module against 8.x-3.2 on Drupal 9.5.10.
Checking patch tests/src/Functional/MenuLinkCloneTest.php...
Applied patch tests/src/Functional/MenuLinkCloneTest.php cleanly.
And all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_link_clone-3376139/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!