I have applied your latest MR to the Project Browser module against 1.0.x-dev on Drupal 10 and confirmed that the help text at /admin/help/project_browser is now updated and other information is also implemented.
Please see the attachments for reference.
I'm marking this now as 'RTBC'.
Thank you!
Hi @alexb7217,
I enabled the RSVP List module against 1.0.x-dev on my Drupal 10 site, tested all the functionalities, and confirmed it works without getting any of the errors mentioned above.
Please see the attachments for reference.
I'm marking this now to 'RTBC'.
Thank you.
Hi guys!
I have reviewed the changes and confirmed that Patch #30 was applied cleanly to the Preview Site module against 1.x-dev on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml preview_site
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @arunkumark,
I have reviewed the changes and confirmed that Patch #23 was applied cleanly to the Mail System module against 8.x-4.x on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig mailsystem
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @silvi.addweb,
I have reviewed the changes and confirmed that Patch #35 was applied cleanly to the Token module against 8.x-1.x-dev on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md token
Please see the attached file for reference.
I'm moving this now to ‘RTBC’.
Thank you!
Hi @noorulshameera,
I have reviewed the changes and confirmed that Patch #12 was applied cleanly to the Telephone Validation module against 8.x-2.x-dev on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js telephone_validation
Please see the attached files for reference.
I'm moving this now to 'RTBC'.
Thank you!
Hi @IGhosh,
After applying your latest MR !5 to the Drupal REST & JSON API module against 2.0.12 on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/rest_api_authentication.info.yml
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/Form/miniorangeAPIAuth.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------------------
23 | ERROR | Class name doesn't match filename; expected "class miniorangeAPIAuth"
81 | WARNING | Unused global variable $base_url.
82 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
295 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/setupAuthenticationForm.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Class name doesn't match filename; expected "class setupAuthenticationForm"
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/customerSetupForm.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Class name doesn't match filename; expected "class customerSetupForm"
----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/upgradePlansForm.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Class name doesn't match filename; expected "class upgradePlansForm"
24 | WARNING | Unused global variable $base_url.
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/advancedSettingsForm.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Class name doesn't match filename; expected "class advancedSettingsForm"
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/Utilities.php
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------
86 | WARNING | Unused variable $ajax_form.
95 | WARNING | Unused variable $ajax_form.
--------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/MiniorangeApiAuthSupport.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
170 | WARNING | Unused variable $response.
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/Routing/RouteSubscriber.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------
35 | WARNING | Unused private method restLoginRount()
----------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/requestForDemoForm.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | Class name doesn't match filename; expected "class requestForDemoForm"
-----------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/rest_api_authentication/src/Authentication/Provider/restAPI.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
18 | ERROR | Class name doesn't match filename; expected "class restAPI"
------------------------------------------------------------------------------------------------------------------------------------------------
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml rest_api_authentication
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @Deepthi kumari,
After applying your Patch #3 to the Start Trek module on Drupal 10, not all of the PHPCS errors were resolved.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/startrek.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/EnterpriseMessage.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManager.
13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
43 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
44 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
45 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
45 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
45 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/Controller/KobayashiMaruController.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/StarTrekParserInterface.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/EnterpriseMessageInterface.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
9 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/StarTrekParserYAML.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Exception\InvalidDataTypeException.
13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
--------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/startrek/src/EventSubscriber/CrewSubscriber.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Authentication\AuthenticationManager.
16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
43 | ERROR | [x] The first parameter of a multi-line function declaration must be on the line after the opening bracket
44 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
45 | ERROR | [x] Multi-line function declaration not indented correctly; expected 4 spaces but found 30
45 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
45 | ERROR | [x] The closing parenthesis of a multi-line function declaration must be on a new line
---------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------
Time: 101ms; Memory: 10MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml startrek
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @avinashm,
After applying your Patch #4 to the Custom Messages module against 8.x-1.x-dev on Drupal 10, not all of the PHPCS errors were resolved.
See errors below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/custom_messages.info.yml
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | [ ] "core_version_requirement" property is missing in the info.yml file
4 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/src/Form/CustomMessageForm.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
19 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/src/Form/CustomMessageSettingsForm.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
14 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/src/Entity/CustomMessage.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\ContentEntityBase.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/src/CustomMessageAccessControlHandler.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Access\AccessResult.
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/custom_messages/src/CustomMessageListBuilder.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
32 | WARNING | [x] Inline @var declarations should use the /** */ delimiters
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------
Time: 125ms; Memory: 10MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml custom_messages
I'm moving this to ‘Needs work’ for now.
Thank you!
Hi @Deepthi kumari,
After applying your Patch #3 to the Ckeditor Shortcode module against 8.x-1.1 on Drupal 10, not all of the PHPCS errors were resolved.
Please see below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/ckeditor_shortcodes/ckeditor_shortcodes.info.yml
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/ckeditor_shortcodes/src/Plugin/CKEditorPlugin/btshortcodes.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\ckeditor\CKEditorPluginBase.
17 | ERROR | [ ] Class name doesn't match filename; expected "class btshortcodes"
-----------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------
Time: 77ms; Memory: 10MB
I'm moving this to 'Needs work' for now.
Thank you!
Hi @silvi,
After applying your Patch #10 to the Content Editing Messages module against 8.x-1.x-dev on Drupal 10, I still see 1 PHPCS warning.
See below:
FILE: /Users/roberttabigue/Project/DrupalOrg/drupalorgissues/web/modules/contrib/content_editing_message/src/Form/ContentEditingMessageFormBase.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
194 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------------------------------
Time: 159ms; Memory: 12MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml content_editing_message
Please see the attached files for reference.
I'm moving this now to Needs work.
Thank you!
Hi @chaitanyadessai,
I have reviewed the changes and confirmed that Patch was applied cleanly to the Drupal Mega Menu module against 8.x-1.x-dev on Drupal 10.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme we_megamenu
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi @Dydave,
I have applied the latest MR !36 to the Entity Reference Revisions module against 8.x-1.x-dev on Drupal 10 and confirmed that all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,inc,module,install,info,test,profile,theme entity_reference_revisions
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I have reviewed the changes and confirmed that Patch #5 was applied cleanly to the OMDB API module on Drupal 10.1.2.
And all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig omdb_api/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I have reviewed the changes and confirmed that Patch #5 was applied cleanly to the Widget Type module against 1.5.14 on Drupal 10.1.2.
Checking patch css/options-filter.css...
Checking patch src/Controller/InteractiveComponents.php...
Checking patch src/Element/WidgetSelectorElement.php...
Checking patch src/Entity/WidgetType.php...
Checking patch src/Form/WidgetTypeSettingsForm.php...
Checking patch src/Plugin/EntityReferenceSelection/WidgetTypeSelection.php...
Checking patch src/WidgetRegistrySourceInterface.php...
Checking patch src/WidgetRegistrySourceListBuilder.php...
Checking patch src/WidgetTypeInterface.php...
Checking patch src/WidgetTypeListBuilder.php...
Checking patch tests/src/Unit/WidgetTypeConfigurationTest.php...
Checking patch widget_type.install...
Applied patch css/options-filter.css cleanly.
Applied patch src/Controller/InteractiveComponents.php cleanly.
Applied patch src/Element/WidgetSelectorElement.php cleanly.
Applied patch src/Entity/WidgetType.php cleanly.
Applied patch src/Form/WidgetTypeSettingsForm.php cleanly.
Applied patch src/Plugin/EntityReferenceSelection/WidgetTypeSelection.php cleanly.
Applied patch src/WidgetRegistrySourceInterface.php cleanly.
Applied patch src/WidgetRegistrySourceListBuilder.php cleanly.
Applied patch src/WidgetTypeInterface.php cleanly.
Applied patch src/WidgetTypeListBuilder.php cleanly.
Applied patch tests/src/Unit/WidgetTypeConfigurationTest.php cleanly.
Applied patch widget_type.install cleanly.
And all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml widget_type/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi @akshay.singh,
After applying the latest MR !3 to the Trumba module against 2.0.1 on Drupal 9.5.10, not all of the PHPCS errors were resolved.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml trumba/
Please see the attached file.
Moving this now to Needs work for now.
Thank you.
Hi,
I have reviewed the changes and confirmed that Patch was applied cleanly to the CKEditor Styles Combo Plus module against 1.0.x-dev on Drupal 9.5.10.
And confirmed all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig stylescomboplus/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I have reviewed the changes and confirmed Patch #3 was applied cleanly to the Node By Term module against 1.0.x-dev on Drupal 9.5.10.
For that Patch, confirmed all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml node_by_term/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi @prachi6824,
I've checked your Patch and it doesn't work on my end.
Please see the attached file.
Moving this to Needs work for now.
Thank you.
Hi,
I reviewed the changes and it looks good on my end.
Moving this now to RTBC.
Thank you!
Hi,
I have applied the latest MR !2 to the Feeds LDAP module against 4.0.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml feeds_ldap/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi @chaitanyadessai,
After applying your Patch #23 to the Progressive Web App module against 2.x-dev on Drupal 9.5.10, not all of the PHPCS errors were resolved.
<stdin>:20: trailing whitespace.
Service workers are only available
Checking patch README.md...
Checking patch modules/pwa_extras/pwa_extras.links.menu.yml...
Checking patch modules/pwa_extras/pwa_extras.module...
Checking patch modules/pwa_extras/src/Form/PwaExtrasSettingsForm.php...
Checking patch pwa.api.php...
Checking patch pwa.install...
Checking patch src/Controller/PWAController.php...
Checking patch src/EventSubscriber/ResponseSubscriber.php...
Checking patch src/Form/BasicConfigurationForm.php...
Checking patch src/Form/ManifestConfigurationForm.php...
Checking patch src/Form/ServiceWorkerConfigurationForm.php...
Checking patch src/Manifest.php...
Applied patch README.md cleanly.
Applied patch modules/pwa_extras/pwa_extras.links.menu.yml cleanly.
Applied patch modules/pwa_extras/pwa_extras.module cleanly.
Applied patch modules/pwa_extras/src/Form/PwaExtrasSettingsForm.php cleanly.
Applied patch pwa.api.php cleanly.
Applied patch pwa.install cleanly.
Applied patch src/Controller/PWAController.php cleanly.
Applied patch src/EventSubscriber/ResponseSubscriber.php cleanly.
Applied patch src/Form/BasicConfigurationForm.php cleanly.
Applied patch src/Form/ManifestConfigurationForm.php cleanly.
Applied patch src/Form/ServiceWorkerConfigurationForm.php cleanly.
Applied patch src/Manifest.php cleanly.
warning: 1 line adds whitespace errors.
Please run this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig pwa/
Please see the attached files for reference.
I'm moving this to Needs work for now.
Thank you!
Hi @kpoornima,
When I applied your MR !3 to the Audio Embed Field module against 8.x-2.x-dev on Drupal 9.5.10, it didn't resolve all the errors.
See the remaining 1 error below:
FILE: /.../audio_embed_field/modules/audio_embed_media/audio_embed_media.info.yml
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
--------------------------------------------------------------------------------------------------------------------------------------------------
Time: 473ms; Memory: 10MB
Please run this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig audio_embed_field
Moving this to Needs work for now.
Thank you!
Hi,
I reviewed the changes made in #12 to address the issues mentioned in #9, and confirmed that Patch #12 was applied cleanly to the module.
Checking patch README.md...
Checking patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php...
Applied patch README.md cleanly.
Applied patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php cleanly.
And no PHPCS errors have been detected.
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR !2 to the module on Drupal 9.5.10 and confirmed all PHPCS errors have been resolved!
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml codefilter/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR !12 to the Real Name module against 2.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml realname/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
Reviewed the latest MR and applied it to the module, confirmed no PHPCS errors were detected.
Please see the attached file.
Moving this to RTBC.
Thank you!
Hi,
Patch #47 was applied cleanly and no PHPCS errors were detected.
Please see the attached file.
Moving this to RTBC.
Thank you!
Hi @bharath-kondeti,
I applied the latest MR !2 to the Gif Player Field module against 8.x-1.x-dev on Drupal 9.5.10 and I'm still seeing 1 warning from GifPlayerFormatter.php file, please see below:
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig gifplayer/
Please see the attached files for reference.
I'm moving this to Needs work for now.
Thank you!
Hi @apaderno,
Moving this again to RTBC, please check the feedback of @bharath-kondeti.
Thank you!
Hi,
I applied the latest MR !13 to the Accordion for Layout Builder module against 1.0.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors had been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js lb_accordion/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
After applying the MR !3, confirmed the README.md file has been added to the ZURB Foundation Sites module against 2.x-dev on Drupal 9.5.10 and upon reviewing the README.md file, confirmed it has all relevant information based on this documentation https://www.drupal.org/docs/develop/managing-a-drupalorg-theme-module-or... → .
Attaching screenshots.
I'm moving this now to RTBC.
Thanks!
Hi,
Patch #2 was applied cleanly to the External Entities module against 8.x-2.x-dev on Drupal 9.5.10, and confirmed that the ExternalEntityStorageClientInterface.php is now updated.
Checking patch src/StorageClient/ExternalEntityStorageClientInterface.php...
Applied patch src/StorageClient/ExternalEntityStorageClientInterface.php cleanly.
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed that Patch #6 was applied cleanly to the Group Message module against 1.0.x-dev on Drupal 9.5.10.
Checking patch src/Plugin/Group/Relation/GroupMessage.php...
Checking patch src/Plugin/Group/Relation/GroupMessageDeriver.php...
Checking patch src/Plugin/GroupContentEnabler/GroupMessageDeriver.php...
Applied patch src/Plugin/Group/Relation/GroupMessage.php cleanly.
Applied patch src/Plugin/Group/Relation/GroupMessageDeriver.php cleanly.
Applied patch src/Plugin/GroupContentEnabler/GroupMessageDeriver.php cleanly.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml gmessage/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed that Patch#8 was applied cleanly to the Save All Nodes module against 2.x-dev on Drupal 9.5.10.
Checking patch src/Commands/SaveAllNodesCommands.php...
Applied patch src/Commands/SaveAllNodesCommands.php cleanly.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig save_all_nodes/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi @mrinalini9,
I reviewed the changes and confirmed the Patch#9 was applied cleanly to the Layout Builder No-render module against 1.0.0 on Drupal 9.5.10.
Checking patch layout_builder_norender.info.yml...
Checking patch layout_builder_norender.module...
Checking patch src/Element/NorenderLayoutBuilder.php...
Checking patch src/EventSubscriber/SectionComponentNorender.php...
Applied patch layout_builder_norender.info.yml cleanly.
Applied patch layout_builder_norender.module cleanly.
Applied patch src/Element/NorenderLayoutBuilder.php cleanly.
Applied patch src/EventSubscriber/SectionComponentNorender.php cleanly.
However, the Patch didn't fix the PHPCS errors:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/layout_builder_norender-3355278/css/norender.css
----------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------------------
34 | ERROR | [x] CSS colours must be defined in lowercase; expected #ff0000ff but found #FF0000FF
44 | ERROR | [x] CSS colours must be defined in lowercase; expected #ff0000ff but found #FF0000FF
47 | ERROR | [x] Blank lines are not allowed in class definitions
69 | ERROR | [x] CSS colours must be defined in lowercase; expected #ff0000ff but found #FF0000FF
70 | ERROR | [x] CSS colours must be defined in lowercase; expected #ff0000ff but found #FF0000FF
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/layout_builder_norender-3355278/README.md
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 6 WARNINGS AFFECTING 7 LINES
---------------------------------------------------------------------------------------------------------------------
17 | WARNING | [ ] Line exceeds 80 characters; contains 132 characters
18 | WARNING | [ ] Line exceeds 80 characters; contains 135 characters
21 | WARNING | [ ] Line exceeds 80 characters; contains 123 characters
22 | WARNING | [ ] Line exceeds 80 characters; contains 123 characters
23 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
34 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
44 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/layout_builder_norender-3355278/src/Element/NorenderLayoutBuilder.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
28 | ERROR | Type hint "array" missing for $element
-------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/layout_builder_norender-3355278/src/Controller/NorenderBlockController.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------
49 | ERROR | Missing parameter type
51 | ERROR | Missing parameter type
53 | ERROR | Missing parameter type
56 | ERROR | Description for the @return value is missing
------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/layout_builder_norender-3355278/src/EventSubscriber/SectionComponentNorender.php
------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------
25 | ERROR | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
30 | WARNING | [ ] Line exceeds 80 characters; contains 100 characters
58 | ERROR | [x] Array closing indentation error, expected 10 spaces but found 12
------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 105ms; Memory: 10MB
Moving this now to Needs work for investigations.
Thank you!
Hi,
I reviewed the changes and confirmed the Patch #10 was applied cleanly to the CSV Serialization module against 3.x-dev on Drupal 9.5.10.
Checking patch README.md...
Checking patch csv_serialization.install...
Applied patch README.md cleanly.
Applied patch csv_serialization.install cleanly.
And all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml csv_serialization/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the MR !8 to the Advanced Link Attributes module against 8.x-2.5-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,md ala/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR !8 to the Menu Trail By Path module against 2.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command on the module:
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml menu_trail_by_path/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi @imustakim,
I reviewed your changes and after applying the MR !12 on the module, there were coding standard issues found by the PHPCS:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/y_branch_menu/assets/css/y_branch_menu.css
----------------------------------------------------------------------------------------------------------------------
FOUND 104 ERRORS AFFECTING 87 LINES
----------------------------------------------------------------------------------------------------------------------
2 | ERROR | [x] Closing brace of class definition must be on new line
5 | ERROR | [x] Closing brace of class definition must be on new line
6 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
7 | ERROR | [x] Closing brace of class definition must be on new line
11 | ERROR | [x] Closing brace of class definition must be on new line
12 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Closing brace of class definition must be on new line
22 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
33 | ERROR | [x] CSS colours must be defined in lowercase; expected #e9e9e9 but found #E9E9E9
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
34 | ERROR | [x] Closing brace of class definition must be on new line
35 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
37 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
37 | ERROR | [x] Closing brace of class definition must be on new line
38 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
39 | ERROR | [x] Closing brace of class definition must be on new line
40 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [x] Closing brace of class definition must be on new line
45 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
47 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
48 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
49 | ERROR | [x] Closing brace of class definition must be on new line
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
51 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
51 | ERROR | [x] Closing brace of class definition must be on new line
52 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
55 | ERROR | [x] Closing brace of class definition must be on new line
56 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
58 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
59 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
60 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
60 | ERROR | [x] Closing brace of class definition must be on new line
61 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 6
62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 8
67 | ERROR | [x] Closing brace of class definition must be on new line
68 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 8
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
71 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
72 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
73 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 12
73 | ERROR | [x] Closing brace of class definition must be on new line
74 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 8
75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
76 | ERROR | [x] Closing brace of class definition must be on new line
77 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 8
78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
80 | ERROR | [x] Closing brace of class definition must be on new line
81 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 8
82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
89 | ERROR | [x] Closing brace of class definition must be on new line
90 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 10
91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 12
92 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 14
92 | ERROR | [x] Closing brace of class definition must be on new line
94 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 104 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------
Time: 229ms; Memory: 10MB
I re-ran this command on the module after the MR applied:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml y_branch_menu/
Moving this now to Needs work for investigations.
Thank you!
Hi,
I applied the latest MR to the SpamSpan filter module against 3.x-dev on Drupal 9.5.10 and confirmed the spamspan.js
file has been updated now.
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR to the SpamSpan filter module against 3.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig spamspan/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR and confirmed I'm seeing the 2 issues remaining mentioned above which can be ignored.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig bootstrap_pages/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the latest changes and confirmed that Patch #14 was applied cleanly and no PHPCS errors were found.
Checking patch assets/css/y_branch_menu.css...
Checking patch src/Plugin/Block/BranchMenuBlock.php...
Checking patch y_branch_menu.info.yml...
Checking patch y_branch_menu.module...
Applied patch assets/css/y_branch_menu.css cleanly.
Applied patch src/Plugin/Block/BranchMenuBlock.php cleanly.
Applied patch y_branch_menu.info.yml cleanly.
Applied patch y_branch_menu.module cleanly.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml y_branch_menu/
Please see the attached file for reference.
Moving this again to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed the Patch was applied cleanly to the Menu Link Clone module against 8.x-3.2 on Drupal 9.5.10.
Checking patch tests/src/Functional/MenuLinkCloneTest.php...
Applied patch tests/src/Functional/MenuLinkCloneTest.php cleanly.
And all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig menu_link_clone-3376139/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I'm not sure why I keep seeing the issues in the 8.x-1.x branch on my end, anyhow, I'm moving this now to RTBC since @nitin_lama is not seeing the issues after his testing.
Thank you.
Hi @Anjali Mehta,
Upon reviewing your changes and applied to the Paxton module against 8.x-1.3 on Drupal 9.5.10.
I'm still seeing 1 error:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/paxton/templates/menu--main.html.twig
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
48 | ERROR | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------
Time: 1.92 secs; Memory: 50.01MB
I re-ran this command on the module:
hpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig paxton/
Moving this to Needs work for now for investigations.
Thank you!
Hi,
I applied the latest MR !2 to the Smart Trim Readmore module against 8.x-1.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig smart_trim_readmore/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
The Patch #13 was applied cleanly and no PHPCS errors were shown.
Checking patch README.txt...
Checking patch infogram.info.yml...
Checking patch infogram.install...
Checking patch infogram.libraries.yml...
Checking patch infogram.module...
Checking patch infogram.services.yml...
Checking patch src/Infogram.php...
Checking patch src/Plugin/Filter/FilterInfogram.php...
Checking patch templates/infogram.html.twig...
Applied patch README.txt cleanly.
Applied patch infogram.info.yml cleanly.
Applied patch infogram.install cleanly.
Applied patch infogram.libraries.yml cleanly.
Applied patch infogram.module cleanly.
Applied patch infogram.services.yml cleanly.
Applied patch src/Infogram.php cleanly.
Applied patch src/Plugin/Filter/FilterInfogram.php cleanly.
Applied patch templates/infogram.html.twig cleanly.
Please see the attached file for reference.
Moving this to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed the Patch was applied cleanly to the Search API MeiliSearch module against 1.0.x-dev on Drupal 9.5.10.
Checking patch search_api_meilisearch.module...
Checking patch src/Api/MeiliSearchApiService.php...
Checking patch src/Api/MeiliSearchApiServiceInterface.php...
Checking patch src/Client/MeiliSearchClientFactory.php...
Checking patch src/Plugin/search_api/backend/SearchApiMeiliSearchBackend.php...
Checking patch src/Plugin/search_api/processor/Synonyms.php...
Applied patch search_api_meilisearch.module cleanly.
Applied patch src/Api/MeiliSearchApiService.php cleanly.
Applied patch src/Api/MeiliSearchApiServiceInterface.php cleanly.
Applied patch src/Client/MeiliSearchClientFactory.php cleanly.
Applied patch src/Plugin/search_api/backend/SearchApiMeiliSearchBackend.php cleanly.
Applied patch src/Plugin/search_api/processor/Synonyms.php cleanly.
And all PHPCS errors have been fixed.
I re-ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig search_api_meilisearch/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the MR !1 to the MerlinOne module against 3.2.0 on Drupal 9.5.10 and confirmed only the 1 Warning mentioned by imustakim remains.
I re-ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig merlinone/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
The Patch #44 was applied cleanly and no PHPCS errors were shown.
Checking patch editor_mailto_link.info.yml...
Checking patch editor_mailto_link.module...
Applied patch editor_mailto_link.info.yml cleanly.
Applied patch editor_mailto_link.module cleanly.
Please see the attached file for reference.
Moving this to RTBC.
Thank you!
Hi @MukhtarM,
I reviewed your latest changes and after applying MR !19, there are new warnings found.
Please see the attached file for reference.
Moving this to Needs work for now for investigation.
Thank you!
Hi,
I applied the latest MR !1 to the CiviCRM Field Options module against 8.x-1.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig civicrm_field_options/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed the Patch was applied cleanly to the Feeds Fetcher POST module against 1.2.0 on Drupal 9.5.10.
Checking patch src/Feeds/Fetcher/HttpFetcherPost.php...
Applied patch src/Feeds/Fetcher/HttpFetcherPost.php cleanly.
And no errors were found after running the command below:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig feeds_fetcher_post/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi @roshni27,
I reviewed the changes and confirmed the Patch was applied cleanly to the Dropfort Update module against 2.1.x-dev on Drupal 9.5.10.
Checking patch LICENSE.txt...
Checking patch dropfort_update.module...
Applied patch LICENSE.txt cleanly.
Applied patch dropfort_update.module cleanly.
However, I'm still moving this to Needs Work for now due to pending errors:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/dropfort_update/README.md
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES
-----------------------------------------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 135 characters
15 | WARNING | Line exceeds 80 characters; contains 88 characters
25 | WARNING | Line exceeds 80 characters; contains 319 characters
30 | WARNING | Line exceeds 80 characters; contains 144 characters
32 | WARNING | Line exceeds 80 characters; contains 597 characters
34 | WARNING | Line exceeds 80 characters; contains 237 characters
36 | WARNING | Line exceeds 80 characters; contains 172 characters
39 | WARNING | Line exceeds 80 characters; contains 298 characters
41 | WARNING | Line exceeds 80 characters; contains 117 characters
45 | WARNING | Line exceeds 80 characters; contains 94 characters
47 | WARNING | Line exceeds 80 characters; contains 168 characters
48 | WARNING | Line exceeds 80 characters; contains 167 characters
55 | WARNING | Line exceeds 80 characters; contains 415 characters
57 | WARNING | Line exceeds 80 characters; contains 396 characters
62 | WARNING | Line exceeds 80 characters; contains 307 characters
63 | WARNING | Line exceeds 80 characters; contains 92 characters
-----------------------------------------------------------------------------------------------------
Time: 113ms; Memory: 10MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig dropfort_update
Thank you!
roberttabigue → created an issue.
Hi,
I applied the latest MR !3 to the Paypal Subscriptions module against 2.0.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig paypal_subscriptions/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I applied the latest MR !7 to the Entity Type Clone module against 4.0.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig entity_type_clone/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi @Indrapatil,
After applying the latest MR !2 to the Bootstrap Pages module against 8.x-1.x-dev on Drupal 9.5.10, I'm still seeing several errors:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/bootstrap_pages/CONTRIBUTOR.md
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 24 WARNINGS AFFECTING 24 LINES
----------------------------------------------------------------------------------------------------------
30 | WARNING | Line exceeds 80 characters; contains 113 characters
35 | WARNING | Line exceeds 80 characters; contains 135 characters
36 | WARNING | Line exceeds 80 characters; contains 90 characters
48 | WARNING | Line exceeds 80 characters; contains 236 characters
52 | WARNING | Line exceeds 80 characters; contains 192 characters
60 | WARNING | Line exceeds 80 characters; contains 93 characters
63 | WARNING | Line exceeds 80 characters; contains 427 characters
65 | WARNING | Line exceeds 80 characters; contains 128 characters
70 | WARNING | Line exceeds 80 characters; contains 171 characters
74 | WARNING | Line exceeds 80 characters; contains 115 characters
76 | WARNING | Line exceeds 80 characters; contains 151 characters
77 | WARNING | Line exceeds 80 characters; contains 448 characters
83 | WARNING | Line exceeds 80 characters; contains 99 characters
87 | WARNING | Line exceeds 80 characters; contains 294 characters
100 | WARNING | Line exceeds 80 characters; contains 81 characters
101 | WARNING | Line exceeds 80 characters; contains 101 characters
102 | WARNING | Line exceeds 80 characters; contains 142 characters
103 | WARNING | Line exceeds 80 characters; contains 103 characters
105 | WARNING | Line exceeds 80 characters; contains 137 characters
106 | WARNING | Line exceeds 80 characters; contains 81 characters
112 | WARNING | Line exceeds 80 characters; contains 91 characters
114 | WARNING | Line exceeds 80 characters; contains 100 characters
131 | WARNING | Line exceeds 80 characters; contains 82 characters
135 | WARNING | Line exceeds 80 characters; contains 234 characters
----------------------------------------------------------------------------------------------------------
Time: 500ms; Memory: 10MB
I'm moving this for now to Needs work for investigations.
Thank you!
Hi,
I reviewed the changes and confirmed the Patch was applied cleanly to the Single Page Site module against 2.0.x-dev on Drupal 9.5.10.
Checking patch modules/single_page_site_next_page/src/EventSubscriber/AlterSinglePageSiteOutput.php...
Checking patch single_page_site.module...
Checking patch src/Controller/SinglePageSiteController.php...
Checking patch src/Event/EventSinglePageSiteAlterOutput.php...
Checking patch src/Event/SinglePageSiteEvents.php...
Checking patch src/Form/SinglePageSiteConfigForm.php...
Checking patch src/Manager/SinglePageSiteManager.php...
Applied patch modules/single_page_site_next_page/src/EventSubscriber/AlterSinglePageSiteOutput.php cleanly.
Applied patch single_page_site.module cleanly.
Applied patch src/Controller/SinglePageSiteController.php cleanly.
Applied patch src/Event/EventSinglePageSiteAlterOutput.php cleanly.
Applied patch src/Event/SinglePageSiteEvents.php cleanly.
Applied patch src/Form/SinglePageSiteConfigForm.php cleanly.
Applied patch src/Manager/SinglePageSiteManager.php cleanly.
And all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml single_page_site/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed that Patch #9 was applied cleanly to the Website Services Branch Menu module against 1.0.x-dev on Drupal 9.5.10.
Checking patch assets/css/y_branch_menu.css...
Checking patch src/Plugin/Block/BranchMenuBlock.php...
Checking patch y_branch_menu.info.yml...
Checking patch y_branch_menu.module...
Applied patch assets/css/y_branch_menu.css cleanly.
Applied patch src/Plugin/Block/BranchMenuBlock.php cleanly.
Applied patch y_branch_menu.info.yml cleanly.
Applied patch y_branch_menu.module cleanly.
And all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml y_branch_menu
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
roberttabigue → created an issue.
roberttabigue → created an issue.
roberttabigue → created an issue.
Hi,
I applied the latest MR to the Profile module against 8.x-1.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig profile/
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
roberttabigue → created an issue. See original summary → .
roberttabigue → created an issue.
roberttabigue → created an issue.
roberttabigue → created an issue.
roberttabigue → created an issue.
roberttabigue → created an issue.
roberttabigue → created an issue.
roberttabigue → created an issue.
Hi,
I reviewed the latest changes and confirmed the Patch #10 was applied cleanly.
Checking patch README.txt...
Checking patch infogram.info.yml...
Checking patch infogram.install...
Checking patch infogram.libraries.yml...
Checking patch infogram.module...
Checking patch infogram.services.yml...
Checking patch src/Infogram.php...
Checking patch src/Plugin/Filter/FilterInfogram.php...
Checking patch templates/infogram.html.twig...
Applied patch README.txt cleanly.
Applied patch infogram.info.yml cleanly.
Applied patch infogram.install cleanly.
Applied patch infogram.libraries.yml cleanly.
Applied patch infogram.module cleanly.
Applied patch infogram.services.yml cleanly.
Applied patch src/Infogram.php cleanly.
Applied patch src/Plugin/Filter/FilterInfogram.php cleanly.
Applied patch templates/infogram.html.twig cleanly.
And all PHPCS errors have been fixed.
I re-ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig infogram/
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed that Patch #8 was applied cleanly
Checking patch css/banner.css...
Checking patch css/content_full.css...
Checking patch css/content_one.css...
Checking patch css/navbar.css...
Checking patch curious_chronicles.libraries.yml...
Checking patch curious_chronicles.theme...
Checking patch js/navbar.js...
Applied patch css/banner.css cleanly.
Applied patch css/content_full.css cleanly.
Applied patch css/content_one.css cleanly.
Applied patch css/navbar.css cleanly.
Applied patch curious_chronicles.libraries.yml cleanly.
Applied patch curious_chronicles.theme cleanly.
Applied patch js/navbar.js cleanly.
And all PHPCS errors have been fixed.
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi @sakthi_dev,
Confirmed your Patch was applied cleanly.
Checking patch README.txt...
Checking patch infogram.info.yml...
Checking patch infogram.install...
Checking patch infogram.libraries.yml...
Checking patch infogram.module...
Checking patch infogram.services.yml...
Checking patch src/Infogram.php...
Checking patch src/Plugin/Filter/FilterInfogram.php...
Checking patch templates/infogram.html.twig...
Applied patch README.txt cleanly.
Applied patch infogram.info.yml cleanly.
Applied patch infogram.install cleanly.
Applied patch infogram.libraries.yml cleanly.
Applied patch infogram.module cleanly.
Applied patch infogram.services.yml cleanly.
Applied patch src/Infogram.php cleanly.
Applied patch src/Plugin/Filter/FilterInfogram.php cleanly.
Applied patch templates/infogram.html.twig cleanly.
However, I'm seeing new ones:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/infogram/infogram.module
---------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------
34 | ERROR | [ ] Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
36 | ERROR | [x] Whitespace found at end of line
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/infogram/src/Infogram.php
-----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
26 | ERROR | [x] There must be exactly one blank line before the tags in a doc comment
-----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------
Time: 212ms; Memory: 10MB
Assigning to Needs work for the investigation.
Thank you!
Hi @sourabhjain,
Confirmed no PHPCS errors were shown after applying patch #40.
Checking patch editor_mailto_link.info.yml...
Checking patch editor_mailto_link.module...
Applied patch editor_mailto_link.info.yml cleanly.
Applied patch editor_mailto_link.module cleanly.
Please see the attached file for reference.
Moving this now to RTBC.
Thank you!
Hi @sakthi_dev,
Confirmed your Patch was applied cleanly.
Checking patch README.md...
Checking patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php...
Applied patch README.md cleanly.
Applied patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php cleanly.
However, I'm seeing new PHPCS errors, and the errors for the "line exceeds" have been fixed already.
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/informea_api/src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------------------------
58 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
59 | ERROR | [x] Array indentation error, expected 6 spaces but found 8
-----------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------------------------------
Time: 493ms; Memory: 10MB
Assigning to Needs work for the investigation.
Thank you!
Hi @sonam_sharma,
I reviewed your changes and confirmed the Patch was applied cleanly to the Curious Chronicles module against 1.0.x-dev on Drupal 9.5.10.
Checking patch curious_chronicles.theme...
Applied patch curious_chronicles.theme cleanly.
However, there were still massive PHPCS errors detected.
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/css/navbar.css
-------------------------------------------------------------------------------------------------------------
FOUND 179 ERRORS AFFECTING 179 LINES
-------------------------------------------------------------------------------------------------------------
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
112 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
114 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
115 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
117 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
119 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
120 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
124 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
125 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
126 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
129 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
130 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
131 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
132 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
136 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
137 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
140 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
144 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
145 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
146 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
147 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
148 | ERROR | [x] Blank lines are not allowed in class definitions
149 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
150 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
151 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
152 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
153 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
154 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
155 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
156 | ERROR | [x] Blank lines are not allowed in class definitions
157 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
158 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
159 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
160 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
161 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
162 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
163 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
164 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
165 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
166 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
167 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
168 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
170 | ERROR | [x] Blank lines are not allowed in class definitions
171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
172 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
173 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
174 | ERROR | [x] Blank lines are not allowed in class definitions
175 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
176 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
178 | ERROR | [x] Blank lines are not allowed in class definitions
179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
180 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
181 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
182 | ERROR | [x] Blank lines are not allowed in class definitions
183 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
184 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
185 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
187 | ERROR | [x] Blank lines are not allowed in class definitions
188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
189 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
190 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
191 | ERROR | [x] Blank lines are not allowed in class definitions
192 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
193 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
194 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
200 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
201 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
202 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
203 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
204 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
208 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
209 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
210 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
214 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
219 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
220 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
221 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
222 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
223 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
224 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
225 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
226 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
227 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
231 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
238 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
239 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
240 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
241 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
245 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
246 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
247 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
248 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
249 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
250 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
251 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
255 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
256 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
257 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
258 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
259 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
263 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
264 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
265 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
266 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
267 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
268 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
269 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
270 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
271 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
272 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 179 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/css/banner.css
-------------------------------------------------------------------------------------------------------------
FOUND 78 ERRORS AFFECTING 78 LINES
-------------------------------------------------------------------------------------------------------------
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
10 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
11 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
12 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
23 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
35 | ERROR | [x] Blank lines are not allowed in class definitions
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
44 | ERROR | [ ] More than 2 empty lines are not allowed
45 | ERROR | [ ] More than 2 empty lines are not allowed
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
62 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
63 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
68 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
70 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
74 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
75 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
76 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
80 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
81 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
86 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | [ ] More than 2 empty lines are not allowed
111 | ERROR | [ ] More than 2 empty lines are not allowed
112 | ERROR | [ ] More than 2 empty lines are not allowed
113 | ERROR | [ ] More than 2 empty lines are not allowed
114 | ERROR | [x] Whitespace found at end of line
182 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 72 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/css/content_full.css
-------------------------------------------------------------------------------------------------------------------
FOUND 145 ERRORS AFFECTING 141 LINES
-------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Opening brace should be the last content on the line
1 | ERROR | [ ] Class definition is empty
1 | ERROR | [x] Closing brace of class definition must be on new line
4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
25 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
42 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
52 | ERROR | [x] Whitespace found at end of line
58 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
64 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
70 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
111 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
119 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
120 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
126 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
127 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
129 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
137 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
145 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
146 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
147 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
148 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
149 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
150 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
154 | ERROR | [x] Opening brace should be the last content on the line
154 | ERROR | [ ] Class definition is empty
154 | ERROR | [x] Closing brace of class definition must be on new line
157 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
158 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
159 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
160 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
164 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
168 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
169 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
170 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
175 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
176 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
178 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
187 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
188 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
189 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
190 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
191 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
192 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
193 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
195 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
196 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
197 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
198 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
200 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
201 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
202 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
205 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
206 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
207 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
209 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
210 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
211 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
212 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
214 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
215 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
216 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
218 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
219 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
220 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
228 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
229 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
233 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
234 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
235 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
236 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
237 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
238 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
242 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
243 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
244 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
248 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
249 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
250 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
251 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
252 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
253 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
254 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 143 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/css/content_one.css
------------------------------------------------------------------------------------------------------------------
FOUND 77 ERRORS AFFECTING 77 LINES
------------------------------------------------------------------------------------------------------------------
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
26 | ERROR | [ ] More than 2 empty lines are not allowed
28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
45 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
47 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
49 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
71 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
92 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
93 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
94 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
99 | ERROR | [ ] More than 2 empty lines are not allowed
101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
104 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
106 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
111 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
112 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
116 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
117 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
124 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
125 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
126 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
127 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
132 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
133 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
134 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
137 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 75 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/js/navbar.js
-----------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Whitespace found at end of line
7 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
13 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
23 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
31 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/curious_chronicles.libraries.yml
-------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
14 | ERROR | [x] Expected 1 newline at end of file; 3 found
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/curious_chronicles/curious_chronicles.theme
-----------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
-----------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] There must be no blank lines after the function comment
19 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
57 | ERROR | [x] There must be no blank lines after the function comment
85 | ERROR | [x] Expected 1 blank line after function; 0 found
88 | ERROR | [x] There must be no blank lines after the function comment
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------
Time: 227ms; Memory: 10MB
I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml,css,js curious_chronicles/
Moving this to Needs work for now.
Thank you!
Hi @sakthi_dev
I applied your Patch and confirmed it resolves the other PHPCS errors.
Checking patch README.md...
Checking patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php...
Applied patch README.md cleanly.
Applied patch src/Plugin/Field/FieldFormatter/InformeaCountryIso3Formatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LegislationRelationsFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/LinkWithTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MeetingStatusFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/MultipleValueListTextFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/StringToBooleanFormatter.php cleanly.
However, the errors regarding the "line exceeds" still exist.
Please see the attached file for your reference.
Moving this again to "Needs work".
Thank you!
Hi,
I applied the patch provided by @sourabhjain and confirmed the Patch applied cleanly without affecting the other coding standards.
Checking patch social_auth_wechat.info.yml...
Checking patch social_auth_wechat.install...
Checking patch social_auth_wechat.module...
Checking patch social_auth_wechat.routing.yml...
Checking patch src/Controller/WeChatAuthController.php...
Checking patch src/Form/WeChatAuthSettingsForm.php...
Checking patch src/Plugin/Network/WeChatAuth.php...
Checking patch src/Settings/WeChatAuthSettings.php...
Applied patch social_auth_wechat.info.yml cleanly.
Applied patch social_auth_wechat.install cleanly.
Applied patch social_auth_wechat.module cleanly.
Applied patch social_auth_wechat.routing.yml cleanly.
Applied patch src/Controller/WeChatAuthController.php cleanly.
Applied patch src/Form/WeChatAuthSettingsForm.php cleanly.
Applied patch src/Plugin/Network/WeChatAuth.php cleanly.
Applied patch src/Settings/WeChatAuthSettings.php cleanly.
I attached a screenshot for reference.
Moving this again to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed the Patch was applied cleanly to the IMCE Copy Link module against 8.x-1.x-dev on Drupal 9.5.10.
Checking patch imce_copylink.css...
Checking patch src/Plugin/ImcePlugin/Copylink.php...
Applied patch imce_copylink.css cleanly.
Applied patch src/Plugin/ImcePlugin/Copylink.php cleanly.
And all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig imce_copylink
Please see the attached file for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the changes and confirmed the Patch was applied cleanly.
Checking patch src/Element/EasyQRCodeJs.php...
Applied patch src/Element/EasyQRCodeJs.php cleanly.
And all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig easyqrcodejs
Successfully applied to EasyQRCodeJS module against the 1.0.0 version and with the Drupal core version of 9.5.x.
Please see the attached files for your reference.
I'm moving this now to RTBC.
Thank you!
Hi @ sidharth_soman,
I reviewed your changes and confirmed your Patch applied cleanly to the Infogram charts module against 8.x-1.x-dev.
Checking patch README.txt...
Checking patch infogram.info.yml...
Checking patch infogram.install...
Checking patch infogram.libraries.yml...
Checking patch infogram.module...
Checking patch infogram.services.yml...
Checking patch src/Plugin/Filter/FilterInfogram.php...
Checking patch templates/infogram.html.twig...
Applied patch README.txt cleanly.
Applied patch infogram.info.yml cleanly.
Applied patch infogram.install cleanly.
Applied patch infogram.libraries.yml cleanly.
Applied patch infogram.module cleanly.
Applied patch infogram.services.yml cleanly.
Applied patch src/Plugin/Filter/FilterInfogram.php cleanly.
Applied patch templates/infogram.html.twig cleanly.
However, I'm still seeing some PHPCS errors.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig infogram
Please see the attached file named "phpcsafterpatch.png".
I'm moving this to Needs work for now.
Thank you!
Hi,
I reviewed the changes and confirmed the Patch was applied cleanly.
Checking patch src/JsonToArray.php...
Applied patch src/JsonToArray.php cleanly.
And all PHPCS errors have been fixed.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig twig_json_decode/
Successfully applied to Twig JSON Decode module against 1.0.x-dev version and with the Drupal core version of 9.5.x.
Please see the attached files for reference.
I'm moving this now to RTBC.
Thank you!
Hi,
I reviewed the changes made by @Indrapatil and applied the latest MR to the Flag Block module against 8.x-1.4.
Confirmed it resolves the PHPCS errors.
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig flag_block/
Please see the attached files for reference.
I'm moving this to RTBC.
Thank you!
Hi @Indrapatil,
Kindly provide me your patch or commit your latest MR please, in order for me to verify your fixes.
Moving this again to Needs work.
Thank you.
Hi,
I reviewed the changes of @mrinalini9 and confirmed her patch was applied cleanly.
Checking patch social_auth_wechat.info.yml...
Checking patch social_auth_wechat.install...
Checking patch social_auth_wechat.module...
Checking patch social_auth_wechat.routing.yml...
Checking patch src/Controller/WeChatAuthController.php...
Checking patch src/Form/WeChatAuthSettingsForm.php...
Checking patch src/Plugin/Network/WeChatAuth.php...
Checking patch src/Settings/WeChatAuthSettings.php...
Applied patch social_auth_wechat.info.yml cleanly.
Applied patch social_auth_wechat.install cleanly.
Applied patch social_auth_wechat.module cleanly.
Applied patch social_auth_wechat.routing.yml cleanly.
Applied patch src/Controller/WeChatAuthController.php cleanly.
Applied patch src/Form/WeChatAuthSettingsForm.php cleanly.
Applied patch src/Plugin/Network/WeChatAuth.php cleanly.
Applied patch src/Settings/WeChatAuthSettings.php cleanly.
After running the phpcs command, there are no PHPCS errors anymore.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig social_auth_wechat
Please see attached file for reference and moving this now to RTBC.
Thank you!
Hi,
I reviewed the changes and applied the latest MR to the UIkit Image Formatter against 8.x-1.x-dev.
I ran the command below on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig uikit_image_formatter/
Confirmed it resolves some of the PHPCS errors but I'm still seeing ones:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/uikit_image_formatter/uikit_image_formatter.module
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
91 | WARNING | Unused variable $size.
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/uikit_image_formatter/README.md
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------
26 | WARNING | Line exceeds 80 characters; contains 126 characters
29 | WARNING | Line exceeds 80 characters; contains 82 characters
-----------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/uikit_image_formatter/uikit_image_formatter.theme.inc
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------
130 | WARNING | Line exceeds 80 characters; contains 85 characters
217 | WARNING | Line exceeds 80 characters; contains 81 characters
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/uikit_image_formatter/src/Plugin/Field/FieldFormatter/UikitSlideshow.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
122 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
319 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
----------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/uikit_image_formatter/src/Plugin/Field/FieldFormatter/UikitSlider.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------------------------
130 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
289 | WARNING | Only string literals should be passed to t() where possible
362 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
-------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/uikit_image_formatter/src/Plugin/Field/FieldFormatter/UikitLightbox.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------------------
126 | WARNING | Only string literals should be passed to t() where possible
---------------------------------------------------------------------------------------------------------------------------------------------------
Time: 495ms; Memory: 14MB
I've created a new patch to resolve the PHPCS errors above.
Please review the attached Patch file.
I'm moving this now to Needs review.
Thank you.
Hi @urvashi_vora,
Your patch provided didn't work on my end.
I applied your patch to the Dependent Country, State and City module against 1.0.6.
Ran this command on the module:
curl https://www.drupal.org/files/issues/2023-07-06/coding-standard-fixes_10.patch | git apply -v
Please see the attached file for your reference.
Moving this to Needs work for now.
Thank you!
Hi,
When I applied the latest MR to the Switch Theme against 1.0.x-dev, confirmed it resolves some of the PHPCS errors but not everything, please see:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/switch_theme/CHANGELOG.md
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------
8 | WARNING | Line exceeds 80 characters; contains 99 characters
9 | WARNING | Line exceeds 80 characters; contains 107 characters
10 | WARNING | Line exceeds 80 characters; contains 97 characters
-----------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/switch_theme/README.md
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
34 | WARNING | Line exceeds 80 characters; contains 105 characters
--------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/switch_theme/src/Form/DeleteForm.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
11 | ERROR | Doc comment is empty
----------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/switch_theme/src/Form/EditForm.php
--------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------
82 | ERROR | If there is no return value for a function, there must not be a @return tag.
82 | ERROR | Description for the @return value is missing
85 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
86 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
117 | ERROR | Description for the @return value is missing
124 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
125 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/switch_theme/src/SwitchthemeManagerInterface.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------
5 | ERROR | Doc comment is empty
13 | ERROR | Description for the @return value is missing
20 | ERROR | Description for the @return value is missing
27 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/switch_theme/src/Controller/SwitchthemeController.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
46 | ERROR | Description for the @return value is missing
---------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/switch_theme/src/Theme/ThemeNegotiator.php
----------------------------------------------------------------------------------------------------------------------
FOUND 13 ERRORS AND 8 WARNINGS AFFECTING 21 LINES
----------------------------------------------------------------------------------------------------------------------
9 | ERROR | Doc comment is empty
25 | ERROR | The @var tag must be the first tag in a member variable comment
49 | WARNING | Line exceeds 80 characters; contains 111 characters
54 | ERROR | Description for the @return value is missing
58 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
59 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
64 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
65 | WARNING | Line exceeds 80 characters; contains 94 characters
68 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
72 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
77 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
78 | WARNING | Line exceeds 80 characters; contains 96 characters
82 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
84 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
88 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
92 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
97 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
98 | WARNING | Line exceeds 80 characters; contains 119 characters
107 | ERROR | Inline doc block comments are not allowed; use "/* Comment */" or "// Comment" instead
108 | WARNING | Line exceeds 80 characters; contains 104 characters
119 | ERROR | Description for the @return value is missing
----------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/switch_theme/src/SwitchthemeManager.php
-------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------
19 | ERROR | Missing short description in doc comment
29 | ERROR | Description for the @return value is missing
63 | ERROR | Description for the @return value is missing
84 | ERROR | Description for the @return value is missing
-------------------------------------------------------------------------------------------------------------------
Time: 187ms; Memory: 10MB
I run this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig switch_theme/
I'm moving this to Needs work for now.
Thank you.
Hi,
I reviewed the changes and applied the latest MR to the Linkychecker module against 2.2.x-dev, confirmed it resolves the t() calls errors.
However, I'm still seeing some PHPCS errors:
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/linkychecker/linkychecker.module
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
13 | WARNING | [x] Unused use statement
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/linkychecker/src/Form/LinkyCheckerRecheckForm.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
90 | WARNING | Unused variable $severity.
-----------------------------------------------------------------------------------------------------------------------------
FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/linkychecker/src/Form/LinkyCheckerLinkyCheckForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
105 | ERROR | The array declaration extends to column 105 (the limit is 80). The array content should be split up over multiple lines
131 | WARNING | Unused variable $severity.
-----------------------------------------------------------------------------------------------------------------------------------------
Time: 383ms; Memory: 10MB
I ran this command:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig linkychecker/
Since this ticket is intended to fix the t() calls only, I'm moving this now to RTBC.
Please see the attached files for your reference.
Thank you!
Hi @indrapatil,
I reviewed your changes and applied the latest MR to the CMRF Form Processor module against 2.0.x-dev, and confirmed not resolved all the PHPCS errors.
Please see the attached file "phpcsafterpatch.png" for your reference.
I'm moving this to Needs work for now.
Thank you.
Hi,
I have created a patch to fix the issues reported by phpcs.
Please review.
Thank you!