Fix the issues reported by phpcs

!12 MR created, Please Review.

checked above MR it fixed the PHPCS issue

-    // Process TWIG
+    // Process TWIG.
     $twig_service = \Drupal::service('twig');

TWIG is misspelled.
Instead of fixing that comment, it should be better to remove it, as it just describes what is already clear from the code.

-    if ($target_type !== 'user' || !in_array($selection_handler, ['default:user', 'default'], TRUE)) {
+    if ($target_type !== 'user' || !in_array($selection_handler, [
+      'default:user', 'default',
+    ], TRUE)) {
       return parent::handleAutocomplete($request, $target_type, $selection_handler, $selection_settings_key);
     }

The Drupal coding standards say that control structures are written in a single line.
That code is formatted as per PSR12 coding standards, not the coding standards followed by Drupal.

Thanks for reviewing, recently mentioned issues are fixed in the following patch https://www.drupal.org/files/issues/2023-07-07/t_calls_should_be_avoided-3359562-11.patch. Thread - https://www.drupal.org/project/realname/issues/3359562#comment-15140770 📌 t() should not be used in test classes Needs review

IMO attaching the same patch to this thread would be redundant since it is already available in the mentioned thread.

It is the other issue that is doing off-topic changes. If I open an issue to avoid calls to t() in classes, I cannot then fix all the coding standards issues reported by a tool, or I would change the topic of the issue.

I also not get any error about invalid end-of-line characters, when I run PHP_CodeSniffer.

keshav.k → made their first commit to this issue’s fork.

I have scanned the module with the command

../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml  modules/custom/realname

and fixed all pending issues.

Now we can review and merge it.

Thank you.

Hi,

I applied the latest MR !12 to the Real Name module against 2.x-dev on Drupal 9.5.10 and confirmed all PHPCS errors have been fixed.

I ran this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml realname/

Please see the attached files for reference.

I'm moving this now to RTBC.

Thank you!

Hello, I cloned the repository, checked out to the branch '3352347-fix-the-issues', ran the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml. Found one error remaining:

FILE: C:\Users\YASHASWI\OneDrive\Desktop\Contrib\realname\src\Controller\Realnam
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
 24 | ERROR | The array declaration extends to column 92 (the limit is 80). The The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------------

Hi, @Yashaswi18, can you please provide steps to reproduce these errors you found?

I have also applied the latest MR !12 and checked out to the branch '3352347-fix-the-issues'.
I scanned the module with the command:

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/realname

and confirmed all PHPCS errors have been fixed.

Thank you

Applied the latest MR !12 and checked out to the branch '3352347-fix-the-issues'.
I have scanned module with this command :

vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/realname

all PHPCS errors have been fixed.
screenshot is attached for reference

Moving this to RTBC