Hi,
I have applied the latest MR !2 and checkedout to 'online_food_blog-3399814' branch
I found that the menu is not styled properly, I'm attaching a screenshot for reference.
Applied the latest MR !12 and checked out to the branch '3352347-fix-the-issues'.
I have scanned module with this command :
vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/realname
all PHPCS errors have been fixed.
screenshot is attached for reference
Moving this to RTBC
Hi, @Yashaswi18, can you please provide steps to reproduce these errors you found?
I have also applied the latest MR !12 and checked out to the branch '3352347-fix-the-issues'.
I scanned the module with the command:
vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml modules/contrib/realname
and confirmed all PHPCS errors have been fixed.
Thank you
Hi,
I have Applied the MR !4. and ran the command :
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml profile_manager/
Found no phpcs issues or warnings.
Moving to RTBC
I have applied this patch and got this error :
error: patch failed: tara.theme:108
error: tara.theme: patch does not apply
Checking patch theme-settings.php...
error: while searching for:
* Custom setting for Tara theme.
*/
function tara_form_system_theme_settings_alter(&$form, FormStateInterface &$form_state, $form_id = NULL) {
$img_path = $GLOBALS['base_url'] . '/' . drupal_get_path('theme', 'tara') . '/images/tarapro.jpg';
$img = '<img src="'.$img_path.'" alt="image" />';
$form['tara'] = [
'#type' => 'vertical_tabs',
error: patch failed: theme-settings.php:5
error: theme-settings.php: patch does not apply
I have created a patch to fix this issue attached below, please review
Screenshot with existing patch:
Screenshot with the patch which i have created :
I have applied your patch, and this is working fine,
moving to RTBC .
Hi @aayushmankotia,
I have applied your patch #2 and ran phpcs command
../../../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig ../entity_reference_purger/
.
I assure you that this patch is fixing all the errors. Screenshot is attached for your reference.
Also moving status to RTBC.
Hi @aayushDrupal ,
i have applied merge request !3
These are the steps I followed:
1. Took clone from git version 2.0.1 in drupal 9.5.10
2. Ran this command:
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig modules/contrib/trumba
3. Applied this MR !3 and again ran phpcs command.
I found no error. Moving it to RTBC.