Fix the issue reported by phpcs

Issue created by @jahanaraS
Status changed to Needs review 10 months ago3:23pm 25 January 2024
Comment 10 months ago →
🇮🇳India jahanaraS Bangalore
Fixed issues reported by PHPcs
attached patch and the screenshots.
Issue was unassigned.
Comment 10 months ago →
🇮🇳India jahanaraS Bangalore
Status changed to Needs work 10 months ago11:13am 29 January 2024

I applied your patch #2 and there are many PHPCS issues that PHPCS flagged.

➜  profile_manager git:(1.0.x)  curl https://www.drupal.org/files/issues/2024-01-25/fix-php-issue-3416993-10.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 24267  100 24267    0     0  45231      0 --:--:-- --:--:-- --:--:-- 45786
patching file 'js/closeOnHome.js'
patching file 'js/toolbar.js'
patching file 'js/toolbar.menu.js'
patching file profile_manager.module
patching file 'src/Annotation/ProfileManager.php'
patching file 'src/Annotation/ProfileManagerDefinition.php'
patching file 'src/Annotation/ProfileManagerRoute.php'
patching file 'src/Commands/ProfileConfigCommands.php'
patching file 'src/EventSubscriber/HandleOptionalModulesCoreExtensions.php'
patching file 'src/EventSubscriber/MergeOptionalModuleConfigPartials.php'
patching file 'src/Form/ProfileManagerInstallOptionalModulesForm.php'
patching file 'src/Form/ProfileManagerModulesForm.php'
patching file 'src/Form/ProfileManagerSettingsForm.php'
patching file 'src/OptionalModulesTrait.php'
patching file 'src/Plugin/ProfileManager/ProfileManagerBase.php'
patching file 'src/ProfileManagerInterface.php'
patching file 'src/ProfileManagerPluginManager.php'
patching file 'src/Routing/RouteSubscriber.php'
patching file 'src/ToolbarController.php'
➜  profile_manager git:(1.0.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml profile_manager

FILE: ...cts/d9/d9-local/web/modules/contrib/profile_manager/profile_manager.module
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 5 WARNINGS AFFECTING 9 LINES
--------------------------------------------------------------------------------
   3 | ERROR   | [ ] Missing short description in doc comment
  15 | WARNING | [x] Unused use statement
  16 | WARNING | [x] Unused use statement
  17 | WARNING | [x] Unused use statement
  18 | WARNING | [x] Unused use statement
  29 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
 146 | ERROR   | [ ] Doc comment is empty
 171 | ERROR   | [ ] Doc comment is empty
 180 | ERROR   | [ ] Doc comment is empty
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../d9-local/web/modules/contrib/profile_manager/src/OptionalModulesTrait.php
--------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
--------------------------------------------------------------------------------
  17 | ERROR | Missing short description in doc comment
  43 | ERROR | Missing short description in doc comment
  44 | ERROR | Missing parameter comment
  45 | ERROR | Missing parameter comment
  46 | ERROR | Missing parameter comment
  47 | ERROR | Missing parameter comment
  59 | ERROR | Description for the @return value is missing
  74 | ERROR | Doc comment is empty
 108 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------


FILE: ...web/modules/contrib/profile_manager/src/Form/ProfileManagerModulesForm.php
--------------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 11 LINES
--------------------------------------------------------------------------------
  13 | ERROR   | Doc comment is empty
  32 | ERROR   | Missing short description in doc comment
  37 | ERROR   | Doc comment is empty
  49 | ERROR   | Doc comment is empty
  73 | ERROR   | Doc comment is empty
 100 | ERROR   | Doc comment is empty
 106 | WARNING | Unused variable $package.
 115 | ERROR   | Doc comment is empty
 125 | ERROR   | Doc comment is empty
 137 | ERROR   | Doc comment is empty
 162 | ERROR   | Doc comment is empty
--------------------------------------------------------------------------------


FILE: ...eb/modules/contrib/profile_manager/src/Form/ProfileManagerSettingsForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 9 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------


FILE: ...trib/profile_manager/src/Form/ProfileManagerInstallOptionalModulesForm.php
--------------------------------------------------------------------------------
FOUND 14 ERRORS AFFECTING 14 LINES
--------------------------------------------------------------------------------
  13 | ERROR | Doc comment is empty
  46 | ERROR | Doc comment is empty
  56 | ERROR | Missing short description in doc comment
  57 | ERROR | Missing parameter comment
  70 | ERROR | Missing short description in doc comment
  71 | ERROR | Description for the @return value is missing
  77 | ERROR | Missing short description in doc comment
  78 | ERROR | Missing parameter comment
  79 | ERROR | Missing parameter comment
  81 | ERROR | Description for the @return value is missing
 114 | ERROR | Missing short description in doc comment
 115 | ERROR | Missing parameter comment
 116 | ERROR | Missing parameter comment
 118 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------


FILE: ...al/web/modules/contrib/profile_manager/src/ProfileManagerPluginManager.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
--------------------------------------------------------------------------------
 10 | ERROR   | Doc comment is empty
 15 | ERROR   | Missing short description in doc comment
 20 | ERROR   | Doc comment is empty
 31 | ERROR   | Doc comment is empty
 35 | WARNING | Line exceeds 80 characters; contains 98 characters
 53 | ERROR   | Doc comment is empty
--------------------------------------------------------------------------------


FILE: ...modules/contrib/profile_manager/src/Plugin/ProfileManager/SiteSettings.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
--------------------------------------------------------------------------------
  7 | ERROR   | [ ] Missing short description in doc comment
 18 | ERROR   | [ ] Missing short description in doc comment
 19 | ERROR   | [ ] Description for the @return value is missing
 25 | ERROR   | [ ] Missing short description in doc comment
 26 | ERROR   | [ ] Missing parameter comment
 28 | ERROR   | [ ] Description for the @return value is missing
 32 | WARNING | [x] A comma should follow the last multiline array item. Found:
    |         |     'access profile manager site settings'
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ules/contrib/profile_manager/src/Plugin/ProfileManager/OptionalModules.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------


FILE: .../modules/contrib/profile_manager/src/Plugin/ProfileManager/SiteSection.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 7 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------


FILE: ...s/contrib/profile_manager/src/Plugin/ProfileManager/ProfileManagerBase.php
--------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
--------------------------------------------------------------------------------
   9 | ERROR | Doc comment is empty
  92 | ERROR | Description for the @return value is missing
 105 | ERROR | Description for the @return value is missing
 121 | ERROR | Description for the @return value is missing
 136 | ERROR | Description for the @return value is missing
 151 | ERROR | Description for the @return value is missing
 165 | ERROR | Description for the @return value is missing
 179 | ERROR | Description for the @return value is missing
 193 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------


FILE: ...web/modules/contrib/profile_manager/src/Annotation/ProfileManagerRoute.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
--------------------------------------------------------------------------------
  6 | WARNING | [x] Unused use statement
  9 | ERROR   | [ ] Missing short description in doc comment
 28 | ERROR   | [ ] Missing short description in doc comment
 33 | ERROR   | [ ] Doc comment is empty
 43 | ERROR   | [ ] Doc comment is empty
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ocal/web/modules/contrib/profile_manager/src/Annotation/ProfileManager.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  7 | ERROR | Missing short description in doc comment
 12 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------


FILE: ...odules/contrib/profile_manager/src/Annotation/ProfileManagerDefinition.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
--------------------------------------------------------------------------------
   8 | WARNING | [x] Unused use statement
  10 | ERROR   | [ ] Doc comment is empty
  68 | ERROR   | [ ] Missing short description in doc comment
  69 | ERROR   | [ ] Description for the @return value is missing
  99 | ERROR   | [ ] Missing short description in doc comment
 100 | ERROR   | [ ] Description for the @return value is missing
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: .../d9/d9-local/web/modules/contrib/profile_manager/src/ToolbarController.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 8 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------


FILE: ...web/modules/contrib/profile_manager/src/Commands/ProfileConfigCommands.php
--------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 8 LINES
--------------------------------------------------------------------------------
  59 | ERROR | Doc comment is empty
 155 | ERROR | Doc comment is empty
 171 | ERROR | Doc comment is empty
 190 | ERROR | Doc comment is empty
 197 | ERROR | Doc comment is empty
 216 | ERROR | Missing parameter comment
 216 | ERROR | Missing parameter type
 217 | ERROR | Missing parameter comment
 218 | ERROR | Missing parameter comment
--------------------------------------------------------------------------------


FILE: ...-local/web/modules/contrib/profile_manager/src/Routing/RouteSubscriber.php
--------------------------------------------------------------------------------
FOUND 9 ERRORS AND 3 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------
  11 | WARNING | [x] Unused use statement
  52 | ERROR   | [ ] Parameter $link_manager is not described in comment
  52 | ERROR   | [ ] Parameter $factory is not described in comment
  99 | ERROR   | [ ] Doc comment is empty
 109 | ERROR   | [ ] Doc comment is empty
 120 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'access profile manager overview'
 138 | ERROR   | [ ] Doc comment is empty
 149 | WARNING | [x] A comma should follow the last multiline array item.
     |         |     Found: 'access profile manager modules'
 155 | ERROR   | [ ] Doc comment is empty
 169 | ERROR   | [ ] Doc comment is empty
 208 | ERROR   | [ ] Doc comment is empty
 218 | ERROR   | [ ] Doc comment is empty
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...rofile_manager/src/EventSubscriber/HandleOptionalModulesCoreExtensions.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
 10 | WARNING | [x] Unused use statement
 31 | ERROR   | [ ] The array declaration extends to column 82 (the limit is
    |         |     80). The array content should be split up over multiple
    |         |     lines
 32 | ERROR   | [ ] The array declaration extends to column 82 (the limit is
    |         |     80). The array content should be split up over multiple
    |         |     lines
 83 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters
 86 | ERROR   | [ ] The array declaration extends to column 100 (the limit is
    |         |     80). The array content should be split up over multiple
    |         |     lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...contrib/profile_manager/src/EventSubscriber/OptionalModuleConfigImport.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 25 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 62 | ERROR | The array declaration extends to column 102 (the limit is 80).
    |       | The array content should be split up over multiple lines
--------------------------------------------------------------------------------


FILE: .../profile_manager/src/EventSubscriber/MergeOptionalModuleConfigPartials.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
 32 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 33 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 86 | ERROR | Missing parameter comment
 87 | ERROR | Missing parameter comment
 89 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------


FILE: ...-local/web/modules/contrib/profile_manager/src/ProfileManagerInterface.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
  9 | ERROR | Doc comment is empty
 14 | ERROR | Doc comment is empty
 19 | ERROR | Doc comment is empty
 24 | ERROR | Doc comment is empty
 29 | ERROR | Doc comment is empty
 34 | ERROR | Doc comment is empty
--------------------------------------------------------------------------------

Time: 706ms; Memory: 12MB

➜  contrib git:(master) ✗

First commit to issue fork.
Assigned to Esha_Kundu
Comment 10 months ago →
Esha_Kundu
I'm working on it.
Issue was unassigned.
Status changed to Needs review 10 months ago7:17am 1 February 2024
Comment 10 months ago →
Esha_Kundu
I have fixed the issues reported by PHPCS.
Attached patch.
Status changed to Needs work 10 months ago9:01am 2 February 2024

Comment 10 months ago →

🇵🇭Philippines clarkssquared

I applied the patch #7 and these are the PHPCS issues that remains

➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml profile_manager 

FILE: ...web/modules/contrib/profile_manager/src/Form/ProfileManagerModulesForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 108 | WARNING | Unused variable $package.
--------------------------------------------------------------------------------


FILE: ...rofile_manager/src/EventSubscriber/HandleOptionalModulesCoreExtensions.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 30 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 31 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 86 | ERROR | The array declaration extends to column 100 (the limit is 80).
    |       | The array content should be split up over multiple lines
--------------------------------------------------------------------------------


FILE: ...contrib/profile_manager/src/EventSubscriber/OptionalModuleConfigImport.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 25 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 62 | ERROR | The array declaration extends to column 102 (the limit is 80).
    |       | The array content should be split up over multiple lines
--------------------------------------------------------------------------------


FILE: .../profile_manager/src/EventSubscriber/MergeOptionalModuleConfigPartials.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 32 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 33 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
--------------------------------------------------------------------------------

Time: 649ms; Memory: 12MB

➜  contrib git:(master) ✗

This is the full snippet of PHPCS testing I applied patch #7

➜  profile_manager git:(1.0.x) curl https://www.drupal.org/files/issues/2024-02-01/fix-php-issue-3416993-11_0.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 44140  100 44140    0     0  79703      0 --:--:-- --:--:-- --:--:-- 80400
patching file 'js/closeOnHome.js'
patching file 'js/toolbar.js'
patching file 'js/toolbar.menu.js'
patching file profile_manager.module
patching file 'src/Annotation/ProfileManager.php'
patching file 'src/Annotation/ProfileManagerDefinition.php'
patching file 'src/Annotation/ProfileManagerRoute.php'
patching file 'src/Commands/ProfileConfigCommands.php'
patching file 'src/EventSubscriber/HandleOptionalModulesCoreExtensions.php'
patching file 'src/EventSubscriber/MergeOptionalModuleConfigPartials.php'
patching file 'src/Form/ProfileManagerInstallOptionalModulesForm.php'
patching file 'src/Form/ProfileManagerModulesForm.php'
patching file 'src/Form/ProfileManagerSettingsForm.php'
patching file 'src/OptionalModulesTrait.php'
patching file 'src/Plugin/ProfileManager/OptionalModules.php'
patching file 'src/Plugin/ProfileManager/ProfileManagerBase.php'
patching file 'src/Plugin/ProfileManager/SiteSection.php'
patching file 'src/Plugin/ProfileManager/SiteSettings.php'
patching file 'src/ProfileManagerInterface.php'
patching file 'src/ProfileManagerPluginManager.php'
patching file 'src/Routing/RouteSubscriber.php'
patching file 'src/ToolbarController.php'
➜  profile_manager git:(1.0.x) ✗ ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml profile_manager 

FILE: ...web/modules/contrib/profile_manager/src/Form/ProfileManagerModulesForm.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 108 | WARNING | Unused variable $package.
--------------------------------------------------------------------------------


FILE: ...rofile_manager/src/EventSubscriber/HandleOptionalModulesCoreExtensions.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 30 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 31 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 86 | ERROR | The array declaration extends to column 100 (the limit is 80).
    |       | The array content should be split up over multiple lines
--------------------------------------------------------------------------------


FILE: ...contrib/profile_manager/src/EventSubscriber/OptionalModuleConfigImport.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 25 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 62 | ERROR | The array declaration extends to column 102 (the limit is 80).
    |       | The array content should be split up over multiple lines
--------------------------------------------------------------------------------


FILE: .../profile_manager/src/EventSubscriber/MergeOptionalModuleConfigPartials.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 32 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
 33 | ERROR | The array declaration extends to column 82 (the limit is 80). The
    |       | array content should be split up over multiple lines
--------------------------------------------------------------------------------

Time: 649ms; Memory: 12MB

➜  contrib git:(master) ✗

Status changed to Needs review 10 months ago10:08am 2 February 2024
Comment 10 months ago →
Esha_Kundu
Fixed the phpcs issues reported #8.
Please review the attached patch.

Comment 10 months ago →

🇮🇳India Yashaswi18

Hello, the patch provided in #9 is applying successfully.
Ran the command phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml profile_manager/ again and there are no issues remaining.

git apply fix-php-issue-3416993-12.patch -v
Checking patch js/closeOnHome.js...
Checking patch js/toolbar.js...
Checking patch js/toolbar.menu.js...
Checking patch profile_manager.module...
Checking patch src/Annotation/ProfileManager.php...
Checking patch src/Annotation/ProfileManagerDefinition.php...
Checking patch src/Annotation/ProfileManagerRoute.php...
Checking patch src/Commands/ProfileConfigCommands.php...
Checking patch src/EventSubscriber/HandleOptionalModulesCoreExtensions.php...
Checking patch src/EventSubscriber/MergeOptionalModuleConfigPartials.php...
Checking patch src/EventSubscriber/OptionalModuleConfigImport.php...
Checking patch src/Form/ProfileManagerInstallOptionalModulesForm.php...
Checking patch src/Form/ProfileManagerModulesForm.php...
Checking patch src/Form/ProfileManagerSettingsForm.php...
Checking patch src/OptionalModulesTrait.php...
Checking patch src/Plugin/ProfileManager/OptionalModules.php...
Checking patch src/Plugin/ProfileManager/ProfileManagerBase.php...
Checking patch src/Plugin/ProfileManager/SiteSection.php...
Checking patch src/Plugin/ProfileManager/SiteSettings.php...
Checking patch src/ProfileManagerInterface.php...
Checking patch src/ProfileManagerPluginManager.php...
Checking patch src/Routing/RouteSubscriber.php...
Checking patch src/ToolbarController.php...
Applied patch js/closeOnHome.js cleanly.
Applied patch js/toolbar.js cleanly.
Applied patch js/toolbar.menu.js cleanly.
Applied patch profile_manager.module cleanly.
Applied patch src/Annotation/ProfileManager.php cleanly.
Applied patch src/Annotation/ProfileManagerDefinition.php cleanly.
Applied patch src/Annotation/ProfileManagerRoute.php cleanly.
Applied patch src/Commands/ProfileConfigCommands.php cleanly.
Applied patch src/EventSubscriber/HandleOptionalModulesCoreExtensions.php cleanly.
Applied patch src/EventSubscriber/MergeOptionalModuleConfigPartials.php cleanly.
Applied patch src/EventSubscriber/OptionalModuleConfigImport.php cleanly.
Applied patch src/Form/ProfileManagerInstallOptionalModulesForm.php cleanly.
Applied patch src/Form/ProfileManagerModulesForm.php cleanly.
Applied patch src/Form/ProfileManagerSettingsForm.php cleanly.
Applied patch src/OptionalModulesTrait.php cleanly.
Applied patch src/Plugin/ProfileManager/OptionalModules.php cleanly.
Applied patch src/Plugin/ProfileManager/ProfileManagerBase.php cleanly.
Applied patch src/Plugin/ProfileManager/SiteSection.php cleanly.
Applied patch src/Plugin/ProfileManager/SiteSettings.php cleanly.
Applied patch src/ProfileManagerInterface.php cleanly.
Applied patch src/ProfileManagerPluginManager.php cleanly.
Applied patch src/Routing/RouteSubscriber.php cleanly.
Applied patch src/ToolbarController.php cleanly.

Merge request !4Issue #3416993: Fix the issue reported by phpcs → (Open) created by Esha_Kundu
Comment 10 months ago →
Esha_Kundu
I have created the MR for fixing the phpcs.
merge request !4
Added 1 commit

12665e98 - Issue #3416993: Fix the issue reported by phpcs
Comment 9 months ago →
🇮🇳India pray_12
Hi,
Applied the MR !4. Found no phpcs issues or warnings.
Thank you!!
Comment 8 months ago →
🇮🇳India Yashaswi18
Hello, checked out to the branch '3416993-fix-the-issue' and ran the command phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig profile_manager/. Found no errors or warnings remaining.
Status changed to RTBC 8 months ago8:34am 2 April 2024
Comment 8 months ago →
🇮🇳India Nitinkumar_7
Hi,
I have Applied the MR !4. and ran the command :
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml profile_manager/

Found no phpcs issues or warnings.
Moving to RTBC
Status changed to Closed: won't fix 18 days ago8:28pm 28 October 2024
Comment 18 days ago →
🇺🇸United States Tim Bozeman

Fix the issue reported by phpcs

Problem/Motivation

Merge Requests

!4Fix the issue reported by phpcs
Open

Comments & Activities

Fix the issue reported by phpcs

Problem/Motivation

Merge Requests

!4Fix the issue reported by phpcsOpen

Comments & Activities

!4Fix the issue reported by phpcs
Open