tonypaulbarker → credited akram khan → .
Checked MR #2 after removing delete() function from OgMembershipType.php module will successfully uninstall. Attached snap for the reference.
RTBC +1
Verified #2 error is resolved. Added both before and after patch snap for the reference.
while reviewing this issue observed some TypeError issue as well. so i added updated patch for that and it resolve the issue now.
I reviewed the patch and it's resolved the issue. Before patch when i try to extend the module it gives Error and after applying patch the module got enabled successfully. Additionally, I have attached before and after state screenshots for reference.
I reviewed the patch and it's resolved the issue. Before patch when i try to extend the module it gives Error and after applying patch the module got enabled successfully. Additionally, I have attached before and after state screenshots for reference.
I reviewed the patch and it's resolved the issue. Before patch when i try to access the (path: /admin/group/group-hierarchy) it gives TypeError and after applying patch the page appear successfully. Additionally, I have attached before and after state screenshots for reference.
I reviewed the above patch and it's resolved the issue. Before patch when i try to extend the module it gives fatal error and after applying patch the module enabled successfully. Additionally, I have attached before and after state screenshots for reference.
I reviewed the patch and it's resolved the issue. Before patch when i try to extend the module it give fatal error and after applying patch the module got enabled successfully. Additionally, I have attached before and after state screenshots for reference.
created patch for this
I reviewed the above patch and it's resolved the issue. when i try to submit the webform before applying patch it gives "TypeError" and after applying the patch error got resolved and webform got submitted successfully. Additionally, I have attached before and after state screenshots for reference.
I reviewed the above patch #5 and it's resolved the issue. Additionally, I have attached before and after state screenshots for reference
i tried in my local the patch doesn't work for 10 version facing this issue adding Screen shot for reference so moving to NW.
I reviewed the MR and it's resolved the issue. Additionally, I have attached before and after state screenshots for reference
I reviewed the patch and it's resolved the issue. Additionally, I have attached before and after state screenshots for reference
added updated patch address #3
I reviewed the patch and it's resolved the issue. Additionally, I have attached before and after state screenshots for reference
I reviewed the MR and it's resolved the issue. Additionally, I have attached before and after state screenshots for reference
Replace README.txt with README.md
added updated patch and addressed #17
added a patch and To improve the documentation for the FieldStorageConfig class, add a more detailed description of what the translatable property does and what it means when it's set to FALSE.
addressed #9
addressed #4
addressed #41
hi @apaderno then is it okey to keep "Use null coalesce operator instead of ternary operator." error message ?
Addressed #4
added updated patch and it fixed remaining issue
added updated patch now it remove all the remaining issue
try to fixed CCF #112 and remove the second parameter from the expectException() method call and for custom error message, i used the expectExceptionMessage().
address #2 now it remove all phpcs issue
still issues remaining so move to NW
FILE: /Users/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/prismjs/src/Controller/PrismJsPreview.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
90 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------
Time: 295ms; Memory: 12MB
still issue remaining so move to NW
FILE: ...s/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/tests/src/Kernel/LocaleStringTest.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
37 | WARNING | Possible useless method overriding detected
44 | WARNING | Possible useless method overriding detected
------------------------------------------------------------------------------------------------------------------------------
FILE: ...khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/tests/src/Kernel/ExtendedLocaleStringTest.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
115 | WARNING | Unused variable $source2.
------------------------------------------------------------------------------------------------------------------------------
FILE: ...n/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/modules/locale_extend_ns/locale_extend_ns.module
------------------------------------------------------------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 22 LINES
------------------------------------------------------------------------------------------------------------------------------
45 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
56 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
67 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
78 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
89 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
100 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
111 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
122 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
133 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
144 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
155 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
166 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
177 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
188 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
199 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
210 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
221 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
232 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
243 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
254 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
265 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
276 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
------------------------------------------------------------------------------------------------------------------------------
FILE: ...han/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/modules/locale_extend_t/locale_extend_t.module
------------------------------------------------------------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 22 LINES
------------------------------------------------------------------------------------------------------------------------------
40 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_bg" but expected
| | "locale_extend_t_t_bg"
46 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_cs" but expected
| | "locale_extend_t_t_cs"
52 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_da" but expected
| | "locale_extend_t_t_da"
58 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_de" but expected
| | "locale_extend_t_t_de"
64 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_et" but expected
| | "locale_extend_t_t_et"
70 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_el" but expected
| | "locale_extend_t_t_el"
76 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_es" but expected
| | "locale_extend_t_t_es"
82 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_fi" but expected
| | "locale_extend_t_t_fi"
88 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_fr" but expected
| | "locale_extend_t_t_fr"
94 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_hr" but expected
| | "locale_extend_t_t_hr"
100 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_hu" but expected
| | "locale_extend_t_t_hu"
106 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_is" but expected
| | "locale_extend_t_t_is"
112 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_it" but expected
| | "locale_extend_t_t_it"
118 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_lt" but expected
| | "locale_extend_t_t_lt"
124 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_lv" but expected
| | "locale_extend_t_t_lv"
130 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_pl" but expected
| | "locale_extend_t_t_pl"
136 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_pt" but expected
| | "locale_extend_t_t_pt"
142 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_ro" but expected
| | "locale_extend_t_t_ro"
148 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_ru" but expected
| | "locale_extend_t_t_ru"
154 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_sk" but expected
| | "locale_extend_t_t_sk"
160 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_sl" but expected
| | "locale_extend_t_t_sl"
166 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_sv" but expected
| | "locale_extend_t_t_sv"
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/src/Translation.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------
47 | ERROR | Class property $source_langcode should use lowerCamel naming without underscores
167 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------------------------
FILE: /Users/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/src/Translate.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
52 | WARNING | [ ] Only string literals should be passed to t() where possible
82 | ERROR | [x] list(...) is forbidden, use [...] instead.
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
FILE: ...rs/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/src/Service/ExtendedLocaleLookup.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
24 | ERROR | Class property $source_langcode should use lowerCamel naming without underscores
------------------------------------------------------------------------------------------------------------------------------
FILE: /Users/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/src/StringTranslationTrait.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------
39 | ERROR | Class property $source_langcode should use lowerCamel naming without underscores
46 | WARNING | Only string literals should be passed to t() where possible
----------------------------------------------------------------------------------------------------------------------------
Time: 572ms; Memory: 10MB
address #8
added updated patch address #9 and #10 both
added updated patch try to fix CCF #45. modifies the validateExposed() function to use a local variable $form_element to hold the field element that needs to be set with the form error message. It also changes the if-else block to use the null coalesce operator instead of an if-else block for brevity.
hi @apaderno but if i change it to one-line code. it'll give phpcs warning
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
34 | WARNING | Line exceeds 80 characters; contains 85 characters
-------------------------------------------------------------------------------------------------------
added updated patch and address #4 and it fixed all PHPCS issues
fixed CCF #4
fixed CCF #21
made changes now updated comment is more accurate and clarifies that the getQuery() method returns a query object for loading entity IDs from the storage
fixed CCF #76
added updated patch and fixed CCF of #75
Addressed #73 The updated code inserts a row with a big value for wid and another row without a value for wid. It then tests that the first row exists with the expected value for wid and that the second row exists with the expected auto-incremented value for wid.
added updated patch and addressed #71
added updated patch to fix CCF #16
made changes according to comment #17
added updated patch and addressed #41
added updated patch and address comment #10
added updated patch fixed prettier and object-shorthand CCF of #9. sorry for not adding interdiff facing issue with create interdiiff file it create empty interdiff and give interdiff: Whitespace damage detected in input .
checked above MR it fixed the PHPCS issue
try to fixed CCF #150
added updated patch address #149
adding updated patch and to fix the error
try to fixed CCF #45
address #44
checked patch #2 apply cleanly and fixed the above phpcs issue
try to fix CCF #41
added patch and address #41
added updated patch and address #7
checked patch #5 it remove all PHPCS issues
sorry for the wrong patch #22
added updated patch and try to fixed CCF #18
added updated patch remove CCF
sry for all the wrong file @daffie now address your comment
yes @daffie sry for that address now
address comment #5
added updated patch and address #3
added updated patch and try to fixed CCF #215. add accessCheck() because entity queries to check access by default is deprecated so need to check it with true and false.
added updated patch and fixed CCF #3
added updated patch and address comment #14
checked patch #2 it apply cleanly and fixed PHPCS issue
checked patch #2 it apply cleanly and fixed PHPCS issue so RTBC +1
checked patch #2 it apply cleanly and remove above PHPCS issue RTBC +1
checked patch #2 it apply cleanly and remove the PHPCS issue RTBC +1
fixed CCF #17
added updated patch and Fixed remaining issue
checked MR still there are one issue
FILE: ...ktop/Contribution/drupal9.5.x/drupal/modules/contrib/token_views_filter/src/TokensFilterTrait.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
139 | ERROR | [x] Expected 1 newline at end of file; 2 found
-------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------
checked patch #2 apply cleanly and fixed the PHPCS issue
checked patch #15 applied cleanly and it Fixed phpcs issue. look good to me.
Forgot to added SS
checked patch #7 it apply cleanly and Fix phpcs coding standards issue
checked MR #6 it Replace README.txt with README.md