- Issue created by @samit.310@gmail.com
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 3:37pm 20 April 2023 - Status changed to RTBC
over 1 year ago 4:53pm 20 April 2023 - ๐ต๐ญPhilippines kenyoOwen
I applied the patch #2 to the โRedirect Nodesโ module against Version 8.x-1..x-dev coding-standard-fixes.patch and confirmed that the errors is resolved. Please see the screenshots attached.
For your review.
Thank you. - Status changed to Needs work
over 1 year ago 5:52pm 21 April 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ // Calls _redirect_node_replace_node_url_walk_array() recursively on all + // menu items and their children. If the url for a menu item is rewritten, + // then a js script is attached that will inject edit links on each of the + // menu items. if (isset($build['content']['#items'])) {
In comments used inside functions or method, verbs use the imperative module.
Also, instead of js script, it should be JavaScript code. - Status changed to Needs review
over 1 year ago 7:09pm 21 April 2023 - Status changed to Needs work
over 1 year ago 7:19am 22 April 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
+ // Calls _redirect_node_replace_node_url_walk_array() recursively on all + // menu items and their children. If the url for a menu item is rewritten, + // attach JavaScript code that will inject edit links on each of the + // menu items.
Calls is the indicative of call, not its imperative.
url is misspelled, since that is an acronym. - ๐ฎ๐ณIndia pray_12
Preethy_ray โ made their first commit to this issueโs fork.
- ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
Also, If a menu item URL is rewritten is probably better.
- Assigned to nitin_lama
- ๐ฎ๐ณIndia nitin_lama India
Providing updated patch. Addressing comment #6, #8.
- ๐ฎ๐ณIndia nitin_lama India
Addressing changes in the MR. Please review.
- Issue was unassigned.
- Status changed to Needs review
12 months ago 10:15am 7 December 2023 - Status changed to RTBC
6 months ago 6:19am 11 June 2024 - ๐ฎ๐ณIndia dev16.addweb
The above MR !4 looks good, no phpcs error/warning was found.
Thanks