Refactor references to images in Claro's images/core directory

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Patch #31, no more applies to 10.1.x. because some files doesn't exist in 10.1.x. Adding patch for 10.1.x. Please review

git apply -v 3133823-31.patch
Checking patch core/themes/claro/css/components/details.css...
Hunk #1 succeeded at 477 (offset -102 lines).
Checking patch core/themes/claro/css/components/details.pcss.css...
Hunk #1 succeeded at 449 (offset -106 lines).
Checking patch core/themes/claro/css/components/system-admin--status-report.css...
Checking patch core/themes/claro/css/components/system-admin--status-report.pcss.css...
Hunk #1 succeeded at 48 (offset -2 lines).
Checking patch core/themes/claro/css/components/system-status-counter.css...
error: while searching for:
}

.system-status-counter__status-icon--error:before {

Think patch #34 is missing some changes. The patch is much smaller then #23.

Think somethings were removed in #31

From what I can tell the new images aren't there.

I have added the missing SVG image. please review

Tested the Patch #37 and getting error while patch applying

fixed build error. attached interdiff for same.

Missing changes have been added back.

Sorry it took me a while to review this. The patch applies, but it's actually changing the color for several icons with different level of visual implication.

1. +++ b/core/themes/claro/css/components/system-status-report-general-info.pcss.css 
   @@ -41,17 +41,17 @@
   +  background-image: url(../../images/icons/cccccc/clock.svg);
   

   This shouldn't be changing the icon color from white(#fff) to #CCC. So it should land on the existing folder /ffffff.

2. +++ b/core/themes/claro/css/components/system-status-report-general-info.pcss.css
   @@ -41,17 +41,17 @@
   +  background-image: url(../../images/icons/cccccc/server.svg);
   

   Same, this shouldn't be changing the icon color from white to #CCC. So it should land on the existing folder /ffffff.

3. +++ b/core/themes/claro/css/components/system-status-report-general-info.pcss.css
   @@ -41,17 +41,17 @@
   +  background-image: url(../../images/icons/cccccc/php-logo.svg);
   

   Same, this shouldn't be changing the icon color from white to #CCC. So it should land on the existing folder /ffffff.

4. +++ b/core/themes/claro/css/components/system-status-report-general-info.pcss.css
   @@ -41,17 +41,17 @@
   +  background-image: url(../../images/icons/cccccc/database.svg);
   

   Same, this shouldn't be changing the icon color from white to #CCC. So it should land on the existing folder /ffffff.

5. +++ b/core/themes/claro/css/components/system-status-report.pcss.css
   @@ -60,10 +60,10 @@
   +  background-image: url(../../../../misc/icons/e32700/error.svg);
   

   Why is this changing the color from #dc2323 to #e32700? I understand this is to reuse the default core icon, but it's actually changing the red used in Claro. Meaning it's changing the designs. Both icons still exist in core, so please keep the same color. Another question is way we keep the same icon in core with similar reds, but that should be solved in another issue :)

I forgot to reference a related issue for Claro related to icons: #3269881: Update icon colors with the new color scale →

added patch and address #41

try to fix CCF #41

Thank you for all the work on this issue. I've tried most of the recent patches against D10.1-beta1, and cannot get them to apply.

I have provided patch for 11.x, addressed #41. please review

From what I can tell the images are still landing in cccccc

Addressed #48, please review

When I filed this issue in 2020...

• Claro was an experimental theme. It has since become Drupal's admin theme
• I was not a frontend framework manager. I have since become a frontend framework manager

Given that it is 2+ years since Claro graduated from experimental status, I'm not sure the benefits of of moving the assets + references outweigh the potential disruption. Testing this manually requires time and it is a lengthy process without tests to confirm things are OK. Something unwanted could slip through, and custom modules/themes may be referencing some of these assets. Had this happened while Claro was still experimental I'd be all for the change. While it should have occurred when Claro was added to core on October 4, 2019, that doesn't necessarily mean it should happen now. I'm setting this to Closed (outdated), but I don't intend this to be a stern "final word". If anyone here believes the benefits of doing this outweigh the risks then document that and re-open.

Alternatively, get some quick issue credit and open an issue that simply removes this from the readme:

Icons in this folder are copied from Drupal core. This folder with its content
should be removed before moving Claro to Drupal core