- Issue created by @_shy
- 🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
Here is a patch to fix the issue with a function declaration.
- Status changed to Needs review
almost 2 years ago 7:48am 23 June 2023 - 🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
Updated the patch, and found a few entity query calls without
accessCheck()
function. - 🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
Also, found and fixed the following error:
Fetching deprecated class constant MASTER_REQUEST of class Symfony\Component\HttpKernel\HttpKernelInterface: since symfony/http-kernel 5.3, use MAIN_REQUEST instead. To ease the migration, this constant won't be removed until Symfony 7.0.
P.S. sorry for spamming patches.
- Status changed to RTBC
almost 2 years ago 5:34am 10 July 2023 - 🇮🇳India Akram Khan Cuttack, Odisha
I reviewed the patch and it's resolved the issue. Before patch when i try to extend the module it give fatal error and after applying patch the module got enabled successfully. Additionally, I have attached before and after state screenshots for reference.
- 🇨🇦Canada netgeek123
Is anyone going to fork this and bring it up to drupal 11? :)
- First commit to issue fork.
- 🇺🇸United States mrweiner
Updating this so that it's against 2.x since that is the forked version for updates.
- Merge request !8Resolve #3368921 "Function declaration compatibility 2x" → (Merged) created by mrweiner
-
mrweiner →
committed 71155724 on 2.x
Issue #3368921 by mrweiner, akram khan: Function declaration...
-
mrweiner →
committed 71155724 on 2.x
- 🇺🇸United States mrweiner
Sorry all -- not sure why I never saw this issue (and the errors never showed up on our D10 install until today). Merged in the patch from $6. Opened up another ticket for D11 compatibility.
Automatically closed - issue fixed for 2 weeks with no activity.