Fix the issues reported by phpcs

still issue remaining so move to NW

FILE: ...s/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/tests/src/Kernel/LocaleStringTest.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------
37 | WARNING | Possible useless method overriding detected
44 | WARNING | Possible useless method overriding detected
------------------------------------------------------------------------------------------------------------------------------

FILE: ...khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/tests/src/Kernel/ExtendedLocaleStringTest.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
115 | WARNING | Unused variable $source2.
------------------------------------------------------------------------------------------------------------------------------

FILE: ...n/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/modules/locale_extend_ns/locale_extend_ns.module
------------------------------------------------------------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 22 LINES
------------------------------------------------------------------------------------------------------------------------------
45 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
56 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
67 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
78 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
89 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
100 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
111 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
122 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
133 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
144 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
155 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
166 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
177 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
188 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
199 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
210 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
221 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
232 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
243 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
254 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
265 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
276 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "tr" but expected
| | "locale_extend_ns_tr"
------------------------------------------------------------------------------------------------------------------------------

FILE: ...han/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/modules/locale_extend_t/locale_extend_t.module
------------------------------------------------------------------------------------------------------------------------------
FOUND 22 ERRORS AFFECTING 22 LINES
------------------------------------------------------------------------------------------------------------------------------
40 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_bg" but expected
| | "locale_extend_t_t_bg"
46 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_cs" but expected
| | "locale_extend_t_t_cs"
52 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_da" but expected
| | "locale_extend_t_t_da"
58 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_de" but expected
| | "locale_extend_t_t_de"
64 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_et" but expected
| | "locale_extend_t_t_et"
70 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_el" but expected
| | "locale_extend_t_t_el"
76 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_es" but expected
| | "locale_extend_t_t_es"
82 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_fi" but expected
| | "locale_extend_t_t_fi"
88 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_fr" but expected
| | "locale_extend_t_t_fr"
94 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_hr" but expected
| | "locale_extend_t_t_hr"
100 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_hu" but expected
| | "locale_extend_t_t_hu"
106 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_is" but expected
| | "locale_extend_t_t_is"
112 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_it" but expected
| | "locale_extend_t_t_it"
118 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_lt" but expected
| | "locale_extend_t_t_lt"
124 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_lv" but expected
| | "locale_extend_t_t_lv"
130 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_pl" but expected
| | "locale_extend_t_t_pl"
136 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_pt" but expected
| | "locale_extend_t_t_pt"
142 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_ro" but expected
| | "locale_extend_t_t_ro"
148 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_ru" but expected
| | "locale_extend_t_t_ru"
154 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_sk" but expected
| | "locale_extend_t_t_sk"
160 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_sl" but expected
| | "locale_extend_t_t_sl"
166 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "t_sv" but expected
| | "locale_extend_t_t_sv"
------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/src/Translation.php
-----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------
47 | ERROR | Class property $source_langcode should use lowerCamel naming without underscores
167 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------------------------

FILE: /Users/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/src/Translate.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
52 | WARNING | [ ] Only string literals should be passed to t() where possible
82 | ERROR | [x] list(...) is forbidden, use [...] instead.
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: ...rs/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/src/Service/ExtendedLocaleLookup.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
24 | ERROR | Class property $source_langcode should use lowerCamel naming without underscores
------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/akram.khan/Desktop/Contribution/drupal9.5.x/drupal/modules/contrib/locale_extend/src/StringTranslationTrait.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------
39 | ERROR | Class property $source_langcode should use lowerCamel naming without underscores
46 | WARNING | Only string literals should be passed to t() where possible
----------------------------------------------------------------------------------------------------------------------------

Time: 572ms; Memory: 10MB

Providing patch with phpcs fixes some "Possible useless method overriding detected" Issue remaining.
also issue summary updated with command and arguments.

 /**
  * @file
- * Drupal module install file: locale_extend
+ * Drupal module install file: locale_extend.
  */

The usual description is Install, update, and uninstall function for the Locale Extend module. (Locale Extend must be the module name given in its .info.yml file.)

- * Drupal module: locale_extend
+ * @file
+ * Drupal module: locale_extend.

The usual description is Hook implementations for the Locale Extend module. (Locale Extend must be the module name given in its .info.yml file.)

-   * @return \Drupal\Core\StringTranslation\TranslationInterface
-   *   A string translation service with predefined source language.
+ *   Language code to translate from.
+ *
+ * @return \Drupal\Core\StringTranslation\TranslationInterface
+ *   A string translation service with predefined source language.
  */
 function locale_extend_translation($source_langcode) {
   return Translate::translation($source_langcode);

That is not what that function returns. I know the existing comment already says that, but since the comment is edited, that should be corrected too.

  * @return \Drupal\Core\StringTranslation\TranslatableMarkup
+ *   Return TranslatableMarkup.

The description does not repeat what the @return line made already clear.

- * @return string|FALSE
+ * @return string|false
+ *   Return string/NULL.

The description is not correct. It should also say what is returned and when, not the return value type, which is already reported in the previous line.

 /**
- * Define tr() function for different namespaces
+ * @file
+ * Define tr() function for different namespaces.

Since that is a module description, it should be different.

+  /**
+   * Translate from Bulgarian. @see t()
+   */

The verb must be declined to the third person singular.
The parameter and the return value descriptions are missing.
@see needs to be in its own line, after the parameter and the return value descriptions.

- * languages will be added, it is easy enough to add new ones in your custom module.
+ * languages will be added,
+ * it is easy enough to add new ones in your custom module.

It is correct to avoid that comment lines exceed 80 characters, but they should still be close to 80 characters as much as possible. This means avoiding to make a line 10-character long.

+  /**
+   * Alters the container to replace some locale and translation services.
+   *
+   * @param \Drupal\Core\DependencyInjection\ContainerBuilder $container
+   *   The container builder.
+   */
   public function alter(ContainerBuilder $container) {

Since that is a method defined in an interface, its documentation comment must be different.

-    // Change path '/admin/config/regional/translate'
+    // Change path '/admin/config/regional/translate'.

It is better to say Alter the /admin/config/regional/translate path. It is not necessary to quote the path.

-    return new TranslatableMarkup($string, $args, $options);
+    return new TranslatableMarkup('@string', '@args', '@options', [
+      '@string' => $string,
+      '@args' => $args,
+      '@options' => $options,
+    ]);

This change is not correct. The new code is translating '@string', not $string. Furthermore, the second and the third parameter must be two arrays, not two strings.

Addressed 7.1, 7.2, 7.4, 7.8, 7.10, 7.11. Updated patch.

There were still remaining errors. I've fixed it.

FILE: /home/system/Documents/contribution/locale_extend/src/Service/ExtendedStringDatabaseStorage.php
-----------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------
 63 | ERROR | Type hint "\Drupal\locale\StringInterface" missing for $string
 97 | ERROR | Type hint "\Drupal\locale\StringInterface" missing for $string
-----------------------------------------------------------------------------------------------------

Time: 142ms; Memory: 8MB

Hi @nitin_lama,,

Applied patch #9 successfully, however it still threw 2 warnings. Please see below:

locale_extend git:(1.0.x) curl https://www.drupal.org/files/issues/2023-06-19/phpcs-issue-fixes-3353934-9.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 56548  100 56548    0     0   357k      0 --:--:-- --:--:-- --:--:--  391k
patching file README.md
patching file locale_extend.install
patching file locale_extend.module
patching file locale_extend.services.yml
patching file modules/README.md
patching file modules/locale_extend_ns/locale_extend_ns.module
patching file modules/locale_extend_t/locale_extend_t.module
patching file src/Form/TranslateEditForm.php
patching file src/Form/TranslateFilterForm.php
patching file src/Form/TranslateFormTrait.php
patching file src/LocaleExtendServiceProvider.php
patching file src/Routing/RouteSubscriber.php
patching file src/Service/ExtendedLocaleLookup.php
patching file src/Service/ExtendedLocaleTranslation.php
patching file src/Service/ExtendedStringDatabaseStorage.php
patching file src/Service/ExtendedTranslatorInterface.php
patching file src/Service/TranslationManager.php
patching file src/StringTranslationTrait.php
patching file src/Translate.php
patching file src/Translation.php
patching file tests/src/Kernel/ExtendedLocaleStringTest.php
patching file tests/src/Kernel/LocaleExtendKernelTestTrait.php
patching file tests/src/Kernel/LocaleStringTest.php
➜  locale_extend git:(1.0.x) ✗ cd ..
➜  contrib git:(master) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig locale_extend

FILE: ...sers/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/locale_extend/src/Translation.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 167 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------------------


FILE: /Users/PrometInterns/Demo-site/drupal-orgissue-v9/web/modules/contrib/locale_extend/src/Translate.php
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
 52 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------------------------------------

Time: 731ms; Memory: 12MB

Kindly check.

Thanks,
Jake