🇮🇳India @arpitk

It is still reproducible after running updb.

I was able to reproduce this. Once you install the module and visit the general setting page you get this warning as the default value for view mode is not set and the array key is missing from the config. Attached patch please review.

Hi Any update on this issue. Its is still persists.

VladimirAus → credited arpitk → .

These fixes should always target dev branch.

Rebased MR9 and fixed some code break issues along with some phpcs issues. Please review.

Thanks!

arpitk → made their first commit to this issue’s fork.

I reviewed the patch #2. It applied cleanly and no error/warning related to phpcs Drupal are produced. How ever this issue is about fixing phpcs issues so all issues can be taken care in single issue no need to create different issues. like https://www.drupal.org/project/menu_trail_by_path/issues/3371326 📌 Replace the t() calls to $this->t() in classes. Needs review

Thanks!

Please review the patch.

Thanks!

arpitk → created an issue.

Here is the patch fixing the DI issues still other comments issues need to be addressed. So keeping the status as NW.

Thanks!

arpitk → created an issue.

Hi @mstrelan, Could you please update the full steps to reproduce this. I tried installing and enabling the module Drupal 10.1.x. But I couldn't reproduce this error.

Here is the patch please review.

Thanks!

arpitk → created an issue.

Here is the patch please review.

Thanks!

arpitk → created an issue.

Here is the patch please review.

arpitk → created an issue.

Fixed the errors/warning reported by phpcs. Please review the MR.

Thanks!

arpitk → created an issue.

Hi I tried the patch #24 but it didnt apply cleanly.

Thanks!

arpitk → made their first commit to this issue’s fork.

Please update the summary with all details including the command and the arguments used to scan and the errors/warnings produced.

Thanks!

Hi The patch #2 fixes the issue on media library for alt text. but as mentioned in #5 the patch name is not correct. updated the patch.

Thank!

Thanks @diaodiallo patch #10 applied cleanly and now i see no error.

Hi I have fixed the DI issues reported y phpcs. Still there is some errors/warning remaing that need to be fixed. Keeping the status as NW.
Please review the MR https://git.drupalcode.org/project/acknowledgements/-/merge_requests/2

Thanks!

The issues has been taken care in this issue https://www.drupal.org/project/paragraphs/issues/3334005 📌 Fix the issues reported by phpcs Needs review .

arpitk → made their first commit to this issue’s fork.

HI @agunjan085 I reviewed the MR in #5. It seems to resolve issues however still some errors are produced that need to be addressed.

Running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,js .

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/paragraphs_sets-3361247/paragraphs_sets.module
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
24 | WARNING | Global constants should not be used, move it to a class or interface
574 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "paragraphs_set_load" but expected "paragraphs_sets_paragraphs_set_load"
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

HI I have worked on a patch to fix DI and some other issues. Still some issues need to be fixed.
Here is the patch. The patch works on top of #2 MR. Please review.

Thanks!

Hi Updated the patch #15 with the issues addresed in #17 Please review.

Thanks!

HI The patch #18 it applied cleanly. However these errors/warnings are produced when running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,js . Tested on Drupal 9.5.8 and social_login:3.x-dev

Thanks!

HI I worked on some phpcs errors/warning fixes on the latest code. Still there are few issues need to be fixed. Please review.

Thanks!

Hi The patch #3 applies cleanly running phpcs sniffer produced no errors/warnings. However some test cases needs to be updated. Moving it to NW for test cases.

Thanks!

arpitk → made their first commit to this issue’s fork.

Hi I have worked on fixing some issues. Still soome issues remains. Attaching the patch here and keeping the status to Need Work.

Thanks!

arpitk → created an issue.

Updated patch to include default view default display title.

I reviewed the MR the current changes crashed the modules. Providing the updated MR.
ArgumentCountError: Too few arguments to function Drupal\eu_cookie_compliance\EventSubscriber\EuCookieComplianceConfigEventsSubscriber::__construct(), 0 passed in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 3 expected in Drupal\eu_cookie_compliance\EventSubscriber\EuCookieComplianceConfigEventsSubscriber->__construct() (line 65 of /app/web/modules/contrib/eu_cookie_compliance/src/EventSubscriber/EuCookieComplianceConfigEventsSubscriber.php)

Thanks!

I could see more errors in the report as follows.

------ -----------------------------------------------------------------------------
Line eu_cookie_compliance.install
------ -----------------------------------------------------------------------------
133 Variable $default_filter_format might not be defined.
134 Variable $default_filter_format might not be defined.
135 Variable $default_filter_format might not be defined.
136 Variable $default_filter_format might not be defined.
634 Call to an undefined method
Drupal\Core\Language\LanguageManagerInterface::getLanguageConfigOverride().
644 Call to an undefined method
Drupal\Core\Language\LanguageManagerInterface::getLanguageConfigOverride().
------ -----------------------------------------------------------------------------

------ -----------------------------------------------------------------------
Line eu_cookie_compliance.module
------ -----------------------------------------------------------------------
211 Call to deprecated function file_create_url():
in drupal:9.3.0 and is removed from drupal:10.0.0.
Use the appropriate method on
\Drupal\Core\File\FileUrlGeneratorInterface
instead.
211 Call to deprecated function file_url_transform_relative():
in drupal:9.3.0 and is removed from drupal:10.0.0.
Use \Drupal\Core\File\FileUrlGenerator::transformRelative()
instead.
454 Call to an undefined method
Drupal\Core\Entity\EntityStorageInterface::getCookieCategories().
495 Variable $primary_button_label might not be defined.
498 Variable $secondary_button_label might not be defined.
499 Variable $primary_button_class might not be defined.
500 Variable $secondary_button_class might not be defined.
506 Variable $privacy_settings_tab_label might not be defined.
517 Variable $primary_button_label might not be defined.
520 Variable $secondary_button_label might not be defined.
521 Variable $primary_button_class might not be defined.
522 Variable $secondary_button_class might not be defined.
528 Variable $privacy_settings_tab_label might not be defined.
583 Call to an undefined method
Drupal\Core\Entity\EntityStorageInterface::getCookieCategories().
590 Variable $click_confirmation might not be defined.
591 Variable $scroll_confirmation might not be defined.
802 PHPDoc tag @var for variable $location_service contains unknown class
Drupal\smart_ip\SmartIpLocation.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
803 Call to static method query() on an unknown class
Drupal\smart_ip\SmartIp.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
804 Call to method get() on an unknown class
Drupal\smart_ip\SmartIpLocation.
💡 Learn more at https://phpstan.org/user-guide/discovering-symbols
995 Call to deprecated function file_create_url():
in drupal:9.3.0 and is removed from drupal:10.0.0.
Use the appropriate method on
\Drupal\Core\File\FileUrlGeneratorInterface
instead.
995 Call to deprecated function file_url_transform_relative():
in drupal:9.3.0 and is removed from drupal:10.0.0.
Use \Drupal\Core\File\FileUrlGenerator::transformRelative()
instead.
------ -----------------------------------------------------------------------

------ --------------------------------------------
Line src/CookieCategoryListBuilder.php
------ --------------------------------------------
49 Call to an undefined method
Drupal\Core\Entity\EntityInterface::get().
50 Call to an undefined method
Drupal\Core\Entity\EntityInterface::get().
50 Call to an undefined method
Drupal\Core\Entity\EntityInterface::get().
------ --------------------------------------------

------ ------------------------------------------------------------------
Line src/EventSubscriber/EuCookieComplianceConfigEventsSubscriber.php
------ ------------------------------------------------------------------
56 Call to deprecated function file_save_data():
in drupal:9.3.0 and is removed from drupal:10.0.0. Use
\Drupal\file\FileRepositoryInterface::writeData() instead.
------ ------------------------------------------------------------------

------ --------------------------------------------------------------------
Line src/Form/CookieCategoryForm.php
------ --------------------------------------------------------------------
85 Call to an undefined method
Drupal\Core\Entity\EntityInterface::get().
94 Call to an undefined method
Drupal\Core\Entity\EntityInterface::get().
124 Method Drupal\eu_cookie_compliance\Form\CookieCategoryForm::save()
should return int but return statement is missing.
135 Call to an undefined method
Drupal\Core\Entity\EntityInterface::getWeight().
136 Call to an undefined method
Drupal\Core\Entity\EntityInterface::setWeight().
------ --------------------------------------------------------------------

------ -------------------------------------------
Line src/Form/EuCookieComplianceConfigForm.php
------ -------------------------------------------
1314 Variable $role_name might not be defined.
------ -------------------------------------------

------ ------------------------------------------------
Line src/Plugin/migrate/source/EuCookieCategory.php
------ ------------------------------------------------
59 Call to an undefined method Iterator::count().
------ ------------------------------------------------

Please update the issue summary with more details. What errors has been fixed, which command and arguments has been used to produce the errors. and the title should be more clear and specific about the issue.

Thanks!

Hi @yashmalviya i reviewed the patch #2. It applied cleanly. Please see the attached screenshot for reference. One warning remains.

Thanks!

arpitk → created an issue.

Hi @eiriksm, I have worked on a patch for the fix. Please review.

Thanks!

This is probably a duplicate issue.

I am getting other error on saving the node.
Error: Class "Drupal\content_to_group\Util\ContentToGroupUtility" not found in content_to_group_node_insert() (line 39 of /app/web/modules/contrib/content_to_group/content_to_group.module)

I reviewed the patch #9. The patch is failing to apply. Moving it to Needs Works to fix the issue and update the patch.

Thanks!

Worked on major issue few issues need to be addressed. Attaching the patch.

Thanks!

arpitk → created an issue.

Please review the patch.

Thanks!

arpitk → created an issue.

HI I reviewed the patch #3 it applies cleanly no more phpcs errors/warnings are shown. I used phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig to test.
Moving to RTBC.

Thanks!

Hi the patch #2 applies cleanly and the error mentioned in the issue description is fixed. However the issue summary need to be updated with the command and the arguments used to check should be mentioned in the summary. Moving it to Needs Works.

Thanks!

Reviewing this.

arpitk → made their first commit to this issue’s fork.

Here is the updated patch. Please review.

Thanks!

Worked on all issues. Ignored the readme file and a an array declaration errors as they were in readable format. Please review.

Thanks!

arpitk → created an issue.

Updated issue summary.

The issue description need to be updated with details which command used to scan and which arguments are used.

Updated patch.

Hi @sourabhjain I reviewed the patch #22. It applied cleanly all the errors/warnings are fixed. Running phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,js . returned clean.
Keeping the status as Needs work as the test cases are failing that need to be be fixed as well.

Thanks!

Please review MR.

Thanks!

Reviewing the MR.

Hi i reviewed the patch #4. The patch applies cleanly no phpcs warnings/errors are produced. I ran phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,js .

moving it to RTBC

Thanks!

Hi the patch #10 applied cleanly however there are few more issues needs to be fixed.

arpitkayare@Arpitk:~/drupal_9.5/web/themes/contrib/uikit$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig,js .

FILE: /home/arpitkayare/drupal_9.5/web/themes/contrib/uikit/STARTERKIT/theme-settings.php
-----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------------
13 | ERROR | Invalid function name, expected s_ta_rt_er_ki_t_form_system_theme_settings_alter but found STARTERKIT_form_system_theme_settings_alter
-----------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/themes/contrib/uikit/STARTERKIT/includes/preprocess.inc
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 12 WARNINGS AFFECTING 12 LINES
----------------------------------------------------------------------------------------------
20 | WARNING | There must be no blank line following an inline comment
28 | WARNING | There must be no blank line following an inline comment
36 | WARNING | There must be no blank line following an inline comment
44 | WARNING | There must be no blank line following an inline comment
52 | WARNING | There must be no blank line following an inline comment
60 | WARNING | There must be no blank line following an inline comment
70 | WARNING | There must be no blank line following an inline comment
78 | WARNING | There must be no blank line following an inline comment
86 | WARNING | There must be no blank line following an inline comment
94 | WARNING | There must be no blank line following an inline comment
102 | WARNING | There must be no blank line following an inline comment
110 | WARNING | There must be no blank line following an inline comment
----------------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/themes/contrib/uikit/STARTERKIT/includes/process.inc
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
20 | WARNING | There must be no blank line following an inline comment
-------------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/themes/contrib/uikit/STARTERKIT/includes/alter.inc
-----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
26 | WARNING | There must be no blank line following an inline comment
-----------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/themes/contrib/uikit/STARTERKIT/includes/theme.inc
-----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------
17 | WARNING | There must be no blank line following an inline comment
-----------------------------------------------------------------------------------------

Thanks!

Updated issues description.

Hi @Harsh panchal I have reviewed the patch #2 it applied cleanly.

Thanks!

Hi @urvashi_vora I reviewed the patch. After applying the patch few errors in simple_sitemap_page_manager.module are reported. Attaching before and after patch results. I have fixed those errors and updated the patch. Please review.

Thanks!

Reviewing this.

Hi The patch #7 applies cleanly. No errors/warnings are produced anymore. The issues from #5 are also taken care. I used phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml to test.

Thanks!

Hi here is the updated patch addressing #10. Please review.

Thanks!

Hi The MR looks good. No phpcs errors/warning are produced other than css as mentioned in #4.
I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

Thanks!

Reviewing this.

Here is the updated patch. Please review.

Thanks!

working on remaining issues.

HI @bharath-kondeti the patch #13 it applied cleanly. No more phpcs errors/warnings are produced.
I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,js . to test.

Thanks!

Hi I have created a patch with some fixes. Few more issues need to be worked on. Please review.

remaining issues

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/feeds_ldap/feeds_ldap.install
------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/feeds_ldap/src/Feeds/Fetcher/Form/QueryFetcherFeedForm.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/feeds_ldap/src/Feeds/Fetcher/QueryFetcher.php
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
9 | WARNING | [x] Unused use statement
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/feeds_ldap/src/Feeds/Result/QueryFetcherResult.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
15 | ERROR | [x] Expected "" but found "???" for @var tag in member variable comment
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/feeds_ldap/feeds_ldap.info.yml
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
----------------------------------------------------------------------------------------------
Thanks!

Here is the updated patch. Please review.

Thanks!

The patch #4 applied cleanly however there is still following errors/warnings reported :

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/commerce_simple_stock/src/EventSubscriber/OrderEventSubscriber.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------
52 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
166 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/commerce_simple_stock/src/Form/StockInventoryControlForm.php
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------
142 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
145 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
164 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/commerce_simple_stock/src/OrderProcessor/AvailabilityOrderProcessor.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
30 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------

FILE: /home/arpitkayare/drupal_9.5/web/modules/contrib/commerce_simple_stock/js/inventory_control.js
----------------------------------------------------------------------------------------------------
FOUND 44 ERRORS AFFECTING 22 LINES
----------------------------------------------------------------------------------------------------
3 | ERROR | [x] Space before opening parenthesis of function call prohibited
4 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
4 | ERROR | [x] Expected 1 space before opening brace; found 0
11 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
11 | ERROR | [x] Expected 1 space before opening brace; found 0
13 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
15 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
17 | ERROR | [x] Expected 1 space before "=="; 0 found
17 | ERROR | [x] Expected 1 space after "=="; 0 found
23 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
23 | ERROR | [x] Expected 1 space before opening brace; found 0
29 | ERROR | [x] Whitespace found at end of line
30 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
30 | ERROR | [x] Expected 1 space before opening brace; found 0
37 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
42 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
53 | ERROR | [x] Whitespace found at end of line
66 | ERROR | [x] Expected 1 space before "+"; 0 found
66 | ERROR | [x] Expected 1 space after "+"; 0 found
71 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
79 | ERROR | [x] Expected 1 space before "+"; 0 found
79 | ERROR | [x] Expected 1 space after "+"; 0 found
79 | ERROR | [x] Expected 1 space before "+"; 0 found
79 | ERROR | [x] Expected 1 space after "+"; 0 found
80 | ERROR | [x] Expected 1 space before "+"; 0 found
80 | ERROR | [x] Expected 1 space after "+"; 0 found
80 | ERROR | [x] Expected 1 space before "+"; 0 found
80 | ERROR | [x] Expected 1 space after "+"; 0 found
80 | ERROR | [x] Expected 1 space before "+"; 0 found
80 | ERROR | [x] Expected 1 space after "+"; 0 found
81 | ERROR | [x] Expected 1 space before "+"; 0 found
81 | ERROR | [x] Expected 1 space after "+"; 0 found
81 | ERROR | [x] Expected 1 space before "+"; 0 found
81 | ERROR | [x] Expected 1 space after "+"; 0 found
82 | ERROR | [x] Expected 1 space before "+"; 0 found
82 | ERROR | [x] Expected 1 space after "+"; 0 found
82 | ERROR | [x] Expected 1 space before "+"; 0 found
82 | ERROR | [x] Expected 1 space after "+"; 0 found
82 | ERROR | [x] Expected 1 space before "+"; 0 found
82 | ERROR | [x] Expected 1 space after "+"; 0 found
89 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
90 | ERROR | [x] Inline control structures are not allowed
98 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
99 | ERROR | [x] Equals sign not aligned correctly; expected 1 space but found 2 spaces
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 44 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------

command used phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,js .

Working on updating the patch.

Thanks!

Hi here is the updated patch.
command used; phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,js .
Please review.

Thanks!

Hi @mrinalini9 I reviewed the patch #31 Applies cleanly on version
8.x-1.x-dev. The changes from #30 also has been taken care. Only the error produced but phpcs as follows:

C:\xampp\htdocs\d8\web\modules\contrib\registration_invite> phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .

FILE: ...modules\contrib\registration_invite\registration_invite.info.yml
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the
| | info.yml file
----------------------------------------------------------------------

As mention in #30 regarding core_version_requirement. This remains.

Thanks!