- Issue created by @arpitk
- First commit to issue fork.
- @gowthamrajkrishnasamy opened merge request.
- Assigned to gowthamrajkrishnasamy
- Issue was unassigned.
- Status changed to Needs review
10 months ago 7:11am 8 September 2023 - 🇮🇳India Shreya_98
I have fixed all the phpcs issues properly. Kindly review the patch file and attached screenshot as well.
- Status changed to RTBC
10 months ago 11:18am 8 September 2023 - 🇮🇳India aayushDrupal
Hello, @Shreya_th thanks for the patch, I have applied your patch and it ran successfully.
These are the steps I followed:
1. Took clone from git version 8.x-1.x-dev in drupal 10.1.x
2. Ran this command:
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,m
d,yml,twig modules/contrib/ajax_add_to_cart/3. Applied your patch and, again ran phpcs command and found no errors.
Screenshot attached for your reference.
Moving to RTBC for now.