Argument #1 ($value) must be of type Countable|array, null given in count() (line 57 of core/lib/Drupal/Core/Render/Element/Radios.php).

Patch #10 added support for Checkboxes, Table, and Tableselect, but removed the necessary isset() from #3 on those, now giving (D10.0.9, PHP 8.1.18):

Warning: Undefined array key "#options" in Drupal\Core\Render\Element\Radios::processRadios() (line 62 of core/lib/Drupal/Core/Render/Element/Radios.php).

Either an isset() or my preferential array_key_exists() needs to be added to these to suppress this warning. I've rerolled #10 to add array_key_exists() on all of the changes.

Looks good.

The last submitted patch, 25: 3252288-25.patch, failed testing. View results →

Patch #25 was failing. I am attaching a new patch.

Was previously tagged for steps to reproduce, tests, and issue summary update which still need to happen before review.

Step to reproduce

• Create a custom form.
• Add a field of type radios/checkbox/tableselct.
• Make the option to be NULL.
• I also attached the screenshot of the PHP error.
• This can also be reproduced if we use a blank taxonomy term as an exposed filter in view.

$form['testempty'] = [
    '#type' => 'tableselect',
    '#options' => NULL,
    '#empty' => $this->t('No Data'),
];

Test

• Create a custom form same as above and apply the patch.
• After applying the patch, the form will display blank data. It will not throw a PHP error and the page will not blank with "Website encounter error."

Updated issue summary.

Proposed solution is still empty and tests appear to be missing

Hello smustgrave,
The proposed solution has been updated and also added the tests.

I do not see a patch or MR with test case.

Patch on #28 works like a charm. Thanks!

Hello smustgrave ,
I understand your suggestion to create the test case for the patch. Could you suggest where can be written the test case for this?

Since the fix is coming out of the core/lib folder tests could probably be added in the tests folder. Would see if a test could be expanded

Got bit by this nightmare again over in better_exposed_filters.

Cleaning up the tags but still leaving in NW for the tests.

I have test this issue in my system and work on it.
provided the patch.

Thanks

Hi @anchal_gupta, I am seeing a typo in your patch:
+ if (is_countablet($element['#options']) > 0) {
'is_countablet' should be 'is_countable' I think?

I have tried to apply patch 28 but I get errors:

| => curl https://www.drupal.org/files/issues/2023-06-12/argument-countable-null-3... → | git apply --index -
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 3876 100 3876 0 0 58034 0 --:--:-- --:--:-- --:--:-- 58727
error: patch failed: core/lib/Drupal/Core/Render/Element/Table.php:366
error: core/lib/Drupal/Core/Render/Element/Table.php: patch does not apply

So, tried this command instead:
curl https://www.drupal.org/files/issues/2023-06-12/argument-countable-null-3... → | git apply --reject --whitespace=fix --index -

That works, but creates a .rej file with the rejected 'hunk'. So it should help identify/ narrow down the problem with the patch.

I also applied patch 43. It applies cleanly but #44 is one apparent error. Also the if conditions appear correct in #28 but not in #44.

The Color.php render element class has this function at line 50:

public static function validateColor(&$element, FormStateInterface $form_state, &$complete_form) {

It contains try catch blocks and thrown an exception. This approach could work.

Patches #28 and #43 does not apply on 11.2 branch..

Still NW because no test was added, but this patch applies on 11.x, from merge request https://git.drupalcode.org/project/drupal/-/merge_requests/12448

sorry, commnt mismatch.

- 3252288-50.patch is against 11.x
- 3252288-51_against_11.2.0.patch is against 11.2.0