- 🇺🇸United States smustgrave
Will need to be an MR
Also can steps be added to the issue summary
- 🇨🇦Canada phot0x
Yes custom code was being used, the custom code was a simply making a request to a controller that returned an AjaxOpenDialog response. And Ah sorry didn't know about the 11.x being the main branch.
- 🇬🇧United Kingdom 2dareis2do
I guess the issue will never be fixed in core if the issue queue is now in contrib.
- 🇬🇧United Kingdom 2dareis2do
Right sorry. my bad.
Am i right in thinking this started as a core issue?
- 🇫🇷France fgm Paris, France
Note that this issue is about the contrib statistics project, not statistics in core, but the link you mention https://github.com/drupal/drupal/tree/10.3.1/core/modules/statistics is about core.
- 🇬🇧United Kingdom 2dareis2do
Looks like there are quite a few change in statistics module. with 10.3 release.
https://github.com/drupal/drupal/tree/10.3.1/core/modules/statistics
Patch does not apply and statistics are not updating.
Patch probably needs to be re rolled.
- 🇮🇳India rahul_sankrit New Delhi
I have created a custom token for the PDF link but after the Drupal update (from 10.1.6 to 10.2.7) this is not working.
Please find the attached screenshot (the token is visible in available tokens)[webform_submission:webform_download_file:htmldecode]
Thanks.
Thanks @imran1217!
For me, this combination works for Drupal 10.3.1:"drupal/ckeditor5_font": { "3368736 - 'no config schema' Error": "https://git.drupalcode.org/project/ckeditor5_font/-/merge_requests/8.patch", "3350333 - TypeError: array_filter(): Argument #1 ($array) must be of type array": "https://www.drupal.org/files/issues/2023-04-21/3350333-5.patch" }
- 🇺🇸United States fkildoo
Just an update... 3 days since applying the patch and there have been no errors. I assume the patch did the trick, but the last time there were 5 days between errors, so I can't be 100% sure yet. @banoodle went over 7 days between errors. If we both go over 8 days without seeing the error, I'd say it's probably good. I'll report back in a few days.
- 🇮🇳India sanket1007
I found the issue, we were using time in our code which was causing the bug.
nr_core.datetime.time: public: false class: 'Drupal\nr_core\Time' decorates: datetime.time arguments: - '@request_stack' - '@state' # Workaround for serializing decorated services. Remove when either # https://www.drupal.org/project/drupal/issues/2896993 or # https://www.drupal.org/project/drupal/issues/2531564 are fixed. properties: _serviceId: datetime.time
Tried removing this dependency of - '@state' from here and it worked fine. Thanks
- 🇺🇸United States cilefen
The reason this happens in 10.3 is probably https://www.drupal.org/node/3177901 → . I think you have something overriding
cache.backend.database
so that it depends onDrupal\Component\Datetime\TimeInterface
andstate
.So there is also custom code? What exactly do you mean by Pantheon setup?
I wish the circular dependency exception were more verbose. Some techniques you could try:
- Disable modules that modify default caching.
- Disable default cache overrides in settings.php or services.yml.
I am postponing this issue until all information required to reproduce the bug is available.
- 🇧🇪Belgium Wim Leers Ghent 🇧🇪🇪🇺
Precise steps to reproduce are missing. What was the precise filename of the image that caused the validation error?
Better yet: use that exact filename to add new test coverage to
\Drupal\Tests\experience_builder\Kernel\PropSourceTest
, to trigger the exact error message you were getting! 😄 - 🇮🇳India sanket1007
This is the cache bin that we have created in one of our module -
nr_core.nr_cache:
class: Drupal\Core\Cache\CacheBackendInterface
factory: ['@cache_factory', 'get']
arguments: ['nr_cache']
tags:
- { name: cache.bin } - 🇺🇸United States cilefen
Ok, what are the complete cache configurations? Are settings or modules overriding core services?
- 🇳🇴Norway eiriksm Norway
Hey 👋 Thanks for your contribution! 🚀
The issue summary is a bit lacking. Especially with regards to how to reproduce the issue. Could you for example try to formulate it in a way where we could reproduce it from a clean install?
And what versions are you using? Drupal and PHP especially.
In addition, it's a bit disappointing that our tests do not cover this, so I would like to add test coverage as well. This would also be much easier with exact steps to reproduce
Thanks again ♥️
- 🇮🇳India sanket1007
cache.backend.database:
class: Drupal\Core\Cache\DatabaseBackendFactory
arguments: ['@database', '@cache_tags.invalidator.checksum', '@settings']
tags:
- { name: backend_overridable }Yes, we have cache bins on the site.
- 🇺🇸United States Luke.Leber Pennsylvania
It looks like perhaps an HTML table is needed in the markup to be diffed here? Can you please provide the content you're seeing this on? 🤞
We'll definitely need a failing automated test before committing any sort of bug fix to this module.
- 🇺🇸United States banoodle San Francisco, CA
@larowlan looks like I spoke too soon: we had an incident last night. This was with state_cache set to true. We had gone 10 days since the last incident.
We have applied this issue's patch and will let you know if we have another incident.
- 🇺🇸United States cilefen
What does the service definition for
cache.backend.database
incore/core.services.yml
look like in that codebase?Are there any non-default cache bins or cache configurations on the site?
- 🇬🇧United Kingdom John_B London (UK), Worthing (UK), Innsbruck (Tirol)
I have seen the issue on a site which never was bilingual, and uses language undefined. Not sure what triggered it.
- 🇮🇳India sanket1007
Sure, here is the composer.json file -
{ "name": "drupal/recommended-project", "description": "Project template for Drupal 8 projects with a relocated document root", "type": "project", "license": "GPL-2.0-or-later", "homepage": "https://www.drupal.org/project/drupal", "support": { "docs": "https://www.drupal.org/docs/user_guide/en/index.html", "chat": "https://www.drupal.org/node/314178" }, "repositories": [ { "type": "path", "url": "src/packages/*" }, { "type": "composer", "url": "https://packages.drupal.org/8" }, { "type": "composer", "url": "https://asset-packagist.org" }, { "type": "package", "package": { "name": "toc/toc", "version": "v0.3.2", "type": "drupal-library", "dist": { "url": "https://raw.githubusercontent.com/jgallen23/toc/greenkeeper/update-all/dist/toc.min.js", "type": "file" } } } ], "require": { "bower-asset/countable": "^3.0", "bower-asset/dropzone": "^5.7", "bower-asset/history.js": "^1.8", "bower-asset/lunr": "^2.3", "bower-asset/prism": "^1.22", "bower-asset/slick-carousel": "^1.8", "commerceguys/addressing": "^2", "composer/installers": "^1.9", "cweagans/composer-patches": "^1.7", "drupal-ckeditor-libraries-group/fakeobjects": "^4.17", "drupal/access_unpublished": "^1.4", "drupal/address": "^2", "drupal/admin_toolbar": "^3.4", "drupal/auto_entitylabel": "^3.0@beta", "drupal/better_exposed_filters": "^6.0.3", "drupal/block_field": "^1.0@RC", "drupal/components": "^3", "drupal/config_filter": "^2.4", "drupal/config_ignore": "^2.4", "drupal/config_override_warn": "^1.3", "drupal/config_split": "^2.0@RC", "drupal/config_split_ignore": "dev-main", "drupal/content_lock": "^2.3.0", "drupal/core-composer-scaffold": "10.3.1", "drupal/core-project-message": "10.3.1", "drupal/core-recommended": "10.3.1", "drupal/crop": "^2.3", "drupal/ctools": "^4", "drupal/custom_book_block": "^1.0", "drupal/devel": "^5.1", "drupal/diff": "^1.0", "drupal/editor_md": "^4.0", "drupal/embed": "^1.5", "drupal/entity_browser": "^2.10", "drupal/entity_embed": "^1.4", "drupal/entity_reference_validators": "^1.0@beta", "drupal/entity_usage": "^2.0@beta", "drupal/environment_indicator": "^4.0", "drupal/externalauth": "^2.0", "drupal/fakeobjects": "^1.1", "drupal/fastly": "^4", "drupal/field_group": "^3.4.0", "drupal/file_delete_ui": "^1.0@beta", "drupal/fixed_block_content": "^1.2", "drupal/focal_point": "^2.0", "drupal/gin": "^3.0@RC", "drupal/gin_toolbar": "^1.0@RC", "drupal/hal": "^2.0", "drupal/inline_entity_form": "^1.0@RC", "drupal/jquery_ui": "^1.6.0", "drupal/jquery_ui_datepicker": "^2", "drupal/jquery_ui_slider": "^2", "drupal/jquery_ui_touch_punch": "^1.0", "drupal/jsonapi_extras": "^3.24", "drupal/layout_paragraphs": "^2.0", "drupal/lottiefiles_field": "^2.0", "drupal/markdown": "^3.0", "drupal/maxlength": "^2.1", "drupal/media_entity_browser": "^2.0@alpha", "drupal/media_entity_twitter": "^2.7", "drupal/metatag": "^1", "drupal/migrate_plus": "^6.0.0", "drupal/migrate_source_csv": "^3.5", "drupal/migrate_tools": "^6.0", "drupal/moderation_state_transitions_widget": "dev-main", "drupal/node_edit_protection": "^1.0", "drupal/node_revision_delete": "^1.0.0-rc6", "drupal/pantheon_advanced_page_cache": "^2.1", "drupal/paragraphs": "^1.16", "drupal/paragraphs_features": "^2", "drupal/pate": "^1.2.0", "drupal/pathauto": "^1.9", "drupal/preserve_changed": "^2.0@alpha", "drupal/purge": "^3.0", "drupal/redirect": "^1.9", "drupal/redis": "^1.7", "drupal/replicate": "^1.2", "drupal/replicate_actions": "^1.4", "drupal/replicate_ui": "^1.1", "drupal/scheduler": "^2.0", "drupal/scheduler_content_moderation_integration": "^2.0@beta", "drupal/schema_metatag": "^2.3", "drupal/sdc": "^2.0", "drupal/search_api": "^1.29", "drupal/select2": "^1.15", "drupal/simple_sitemap": "^4.1", "drupal/simplesamlphp_auth": "^4", "drupal/stage_file_proxy": "^2.1", "drupal/svg_formatter": "^2.0.2", "drupal/svg_image": "^3.0", "drupal/tmgmt": "^1.15", "drupal/tmgmt_smartling": "^9.6", "drupal/toc_js": "^2.1", "drupal/token": "^1.12", "drupal/token_custom": "^1.0@alpha", "drupal/token_filter": "^2.0", "drupal/tranc": "^1.0", "drupal/twig_field_value": "^2.0", "drupal/twig_tweak": "^3.1.3", "drupal/type_tray": "^1.2", "drupal/upgrade_status": "^4.0", "drupal/views_ajax_history": "^1.5", "drupal/views_bulk_operations": "^4.2", "drupal/webp": "^1.0@RC", "drupal/xmlsitemap": "^1.5", "drupal/yoast_seo": "^2.0", "drush/drush": "^12", "eluceo/ical": "^0.17", "league/commonmark": "^1.0", "league/csv": "^9.6", "npm-asset/jquery-ui-touch-punch": "^0.2.3", "npm-asset/select2": "^4.0", "oomphinc/composer-installers-extender": "^2.0", "phpspec/prophecy-phpunit": "^2.0", "psr/log": "^3.0", "simplesamlphp/assert": "^1.0", "simplesamlphp/composer-module-installer": "^1.3", "simplesamlphp/simplesamlphp": "^2.1", "symfony/browser-kit": "^6.3", "symfony/console": "^6", "symfony/css-selector": "^5", "symfony/debug": "^4", "symfony/dom-crawler": "^6", "symfony/framework-bundle": "^6", "toc/toc": "^0.3.2", "twig/twig": "^3", "vlucas/phpdotenv": "^4.1" }, "require-dev": { "behat/mink-browserkit-driver": "^2.1", "behat/mink-selenium2-driver": "^1.4", "dealerdirect/phpcodesniffer-composer-installer": "^0.7.0", "dmore/chrome-mink-driver": "^2.7", "drupal/coder": "8.3.13", "drupal/potx": "^1.0", "php-parallel-lint/php-parallel-lint": "^1.2", "phpro/grumphp": "^1.5.1", "squizlabs/php_codesniffer": "^3.5", "symfony/phpunit-bridge": "^5.2", "weitzman/drupal-test-traits": "^2.2" }, "conflict": { "drupal/drupal": "*" }, "minimum-stability": "dev", "prefer-stable": true, "config": { "sort-packages": true, "allow-plugins": { "dealerdirect/phpcodesniffer-composer-installer": true, "composer/installers": true, "cweagans/composer-patches": true, "drupal/core-composer-scaffold": true, "oomphinc/composer-installers-extender": true, "phpro/grumphp": true, "simplesamlphp/composer-module-installer": true, "drupal/core-project-message": true } }, "autoload": { "psr-4": { "NewRelic\\": [ "src/" ] } }, "autoload-dev": { "files": [ "load.environment.php" ] }, "extra": { "drupal-scaffold": { "locations": { "web-root": "web/" }, "file-mapping": { "[web-root]/sites/development.services.yml": false } }, "installer-types": [ "bower-asset", "npm-asset", "component" ], "installer-paths": { "web/core": [ "type:drupal-core" ], "web/libraries/{$name}": [ "type:drupal-library", "type:bower-asset", "type:npm-asset" ], "web/modules/contrib/{$name}": [ "type:drupal-module" ], "web/profiles/contrib/{$name}": [ "type:drupal-profile" ], "web/themes/contrib/{$name}": [ "type:drupal-theme" ], "drush/Commands/{$name}": [ "type:drupal-drush" ], "web/modules/custom/{$name}": [ "type:drupal-custom-module" ], "web/themes/custom/{$name}": [ "type:drupal-custom-theme" ] }, "composer-exit-on-patch-failure": true, "patchLevel": { "drupal/core": "-p2" }, "patches": { "drupal/core": { "Avoid PHP error when saving translatable media items": "https://www.drupal.org/files/issues/2019-02-11/ignore_width_height_on_untranslatable_field_comparision_2941092_8.patch", "Issue #2761273: Make exposed filter values available as tokens for text areas": "https://www.drupal.org/files/issues/2022-10-30/2761273-50.patch", "Issue #2985168: Allow Media Library to update media items in-place": "https://www.drupal.org/files/issues/2023-12-18/2985168-172.patch", "Issue #3175146: Media Library required field error message is too vague": "https://www.drupal.org/files/issues/2023-05-22/3175146-19.patch", "Issue #2539900: Markup wrongly escaped in delete link": "https://www.drupal.org/files/issues/2020-04-21/content_translation-2539900-fix_markup_escaped.patch", "Issue #2873353: Allow updating lists to use allowed values function": "https://www.drupal.org/files/issues/2021-05-18/allow-allowed-values-function-update-D9-2873353_1.patch", "NR patch: Add condition entity->book (see #97 from https://www.drupal.org/project/drupal/issues/2918537#comment-14824128)": "patches/book_20230822.patch", "NR patch: Fix add child page link for Authoring Documentation": "patches/wta-2526-fix-add-child-page-link-for-authoring-documentation.patch", "Issue #3323574: Page index isn't reset when use AJAX for Views module": "https://www.drupal.org/files/issues/2023-09-27/ajax-views-page-not-reset-issue-3323574-10.1.x-11.patch" }, "drupal/access_unpublished": { "Issue #2912066: Only show access unpublished element on relevant forms": "https://www.drupal.org/files/issues/2021-06-28/access_unpublished-only_node_edit-2912066-13.patch" }, "drupal/auto_entitylabel": { "Make Custom Token and Auto Entity Labels play nicely together": "patches/auto_entitylabel_token_fix.patch" }, "drupal/ckeditor": { "Issue #3065095: CKEditor native dialogs not clickable inside of jQuery UI dialogs": "https://www.drupal.org/files/issues/2022-11-22/3065095-71-1.0.x.patch" }, "drupal/markdown": { "Issue #3409277: Formstate incorrect interface error": "https://www.drupal.org/files/issues/2024-01-04/subformstate-incorrect-interface-error-3409277-4.patch" }, "drupal/diff": { "Issue #3227907: Fix current revision listed only for one translation": "https://www.drupal.org/files/issues/2021-08-12/3227907-4-list-current-revision-all-translations.diff" }, "drupal/layout_paragraphs": { "WTA-2403 - Set layout paragraphs widget to be multilingual": "patches/wta-2403-layout-paragraphs-set-widget-multilingual.patch", "WTA-2620: Use modal width setting for component picker": "https://www.drupal.org/files/issues/2023-02-13/layout_paragraphs-3341449-3.patch" }, "drupal/media_entity_twitter": { "Issue #3207992: Media Library form doesn't respect source field constraint validators": "https://www.drupal.org/files/issues/2021-04-09/3207992-2.patch" }, "drupal/migrate_tools": { "Issue #3378047: Fix 'sync' performance": "https://www.drupal.org/files/issues/2024-03-11/3378047-21.patch" }, "drupal/node_edit_protection": { "Issue #2188085: No longer working after validation fails": "https://www.drupal.org/files/issues/2021-12-08/node-edit-protection-2188085-13-d8.patch" }, "drupal/paragraphs": { "Issue #3027525 Improve paragraphs validation errors": "https://www.drupal.org/files/issues/2022-02-07/3027525-14.patch", "Alter widgets item mode using custom business logic.": "patches/paragraphs-alter-item-mode-when-building-widget.patch", "Issue #3310161 Null coalesce view_mode": "https://www.drupal.org/files/issues/2022-09-22/3310161-11.patch" }, "drupal/pate": { "WTA-2166 contributor role": "patches/wta-2166-contributor-role--drupal-pate.patch" }, "drupal/replicate_ui": { "Issue #3215573: Allow editors to choose whether to replicate all translations or not": "https://www.drupal.org/files/issues/2021-05-27/3215573-6.patch" }, "drupal/select2": { "Issue #3211796: Issue with z-index when opening in modal dialog": "https://www.drupal.org/files/issues/2021-05-03/properfix_zindex_ckeditor-3211796-5.patch" }, "drupal/simplesamlphp_auth": { "Issue #3112851: Fix access denied after logging in user from OKTA": "https://www.drupal.org/files/issues/2020-06-22/3112851-4_0.patch", "WTA-2661: Redirect to Authoring Documentation after logging in user from OKTA": "patches/wta-2661-redirect-to-authoring-documentation.patch" }, "drupal/svg_formatter": { "Issue #3284297: Extract dimensions from SVG image": "patches/svg_formatter-3284297.patch" }, "drupal/tmgmt": { "Issue #3188508: UX improvements on Locales source plugin form": "https://www.drupal.org/files/issues/2020-12-15/3188508-2.patch" }, "drupal/tmgmt_smartling": { "Issue #3172935: Do not perform API calls during config sync": "https://www.drupal.org/files/issues/2020-09-24/3172935-3.patch", "Do not show cron warning on non-live environments": "patches/smartling-cron-messages.patch" }, "drupal/toc_js": { "Issue #3031413: Programmatically-created nodes have TOC always enabled by default": "https://www.drupal.org/files/issues/2019-02-07/3031413-2.patch", "Force a couple config strings to be translated as interface strings": "patches/toc-js-translate-interface-strings.patch" }, "drupal/token_custom": { "Issue #2906903: Paragraph Tags Added to Tokens": "patches/2906903-enable-full-html.patch" }, "drupal/yoast_seo": { "Apply some project-specific customizations - 1": "patches/yoast-seo-project-specific-tweaks.patch", "Issue #3394487: Uncaught DOMException": "https://www.drupal.org/files/issues/2023-11-03/3394487-failed-to-execute-remove-on-domtokenlist.patch" }, "toc/toc": { "WTA-2207: remove dash on empty prefix": "patches/wta-2207p2.patch" } }, "composer-version": "^1.7.2" }, "scripts": { "post-install-cmd": [ "rm -rf vendor/simplesamlphp/simplesamlphp/config && ln -sf ../../../config/simplesamlphp/config vendor/simplesamlphp/simplesamlphp/config", "rm -rf vendor/simplesamlphp/simplesamlphp/metadata && ln -sf ../../../config/simplesamlphp/metadata vendor/simplesamlphp/simplesamlphp/metadata", "ln -sfn ../vendor/simplesamlphp/simplesamlphp/public web/simplesaml" ] } }
- @anupsingh-0 opened merge request.
- 🇮🇳India anup.singh
anup.singh → changed the visibility of the branch 3463518-php-warning- to hidden.
- 🇮🇳India anup.singh
anup.singh → changed the visibility of the branch 3463518-php-warning- to active.
- 🇮🇳India anup.singh
anup.singh → changed the visibility of the branch 3463518-php-warning- to active.
- 🇮🇳India anup.singh
anup.singh → changed the visibility of the branch 3463518-php-warning- to hidden.
- 🇺🇸United States cilefen
This looks like https://drupal.stackexchange.com/questions/320037/servicecircularreferen...
Can we have the list of modules installed and patches applied? Perhaps the complete
composer.json
would help. - 🇮🇳India sanket1007
I already checked this issue https://www.drupal.org/project/lightning_workflow/issues/3457016 🐛 Circular reference detected for service "cache.backend.database". Active but in our case, we are not using this module and hence this issue looks like a regression due to some other module.
- Issue created by @sanket1007
- 🇳🇿New Zealand quietone New Zealand
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- 🇳🇿New Zealand quietone New Zealand
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- 🇳🇿New Zealand quietone New Zealand
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- 🇦🇺Australia acbramley
This definitely does not happen on any diff.
This function is called by the caxy/php-htmldiff library, not the diff module directly.
I will need steps to reproduce with sample content.
- 🇺🇸United States cilefen
Thanks for the patch. We need a few more steps to reproduce (is there custom code?) and a merge request.
- Issue created by @phot0x
- Issue created by @maxilein
Looking at this related issue 🐛 RequestContext throws error when current request is empty Needs work , I modified patch #8 to solve this issue in Drupal 10.3.1 when using a custom stack middleware. Previously it would pollute the page cache and break the entire site. Beware that they're not sure whether synthesizing the
Request
in this way and pushing it onto the stack is the best practice here, but it works for me!Got the error (see below) when using the
router.no_access_checks
service in a custom middleware. The patch from #8 fixes the problem, but I'm not sure whether the patch is the solution orrouter.no_access_checks
should not be used in a middleware.Handle function in custom middleware which uses the
router.no_access_checks
service:public function handle(Request $request, $type = self::MASTER_REQUEST, $catch = TRUE) { // ... try { $router = \Drupal::service('router.no_access_checks')->matchRequest($request); // ... } catch (\Exception $e) { // ... } // ... return $this->httpKernel->handle($request, $type, $catch); }
Core service
router.no_access_checks
which callsrouter.request_context
:router.no_access_checks: class: \Drupal\Core\Routing\Router arguments: ['@router.route_provider', '@path.current', '@url_generator'] tags: # @todo Try to combine those tags together, see https://www.drupal.org/node/2915772. - { name: service_collector, tag: non_lazy_route_enhancer, call: addRouteEnhancer } - { name: service_collector, tag: route_enhancer, call: addRouteEnhancer } - { name: service_collector, tag: non_lazy_route_filter, call: addRouteFilter } - { name: service_collector, tag: route_filter, call: addRouteFilter } calls: - [setContext, ['@router.request_context']]
Error:
The website encountered an unexpected error. Please try again later. TypeError: Drupal\Core\Routing\RequestContext::fromRequest(): Argument #1 ($request) must be of type Symfony\Component\HttpFoundation\Request, null given, called in /var/www/html/web/core/lib/Drupal/Core/Routing/RequestContext.php on line 28 in Drupal\Core\Routing\RequestContext->fromRequest() (line 34 of core/lib/Drupal/Core/Routing/RequestContext.php). Drupal\Core\Routing\RequestContext->fromRequest(NULL) (Line: 28) Drupal\Core\Routing\RequestContext->fromRequestStack(Object) call_user_func_array(Array, Array) (Line: 279) Drupal\Component\DependencyInjection\Container->createService(Array, 'router.request_context') (Line: 176) Drupal\Component\DependencyInjection\Container->get('router.request_context', 3) (Line: 437) Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array) (Line: 276) Drupal\Component\DependencyInjection\Container->createService(Array, 'private__C9lAFteypAsjbMduBKjI8pQqjxZI3fGN7cy_1KFyRIk') (Line: 452) Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array) (Line: 240) Drupal\Component\DependencyInjection\Container->createService(Array, 'url_generator') (Line: 176) Drupal\Component\DependencyInjection\Container->get('url_generator', 1) (Line: 437) Drupal\Component\DependencyInjection\Container->resolveServicesAndParameters(Array) (Line: 240) Drupal\Component\DependencyInjection\Container->createService(Array, 'router.no_access_checks') (Line: 176) Drupal\Component\DependencyInjection\Container->get('router.no_access_checks') (Line: 197) Drupal::service('router.no_access_checks') (Line: 50)
- 🇮🇳India VinmayiSwamy
Hi, I attempted to reproduce the issue described here but was unable to replicate the error.
Below are the detailed steps I followed:
Setup:
* Installed Drupal 11.x on a fresh local environment.
* Enabled required modules: Content Translation, Language, and Locale.Language Configuration:
* Added Telugu and French as new languages via Configuration > Regional and language > Languages.Content Type Configuration:
* Enabled translation for the Article content type via Configuration > Regional and language > Content language and translation.
* Ensured fields like Title and Body are set to translatable.Content Creation and Translation:
* Created an Article with a title and body in the default language (English).
* Added Telugu and French translations for the Article, providing translated titles and bodies.Translation Deletion:
* Deleted the Telugu and French translations from the Article.Observations:
* NoInvalidArgumentException
was encountered.
* Checked Reports > Recent log messages: No related errors found.Additional Information:
* Cache was cleared during the process.
* Debug mode was enabled in settings.php.
* Verified on multiple content types and with different languages.If there are any specific configurations or steps that might have been missed, please let me know. Based on my testing, the issue does not appear to be reproducible in the current setup.
Thanks!
- 🇳🇿New Zealand quietone New Zealand
Drupal 10.2 only receives security maintenance now. Thus this issue needs to be reproducible on a Drupal 11.x or Drupal 10.3+. Without the steps to reproduce a proper fix can not be made.
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to our policies.
- 🇳🇿New Zealand janpongos
another tag that gets strips out that's good to be whitelisted is "drupal-media" when using core's ckeditor5.
- 🇦🇺Australia acbramley
Thanks for reporting this issue. We rely on issue reports like this one to resolve bugs and improve Drupal core.
As part of the Bug Smash Initiative, we are triaging issues that are marked "Postponed (maintainer needs more info)". This issue was marked "Postponed (maintainer needs more info)" more than 1 year ago.
Since we need more information to move forward with this issue, I am closing it.
Please feel free to reopen with more information.
- 🇦🇺Australia acbramley
This was triaged as part of Bug Smash Initiative.
I tried reproducing this on 10.3 but couldn't:
\Drupal::entityTypeManager()->getStorage('media_type') ->getQuery() ->condition('name', ['Document'], 'IN') ->accessCheck(FALSE)->execute();
I'm tempted to close this due to the lack of comments and updates since the last time this was traiged, but we will leave it in PMNMI.
Cheers.
- 🇺🇸United States fkildoo
I applied the patch to my production site. So far so good. I've visited all the URLs below (with the site URL in front) and they all redirect to my home page without a 404 or an error in my log. I'll keep monitoring my logs for the error.
/%20
/index.php/
/ - 🇺🇸United States fkildoo
@larowlan Thanks, I figured it out and tested it on my dev site. Will apply to production tonight and report back if I get the error again.
- 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
Thanks @banoodle
@fkildoo - you can turn an MR into a patch by adding `.diff` to the URL - for this issue the patch is at https://git.drupalcode.org/project/drupal/-/merge_requests/8790.diff - however you shouldn't reference that URL directly (as anyone can get access to the branch). Instead you should download the file into e.g. a PATCHES folder inside your codebase, and then with composer patches reference it using a file URL (e.g. "./PATCHES/name-of-the-saved-file.patch". Thanks again 💪
- 🇺🇸United States banoodle San Francisco, CA
@larowlan we can try it, but ever since we set state cache to true last Saturday morning (7/13/24), we haven't had a recurrence of the problem (so it has been over a week since the last incident).
- 🇺🇸United States fkildoo
@larowlan - Sorry, you all lost me a while ago! I don't have any experience with or knowledge of testing a merge request. I know how to implement a patch with Composer so I'm currently reading up on how to download and use a patch file from a merge request → . If successful, I will test it and report back.
On another note, this error has occurred 18 times starting on 7/12. Below are the frequency and times it has occurred, if that is helpful.
2024-07-22 13:45:26.248
2024-07-22 11:24:41.247
2024-07-20 11:48:51.248
2024-07-15 13:15:26.248
2024-07-14 23:12:35.248
2024-07-14 23:12:30.253
2024-07-14 23:12:15.248
2024-07-14 23:10:22.248
2024-07-14 23:00:52.248
2024-07-14 22:00:51.248
2024-07-12 19:15:05.441
2024-07-12 11:32:16.441
2024-07-12 11:28:39.149
2024-07-12 11:28:34.934
2024-07-12 11:24:59.982
2024-07-12 11:20:46.981
2024-07-12 11:00:48.981
2024-07-12 10:00:46.982 - 🇦🇺Australia larowlan 🇦🇺🏝.au GMT+10
@fkildoo, @rbomhof or @banoodle - any chance you could try the RTBC MR for a few days and report back if it fixes your issue?
Updating issue credits
- 🇳🇱Netherlands Summit
Hi, having the same issue, is there already a patch underway?
thanks for your reply in advance, greetings,