#Needs steps to reproduce

Gave a super light review but issue summary appears incomplete.

Updated the MR to include logging without injecting the logger. There were pre-existing calls to the logger service for exceptions so this was consistent with the existing code. Also updated the test for the latest Drupal.

Since it's been a few years of asking for steps I'm going to close this one out. If this particular one is still an issue please reopen providing the steps to reproduce.

Thanks all

MR 11394 is against 11.x and includes a Nightwatch test.

Based on discussion in 🐛 [meta] Some interface components don’t meet the minimum target size Active , I reduced the height of the elements to 1.5rem, which comes to 24px.

I am attaching new screenshots with the changes, as they are different than the previous version.

Tagging for https://www.w3.org/WAI/WCAG22/Understanding/target-size-minimum.html

kentr → changed the visibility of the branch 3223147-mobile-friendly-breadcrumb-fix to hidden.

kentr → changed the visibility of the branch 3223147-mobile-friendly-breadcrumb to hidden.

#24 was this of any help? 🐛 Shield middleware invokes hooks before modules are loaded, corrupting module_implements cache Needs work https://www.drupal.org/project/shield/issues/3277210#comment-15560180 🐛 Shield middleware invokes hooks before modules are loaded, corrupting module_implements cache Needs work

Should this be reopened this?

catch → closed merge request !5800

Committed/pushed to 11.x, thanks!

Did my best with commit credit but this is a long issue with a lot of commenters on it so apologies if someone was overlooked.

Closing as per #20

Rebase seems fine, random javascript error.

As per #13 it seems like #12 is a developer error. AFAIK computed fields should not extend EntityReferenceFieldItemList.

I'm closing this as cannot reproduce. If anyone is able to provide steps to reproduce this from a fresh install feel free to reopen.

I reconfigured the test to not rely on a custom module that also required Domain (for the domain.negotiator service in one of its classes) and this issue went away. It must be something in Domain module and similar modules that rely on core/lib/Drupal/Core/Path/PathMatcher::matchPath.

bluegeek9 → changed the visibility of the branch 1.x to hidden.

Merged in the latest from origin.

I am able to reproduce on 11.x with different STR. I updated the IS and am attaching the HTML Lighthouse report.

I think I can fashion a failing Nightwatch Axe test.

The Axe rule currently referenced by Lighthouse now specifies 24x24 px instead of 48x48 px, but I didn't change that in the IS because I don't know the history.

On a meta-level, in case it is a policy problem:

This issue is WCAG 2.2 AA. A Nightwatch Axe-core test just for this issue will need to explicitly invoke WCAG 2.2 AA, because the existing automated Axe tests don't appear to run WCAG 2.2 AA. So, the standard for this test will differ from the rest unless all tests are updated.

The Accessibility Coding Standards are unclear IMO on whether core / Drupal CMS are required to meet WCAG 2.2 AA.

Though the existing Axe tests still wouldn't have caught this for other reasons, in general they would catch some target-size problems if we started including WCAG 2.2 AA.

I was able to trigger this in a simple kernel test where I want to check that some custom entity routes are marked as admin.

/**
 * Tests the EntityAdminHtmlRouteProvider.
 */
class EntityAdminHtmlRouteProviderTest extends KernelTestBase {

  /**
   * {@inheritdoc}
   */
  protected static $modules = [
    'cci_api',
    'cci_card',
    'domain',
    'node',
    'text',
    'user',
    'system',
  ];

  /**
   * The entity type manager service.
   *
   * @var \Drupal\Core\Entity\EntityTypeManagerInterface
   */
  protected EntityTypeManagerInterface $entityTypeManager;

  /**
   * @var \Drupal\Core\Routing\AccessAwareRouter
   */
  protected AccessAwareRouter $router;

  /**
   * @var \Drupal\Core\ProxyClass\Routing\RouteBuilder
   */
  protected RouteBuilder $routerBuilder;

  /**
   * {@inheritdoc}
   */
  protected function setUp(): void {
    parent::setUp();
    $this->installEntitySchema('mymodule');
    $this->installSchema('system', ['sequences']);
    $this->entityTypeManager = $this->container->get('entity_type.manager');
    $this->router = $this->container->get('router');
    $this->routerBuilder = $this->container->get('router.builder');
    $this->routerBuilder->rebuild();
  }

  /**
   * Tests if the canonical route is correctly configured.
   */
  public function testCanonicalRoute(): void {
    $collection = $this->router->getRouteCollection();
    $route = $collection->get('entity.mymodule_entity.canonical');
    $this->assertTrue($route->getOption('_admin_route'), 'The route is marked as an admin route.');
  }

}

The test passes, but is marked with a deprecation. Not sure how to get around it.

No more reports in two years, closing as outdated.