🇺🇸United States @nmillin

Great! Thanks.

If people are using these patches, I suggest trying out the 3.x version of the facets module. One HUGE added benefit of this; bot traffic will stop crawling the facet "links" when you have checkboxes because there are no more links. (Bot traffic has been causing me tons of issues on my faceted pages. Sigh...)

https://project.pages.drupalcode.org/facets/exposed_filters/#why has documentation on how to get the facets recreated using the new approach. It took me a while to do this, but it seems really nice and I no longer need patches to get AJAX to work.

Last point, the facet maintainers are not going to accept a patch for the AJAX behavior in the 2.x branch (see https://www.drupal.org/project/facets/issues/3052574#comment-15283243 🐛 Facets with AJAX not working in most of situations Needs work from December 2022). It seems like they have been focusing on the 3.x version of the module. FYI.

I created a MR on https://www.drupal.org/project/zurb_foundation/issues/3355260#comment-15... 🐛 The base theme stable is not operated correctly Fixed since I thought that would be best. Hopefully all goes well.

Since we aren't using the contributed theme stable anymore, and are using stable9 from core, I created a MR to remove stable from zurb_foundation's composer.json.
https://git.drupalcode.org/project/zurb-foundation/-/merge_requests/32/d...

I can't reopen the issue, but if a maintainer (@sim_1?) could please review this that would be great. Thanks!

nmillin → made their first commit to this issue’s fork.

hmmm.... it looks like zurb_foundation's composer.json still is requiring drupal/stable. I'm not sure if this should be addressed in https://www.drupal.org/project/zurb_foundation/issues/3355260 🐛 The base theme stable is not operated correctly Fixed or a new issue?

I can confirm this happened to me when I updated to the latest version.

I found a solution at https://www.drupal.org/project/bulma/issues/3361624#comment-15075814 🐛 The base theme stable9 is not enabled when updating the theme on Drupal 9.x Active . Basically, stable9 needs to be enabled, but it is a hidden theme.

drush theme:enable stable9

Will enable the theme. You should also manually update your core.extension.yml file.

stable: 0 to
stable9: 0

Maybe something that could be added to the release notes? https://www.drupal.org/project/zurb_foundation/releases/9.0.0-beta2 →

Thanks!

Sounds good!

I've pushed an update that updates the admin settings form to be human friendly labels. (It helps me better understand the tests too)

Let me know if you need anything from me (when you return to this). Thanks.

nmillin → changed the visibility of the branch 3357207-Disable-individual-tests-via-fui to hidden.

nmillin → changed the visibility of the branch 3357207-Disable-individual-tests-via-gui-v2 to hidden.

Ok... https://git.drupalcode.org/project/editoria11y/-/merge_requests/20 is available for review. Let me know what you think.

A couple of things:

1. I updated editoria11y.schema.yml, but I'm not sure that is needed.
2. The admin form currently lists all of the machine names of the tests. I plan to update the label to the title from editoria11y-localization.js to have a more human friendly lable.
3. I made code changes to the Library ed11y.js file so other platforms could leverage this too. The min version of that file would need to be updated (I didn't do that).

Thanks.

nmillin → changed the visibility of the branch 3357207- to hidden.

nmillin → changed the visibility of the branch 3357207-disable-individual-tests to hidden.

Gotcha. I like disallowedTests better.

I'm going to try and work on a MR for this functionality. By default, all tests would be enabled but individual tests could be disabled. I'll share when I have a rough working example. Thanks!

Gotcha. I was able to get something working using a custom test and removing individual tests that I don't want to show my content authors yet. I think this is something that could be done via config in the Drupal settings at /admin/config/content/editoria11y, but I don't want to go down that path if it isn't something you (@itmaybejj) are interested in.

Here is what I did:
https://editoria11y.princeton.edu/configuration/#customtests was used as the starting point
Right before step 4 (when ed11yResume is dispatched), I loop through Ed11y.results and remove all tests not in the allow list I created.

Code sample:

// Only allow the tests you want.
  var allowedTests = [
    // Tests from ed11y tests.
    'headingEmpty',
    'linkNoText',
    'tableNoHeaderCells',
    'tableEmptyHeaderCell',
    // etc...

    // Made sure custom tests are allowed.
    'outlookSafeLink',
  ];
  // These are all of the tests I found in ed11y-test-[type of test].js.
  // linkNewWindow
  // linkNoText
  // altEmptyLinked
  // linkDocument
  // linkTextIsURL
  // linkTextIsGeneric
  // textPossibleList
  // textPossibleHeading
  // textUppercase
  // tableNoHeaderCells
  // tableEmptyHeaderCell
  // tableContainsContentHeading
  // embedVideo
  // embedAudio
  // embedVisualization
  // embedTwitter
  // embedCustom
  // headingEmpty
  // headingIsLong
  // headingLevelSkipped
  // blockquoteIsShort
  // altMissing
  // altNull
  // altMeaningless
  // altURL
  // altImageOf
  // altDeadspace
  // altLong
  // altPartOfLinkWithText
  var newResults = [];
  Ed11y.results.forEach((result) => {
    if (allowedTests.includes(result.test)) {
      newResults.push(result);
    }
  });
  Ed11y.results = newResults;

  let allDone = new CustomEvent('ed11yResume');
  document.dispatchEvent(allDone);

I'll be gone for a week or so, but @itmaybejj let me know if this is something you are interested in having in the Drupal module and I can work on getting a MR spun up.

Thanks for this great tool!

I'm interested in this feature. Is this something that is being worked on?
In looking at https://www.drupal.org/project/editoria11y/issues/3305813 → , there seems to be some v2 upgrades and I want to make sure I'm going down the correct rabbit hole. Right now I'm going down the hole of Ed11y.checkAll();

Thanks!

@itmaybejj so I have something for you to look at. I was able to get the data to drupalSettings. Is this something you could work with?

/**
 * Implements hook_preprocess_HOOK().
 */
function HOOK_preprocess_node(&$variables) {

  // Exit if user does not have "view" permission.
  if (!Drupal::currentUser()->hasPermission('view editoria11y checker')) {
    return;
  }

  // @todo this should probably be tweaked depending on what drupal hook
  // is used.
  if (isset($variables['node']) && $variables['view_mode'] == 'full') {
    // Get the node ID.
    $nid = $variables['node']->id();

    // Found that linkcheckerlink is an entity that we can query.
    $links_entity_manager = \Drupal::entityTypeManager()->getStorage('linkcheckerlink');
    $entity_ids_for_node = $links_entity_manager->getQuery()
      ->accessCheck(FALSE)
      ->condition('parent_entity_type_id', 'node')
      ->condition('parent_entity_id', $nid)
      ->condition('code', NULL, 'IS NOT NULL')
      ->execute();

    /** @var \Drupal\linkchecker\Entity\LinkCheckerLink[] $links_for_node*/
    $links_for_node = $links_entity_manager->loadMultiple($entity_ids_for_node);

    $linkchecker_data = [];
    foreach ($links_for_node as $linkcheckerlink) {
      $linkchecker_data[] = [
        'url' => $linkcheckerlink->get('url')->getString(),
        'code' => $linkcheckerlink->get('code')->getString(),
      ];
    }

    // Pass the data on to JavaScript to handle the rest.
    $variables['#attached']['drupalSettings']['editoria11y']['linkchecker'] = [$linkchecker_data];
  }
}

@itmahybejj re: Honestly – the Editoria11y side of this is quick and easy for me. The hard part for me would be rooting around in LinkChecker’s tables to shove the list of broken URLs on a route into drupalSettings somewhere. If someone took that on, I could do the rest.

I'm going down this rabbit hole and will post back here in the next week or two.

Thanks for the insights!

I'm adding a note here for future devs, and closing this issue since it is out of date (D7 is gone).

I use the layout paragraphs module to nest paragraphs and I was confused on how to get link checking working. The idea is to go to the paragraph where you added text, text_long or text_with_summary fields and enable link checking there. Once I did that to the paragraph, it just works.

I have just started to play with the module, but it seems amazing. Thanks!

Thanks @itmaybejj . I would be interested in looking at the code samples you have. I'll DM you my email if that is easier to share code samples.

We have SiteImprove for link checking, but I'm researching other options to make the content authoring experience better and have Drupal reports.

@itmaybejj have you been able to make some progress on this roadmap?

In looking around, it seems like a custom test could do link checking - https://editoria11y.princeton.edu/configuration/#customtests - but that would be a different way of checking links vs leveraging the linkchecker module.

Thanks!

If people want to get to D11 with zurb_foundation before this gets into the project, check out https://gorannikolovski.com/blog/how-to-upgrade-drupal-9-to-10#how-to-in.... It has nice steps on how to use https://github.com/mglaman/composer-drupal-lenient.

PS - https://git.drupalcode.org/project/zurb-foundation/-/merge_requests/30.p... is the patch that you can download and use OR I've attached a current copy.

@rahulrao.cs have you tried updating versions of select2? It looks like you are on version 4.0.13 and https://github.com/select2/select2/releases (and in issues on github) mentioned the 4.1 version has accessibility improvements.

I ask because I have the same SiteImprove issue that I'm trying to address! I'm going to try updating to 4.1 and I'll make a note here on what happens, but maybe you'll beat me to it and could report too.

I created a MR that handles only the first letter of each word. I'm backing away from trying to do what Google does with every letter. I'm assuming there is a use case for this, but I don't have one at this time and it seems very hard to do.

I've also uploaded a patch file if people want to test it out. Thanks.

nmillin → created an issue.

Updated patch for 2.0.9 release.

**Note** Hopefully this helps a future dev.

I like that the message isn't being displayed anymore. Now an error message of "An error occurred while searching, try again later." will show for me. This is coming from SearchApiSolrBackend.php (for me at least).

This message can be overridden by something like:

/**
 * Implements hook_preprocess_HOOK().
 */
function mymodule_preprocess_status_messages(&$variables) {
  // Normal error message from SearchApiSolrBackend.php. Could be better.
  if (isset($variables['message_list']['error'])) {
    $status_messages = $variables['message_list']['error'];
    foreach ($status_messages as $delta => $message) {
      if (strpos((string) $message, 'An error occurred while searching, try again later.') !== FALSE) {
        $variables['message_list']['error'][$delta] = "Search had a bad time. Call the help desk for assistance.";
      }
    }
  }
}

I've created the MR, but here is a patch if people want to add try it out in the meantime.

Maintainers, please let me know if there should be any changes. Thanks!

I can confirm the same issue.

The stage_file_proxy.fetch_manager service was removed in https://git.drupalcode.org/project/stage_file_proxy/-/commit/aca5a868ef3... from https://www.drupal.org/project/stage_file_proxy/issues/3438649 📌 Automated Drupal 11 compatibility fixes for stage_file_proxy Fixed . It looks like the stage_file_proxy.download_manager service should be used instead.

I'll try to create a patch to address this.

@mglaman, it looks like sarwan_verma did that back in comment 15 - https://www.drupal.org/files/issues/2023-09-28/commerce_cart_flyout-3359... →

I was able to use the patch with https://github.com/mglaman/composer-drupal-lenient (wish I found this project earlier...). I'm kicking the tires of commerce (no live site yet), but things work.

@mglaman can you review if this is the correct direction, and then maybe someone with more commerce experience than I can polish the patch (if needed). Thanks!

sigh... the config change took forever to figure out why it wasn't working in the tests. I found https://www.drupal.org/node/2951441 → (paragraphs module) that is similar. drupal_flush_all_caches() is what is required for the config to work in the second test.

I've added screenshots from the local test results I did. Removed the Needs Tests tag to reflect that tests were added and marking as needs review.

Let me know if there should be any changes!

Sure!

Screenshots
The default (per config/install/layout_paragraphs.settings.yml) is to not show the paragraph labels and not show the layout labels. I've included screenshots of how this looks with both labels showing and with a mouse hover.

Div & a class
I've pushed a commit to the MR doing this. Naming things is hard, so let me know if there should be any changes.

Tests
I'll poke at this. I'm guessing a new test in BuilderTest.php would be best. Let me know if this is the wrong direction.

Thanks!

Marking as Needs review since sakthi_dev addressed feedback in #15.

I noticed the code was only for show_paragraph_labels and not show_layout_labels. I've enhanced the code sakthi_dev did (will try to push to MR) that shows the layout when the setting is checked. Part of this is adding an additional check to existing code to make sure the paragraph is not a layout.

Let me know if anyone has any questions and great to find this issue!

-Nate

I ran across this and it looks like the Webform module handles how this works. src/Plugin/Field/FieldFormatter/WebformEntityReferenceEntityFormatter.php is the webform file that controls this behavior and doesn't know how the layout_paragraphs module does things.

My solution for this is to use a custom display mode (preview) for my webform paragraphs. Then I display the webform URL instead of the default of the webform.

There probably could be an update to $is_entity_edit_form and $is_paragraph_entity_edit_form to fix this functionality, but that would be something for the webform issue queue (and I'm not sure its worth it).

@Dom. I was able to have a view working with masonry_views as the display format.

The biggest issue I had was including "px" in the Gutter Width setting (px isn't needed). Ideally there would be a warning to prevent people doing what I did, but that is a separate issue.

+1 from me on this. Thanks!

Thanks Dom. I plan to test it this week and report back here. If anyone else wants to test this, here is the git info that I added to my composer.json in the repositories section:

"drupal/masonry_views": {
            "type": "package",
            "package": {
                "name": "drupal/masonry_views",
                "version": "2.x-dev",
                "type": "drupal-module",
                "source": {
                    "type": "git",
                    "url": "https://git.drupalcode.org/project/masonry_views.git",
                    "reference": "9cf47eae179ddca42dcb4883461cbd555cca4809"
                }
            }
        }

Then you can reference the 2.x version of the module. Aka "drupal/masonry_views": "^2.0",

@Dom. any chance you can promote the 2.0 version on the project homepage? https://git.drupalcode.org/project/masonry_views shows the 2.x branch as default, but https://www.drupal.org/project/masonry_views → doesn't show it.

Thanks!

@mingsong, thanks for the documentation page!

One thing I got caught up on is the "if (Drupal.fullcalendar_block) {" not working. This ended up being due to the order of the JS being loaded. I resolved it by adding a dependency in my library to:
- fullcalendar_block/fullcalendar

I'm not sure if/how to add this note to the documentation page, so adding it here in case it is helpful for others. Thanks.